aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5229bors[bot]2020-07-064-18/+49
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5229: Improve client logging (use output channel and more log levels) r=matklad a=Veetaha The improvements: * Separate output channel allows viewing the logs belonging to only our extension (without the intervention of other vscode extensions) * All the objects in the output channel are always expanded so users only need to `Ctrl + A and Ctrl + C` to copy the entire output to send us and nothing more (e.g. currently users need to expand the object which is not obvious for them and we may lose the logs this way, see two comments: https://github.com/rust-analyzer/rust-analyzer/issues/5009#issuecomment-651361137 * More log levels allows us to be more granular in disabling only optional verbose debug-level output and leave the logs for us as developers to understand the context of user issues. * For `log.error(...)` invocations we reveal `Rust Analyzer Client` channel automatically so that users don't have to do any additional actions to get the logs output window visible Demo: ![image](https://user-images.githubusercontent.com/36276403/86535275-d7795f80-bee7-11ea-8c30-135c83c1bc7d.png) Co-authored-by: Veetaha <[email protected]>
| * Revert "Dispose logger on extension deactivation"Veetaha2020-07-052-6/+0
| | | | | | | | | | This reverts commit 13872543e074adc153b440660beda441fd562f53. That commit was wrong because we use-after-free the logger
| * Dispose logger on extension deactivationVeetaha2020-07-052-0/+6
| |
| * Improve client logging (use output channel and more log levels)Veetaha2020-07-054-18/+49
| |
* | Merge #5231bors[bot]2020-07-061-29/+14
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 5231: Simplify file watcher r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Simplify file watcherAleksey Kladov2020-07-061-29/+14
|/
* Merge #5228bors[bot]2020-07-052-6/+6
|\ | | | | | | | | | | | | | | | | | | | | 5228: Fix typo r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix typoAleksey Kladov2020-07-052-6/+6
| |
* | Merge #5227bors[bot]2020-07-051-3/+3
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 5227: AbsPath r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * AbsPathAleksey Kladov2020-07-051-3/+3
|/
* Merge #5226bors[bot]2020-07-041-265/+199
|\ | | | | | | | | | | | | | | | | | | | | 5226: Modernise item completion tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Modernise item completion testsAleksey Kladov2020-07-041-265/+199
|/
* Merge #4864bors[bot]2020-07-043-1/+23
|\ | | | | | | | | | | | | | | | | | | | | | | | | 4864: Add optional target to crates in json project r=Nashenas88 a=Nashenas88 Lookup default cfgs per target when generating cfg list. Should fully address #4840 CC @woody77 Co-authored-by: Paul Daniel Faria <[email protected]> Co-authored-by: Paul Daniel Faria <[email protected]>
| * Fallback to target in cfg if not specified in project json configPaul Daniel Faria2020-07-041-1/+1
| |
| * Add optional target to crates in json project, lookup default cfgs per ↵Paul Daniel Faria2020-07-043-1/+23
|/ | | | target when generating cfg list
* Merge #5225bors[bot]2020-07-049-1207/+542
|\ | | | | | | | | | | | | | | | | | | | | 5225: Alight details in comkplation list r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Alight details in comkplation listAleksey Kladov2020-07-047-50/+63
| |
| * Modernize qual path completion testsAleksey Kladov2020-07-043-1105/+475
| |
| * Modernize snippet completion testsAleksey Kladov2020-07-041-77/+29
|/
* Merge #5223bors[bot]2020-07-041-10/+10
|\ | | | | | | | | | | | | | | 5223: update deps r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * update depsJeremy Kolb2020-07-041-10/+10
| |
* | Merge #5222bors[bot]2020-07-042-15/+27
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 5222: Add Item change to the set of benches r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add Item change to the set of benchesAleksey Kladov2020-07-041-0/+13
| |
| * Fix bench to work with relative pathsAleksey Kladov2020-07-042-15/+14
|/
* Merge #5221bors[bot]2020-07-042-600/+160
|\ | | | | | | | | | | | | | | | | | | | | 5221: Modernize postfix completion tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Modernize postfix completion testsAleksey Kladov2020-07-041-512/+123
| |
| * Modernize pattern completion testsAleksey Kladov2020-07-041-88/+37
| |
* | Merge #5220bors[bot]2020-07-046-183/+141
|\| | | | | | | | | | | | | | | | | | | | | 5220: Fix lookup in tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix lookup in testsAleksey Kladov2020-07-043-0/+11
| |
| * Macro testsAleksey Kladov2020-07-042-119/+70
| |
| * Modernize testsAleksey Kladov2020-07-041-64/+60
|/
* Merge #5219bors[bot]2020-07-046-1301/+695
|\ | | | | | | | | | | | | | | | | | | | | 5219: Cleanup dot completiont tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Cleanup dot completiont testsAleksey Kladov2020-07-044-720/+407
| |
| * CommentsAleksey Kladov2020-07-042-2/+3
| |
| * Better tests for completion scoringAleksey Kladov2020-07-043-192/+61
| |
| * Modernize completion presentation testsAleksey Kladov2020-07-041-393/+340
| |
| * Unify namingAleksey Kladov2020-07-041-8/+8
| |
| * Cleanup testsAleksey Kladov2020-07-041-172/+62
|/
* Merge #5197bors[bot]2020-07-045-191/+243
|\ | | | | | | | | | | | | | | | | | | | | 5197: SSR internal refactorings r=davidlattimore a=davidlattimore - Extract error code out to a separate module - Improve error reporting when a test fails - Refactor matching code - Update tests so that all paths in search patterns can be resolved Co-authored-by: David Lattimore <[email protected]>
| * SSR: Update tests so that all paths in patterns can be resolvedDavid Lattimore2020-07-031-67/+97
| |
| * SSR: Refactor matching code.David Lattimore2020-07-031-80/+75
| | | | | | | | | | | | Mutable state is now stored in the enum Phase. MatchState, since it now has no mutable state is renamed Matcher. MatchInputs is merged into Matcher
| * SSR: Improve error reporting when a test failsDavid Lattimore2020-07-032-21/+36
| |
| * SSR: Extract error code out to a separate moduleDavid Lattimore2020-07-033-23/+35
| | | | | | | | | | This is to make reusing it outside of parsing easier in a subsequent change.
* | Merge #5215bors[bot]2020-07-033-331/+177
|\ \ | | | | | | | | | | | | | | | | | | | | | 5215: Cleanup more completion tests r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * | Cleanup more completion testsAleksey Kladov2020-07-033-331/+177
| | |
* | | Merge #5214bors[bot]2020-07-032-146/+59
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5214: Cleanup presentation tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Cleanup presentation testsAleksey Kladov2020-07-032-146/+59
|/ /
* | Merge #5213bors[bot]2020-07-039-228/+243
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5213: Add AssistKind::Generate r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add AssistKind::GenerateAleksey Kladov2020-07-037-26/+32
| | |
| * | Unify naming of generating assistsAleksey Kladov2020-07-038-207/+216
|/ /