aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Apply suggestions from code reviewivan7702020-12-091-17/+20
| | | Co-authored-by: bjorn3 <[email protected]>
* Format codeivan7702020-12-083-8/+24
|
* Remove unused useivan7702020-12-081-1/+1
|
* Remove use via superivan7702020-12-081-3/+1
|
* Remove this semicolonivan7702020-12-085-8/+74
|
* Merge #6760bors[bot]2020-12-082-15/+17
|\ | | | | | | | | | | | | | | | | 6760: Open Cargo.toml opens more specific manifest r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Open Cargo.toml opens more specific manifestAleksey Kladov2020-12-082-10/+12
| |
| * cleanup: match over unwrapAleksey Kladov2020-12-081-5/+5
| |
* | Merge #6750bors[bot]2020-12-0812-213/+137
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6750: Remove documentation query, move doc handling to attributes r=matklad a=Veykril Fixes #3182 Removes the documentation query in favor of `Attrs::docs`. Attrs already handlded doc comments partially but the alloc saving check was wrong so it only worked when other attributes existed as well. Unfortunately the `new` constructor has to do an intermediate allocation now because we need to keep the order of mixed doc attributes and doc comments. I've also partially adjusted the `hover` module to have its tests check the changes, it still has some `HasSource` trait usage due to the `ShortLabel` trait usage, as that is only implemented on the Ast parts and not the Hir, should this ideally be implemented for the Hir types as well?(would be a follow up PR of course) Co-authored-by: Lukas Wirth <[email protected]>
| * | Simplify ast::Comment api surfaceLukas Wirth2020-12-081-10/+15
| | |
| * | Escape string literals in Attr::from_srcLukas Wirth2020-12-082-12/+6
| | |
| * | Replace Arc<[str]> with String in attr::DocumentationLukas Wirth2020-12-071-2/+2
| | |
| * | Keep doc attribute orderLukas Wirth2020-12-073-55/+61
| | |
| * | Remove raw pre and suffixes from string attr literalsLukas Wirth2020-12-071-2/+5
| | |
| * | Remove hir_def/docs.rs moduleLukas Wirth2020-12-076-114/+63
| | |
| * | Remove documentation queryLukas Wirth2020-12-076-59/+26
| | |
* | | Merge #6706bors[bot]2020-12-0817-118/+565
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6706: Move import text edit calculation into a completion resolve request r=matklad a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/6612 (presumably fixing it) Part of https://github.com/rust-analyzer/rust-analyzer/issues/6366 (does not cover all possible resolve capabilities we can do) Closes https://github.com/rust-analyzer/rust-analyzer/issues/6594 Further improves imports on completion performance by deferring the computations for import inserts. To use the new mode, you have to have the experimental completions enabled and use the LSP 3.16-compliant client that reports `additionalTextEdits` in its `CompletionItemCapabilityResolveSupport` field in the client capabilities. rust-analyzer VSCode extension does this already hence picks up the changes completely. Performance implications are descrbed in: https://github.com/rust-analyzer/rust-analyzer/issues/6633#issuecomment-737295182 Co-authored-by: Kirill Bulatov <[email protected]>
| * | Tweak the search query params for better lookup speedKirill Bulatov2020-12-082-32/+38
| | |
| * | Better config nameKirill Bulatov2020-12-086-16/+19
| | |
| * | Disable the completion for no corresponding client resolve capabilitiesKirill Bulatov2020-12-0712-163/+87
| | |
| * | Document the featureKirill Bulatov2020-12-071-0/+43
| | |
| * | SimplifyKirill Bulatov2020-12-074-36/+35
| | |
| * | Check lsp completions' edits for disjointnessKirill Bulatov2020-12-072-1/+176
| | |
| * | Less panic, more testsKirill Bulatov2020-12-073-11/+62
| | |
| * | Fix the profiling labelKirill Bulatov2020-12-071-1/+1
| | |
| * | Use stateless completion resolveKirill Bulatov2020-12-076-71/+124
| | |
| * | Remove the stateKirill Bulatov2020-12-077-107/+37
| | |
| * | Make completion resolve asyncKirill Bulatov2020-12-077-53/+116
| | |
| * | Simplify import edit calculationKirill Bulatov2020-12-0712-111/+114
| | |
| * | Remove redundant codeKirill Bulatov2020-12-078-103/+80
| | |
| * | Refactor the codeKirill Bulatov2020-12-0711-34/+48
| | |
| * | Add eager resolve capabilityKirill Bulatov2020-12-078-13/+43
| | |
| * | Better support client completion resolve capsKirill Bulatov2020-12-075-105/+120
| | |
| * | Properly fill client completion resolve capabilities dataKirill Bulatov2020-12-075-5/+56
| | |
| * | Resolve import inserts betterKirill Bulatov2020-12-072-38/+91
| | |
| * | Remove unnecessary leftoversKirill Bulatov2020-12-072-3/+0
| | |
| * | Working resolve completion imports prototypeKirill Bulatov2020-12-079-46/+78
| | |
| * | Draft the new lsp handlerKirill Bulatov2020-12-075-24/+52
| | |
* | | Merge #6759bors[bot]2020-12-081-4/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6759: Remove workaround & fix fetch$1 is not a function r=lnicola a=kafji Remove workaround for https://github.com/rollup/plugins/issues/491 because it's fixed in 15.0 https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md#v1500. Also fix fetch$1 is not a function error https://github.com/rust-analyzer/rust-analyzer/issues/6757. Co-authored-by: Kafji <[email protected]>
| * | Remove workaround & fix fetch$1 is not a functionKafji2020-12-081-4/+1
|/ / | | | | | | | | | | | | | | | | Remove workaround for https://github.com/rollup/plugins/issues/491 because it's fixed in 15.0 https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md#v1500. Also fix fetch$1 is not a function error https://github.com/rust-analyzer/rust-analyzer/issues/6757.
* | Merge #6754bors[bot]2020-12-072-2/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6754: Apply environment set by build scripts r=jonas-schievink a=jonas-schievink Fixes inclusion of generated files in typenum/heapless/defmt etc. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | Apply environment set by build scriptsJonas Schievink2020-12-072-2/+20
|/ /
* | Merge #6752bors[bot]2020-12-071-0/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | 6752: Pass `--target` when loading out dirs from check r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | Pass `--target` when loading out dirs from checkJonas Schievink2020-12-071-0/+5
| | |
* | | Merge #6749bors[bot]2020-12-072-30/+19
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6749: cargo update r=lnicola a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update expect-test and remove outdated licensekjeremy2020-12-072-5/+4
| | |
| * | cargo updatekjeremy2020-12-071-25/+15
| | |
* | | Merge #6719bors[bot]2020-12-075-23/+23
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6719: Use items can also have doc comments r=matklad a=Veykril Prior to this change modules show more docs than they have cause they inherit the docs from documented use items inside of them. Co-authored-by: Lukas Wirth <[email protected]>
| * | Use items can also have doc commentsLukas Wirth2020-12-045-23/+23
| | |
* | | Merge #6751bors[bot]2020-12-071-1/+1
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6751: Use the right `def_crate` for builtin macros r=jonas-schievink a=jonas-schievink Fixes the incorrect macro resolution in https://github.com/rust-analyzer/rust-analyzer/issues/6716 No test, because diagnostics do not get remapped correctly for some reason. I've checked manually that this fixes the resolution errors. bors r+ Co-authored-by: Jonas Schievink <[email protected]>