aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
*-. Merge #4207 #4253bors[bot]2020-05-028-14/+390
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4207: Add unwrap block assist #4156 r=matklad a=bnjjj close issue #4156 4253: Remove `workspaceLoaded` setting r=matklad a=eminence The `workspaceLoaded` notification setting was originally designed to control the display of a popup message that said: "workspace loaded, {} rust packages" This popup was removed and replaced by a much sleeker message in the VSCode status bar that provides a real-time status while loading: rust-analyzer: {}/{} packages This was done as part of #3587 The change in this PR simply renames this setting from `workspaceLoaded` to `progress` to better describe what it actually controls. At the moment, the only type of progress message that is controlled by this setting is the initial load messages, but in theory other messages could also be controlled by this setting. Reviewer notes: * If we didn't like the idea of causing minor breaking to user's config, we could keep the setting name as `workspaceLoaded` * I think we can now close both #2719 and #3176 since the notification dialog in question no longer exists (actually I think you can close those issues even if you reject this PR 😄 ) Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * Remove `workspaceLoaded` settingAndrew Chin2020-05-023-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `workspaceLoaded` notification setting was originally designed to control the display of a popup message that said: "workspace loaded, {} rust packages" This popup was removed and replaced by a much sleeker message in the VSCode status bar that provides a real-time status while loading: rust-analyzer: {}/{} packages This was done as part of #3587 The new status-bar indicator is unobtrusive and shouldn't need to be disabled. So this setting is removed.
| * | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-0213-17/+139
| |\ \
| * | | Add unwrap block assist #4156Benjamin Coenen2020-05-021-3/+2
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-02255-11165/+11241
| |\ \ \
| * | | | Add unwrap block assist #4156Benjamin Coenen2020-05-021-76/+13
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | Add unwrap block assist #4156Benjamin Coenen2020-05-011-46/+23
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-0168-592/+1928
| |\ \ \ \
| * | | | | Add unwrap block assist #4156Benjamin Coenen2020-04-293-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | Add unwrap block assist #4156Benjamin Coenen2020-04-295-1/+475
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | Merge #4261bors[bot]2020-05-0211-62/+107
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4261: Fix parsing of blocks without `{` r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Fix parsing of blocks without `{`Aleksey Kladov2020-05-0211-62/+107
|/ / / / /
* | | | | Merge #4234bors[bot]2020-05-0213-17/+139
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4234: Support local_inner_macros r=jonas-schievink a=edwin0cheng This PR implements `#[macro_export(local_inner_macros)]` support. Note that the rustc implementation is quite [hacky][1] too. :) [1]: https://github.com/rust-lang/rust/blob/614f273e9388ddd7804d5cbc80b8865068a3744e/src/librustc_resolve/macros.rs#L456 Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Test whether it is bang macro properlyEdwin Cheng2020-05-022-8/+10
| | | | |
| * | | | Add test in name resolutionsEdwin Cheng2020-05-021-0/+37
| | | | |
| * | | | Update crates/ra_hir_expand/src/builtin_derive.rs Edwin Cheng2020-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Fix spacing Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Make AttrQuery copyableEdwin Cheng2020-05-012-10/+15
| | | | |
| * | | | Support local_inner_macrosEdwin Cheng2020-05-0110-19/+97
| | |/ / | |/| |
* | | | Merge #4257bors[bot]2020-05-02212-10935/+10656
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4257: ast::EffectExpr r=matklad a=matklad closes #4230 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Add missing members generates indented blocksAleksey Kladov2020-05-024-88/+122
| | | | |
| * | | | Add smoke test for decorated blocksAleksey Kladov2020-05-021-0/+32
| | | | |
| * | | | Cleanup inline testsAleksey Kladov2020-05-029-32/+63
| | | | |
| * | | | Update test dataAleksey Kladov2020-05-02178-10580/+10223
| | | | |
| * | | | Introduce EffectExprAleksey Kladov2020-05-0225-261/+242
| | | | |
* | | | | Merge #4256bors[bot]2020-05-021-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4256: Improve formatting of analyzer status text r=flodiebold a=eminence The old formatting had everything on 1 line, making it quite hard to read: requests: 1 textDocument/documentSymbol 2ms 2 textDocument/codeAction 2ms 3 rust-analyzer/inlayHints 20ms 4 textDocument/foldingRange 108ms 6 textDocument/codeLens 66ms 5 textDocument/semanticTokens/range 76ms 8 rust-analyzer/inlayHints 195ms 7 textDocument/semanticTokens 250ms 9 textDocument/semanticTokens/range 108ms It now looks like this: ``` requests: * 1 textDocument/documentSymbol 11ms 2 textDocument/codeAction 15ms 3 rust-analyzer/inlayHints 4ms 5 textDocument/foldingRange 3ms 4 textDocument/semanticTokens/range 45ms 6 textDocument/codeLens 182ms 8 rust-analyzer/inlayHints 124ms 7 textDocument/semanticTokens 127ms 9 textDocument/documentHighlight 2ms 10 textDocument/codeAction 3ms ``` Co-authored-by: Andrew Chin <[email protected]>
| * | | | | Improve formatting of analyzer status textAndrew Chin2020-05-021-2/+2
| | |_|_|/ | |/| | |
* | | | | Merge #4258bors[bot]2020-05-022-7/+3
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4258: Test/check the whole package r=matklad a=matklad Closes #4255 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Test/check the whole packageAleksey Kladov2020-05-022-7/+3
|/ / / / | | | | | | | | | | | | Closes #4255
* | | | Merge #4254bors[bot]2020-05-029-30/+63
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4254: Put ? back in place r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Revert "Merge #4233"Aleksey Kladov2020-05-029-30/+63
|/ / / / | | | | | | | | | | | | | | | | This reverts commit a5f2b16366f027ad60c58266a66eb7fbdcbda9f9, reversing changes made to c96b2180c1c4206a0a98c280b4d30897eb116336.
* | | | Merge #4252bors[bot]2020-05-012-7/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 4252: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | Update crateskjeremy2020-05-012-7/+7
|/ / /
| | |
| \ \
*-. \ \ Merge #4220 #4240bors[bot]2020-05-0124-127/+293
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4220: Introduce LowerCtx r=matklad a=edwin0cheng This PR introduces `LowerCtx` for path lowering. After this PR, there are only 2 places remains for using deprecated `Path::from_ast`, which is related to `AstTransform` I am not familiar. I would like to change these in another PR by others ;) related disscusiion: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Path.3A.3Afrom_src And also fixed part of https://github.com/rust-analyzer/rust-analyzer/issues/4176#issuecomment-620672930 4240: Bump deps r=matklad a=lnicola Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| | * | | Bump depsLaurențiu Nicola2020-05-019-49/+81
| | |/ /
| * | | Remove lower_path from AssistCtx to SemanticEdwin Cheng2020-05-013-8/+10
| | | |
| * | | Introduce LowerCtx for path loweringEdwin Cheng2020-05-0114-80/+172
| | | |
| * | | Add testEdwin Cheng2020-05-011-0/+40
| |/ /
* | | Merge #4236bors[bot]2020-05-011-1/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4236: Document Gnome Builder support r=matklad a=lnicola Closes #3758. CC @gwutz Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | Document Gnome Builder supportLaurențiu Nicola2020-05-011-1/+10
| |/ /
* | | Merge #4244bors[bot]2020-05-012-1/+16
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4244: Show unsafe trait in hover r=matklad a=DianaNites Following on #2450 and #4210, for traits. `unsafe` is the only qualifier they can have, though. Co-authored-by: Diana <[email protected]>
| * | | Test for unsafe traitDiana2020-05-011-0/+11
| | | |
| * | | Unsafe traitsDiana2020-05-011-1/+5
| |/ /
* | | Merge #4246bors[bot]2020-05-019-75/+178
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4246: Validate uses of self and super r=matklad a=djrenren This change follows on the validation of the `crate` keyword in paths. It verifies the following things: `super`: - May only be preceded by other `super` segments - If in a `UseItem` then all semantically preceding paths also consist only of `super` `self` - May only be the start of a path Just a note, a couple times while working on this I found myself really wanting a Visitor of some sort so that I could traverse descendants while skipping sub-trees that are unimportant. Iterators don't really work for this, so as you can see I reached for recursion. Considering paths are generally small a fancy debounced visitor probably isn't important but figured I'd say something in case we had something like this lying around and I wasn't using it. Co-authored-by: John Renner <[email protected]>
| * | | Validate uses of self and superJohn Renner2020-05-019-75/+178
| | | |
* | | | Merge #4248bors[bot]2020-05-011-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4248: Fix Typos on guide.md r=matklad a=lonesometraveler Co-authored-by: KENTARO OKUDA <[email protected]>
| * | | | Fix Typos on guide.mdKENTARO OKUDA2020-05-011-4/+4
| | | | |
* | | | | Merge #4167bors[bot]2020-05-014-18/+51
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4167: Filter out code actions if unsupported by the client and advertise our capabilities r=matklad a=kjeremy This PR does three things: 1. If the client does not support `CodeActionKind` this will filter the results and only send `Command[]` back. 2. Correctly advertises to the client that the server supports `CodeActionKind`. This may cause clients to not request code actions if they are checking for the provider to be `true` (or implement LSP < 3.8) in the caps but I will fix that in a followup PR. 3. Marks most CodeActions as <strike>"refactor" so that they show up in the menu in vscode.</strike>`""`. Part of #144 #4147 #2833 Co-authored-by: kjeremy <[email protected]>
| * | | | Address commentskjeremy2020-05-012-2/+4
| | | | |
| * | | | Mark most assists as the base "refactor" typekjeremy2020-05-011-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Most of them area. We will separate them out later but this gets them to show up in the "refactor" menu of vscode.
| * | | | Advertise support for all the builtin CodeActionKindskjeremy2020-05-011-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | Even thought we don't return all of these we eventually will so might as well advertise now.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 03:26:34 +0000