aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6435bors[bot]2020-11-031-2/+15
|\ | | | | | | | | | | | | | | 6435: Test Fixture ExplicitRoot + ModuleResolutionRelativePathOutsideRoot. r=matklad a=rickvanprim Updates `module_resolution_relative_path_outside_root` test to check valid paths outside of the root, by moving the root to a subpath so that paths outside of it are possible. If this would be more appropriate as a new test, or if the original check for an invalid path should be left, I'm happy to update. Co-authored-by: James Leitch <[email protected]>
| * Feedback.James Leitch2020-11-023-8/+2
| |
| * Test Fixture ExplicitRoot + ModuleResolutionRelativePathOutsideRoot.James Leitch2020-11-023-3/+22
| |
* | Merge #6450bors[bot]2020-11-031-0/+60
|\ \ | | | | | | | | | | | | | | | | | | | | | 6450: Textmate grammar: Distinguish turbofish function calls from namespaces r=dustypomerleau a=dustypomerleau Fixes #6446. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | fix: distinguish turbofish function calls from namespacesDusty Pomerleau2020-11-031-0/+60
|/ /
* | Merge #6430bors[bot]2020-11-0310-1355/+1781
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6430: Move completions rendering into a separate module r=popzxc a=popzxc This PR extracts rendering-related things from `Completions` structure to the new `render` module. `render` module declares a `Render` structure (which is a generic renderer interface), `RenderContext` (interface for data/methods not required for completions generating, but required for rendering), and a bunch of smaller `*Render` structures which encapsulate logic behind rendering a certain item. This is just a step in full separation direction, since the following this are still to be done: - Move some data from `CompletionContext` to the `RenderContext`; - Forbid any kind of rendering outside of `render` module; - Extract score computing into a separate module. This PR is already pretty big, so not to make it even harder to review I decided to split this process into several subsequent PRs. Co-authored-by: Igor Aleksanov <[email protected]>
| * | Remove intra-crate facade from completionsIgor Aleksanov2020-11-032-10/+16
| | |
| * | Get rid of do-er antipatternIgor Aleksanov2020-11-037-45/+100
| | |
| * | Provide only explicit constructor for RenderContextIgor Aleksanov2020-11-032-16/+14
| | |
| * | Add doc-comments to the new filesIgor Aleksanov2020-11-036-1/+17
| | |
| * | Make structures order more logical in render.rsIgor Aleksanov2020-11-031-5/+5
| | |
| * | Move rendering tests to the render moduleIgor Aleksanov2020-11-036-1095/+1163
| | |
| * | Add TypeAliasRenderIgor Aleksanov2020-11-034-19/+54
| | |
| * | Add ConstRenderIgor Aleksanov2020-11-035-28/+65
| | |
| * | Introduce render moduleIgor Aleksanov2020-11-037-246/+457
| | |
* | | Merge #6447bors[bot]2020-11-031-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6447: Textmate grammar: allow function declarations without curly brackets r=lnicola a=dustypomerleau Functions inside trait declarations can break subsequent highlighting, because they have no curly brackets. In a case such as: ```rust pub trait Summary { fn summarize(&self) -> String; } ``` the scope `meta.function.definition.rust` will continue past the end of the block looking for `{` after `fn`. This PR allows `meta.function.definition.rust` to terminate with `;` in these cases. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | fix: allow functions without curly bracketsDusty Pomerleau2020-11-031-1/+1
| |/ /
* | | Merge #6421bors[bot]2020-11-031-30/+96
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6421: Check for allow(..) attributes in case check diagnostic r=popzxc a=popzxc Resolves #6348 This is not a full-fledged solution, as it doesn't looks up for parent elements (e.g. function -> module -> parent module -> crate root), but it does at least checks attributes of item being checked. I played a bit with code, and it seems that implementing a proper solution (which will also check for `deny` / `warn` attributes overriding values for `allow`s from above). So, this solution should fix all the macros which intentionally do "weird" naming and wrap it with `allow`, such as `lazy_static`. cc @ArifRoktim Co-authored-by: Igor Aleksanov <[email protected]>
| * | Improve decl_check module readabilityIgor Aleksanov2020-11-031-6/+6
| | |
| * | Remove numbers from comments in decl_check.rsIgor Aleksanov2020-11-031-15/+15
| | |
| * | Check for allow(..) attributes for case diagnosticIgor Aleksanov2020-11-031-25/+91
|/ /
* | Merge #6445bors[bot]2020-11-021-14/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6445: Fix coalescing of prime_caches updates r=jonas-schievink a=jonas-schievink The previous implementation could try to create a progress bar when one was already registered. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Fix coalescing of prime_caches updatesJonas Schievink2020-11-021-14/+14
| | | | | | | | | | | | | | | The previous implementation could try to create a progress bar when one was already registered
* | | Merge #6365bors[bot]2020-11-022-41/+121
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6365: Do insertion lookahead in algo::diff r=matklad a=Veykril This is the last blocker for #6287 after this I can update that PR to properly fix things through using `SyntaxRewriter`. This PR also shuffles tests around a bit and adds some more. Ideally this is just a hack until we implement a "proper" diff algorithm that approximates a minimal diff. Maybe something like [gumtree](https://github.com/GumTreeDiff/gumtree)? Co-authored-by: Lukas Wirth <[email protected]>
| * | | Do insertion lookahead in algo::diffLukas Wirth2020-10-262-41/+121
| | | |
| | | |
| \ \ \
*-. \ \ \ Merge #6393 #6399bors[bot]2020-11-022-15/+275
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6393: Remove repetitive inlay hints (take 2) r=matklad a=lnicola 6399: Keep generic annotations when qualifying things r=matklad a=Veykril The `qualify_path` assists currently eats up already annotated generics in all but one cases which can be annoying if one already pre-fills generics of a type before it's been qualified. Co-authored-by: Matthew Sanetra <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| | * | | Keep generic annotations when qualifying thingsLukas Wirth2020-10-291-13/+169
| | | | |
| * | | | Add check if param name is similar to fn nameMatthew Sanetra2020-10-281-2/+106
| | | | |
* | | | | Merge #6443bors[bot]2020-11-021-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6443: Remove unnecessary clone r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | Remove unnecessary cloneJonas Schievink2020-11-021-1/+1
|/ / / / /
* | | | | Merge #6441bors[bot]2020-11-021-9/+34
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6441: Coalesce prime_caches updates r=matklad a=jonas-schievink This reduces the number of progress bar updates we send to the client by collapsing subsequent updates into one. This doesn't work as well as I'd hoped (which is that we end up sending *no* updates, or only `start` and `end`, when the cache is already fresh), but it does reduce the number considerably: instead of ~720 updates on the rust-analyzer codebase, we now only send ~60. It uses the same approach that is already in use for coalescing VFS events. Hopefully this is enough to fix https://github.com/rust-analyzer/rust-analyzer/issues/6413. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | Remove debug printJonas Schievink2020-11-021-1/+0
| | | | | |
| * | | | | Coalesce prime_caches updatesJonas Schievink2020-11-021-9/+35
| | | | | |
* | | | | | Merge #6442bors[bot]2020-11-023-14/+14
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6442: Bump chalk and lexer r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | Bump chalk and lexerkjeremy2020-11-023-14/+14
|/ / / / /
* | | | | Merge #6440bors[bot]2020-11-0240-128/+121
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6440: Deny unreachable pub r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Update cratesAleksey Kladov2020-11-021-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | This is to bust the caches
| * | | | | Remove more unreachable pubsAleksey Kladov2020-11-0239-121/+114
|/ / / / /
* | | | | Merge #6438bors[bot]2020-11-0234-158/+157
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6438: Deny unreachable-pub r=matklad a=matklad It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs https://github.com/rust-lang/cargo/issues/5034. Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Deny unreachable-pubAleksey Kladov2020-11-0234-158/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs https://github.com/rust-lang/cargo/issues/5034.
* | | | | | Merge #6437bors[bot]2020-11-021-0/+54
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6437: Document doer object anti-pattern r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Update docs/dev/style.mdAleksey Kladov2020-11-021-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | | Document doer object anti-patternAleksey Kladov2020-11-021-0/+54
|/ / / / /
* | | | | Merge #6436bors[bot]2020-11-021-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6436: Textmate grammar: allow comments in attributes r=dustypomerleau a=dustypomerleau Fixes #6419 Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | | | fix: allow comments in attributesDusty Pomerleau2020-11-021-0/+6
|/ / / / /
* | | | | Merge #6423bors[bot]2020-10-311-18/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6423: cargo update r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | | cargo updateJeremy Kolb2020-10-311-18/+18
|/ / / / /
* | | | | Merge #6420bors[bot]2020-10-311-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6420: Update Cargo.toml r=flodiebold a=pksunkara This was blocking the automated publishing. Co-authored-by: Pavan Kumar Sunkara <[email protected]>
| * | | | | Update Cargo.tomlPavan Kumar Sunkara2020-10-311-1/+1
|/ / / / /
* | | | | Merge #6416bors[bot]2020-10-303-58/+62
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6416: Respond with JSON-RPC error if we failed to deserialize request r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 05:00:17 +0000