aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | :arrow_up: cratesAleksey Kladov2021-02-251-40/+8
|/ / / / /
* | | | | Merge #7741bors[bot]2021-02-244-0/+327
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall Implements one direction of #7681 I wonder if this tries to guess too much at the right thing here. A common pattern is: ```rust let col = vec![1, 2, 3]; for v in &mut col { *v *= 2; } // equivalent to: col.iter_mut().for_each(|v| *v *= 2); ``` I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind: 1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types) 2. Try to check if iter/iter_mut exists and they return the right iterator type 3. Don't try to do this and just add `.into_iter()` to whatever is after `in` Co-authored-by: Matt Hall <[email protected]>
| * | | | Address further review commentsMatt Hall2021-02-242-51/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use known names for iter/iter_mut method (simplifies checking if the method exists * Extract code to check assist with fixtures to function
| * | | | Address review commentsMatt Hall2021-02-231-33/+125
| | | | | | | | | | | | | | | | | | | | | | | | | * Move code to build replacement into closure * Look for iter/iter_mut methods on types behind reference
| * | | | Add convert_for_to_iter_for_each assistMatt Hall2021-02-233-0/+250
| |/ / /
* | | | Merge #7719bors[bot]2021-02-248-21/+137
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7719: De Morgan's Law assist now correctly parenthesizes binary expressions. r=Veykril a=lbrande Closes #7694 by parenthesizing binary expressions that are negated. Co-authored-by: lbrande <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Add tests for apply_demorganLukas Wirth2021-02-243-18/+83
| | | | |
| * | | | De Morgan's Law assist now correctly inverts <, <=, >, >=.lbrande2021-02-247-13/+68
| | | | |
| * | | | De Morgan's Law assist now correctly parenthesizes binary expressions.lbrande2021-02-243-11/+7
| | |/ / | |/| |
* | | | Merge #7775bors[bot]2021-02-241-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 7775: Fix typo. r=Veykril a=boxdot Co-authored-by: boxdot <[email protected]>
| * | | Fix typo.boxdot2021-02-241-1/+1
|/ / /
* | | Merge #7772bors[bot]2021-02-232-4/+36
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 7772: Pickup ConstReference patterns in FindUsages r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Pickup ConstReference patterns in FindUsagesLukas Wirth2021-02-232-4/+36
|/ /
* | Merge #7770bors[bot]2021-02-231-1/+4
|\ \ | |/ |/| | | | | | | | | | | | | 7770: reliable memory usage during benchmarking r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * reliable memory usage during benchmarkingAleksey Kladov2021-02-231-1/+4
| |
* | Merge #7769bors[bot]2021-02-231-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 7769: Update mio r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update miokjeremy2021-02-231-2/+2
| | |
* | | Merge #7768bors[bot]2021-02-234-9/+65
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 7768: Fix visibility computation when inside a block expression r=jonas-schievink a=jonas-schievink fixes https://github.com/rust-analyzer/rust-analyzer/issues/7728 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | is_visible_from_def_map: handle block expressionsJonas Schievink2021-02-233-9/+37
| | |
| * | Add testJonas Schievink2021-02-231-0/+28
| |/
* | Merge #7766bors[bot]2021-02-232-1630/+1852
|\ \ | |/ |/| | | | | | | | | | | 7766: Update our vscode npm packages r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * Update our vscode npm packageskjeremy2021-02-232-1630/+1852
|/
* Merge #7759bors[bot]2021-02-2286-50/+51
|\ | | | | | | | | | | | | | | | | 7759: 7526: Rename ide related crates r=Veykril a=chetankhilosiya renamed assists -> ide_assists and ssr -> ide_ssr. the completion crate is already renamed. Co-authored-by: Chetan Khilosiya <[email protected]>
| * 7526: Renamed create ssr to ide_ssr.Chetan Khilosiya2021-02-2216-24/+25
| |
| * 7526: Rename crate assists to ide_assists.Chetan Khilosiya2021-02-2273-26/+26
|/
* Merge #7756bors[bot]2021-02-222-22/+2
|\ | | | | | | | | | | | | | | 7756: update tracing-tree r=kjeremy a=kjeremy Removes some dependencies Co-authored-by: kjeremy <[email protected]>
| * update tidykjeremy2021-02-221-1/+0
| |
| * update tracing-treekjeremy2021-02-221-21/+2
|/
* Merge #7753bors[bot]2021-02-221-2/+1
|\ | | | | | | | | | | | | | | | | | | 7753: Add isize to the list of suffixed integers in typed_integer r=kjeremy a=jonasbb The missing `isize` in `typed_integers` seems to just be an oversight. Might fix: #7751 Co-authored-by: Jonas Bushart <[email protected]>
| * Add isize to the list of suffixed integers in typed_integerJonas Bushart2021-02-221-2/+1
| | | | | | | | | | | | The missing `isize` in `typed_integers` seems to just be an oversight. Might fix: #7751
* | Merge #7752bors[bot]2021-02-221-2/+2
|\ \ | |/ |/| | | | | | | | | | | 7752: up once_cell r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * up once_cellkjeremy2021-02-221-2/+2
| |
* | Merge #7749bors[bot]2021-02-225-42/+88
|\ \ | |/ |/| | | | | | | | | | | | | 7749: Make more common assist easier to ues r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Make more common assist easier to uesAleksey Kladov2021-02-225-42/+88
|/
* Merge #7739bors[bot]2021-02-215-28/+100
|\ | | | | | | | | | | | | | | | | | | 7739: Bump deps r=lnicola a=lnicola Closes #7273 bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * Pin ungrammarLaurențiu Nicola2021-02-212-3/+3
| |
| * Add test from #7273Laurențiu Nicola2021-02-211-0/+45
| |
| * Bump depsLaurențiu Nicola2021-02-213-29/+56
|/
* Merge #7735bors[bot]2021-02-211-4/+4
|\ | | | | | | | | | | | | | | 7735: Stop mixing Result and Option with ? in inline_local_variable r=Veykril a=scottmcm Depending on the discussion in https://github.com/rust-lang/rfcs/pull/3058 this might not end up being necessary, but I think it's a reasonable change regardless. Co-authored-by: Scott McMurray <[email protected]>
| * Stop mixing Result and Option with ? in inline_local_variableScott McMurray2021-02-201-4/+4
|/ | | | Depending on the discussion in RFC#3058 this might not end up being necessary, but I think it's a reasonable change regardless.
* Merge #7732bors[bot]2021-02-206-37/+45
|\ | | | | | | | | | | | | | | | | | | | | | | 7732: Don't lower TypeBound::Lifetime as GenericPredicate::Error r=flodiebold a=Veykril Basically we just discard the typebound for now instead when lowering to `GenericPredicate`. I think this shouldn't have any other side effects? Fixes #7683(hopefully for real this time) I also played around with introducing `GenericPredicate::LifetimeOutlives` and `GenericPredicate::TypeOutlives`(see https://github.com/Veykril/rust-analyzer/commit/b9d69048451a5f2e9c5a72c800369bbeef36fdcf) but that won't fix this issue(at least not for now) due to lifetime predicate mismatches when resolving methods so I figure this is a good way to fix it for now. Co-authored-by: Lukas Wirth <[email protected]>
| * Don't write trailing whitespace when formatting empty GenericPredicatesLukas Wirth2021-02-203-14/+24
| |
| * Don't lower TypeBound::Lifetime as GenericPredicate::ErrorLukas Wirth2021-02-204-25/+23
| |
* | Merge #7733bors[bot]2021-02-2011-20/+124
|\ \ | | | | | | | | | | | | | | | | | | | | | 7733: Update some crates r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Update testsJeremy Kolb2021-02-2010-0/+104
| | |
| * | Update some cratesJeremy Kolb2021-02-201-20/+20
|/ /
* | Merge #7729bors[bot]2021-02-201-2/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | 7729: Try to detect musl distros in the Code extension r=andylizi a=lnicola Fixes https://github.com/rust-analyzer/rust-analyzer/pull/7658#issuecomment-782701138 Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | Try to detect musl distros in the Code extensionLaurențiu Nicola2021-02-201-2/+12
| | |
* | | Merge #7730bors[bot]2021-02-201-2/+45
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 7730: Fix #7712 retain visibility extracting mod to file r=lnicola a=mattyhall Co-authored-by: Matt Hall <[email protected]>
| * | Use format_to! to make logic a bit nicerMatt Hall2021-02-201-6/+8
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 05:15:34 +0000