aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #9236bors[bot]2021-06-121-9/+9
|\ | | | | | | | | | | | | | | 9236: Fix some typos in flyimport docs r=SomeoneToIgnore a=SomeoneToIgnore bors r+ Co-authored-by: Kirill Bulatov <[email protected]>
| * Fix some typos in flyimport docsKirill Bulatov2021-06-121-9/+9
|/
* Merge #9233bors[bot]2021-06-127-1781/+1821
|\ | | | | | | | | | | | | | | | | 9233: Move some hir_ty diagnostics to hir r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Move some hir_ty diagnostics to hirAleksey Kladov2021-06-127-1781/+1821
| |
* | Merge #9231bors[bot]2021-06-124-6/+8
|\| | | | | | | | | | | | | | | | | 9231: minor: optimize r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * minor: optimizeAleksey Kladov2021-06-123-3/+6
| | | | | | | | | | We shouldn't be looking at the source map unless we actually have diagnostics.
| * minor: reduce visibilityAleksey Kladov2021-06-121-3/+2
| |
* | Merge #9230bors[bot]2021-06-127-405/+362
|\| | | | | | | | | | | | | | | | | 9230: internal: move inference diagnostics to hir r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * internal: move missing unsafe diagnostic to hirAleksey Kladov2021-06-126-166/+145
| |
| * internal: move inference diagnostics to hirAleksey Kladov2021-06-126-244/+222
| |
* | Merge #9229bors[bot]2021-06-121-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | 9229: minor: squelch "unused" warning r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * minor: squelch "unused" warningAleksey Kladov2021-06-121-1/+1
|/
* Merge #9204bors[bot]2021-06-112-5/+34
|\ | | | | | | | | | | | | | | | | | | 9204: feat: more accurate memory usage info on glibc Linux r=jonas-schievink a=jonas-schievink This adds support for the new `mallinfo2` API added in glibc 2.33. It addresses a shortcoming in the `mallinfo` API where it was unable to handle memory usage of more than 2 GB, which we sometimes exceed. Blocked on https://github.com/rust-lang/libc/pull/2228 Co-authored-by: Jonas Schievink <[email protected]>
| * Update libcJonas Schievink2021-06-111-2/+2
| |
| * Add support for mallinfo2 on glibc LinuxJonas Schievink2021-06-101-3/+32
| |
* | Merge #9223bors[bot]2021-06-114-10/+64
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 9223: Complete associated types in dyn and impl trait r=Veykril a=Veykril Fixes #9222 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Complete associated types in dyn and impl traitLukas Wirth2021-06-114-10/+64
| | |
* | | Merge #9221bors[bot]2021-06-113-4/+7
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 9221: fix: Highlight tuple field accesses correctly r=Veykril a=Veykril Fixes #9220 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Highlight tuple field accesses correctlyLukas Wirth2021-06-113-4/+7
|/ /
* | Merge #9219bors[bot]2021-06-112-3/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | 9219: minor: Replace some AssocItem::containing_trait calls trait_or_trait_impl r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Replace some AssocItem::containing_trait calls trait_or_trait_implLukas Wirth2021-06-112-3/+6
| | |
* | | Merge #9218bors[bot]2021-06-113-11/+215
|\| | | | | | | | | | | | | | | | | | | | | | | 9218: Item search now respects trait impl items r=Veykril a=Veykril Fixes #2977 Co-authored-by: Lukas Wirth <[email protected]>
| * | Item search now respects trait impl itemsLukas Wirth2021-06-113-11/+215
| | |
* | | Merge #9217bors[bot]2021-06-1144-680/+819
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9217: internal: Don't stringify and reparse `cfg_attr`-gated attributes r=jonas-schievink a=jonas-schievink Bumps ungrammar to include https://github.com/rust-analyzer/ungrammar/pull/33 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Don't stringify `cfg_attr`-gated attributesJonas Schievink2021-06-111-4/+18
| | | | | | | | | | | | | | | | This preserves the assigned `TokenId`s
| * | | Update ungrammarJonas Schievink2021-06-1143-676/+801
| | | |
* | | | Merge #9216bors[bot]2021-06-112-18/+21
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 9216: fix: Don't allow lookup by self for unprefixed self access completions r=Veykril a=Veykril Fixes #9211 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | Don't allow lookup by self for unprefixed self access completionsLukas Wirth2021-06-112-18/+21
| |/ /
* | | Merge #9215bors[bot]2021-06-111-2/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9215: change visibility for use and macro items r=jonas-schievink a=Maan2003 Co-authored-by: Maan2003 <[email protected]>
| * | | change visibility for use and macro itemsMaan20032021-06-111-2/+9
| | | |
* | | | Merge #9192bors[bot]2021-06-1110-79/+140
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9192: internal: Build test-macros in a build script r=jonas-schievink a=jonas-schievink This build the test-proc-macros in `proc_macro_test` in a build script, and copies the artifact to `OUT_DIR`. This should make it available throughout all of rust-analyzer at no cost other than depending on `proc_macro_test`, fixing https://github.com/rust-analyzer/rust-analyzer/issues/9067. This hopefully will let us later write inline tests that utilize proc macros, which makes my life fixing proc macro bugs easier. Opening this as a sort of RFC, because I'm not totally sure this approach is the best. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Try to fix unique file names on WindowsJonas Schievink2021-06-091-4/+7
| | | | |
| * | | | Build test-macros in a build scriptJonas Schievink2021-06-099-75/+133
| | | | |
* | | | | Merge #9209bors[bot]2021-06-111-1/+29
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9209: Don't suggest Remove unused param in trait impls r=Veykril a=Maan2003 See the added test for description Co-authored-by: Maan2003 <[email protected]>
| * | | | Don't suggest Remove unused param in trait implsMaan20032021-06-111-1/+29
|/ / / /
* | | | Merge #9208bors[bot]2021-06-117-14/+32
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9208: minor: Populate import maps eagerly to speed up flyimports r=SomeoneToIgnore a=SomeoneToIgnore Part of #7542 Follow up of https://github.com/rust-analyzer/rust-analyzer/pull/9206#issuecomment-859097783 Reduces `import_on_the_fly @ sel` case in the `integrated_completion_benchmark` by ~300ms. Also enables cache priming for manual workspace loading to reflect the results in the benchmarks. Before: <img width="1198" alt="image" src="https://user-images.githubusercontent.com/2690773/121606148-4a734a80-ca56-11eb-812a-7955e93817f1.png"> After: <img width="1200" alt="image" src="https://user-images.githubusercontent.com/2690773/121606156-4e06d180-ca56-11eb-891b-1ed878b53d7e.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | Only prefill caches in the completion benchmarkKirill Bulatov2021-06-115-5/+21
| | | | |
| * | | | Fix visibility issuesKirill Bulatov2021-06-111-5/+5
| | | | |
| * | | | Prime caches on workspace loadKirill Bulatov2021-06-112-2/+3
| | | | |
| * | | | Populate import maps eagerlyKirill Bulatov2021-06-101-3/+4
|/ / / /
* | | | Merge #9206bors[bot]2021-06-106-82/+97
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9206: minor: Speed up fst items lookup during completions r=SomeoneToIgnore a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/7542 A number of profile calls added for `import_on_the_fly` contents. Before: <img width="606" alt="Screenshot 2021-06-11 at 00 19 13" src="https://user-images.githubusercontent.com/2690773/121598998-22321e80-ca4b-11eb-9a3d-dc9cb2936705.png"> After: <img width="859" alt="Screenshot 2021-06-11 at 00 19 27" src="https://user-images.githubusercontent.com/2690773/121599022-2a8a5980-ca4b-11eb-82b6-13ab0ed56d58.png"> As a result, low hanging fruit was spotted: crazy amount of `fst_path` calls. Reducing that won ~200ms in the `import_on_the_fly @ sel` case in the `integrated_completion_benchmark`: <img width="861" alt="Screenshot 2021-06-11 at 00 19 38" src="https://user-images.githubusercontent.com/2690773/121599277-7d641100-ca4b-11eb-8667-53206994de27.png"> I'm not sure how to proceed with the remaining `???` marks in such methods as `collect_import_map` though: there's nothing but library calls in cycles, but maybe I'll come up with something later. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Reduce fst_path callsKirill Bulatov2021-06-101-11/+5
| | | |
| * | | Add more profiling for flyimportsKirill Bulatov2021-06-106-71/+92
|/ / /
* | | Merge #9202bors[bot]2021-06-103-0/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9202: feat: Make `MemoryUsage` work on Windows r=jonas-schievink a=jonas-schievink Unfortunately there is no convenient API for heap statistics, so this instead uses the Commit Charge value, which is the amount of memory that needs to be allocated either in physical RAM or in the page file. This approximation seems to be good enough to find queries that waste a large amount of memory, but it should generally be expected to be off by several MB. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Make `MemoryUsage` work on WindowsJonas Schievink2021-06-103-0/+20
| | | |
* | | | Merge #9196bors[bot]2021-06-092-5/+23
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 9196: fix: Don't classify attributes on macro-calls are the macro itself r=Veykril a=Veykril Fixes #9184 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | Don't classify attributes on macro-calls are the macro itselfLukas Wirth2021-06-092-5/+23
|/ / /
* | | Merge #9195bors[bot]2021-06-091-208/+178
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 9195: minor: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | SimplifyLukas Wirth2021-06-091-208/+178
| |/
* | Merge #9193bors[bot]2021-06-0910-11/+128
|\ \ | |/ |/| | | | | | | | | | | 9193: Implement dummy expansions for builtin attributes r=jonas-schievink a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 22:20:39 +0000