aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #2863bors[bot]2020-01-169-190/+88
|\ | | | | | | | | | | | | | | 2863: Minimize test r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Minimize testAleksey Kladov2020-01-167-129/+51
| |
| * Simplify array parsingAleksey Kladov2020-01-163-68/+44
|/
* Merge #2862bors[bot]2020-01-1616-430/+306
|\ | | | | | | | | | | | | | | 2862: Move from `from_source` to `SourceBinder` r=matklad a=matklad bors r+ Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix commentAleksey Kladov2020-01-161-3/+1
| |
| * Remove dead codeAleksey Kladov2020-01-161-34/+2
| |
| * Correctly discover module containersAleksey Kladov2020-01-161-11/+15
| |
| * Create modules via SourceBinderAleksey Kladov2020-01-1610-112/+65
| |
| * Move module to SourceBinderAleksey Kladov2020-01-165-55/+69
| |
| * Cache source for genericsAleksey Kladov2020-01-161-1/+20
| |
| * Move more stuff to SourceBinderAleksey Kladov2020-01-163-66/+70
| |
| * More natural trait setupAleksey Kladov2020-01-164-27/+49
| |
| * Removed FromSourceAleksey Kladov2020-01-161-165/+16
| |
| * Make FromSource privateAleksey Kladov2020-01-168-41/+84
| |
* | Merge #2827bors[bot]2020-01-165-36/+60
|\ \ | |/ |/| | | | | | | | | | | | | | | 2827: Fix array element attribute position r=matklad a=edwin0cheng This PR fixed a bug which an ATTR node insert in the wrong place in array element. ~~And introduce `precede_next` for allow outer attributes to insert into a parsed `expr`.~~ related #2783 Co-authored-by: Edwin Cheng <[email protected]>
| * fix formatingEdwin Cheng2020-01-161-1/+1
| |
| * Fix array element attribute positionEdwin Cheng2020-01-165-36/+60
| |
* | Merge #2861bors[bot]2020-01-161-39/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | 2861: Micro-optimize type hints to avoid allocations r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Micro-optimize type hints to avoid allocationsAleksey Kladov2020-01-161-39/+38
| | |
* | | Merge #2860bors[bot]2020-01-163-6/+12
|\| | | | | | | | | | | | | | | | | | | | | | | 2860: Minimize visibility r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Minimize visibilityAleksey Kladov2020-01-163-6/+12
|/ /
* | Merge #2837bors[bot]2020-01-1512-177/+4309
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 2837: Accidentally quadratic r=matklad a=matklad Our syntax highlighting is accdentally quadratic. Current state of the PR fixes it in a pretty crude way, looks like for the proper fix we need to redo how source-analyzer works. **NB:** don't be scared by diff stats, that's mostly a test-data file Co-authored-by: Aleksey Kladov <[email protected]>
| * | TyposAleksey Kladov2020-01-152-2/+2
| | |
| * | :arrow_up: once_cellAleksey Kladov2020-01-152-7/+9
| | |
| * | Add commentAleksey Kladov2020-01-151-0/+1
| | |
| * | Optimize inlay hintsAleksey Kladov2020-01-151-5/+6
| | |
| * | Only new-style classificationAleksey Kladov2020-01-155-28/+21
| | |
| * | Add a testAleksey Kladov2020-01-152-3/+4000
| | |
| * | Make syntax highlighting linearAleksey Kladov2020-01-154-57/+78
| | |
| * | Flip genericsAleksey Kladov2020-01-151-12/+12
| | |
| * | Store DB in SourceBinderAleksey Kladov2020-01-153-32/+33
| | |
| * | Introduce SourceBinderAleksey Kladov2020-01-155-101/+217
| | |
* | | Merge #2716bors[bot]2020-01-1511-43/+150
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2716: Allow assists with multiple selectable actions r=SomeoneToIgnore a=SomeoneToIgnore This PR prepares an infra for https://github.com/rust-analyzer/rust-analyzer/issues/2180 task by adding a possibility to specify multiple actions in one assist as multiple edit parameters to the `applySourceChange` command. When this is done, the command opens a selection dialog, allowing the user to pick the edit to be applied. I have no working example to test in this PR, but here's a demo of an auto import feature (a separate PR coming later for that one) using this functionality: ![out](https://user-images.githubusercontent.com/2690773/71633614-f8ea4d80-2c1d-11ea-9b15-0e13611a7aa4.gif) The PR is not that massive as it may seem: all the assist files' changes are very generic and similar. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Reduce visibilityKirill Bulatov2020-01-151-1/+1
| | | |
| * | | itertools::Either -> either::EitherKirill Bulatov2020-01-157-8/+8
| | | |
| * | | Apply the api design suggestionsKirill Bulatov2020-01-1510-59/+97
| | | |
| * | | Another attempt to add multiple editsKirill Bulatov2020-01-158-28/+97
|/ / /
* | | Merge #2856bors[bot]2020-01-153-19/+54
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2856: More orthogonal path editing r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | More orthogonal path editingAleksey Kladov2020-01-153-19/+54
| | | |
* | | | Merge #2855bors[bot]2020-01-155-48/+48
|\| | | | |/ / |/| | | | | | | | | | | | | | | | | 2855: More fluent API r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | More fluent APIAleksey Kladov2020-01-151-10/+12
| | |
| * | Slightly more fluent APIAleksey Kladov2020-01-152-14/+14
| | |
| * | SimplifyAleksey Kladov2020-01-151-5/+8
| | |
| * | SimplifyAleksey Kladov2020-01-151-7/+5
| | |
| * | RenameAleksey Kladov2020-01-153-17/+14
|/ /
* | Merge #2853bors[bot]2020-01-153-68/+97
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2853: Manage `cargo check` state updates in `main_loop` to reduce lock contention r=matklad a=kiljacken State is now updated exclusively from `main_loop` so several threads theoretically can't compete for the lock. Updates to the state are requested via the existing task channel. Also updates some naming to make slightly more sense. Based upon an idea/suggestion from @matklad on Zulip: > I think I've noticed at leas something suspicious! > > In WorldSnapshot, we store an Arc<RwLock<CheckWatcherSharedState>>. We read lock this lock in handle_diagnostics. > > Additionally, we .write this lock from the watcher thread in CheckWatcherState::run. > > I think in general this is less then ideal, b/c diagnostics request can be blocked on another thread. I think it makes sense to architect this in a way which does not block. > > For that, we stop sharing the state between ServerWorld and CheckWatcherState. Instead, the watcher thread sends new diagnostics via a channel, and we accomodate thouse diagnostics intot he server state in the main loop. > > So, instead of: > ```rust > struct Server { > diagnostics: Arc<Mutex<Vec<Diagnostics>>>, > } > > struct Watcher { > diagnostics: Arc<Mutex<Vec<Diagnostics>>>, > } > ``` > we'll have something like this: > ```rust > struct Server { > // this bit now *owns* diagnostics > diagnostisc: Vec<Diagnostics> > } > > struct Watcher { > diagnostics_sink: Sender<Vec<Diagnostics>>, > } > ``` > I am not sure this is the cuprit of slowness on widnows, but I think we should fix it, because it's very useful when all changes to the server's state can occur only via the main loop. > > Note how VFS is set up in a similar way: instead of modifing some global hash map with files, VFS sends a message to the main looop that hey, I have these new files for you. The main loop than incorporates the changes itself. > > Note that I think we'll still need some locks here, to share the state between ServerWorld and WorldSnapshot, but we won't actually be changing anyting mid-snapshot Co-authored-by: Emil Lauridsen <[email protected]>
| * | Extract check task handling into functionEmil Lauridsen2020-01-151-47/+56
| | |
| * | Tweak naming slightlyEmil Lauridsen2020-01-151-5/+5
| | |
| * | Manage check state updates in main_loop to reduce lock contentionEmil Lauridsen2020-01-153-44/+64
| | |
* | | Merge #2854bors[bot]2020-01-152-1/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 2854: Add logo r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 19:39:57 +0000