aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* do not suggest assist for return type to result in bad case #4826Benjamin Coenen2020-06-211-0/+3
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* do not suggest assist for return type to result in bad case #4826Benjamin Coenen2020-06-181-2/+28
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Merge #4941bors[bot]2020-06-182-8/+4
|\ | | | | | | | | | | | | | | | | | | | | 4941: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * SimplifyAleksey Kladov2020-06-182-8/+4
| |
* | Merge #4903bors[bot]2020-06-185-41/+56
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | 4903: Add highlighting support for doc comments r=matklad a=Nashenas88 The language server protocol includes a semantic modifier for documentation. This change exports that modifier for doc comments so users can choose to highlight them differently compared to regular comments. Example: <img width="375" alt="Screen Shot 2020-06-16 at 10 34 14 AM" src="https://user-images.githubusercontent.com/1673130/84788271-f6599580-afbc-11ea-96e5-7a0215da620b.png"> CC @woody77 Co-authored-by: Paul Daniel Faria <[email protected]>
| * Remove logic to mark all doctest code asPaul Daniel Faria2020-06-182-14/+13
| |
| * Ensure all existing doctest code highlights have documentation modifierPaul Daniel Faria2020-06-173-21/+22
| |
| * Add highlighting support for doc commentsPaul Daniel Faria2020-06-175-41/+56
| |
* | Merge #4935bors[bot]2020-06-182-10/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4935: Simplify r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | SimplifyAleksey Kladov2020-06-182-10/+4
| | |
* | | Merge #4821bors[bot]2020-06-182-9/+32
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 4821: display Doctest code lens before comment r=matklad a=bnjjj close #4785 Co-authored-by: Benjamin Coenen <[email protected]>
| * | display Doctest code lens before comment #4785Benjamin Coenen2020-06-182-9/+3
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | display Doctest code lens before comment #4785Benjamin Coenen2020-06-141-2/+2
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | display Doctest code lens before comment #4785Benjamin Coenen2020-06-092-3/+32
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #4872bors[bot]2020-06-181-46/+43
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4872: Reduce the usage of bare subscript operator r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | Reduce the usage of bare subscript operatorVeetaha2020-06-141-46/+43
| | | |
* | | | Merge #4934bors[bot]2020-06-186-212/+69
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4934: Remove special casing for library symbols r=matklad a=matklad We might as well handle them internally, via queries. I am not sure, but it looks like the current LibraryData setup might even predate salsa? It's not really needed and creates a bunch of complexity. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Remove special casing for library symbolsAleksey Kladov2020-06-186-212/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We might as well handle them internally, via queries. I am not sure, but it looks like the current LibraryData setup might even predate salsa? It's not really needed and creates a bunch of complexity.
* | | | | Merge #4932bors[bot]2020-06-181-10/+6
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4932: Simplify r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | | SimplifyVeetaha2020-06-181-10/+6
|/ / / /
* | | | Merge #4927bors[bot]2020-06-172-24/+30
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4927: Better encapsulate reverse-mapping of files to cargo targets r=matklad a=matklad We need to find a better way to do it... CrateGraph by itself is fine, CargoWorkspace as well, but the mapping between the two seems arbitrary... bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Better encapsulate reverse-mapping of files to cargo targetsAleksey Kladov2020-06-172-24/+30
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | We need to find a better way to do it... CrateGraph by itself is fine, CargoWorkspace as well, but the mapping between the two seems arbitrary...
* | | | Merge #4925bors[bot]2020-06-1712-5/+38
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4925: Syntax highlighting for escape sequences in strings r=matklad a=ltentrup I have added a new semantic token type `ESCAPE_SEQUENCE` as the LSP specification does not seem to have an appropriate token type. This may actually be a regression for some users, as the TextMate Rust grammar has a scope `constant.character.escape.rust` which highlights escape sequences (which caused problems with semantic highlighting, see #4138). Fixes #2604. Co-authored-by: Leander Tentrup <[email protected]>
| * | | Syntax highlighting for escape sequences in stringsLeander Tentrup2020-06-1712-5/+38
|/ / /
| | |
| \ \
| \ \
| \ \
*---. \ \ Merge #4913 #4915 #4916bors[bot]2020-06-1710-34/+426
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4913: Remove debugging code for incremental sync r=matklad a=lnicola 4915: Inspect markdown code fences to determine whether to apply syntax highlighting r=matklad a=ltentrup Fixes #4904 4916: Warnings as hint or info r=matklad a=GabbeV Fixes #4229 This PR is my second attempt at providing a solution to the above issue. My last PR(#4721) had to be rolled back(#4862) due to it overriding behavior many users expected. This PR solves a broader problem while trying to minimize surprises for the users. ### Problem description The underlying problem this PR tries to solve is the mismatch between [Rustc lint levels](https://doc.rust-lang.org/rustc/lints/levels.html) and [LSP diagnostic severity](https://microsoft.github.io/language-server-protocol/specification#diagnostic). Rustc currently doesn't have a lint level less severe than warning forcing the user to disable warnings if they think they get to noisy. LSP however provides two severitys below warning, information and hint. This allows editors like VSCode to provide more fine grained control over how prominently to show different diagnostics. Info severity shows a blue squiggly underline in code and can be filtered separately from errors and warnings in the problems panel. ![image](https://user-images.githubusercontent.com/13839236/84830640-0bb8d900-b02a-11ea-9e2f-0561b0e8f1ef.png) ![image](https://user-images.githubusercontent.com/13839236/84826931-ffca1880-b023-11ea-8080-5e5b91a6ac0d.png) Hint severity doesn't show up in the problems panel at all and only show three dots under the affected code or just faded text if the diagnostic also has the unnecessary tag. ![image](https://user-images.githubusercontent.com/13839236/84827165-55062a00-b024-11ea-8bd6-bdbf1217c4c5.png) ### Solution The solution provided by this PR allows the user to configure lists of of warnings to report as info severity and hint severity respectively. I purposefully only convert warnings and not errors as i believe it's a good idea to have the editor show the same severity as the compiler as much as possible. ![image](https://user-images.githubusercontent.com/13839236/84829609-50437500-b028-11ea-80a8-1bbd05680ba7.png) ### Open questions #### Discoverability How do we teach this to new and existing users? Should a section be added to the user manual? If so where and what should it say? #### Defaults Other languages such as TypeScript report unused code as hint by default. Should rust-analyzer similarly report some problems as hint/info by default? Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Leander Tentrup <[email protected]> Co-authored-by: Gabriel Valfridsson <[email protected]>
| | | * | | Warnings as hint or infoGabriel Valfridsson2020-06-167-13/+402
| | | | | |
| | * | | | Inspect markdown code fences to determine whether to apply syntax highlightingLeander Tentrup2020-06-163-4/+22
| | |/ / /
| * / / / Remove debugging code for incremental syncLaurențiu Nicola2020-06-161-17/+2
| |/ / /
* | | | Merge #4914bors[bot]2020-06-171-384/+406
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4914: Fix panic in match checking r=flodiebold a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/4416 Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Use ra_fixture and reformat testsJonas Schievink2020-06-161-387/+385
| | | | |
| * | | | Fix index-out-of-bounds panic in match checkingJonas Schievink2020-06-161-2/+26
| |/ / /
* | | | Merge #4919bors[bot]2020-06-171-54/+20
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 4919: Remove :expr from placeholders r=matklad a=davidlattimore Reasoning discussed at https://github.com/rust-analyzer/rust-analyzer/issues/3186#issuecomment-644069324 Co-authored-by: David Lattimore <[email protected]>
| * | | Remove :expr from placeholdersDavid Lattimore2020-06-171-54/+20
|/ / / | | | | | | | | | Reasoning discussed at #3186
* | | Merge #4911bors[bot]2020-06-161-29/+43
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4911: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | cargo updatekjeremy2020-06-161-29/+43
|/ / /
* | | Merge #4909bors[bot]2020-06-168-81/+67
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4909: Anchor file-system operations to the file, and not to the source root. r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Anchor file-system operations to the file, and not to the source root.Aleksey Kladov2020-06-168-81/+67
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Anchoring to the SourceRoot wont' work if the path is absolute: #[path = "/tmp/foo.rs"] mod foo; Anchoring to a file will. However, we *should* anchor, instead of just producing an abs path. I can imagine a situation where, for example, rust-analyzer processes crates from different machines (or, for example, from in-memory git branch), where the same absolute path in different crates might refer to different files in the end!
* | | Merge #4908bors[bot]2020-06-161-20/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4908: Fix typos in docs/dev/README.md r=kjeremy a=okaneco Small grammar and spelling changes in the README.md for the dev docs. Co-authored-by: okaneco <[email protected]>
| * | | Fix typos in docs/dev/README.mdokaneco2020-06-161-20/+20
|/ / / | | | | | | | | | Small grammar and spelling changes
* | | Merge #4891bors[bot]2020-06-168-0/+520
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4891: New VFS API r=matklad a=matklad cc @flodiebold , @jonas-schievink Co-authored-by: Aleksey Kladov <[email protected]>
| * | | New VFS APIAleksey Kladov2020-06-168-0/+520
| | | |
* | | | Merge #4876bors[bot]2020-06-1612-16/+102
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4876: Syntactic highlighting of NAME_REF for injections r=matklad a=ltentrup This commit adds a function that tries to determine the syntax highlighting class of NAME_REFs based on the usage. It is used for highlighting injections (such as highlighting of doctests) as the semantic logic will most of the time result in unresolved references. It also adds a color to unresolved references in HTML encoding. Follow up of #4683. Fixes #4809. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | Syntactic highlighting of NAME_REF for injectionsLeander Tentrup2020-06-1512-16/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a function that tries to determine the syntax highlighting class of NAME_REFs based on the usage. It is used for highlighting injections (such as highlighting of doctests) as the semantic logic will most of the time result in unresolved references. It also adds a color to unresolved references in HTML encoding.
* | | | | Merge #4878bors[bot]2020-06-165-59/+257
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4878: Make "Replace qualified name with use" replace *all* mentions of the path r=matklad a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/4836 Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Operate only on AST paths instead of HIRJonas Schievink2020-06-151-30/+36
| | | | |
| * | | | SimplifyJonas Schievink2020-06-151-13/+6
| | | | |
| * | | | It's fookin' rawJonas Schievink2020-06-151-48/+48
| | | | |
| * | | | Shorten *all* qualified paths when adding useJonas Schievink2020-06-132-11/+192
| | | | |
| * | | | Expose `find_insert_use_container`Jonas Schievink2020-06-132-8/+18
| | | | |
| * | | | Fix `rewrite_root` when there's only 1 replacementJonas Schievink2020-06-131-0/+8
| | |/ / | |/| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 02:44:07 +0000