aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * Don't show chaining hints for record literals and unit structsLaurențiu Nicola2020-04-011-10/+23
| |
* | Merge #3805bors[bot]2020-04-011-21/+33
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3805: lower literal patterns r=JoshMcguigan a=JoshMcguigan While working on #3706 I discovered literal patterns weren't being lowered. This PR implements that lowering. Questions for reviewers: 1. This re-uses the existing conversion from `ast::LiteralKind` to `Literal`, but `ast::LiteralKind` doesn't include information about the actual value of the literal, which causes `Literal` to be created with the default value for the type (rather than the actual value in the source code). Am I correct in thinking that we'd eventually want to change things in such a way that we could initialize the `Literal` with the actual literal value? Is there an existing issue for this, or else perhaps I should create one to discuss how it should be implemented? My main question would be whether `ast::LiteralKind` should be extended to hold the actual value, or if we should provide some other way to get that information from `ast::Literal`? 2. I couldn't find tests which directly cover this, but it does seem to work in #3706. Do we have unit tests for this lowering code? 3. I'm not sure why `lit.literal()` returns an `Option`. Is returning a `Pat::Missing` in the `None` case the right thing to do? 4. I was basically practicing type-system driven development to figure out the transformation from `ast::Pat::LiteralPat` to `Pat::Lit`. I don't have an immediate question here, but I just wanted to ensure this section is looked at closely during review. Co-authored-by: Josh Mcguigan <[email protected]>
| * | lower literal patternsJosh Mcguigan2020-04-011-21/+33
| | |
* | | Merge #3804bors[bot]2020-04-012-53/+38
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3804: Generalize flycheck to arbitrary commands r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Simplify error handingAleksey Kladov2020-04-011-38/+17
| | | |
| * | | Generalize FlycheckconfigAleksey Kladov2020-04-012-15/+21
|/ / /
* | | Merge #3779bors[bot]2020-04-014-363/+413
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3779: Complete only missing fields in pats r=matklad a=SomeoneToIgnore A follow-up for https://github.com/rust-analyzer/rust-analyzer/pull/3694 Same name vs string [issue](https://github.com/rust-analyzer/rust-analyzer/pull/3694#discussion_r396986819) persists here, now I'm able to obtain `ast::Name`, but I see no way to convert it into `hir::Name` or vice versa. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Unite record completion logic into a single moduleKirill Bulatov2020-04-014-450/+413
| | | |
| * | | Split draftKirill Bulatov2020-04-013-59/+85
| | | |
| * | | Complete only missing fields in patsKirill Bulatov2020-04-011-1/+62
| |/ /
* | | Merge #3803bors[bot]2020-04-013-39/+35
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3803: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | CleanupAleksey Kladov2020-04-013-39/+35
| | | |
* | | | Merge #3765bors[bot]2020-04-011-26/+90
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3765: Adds sort for RecordLit comparison in SSR r=edwin0cheng a=mikhail-m1 an item from #3186 Co-authored-by: Mikhail Modin <[email protected]>
| * | | Adds sort for RecordLit comparison in SSRMikhail Modin2020-04-011-26/+90
| | | |
* | | | Merge #3802bors[bot]2020-04-013-33/+34
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3802: Crisper name r=matklad a=matklad https://www.flycheck.org/en/latest/ bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | SimplifyAleksey Kladov2020-04-011-2/+2
| | | |
| * | | Crisper nameAleksey Kladov2020-04-013-22/+22
| | | | | | | | | | | | | | | | https://www.flycheck.org/en/latest/
| * | | Pull enabled check upAleksey Kladov2020-04-013-11/+12
|/ / /
* | | Merge #3799bors[bot]2020-04-011-87/+76
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | 3799: Streamline flycheck implementation r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Streamline flycheck implementationAleksey Kladov2020-04-011-80/+68
| | |
| * | sort importsAleksey Kladov2020-03-311-7/+8
|/ /
| |
| \
*-. \ Merge #3780 #3787bors[bot]2020-03-314-70/+134
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3780: Simplify r=matklad a=Veetaha I absolutely love tha fact that removing `.clone()` simplifies the code comparing to other languages where it's actually the contrary (ahem ~~`std::move()`~~) 3787: vscode: add syntax tree inspection hovers and highlights r=matklad a=Veetaha ![inspect-tree](https://user-images.githubusercontent.com/36276403/78029767-c7426900-7369-11ea-9ed6-b8a0f8e05bac.gif) I implemented the reverse mapping (when you hover in the rust editor), but it seems overcomplicated, so I removed it Related #3682 Co-authored-by: veetaha <[email protected]> Co-authored-by: Veetaha <[email protected]>
| | * \ vscode: small refactorveetaha2020-03-311-1/+1
| | |\ \
| | | * | vscode: apply review nitsVeetaha2020-03-311-1/+1
| | | | |
| | * | | vscode: scroll to the syntax node in rust editor when highlightingveetaha2020-03-311-1/+2
| | |/ /
| | * | vscode: add docs about syntax treeveetaha2020-03-311-0/+6
| | | |
| | * | vscode: use ctx.subscriptions instead of local .disposablesveetaha2020-03-311-15/+12
| | | |
| | * | vscode: add syntax tree inspection hovers and highlightsveetaha2020-03-312-55/+118
| | | |
| * | | Simplifyveetaha2020-03-311-16/+13
| |/ /
* | | Merge #3795bors[bot]2020-03-314-39/+40
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3795: Reduce deps r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Reduce depsAleksey Kladov2020-03-314-39/+40
|/ / /
* | | Merge #3793bors[bot]2020-03-312-5/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3793: Add integrated test for concat include env r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Add integrated test for concat include envAleksey Kladov2020-03-312-5/+62
|/ / /
* | | Merge #3792bors[bot]2020-03-3118-29/+29
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3792: Rename cargo_watch -> flycheck r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Rename cargo_watch -> flycheckAleksey Kladov2020-03-3118-29/+29
| | | |
* | | | Merge #3791bors[bot]2020-03-311-33/+17
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3791: Revert accidental package.json changes r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Revert accidental package.json changesAleksey Kladov2020-03-311-33/+17
|/ / /
* | | Merge #3738bors[bot]2020-03-3111-23/+696
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3738: Implement ra_proc_macro client logic r=matklad a=edwin0cheng This PR add the actual client logic for `ra_proc_macro` crate: 1. Define all necessary rpc serialization data structure, which include `ra_tt` related data and some task messages. Although adding `Serialize` and `Deserialize` trait to ra_tt directly seem to be much easier, we deliberately duplicate the `ra_tt` struct with `#[serde(with = "XXDef")]` for separation of code responsibility. 2. Define a simplified version of lsp base protocol for rpc, which basically copy from lsp-server code base. 3. Implement the actual `IO` for the client side progress spawning and message passing. Co-authored-by: Edwin Cheng <[email protected]>
| * | | Fix rebasedEdwin Cheng2020-03-311-1/+1
| | | |
| * | | Redirect stderr to nullEdwin Cheng2020-03-311-0/+1
| | | |
| * | | Pipe error to stderrEdwin Cheng2020-03-311-2/+5
| | | |
| * | | Refactor a bitEdwin Cheng2020-03-311-11/+9
| | | |
| * | | Use a weak ptr to hold the send end of channelEdwin Cheng2020-03-311-28/+18
| | | |
| * | | Add drop for processEdwin Cheng2020-03-311-2/+6
| | | |
| * | | Unwrap channel send()Edwin Cheng2020-03-311-13/+4
| | | |
| * | | Use jod_threadEdwin Cheng2020-03-313-17/+16
| | | |
| * | | Fix formattingEdwin Cheng2020-03-312-6/+6
| | | |
| * | | Simple cross-process message protocolEdwin Cheng2020-03-313-225/+86
| | | |
| * | | Remove unused structEdwin Cheng2020-03-311-10/+5
| | | |
| * | | Improve shutdown processEdwin Cheng2020-03-312-19/+54
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-15 19:37:06 +0000