aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6172bors[bot]2020-10-206-24/+1090
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6172: Add qualify path assist r=matklad a=Veykril This implements a `qualify_path` assist which works quite similar to the `auto_import` assist but instead of adding imports to the file it well, qualifies the path. This PR also moves out the `AutoImportAssets` struct and functions from `auto_import` into a utils submodule as most of this is now shared between `auto_import` and `qualify_path`. Changes made to `AutoImportAssets` are solely in its `search_for_imports` function which now takes a prefixed parameter to discern between using `find_use_path_prefixed` and `find_use_path` as the former is the required behavior by `auto_import` and the latter by this assist. For missing imported traits instead of importing this will qualify the path with a trait cast as in: ```rust test_mod::TestStruct::TEST_CONST<|> ``` becomes ```rust <test_mod::TestStruct as test_mod::TestTrait>::TEST_CONST ``` and for trait methods ideally it would do the following: ```rust let test_struct = test_mod::TestStruct {}; test_struct.test_meth<|>od() ``` becomes ```rust let test_struct = test_mod::TestStruct {}; test_mod::TestTrait::test_method(&test_struct) ``` Fixes #4124. Co-authored-by: Lukas Wirth <[email protected]>
| * De-duplicate `add_group` callsite in qualify_pathLukas Wirth2020-10-161-121/+108
| |
| * Properly qualify trait methods in qualify_path assistLukas Wirth2020-10-155-70/+118
| |
| * Add mark tests to qualify_path assistLukas Wirth2020-10-141-0/+9
| |
| * Add qualify path assistLukas Wirth2020-10-142-0/+1022
| |
* | Merge #6299bors[bot]2020-10-208-67/+141
|\ \ | | | | | | | | | | | | | | | | | | | | | 6299: Diagnose items that are #[cfg]d out r=jonas-schievink a=jonas-schievink This emits a hint-level diagnostic with `Unnecessary` tag to "gray out" any items whose `#[cfg]` attributes remove the item before name resolution. Co-authored-by: Jonas Schievink <[email protected]>
| * | Fixup botched renameJonas Schievink2020-10-201-1/+1
| | |
| * | More detailed messageJonas Schievink2020-10-201-1/+1
| | |
| * | Rename UnconfiguredCode -> InactiveCodeJonas Schievink2020-10-203-5/+5
| | |
| * | Add a (hint) diagnostic for unconfigured itemsJonas Schievink2020-10-206-3/+86
| | |
| * | Simplify diagnostic construction, add unused fieldJonas Schievink2020-10-203-64/+55
| | |
* | | Merge #6301bors[bot]2020-10-204-19/+29
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6301: Don't rely on display names in inlay_hints r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Don't rely on display names in inlay_hintsAleksey Kladov2020-10-204-19/+29
|/ /
* | Merge #6297bors[bot]2020-10-203-3/+10
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6297: Support Display name in project.json r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Support Display name in project.jsonAleksey Kladov2020-10-203-3/+10
| | |
* | | Merge #6295bors[bot]2020-10-2014-47/+76
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 6295: More type safety around names r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | More type safety around namesAleksey Kladov2020-10-206-19/+33
| | |
| * | Introduce CrateDisplayNameAleksey Kladov2020-10-201-1/+23
| | |
| * | Rename declaration_name -> display_nameAleksey Kladov2020-10-2011-35/+28
|/ / | | | | | | | | | | | | | | Declaration names sounds like a name of declaration -- something you can use for analysis. It empathically isn't, and is just a label displayed in various UI. It's important not to confuse the two, least we accidentally mix semantics with UI (I believe, there's already a case of this in the FamousDefs at least).
* | Merge #6294bors[bot]2020-10-202-0/+28
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6294: Add a hacky remidy for #6038 r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add a hacky remidy for #6038Aleksey Kladov2020-10-202-0/+28
| | | | | | | | | | | | | | | | | | | | | The proper fix I think is: * move rust-lang/rust library crates to a separate workspace * when packaging rust-src component, vendor sources of external deps
* | | Merge #6266bors[bot]2020-10-2010-6/+156
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6266: Generate diagnostics docs r=matklad a=popzxc Resolves #6215 Co-authored-by: Igor Aleksanov <[email protected]>
| * | Add generated_diagnostic.adoc to the release.rs and smoke_test_docs_generationIgor Aleksanov2020-10-192-1/+9
| | |
| * | Use xshell::read_file instead of fs::read_to_stringIgor Aleksanov2020-10-194-9/+10
| | |
| * | Add descriptions for diagnostics parseable by xtaskIgor Aleksanov2020-10-192-0/+64
| | |
| * | Create xtask module to generate diagnostics docsIgor Aleksanov2020-10-193-0/+77
|/ /
* | Merge #6290bors[bot]2020-10-191-3/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6290: Fix deprecation warning r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fix deprecation warningAleksey Kladov2020-10-191-3/+3
|/ / | | | | | | See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
* | Merge #6288bors[bot]2020-10-191-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6288: Tag release branch rather than master r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Tag release branch rather than masterAleksey Kladov2020-10-191-0/+1
|/ /
* | Merge #6274bors[bot]2020-10-191-1/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | 6274: Check cargoExtraArgs for undefined before using r=matklad a=feileacan Fixes #6273 Co-authored-by: feileacan <[email protected]>
| * | Check cargoExtraArgs for undefined before usingfeileacan2020-10-181-1/+3
| | |
* | | Merge #6284bors[bot]2020-10-191-0/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6284: Document logging of project model r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Document logging of project modelAleksey Kladov2020-10-191-0/+1
|/ / /
* | | Merge #6283bors[bot]2020-10-191-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6283: Minor, rename feature r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Minor, rename featureAleksey Kladov2020-10-191-1/+1
|/ / /
* | | Merge #6282bors[bot]2020-10-191-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6282: Try to fix publishing r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Try to fix publishingAleksey Kladov2020-10-191-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This errro specifically: Updating crates.io index error: failed to select a version for the requirement `ra_ap_stdx = "^0.0.0"` candidate versions found which didn't match: 0.0.20 location searched: /home/runner/work/rust-analyzer/rust-analyzer/crates/stdx required by package `ra_ap_completion v0.0.20 (/home/runner/work/rust-analyzer/rust-analyzer/crates/completion)` error: unable to update Cargo.lock Error: Process completed with exit code 1.
* | | Merge #6280bors[bot]2020-10-191-6/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6280: :arrow_up: crates r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: cratesAleksey Kladov2020-10-191-6/+6
|/ / /
* | | Merge #6277bors[bot]2020-10-182-5/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6277: Change visibility works for type aliases r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Change visibility works for type aliasesAleksey Kladov2020-10-182-5/+19
|/ / /
* | | Merge #6276bors[bot]2020-10-1834-227/+337
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6276: Extract call_info and completion into separate crates r=matklad a=popzxc As it was discussed in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Completion.20refactoring), we need to move `completions` into a separate crate. Unfortunately, the dependency on `call_info::ActiveParameter` doesn't look easy to get rid of, and it seems to be a topic for a separate PR, thus I also extracted `call_info` into a separate crate (on which both `ide` and `completion` crates depend). Additionally, a few `FIXME`s in doc-comments were resolved in order to make `tidy` happy. Co-authored-by: Igor Aleksanov <[email protected]>
| * | | Extract call_info and completion into separate cratesIgor Aleksanov2020-10-1834-227/+337
|/ / /
* | | Merge #6275bors[bot]2020-10-181-14/+6
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | 6275: Textmate grammar: prevent unwanted interpolation scopes r=matklad a=dustypomerleau Fixes the issues noted by @matklad after merging #6248. 1. prevent accidental interpolation scopes when `{` is used in a string 1. prevent interpolations from extending beyond the end of a string Co-authored-by: Dusty Pomerleau <[email protected]>
| * | fix: prevent unwanted interpolation scopesDusty Pomerleau2020-10-181-14/+6
|/ /
* | Merge #6272bors[bot]2020-10-182-9/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6272: :arrow_up: xshell r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | update depsAleksey Kladov2020-10-182-5/+5
| | |
| * | :arrow_up: xshellAleksey Kladov2020-10-181-4/+4
|/ /
* | Merge #6271bors[bot]2020-10-173-2/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6271: Complete methods when receiver is a macro r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-22 14:18:06 +0000