aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #9304bors[bot]2021-06-166-159/+212
|\ \ | |/ |/| | | | | | | | | | | | | 9304: internal: cleanup tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * internal: cleanup testsAleksey Kladov2021-06-162-72/+140
| |
| * internal: switch some tests to minicoreAleksey Kladov2021-06-162-15/+8
| |
| * internal: add iterator to minicoreAleksey Kladov2021-06-162-39/+38
| |
| * internal: switch some tests to minicoreAleksey Kladov2021-06-161-15/+12
| |
| * internal: switch some tests to minicoreAleksey Kladov2021-06-161-19/+15
| |
* | Merge #9301bors[bot]2021-06-1626-414/+430
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | 9301: internal: Start refactoring ide_completion tests r=Veykril a=Veykril Our current completion test infra resovles around usually just checking a specific `CompletionKind` which is suboptimal. We only see what we want to see in tests with this causing us to miss a lot of incorrect completions we are doing. Instead we should test for different cursor locations for all kinds(sans the magic kind maybe? not sure yet). This way we will also see potential duplicate completions that merely different in their kind. Also since most completion submodules complete things in tests of other modules due to the tests overlapping it makes more sense to group these tests differently which implies moving them to a new module. Exceptions for this might be stuff like attribute completion as these cannot currently interfere. I only wrote a few tests to check for completions in `ItemList` position so far and I already found a few incorrect/irrelevant completions as these haven't been tested properly due to them being hidden by the `CompletionKind` filtering. I think `CompletionKind` doesn't really seem to be beneficial to me as to I can't think of a occasion where we would want to only check a specific completion kind. Co-authored-by: Lukas Wirth <[email protected]>
| * Move test_utils into tests moduleLukas Wirth2021-06-1626-238/+194
| |
| * Don't complete paths after attributesLukas Wirth2021-06-167-135/+123
| |
| * Don't show incorrect completions after unsafe or visiblity nodeLukas Wirth2021-06-164-42/+38
| |
| * Don't complete visibility accessors after existing onesLukas Wirth2021-06-164-3/+24
| |
| * Start refactoring ide_completion testsLukas Wirth2021-06-169-247/+302
|/
* Merge #9302bors[bot]2021-06-161-7/+67
|\ | | | | | | | | | | | | | | 9302: internal: Add builtin derives to attribute completion fixtures r=Veykril a=Veykril bors R+ Co-authored-by: Lukas Wirth <[email protected]>
| * Don't complete already used derive attributesLukas Wirth2021-06-161-20/+20
| |
| * Add builtin derives to attribute completion fixturesLukas Wirth2021-06-161-7/+67
| |
* | Merge #9258bors[bot]2021-06-162-8/+10
|\ \ | | | | | | | | | | | | | | | | | | | | | 9258: minor: Give `ImportPrefix` variants better config names r=matklad a=Veykril I feel like `crate` and `self` work better than `by_crate` and `by_self`. The only reason for the current names were that `Self` doesn't work for the variant name on the rust side so I forgot about setting proper config names on serde layer. Co-authored-by: Lukas Wirth <[email protected]>
| * | Give ImportPrefix variants better config namesLukas Wirth2021-06-132-8/+10
| | |
* | | Merge #9300bors[bot]2021-06-163-66/+34
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 9300: minor: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | SimplifyLukas Wirth2021-06-163-66/+34
|/ /
* | Merge #9299bors[bot]2021-06-166-71/+94
|\ \ | | | | | | | | | | | | | | | | | | | | | 9299: minor: Filter out non-type completions in the respective completions modules instead r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Filter out non-type completions in the respective completions modules insteadLukas Wirth2021-06-166-71/+94
| | |
* | | Merge #9297bors[bot]2021-06-167-345/+307
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9297: internal: add fn to minicore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | internal: add fn to minicoreAleksey Kladov2021-06-166-310/+258
| | | |
| * | | internal: add deref_mut to minicoreAleksey Kladov2021-06-163-35/+49
|/ / /
| | |
| \ \
*-. \ \ Merge #9267 #9279bors[bot]2021-06-155-21/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9267: fix: Code: update the LSP server without asking r=matklad a=lnicola Most LSP extensions seem to do the same thing, and this is causing some confusion for users who don't notice the update prompt before Code hides it. 9279: minor: Document installation via Homebrew r=matklad a=Svetlitski `rust-analyzer` can be installed via [Homebrew](https://brew.sh) (AKA`brew`) on macOS. I've added instructions on how to do so to the documentation. Additionally, I added a `.gitignore` rule to ignore the HTML documentation produced by `asciidoctor manual.adoc` so that it is not accidentally checked into `git`. Co-authored-by: LaurenČ›iu Nicola <[email protected]> Co-authored-by: Kevin Svetlitski <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| | * | | Update docs/user/manual.adocAleksey Kladov2021-06-151-1/+1
| | | | |
| | * | | Document installation via Homebrew; Add gitignore entry for asciidoctor outputKevin Svetlitski2021-06-142-0/+10
| | | | |
| * | | | Consolidate the privacy notesLaurențiu Nicola2021-06-153-20/+13
| | | | |
| * | | | Code: automatically update the LSP serverLaurențiu Nicola2021-06-142-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most LSP extensions seem to do the same thing, and this is causing some confusion for users who don't notice the update prompt before Code hides it.
* | | | | Merge #9293bors[bot]2021-06-151-3/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9293: fix: Show diagnostic fixes before assists r=matklad a=lnicola Closes #9212 Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | | | Show diagnostic fixes before assistsLaurențiu Nicola2021-06-151-3/+4
| | | | | |
* | | | | | Merge #9294bors[bot]2021-06-1513-1027/+1149
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9294: internal: introduce minicore -- a subset of libcore for testing r=matklad a=matklad Clearly, we need one more fixed point iteration loop! Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-18/+9
| | | | | | |
| * | | | | | internal: add result to minicoreAleksey Kladov2021-06-152-21/+18
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-151-17/+3
| | | | | | |
| * | | | | | internal: add option to minicoreAleksey Kladov2021-06-153-41/+25
| | | | | | |
| * | | | | | internal: add future to minicoreAleksey Kladov2021-06-152-12/+39
| | | | | | |
| * | | | | | internal: sanity-check minicore flagsAleksey Kladov2021-06-152-2/+11
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-153-70/+59
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-55/+32
| | | | | | |
| * | | | | | internal: add ranges to minicoreAleksey Kladov2021-06-152-28/+42
| | | | | | |
| * | | | | | internal: unindent some testsAleksey Kladov2021-06-151-255/+252
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-111/+102
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-153-62/+75
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-151-181/+129
| | | | | | |
| * | | | | | internal: switch some tests to minicoreAleksey Kladov2021-06-152-118/+88
| | | | | | |
| * | | | | | internal: introduce minicore -- a subset of libcore for testingAleksey Kladov2021-06-156-42/+271
| | | | | | |
* | | | | | | Merge #9292bors[bot]2021-06-153-15/+23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9292: fix: Code: clean-up #8951 r=wxb1ank a=wxb1ank #8951 was a major change in the VS Code extension and caused quite a few problems. This PR is a catch-all for bugs and improvements in the new code. This should fix: - #9284 - [this unreported bug](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) - ...and one or two uncaught exceptions I just found The original lack of testing was my own fault, but this area of the VS Code API is also tricky for a couple reasons: - The [FileSystem](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) API does not list or warn about any exceptions, but [FileSystemProvider](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) (which `FileSystem` is a wrapper of, AFAICT) does. - At first glance, [Uri.path](https://github.com/rust-analyzer/rust-analyzer/pull/8951/files#r651570446) *looks* like it works for FS operations. It does not, at least, on Windows. You need to use `Uri.fsPath`. I only use Windows, so I need people on macOS, Linux, and (possibly) NixOS to test this. Co-authored-by: wxb1ank <[email protected]>
| * | | | | | | Use `.then()` for Thenablewxb1ank2021-06-151-3/+1
| | | | | | | |
| * | | | | | | fix: clean-up #8951wxb1ank2021-06-153-15/+25
| | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-26 16:12:30 +0000