aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Use TextRange::contains_inclusive in fixes checkIgor Aleksanov2020-10-122-5/+4
|
* Keep SyntaxNodePtr::range privateIgor Aleksanov2020-10-124-9/+17
|
* Replace 'if let' with 'match' in decl_check.rsIgor Aleksanov2020-10-121-30/+33
|
* Add to_upper_snake_case function to stdxIgor Aleksanov2020-10-123-6/+13
|
* Fix compilation errorIgor Aleksanov2020-10-121-2/+1
|
* Apply suggestions from code reviewIgor Aleksanov2020-10-122-3/+3
| | | Co-authored-by: Lukas Wirth <[email protected]>
* Fix code style issuesIgor Aleksanov2020-10-123-4/+7
|
* Apply case check diagnostic to impl itemsIgor Aleksanov2020-10-122-1/+26
|
* Fix issues with match arm bindingsIgor Aleksanov2020-10-121-7/+12
|
* Code style adjustmentsIgor Aleksanov2020-10-123-8/+88
|
* Remove previously added parameter names from the function dataIgor Aleksanov2020-10-123-18/+0
|
* Make incorrect case diagnostic work inside of functionsIgor Aleksanov2020-10-124-33/+280
|
* Refactor string helpers for decl_check moduleIgor Aleksanov2020-10-121-32/+97
|
* Add diagnostics for enum names and variantsIgor Aleksanov2020-10-123-2/+173
|
* Add fix for incorrect case diagnosticIgor Aleksanov2020-10-128-30/+112
|
* Improve string helpers functionsIgor Aleksanov2020-10-122-2/+13
|
* Check structure fields to be snake_caseIgor Aleksanov2020-10-121-46/+65
|
* Add check for structure names to be CamelCaseIgor Aleksanov2020-10-122-1/+139
|
* Extract helper functions into a separate moduleIgor Aleksanov2020-10-122-29/+112
|
* Add checks for function parametersIgor Aleksanov2020-10-122-7/+94
|
* Create basic support for names case checks and implement function name case ↵Igor Aleksanov2020-10-126-3/+300
| | | | check
* Merge #5917bors[bot]2020-10-1217-32/+403
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5917: Add a command to open docs for the symbol under the cursor r=matklad a=zacps #### Todo - [ ] Decide if there should be a default keybind or context menu entry - [x] Figure out how to get the documentation path for methods and other non-top-level defs - [x] Design the protocol extension. In future we'll probably want parameters for local/remote documentation URLs, so that should maybe be done in this PR? - [x] Code organisation - [x] Tests Co-authored-by: Zac Pullar-Strecker <[email protected]>
| * Remove methodowner & fix formattingZac Pullar-Strecker2020-10-084-53/+27
| |
| * Rebase fixesZac Pullar-Strecker2020-10-082-14/+6
| |
| * Changes from reviewZac Pullar-Strecker2020-10-081-3/+3
| |
| * Remove outdated part of doc_links module docsZac Pullar-Strecker2020-10-081-2/+0
| |
| * Add ignored test to demonstrate ImportMap bugZac Pullar-Strecker2020-10-081-1/+26
| |
| * Fix namespace detection & function testZac Pullar-Strecker2020-10-081-6/+2
| |
| * Add testsZac Pullar-Strecker2020-10-081-2/+94
| |
| * Update tests for new function fieldZac Pullar-Strecker2020-10-081-12/+12
| |
| * Fix send->sent typoZac Pullar-Strecker2020-10-081-7/+7
| |
| * Change Option::Some bug to a fixme noteZac Pullar-Strecker2020-10-082-3/+4
| | | | | | | | IMO this is too much work to be worth fixing at the moment.
| * Differentiate method/tymethod by determining 'defaultness'Zac Pullar-Strecker2020-10-087-9/+31
| | | | | | | | | | | | | | | | | | Currently a method only has defaultness if it is a provided trait method, but this will change when specialisation is available and may need to become a concept known to hir. I opted to go for a 'fewest changes' approach given specialisation is still under development.
| * Document the protocol extensionZac Pullar-Strecker2020-10-081-1/+12
| |
| * Code reorganisation and field supportZac Pullar-Strecker2020-10-086-60/+105
| |
| * Changes from reviewZac Pullar-Strecker2020-10-086-47/+14
| |
| * Rename ide::link_rewrite -> ide::doc_links & tidy importsZac Pullar-Strecker2020-10-083-4/+4
| |
| * Add support for struct & trait methodsZac Pullar-Strecker2020-10-081-7/+83
| |
| * WIP: Command to open docs under cursorZac Pullar-Strecker2020-10-089-4/+176
| |
* | Merge #6200bors[bot]2020-10-122-30/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | 6200: Update crates r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update crateskjeremy2020-10-112-30/+30
|/ /
* | Merge #5858bors[bot]2020-10-104-61/+138
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5858: Draft: Show reason for failed rename refactoring r=rherrmann a=rherrmann Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors, raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Screenshot of a rename error showing in VS Code ![invalid-rename-ui](https://user-images.githubusercontent.com/607182/91059560-2c08a380-e62a-11ea-9297-f092db935a3b.png) I would kindly ask to get feedback from the maintainers if they can spare the time: * Is the general direction of the proposed changes acceptable? * I'm new to Rust. The code feels clumsy and redundant, please suggest improvements if you find the time for. E.g. is there a simple replacement for `RenameError`? * Should presenting the error with proper severity (i.e. not as a programming error) be part of this change or in a followup change? See https://github.com/rust-analyzer/rust-analyzer/issues/3981 Co-authored-by: Rüdiger Herrmann <[email protected]>
| * | Show reason for failed rename refactoringRüdiger Herrmann2020-10-104-61/+138
|/ / | | | | | | | | | | | | | | | | | | | | Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Resolves https://github.com/rust-analyzer/rust-analyzer/issues/3981
* | Merge #6176bors[bot]2020-10-101-0/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | 6176: add eprintln in fmt-like postfix r=SomeoneToIgnore a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]>
| * | add eprintln in fmt-like postfixBenjamin Coenen2020-10-081-0/+2
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #6187bors[bot]2020-10-091-12/+0
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6187: Remove release build overrides r=jonas-schievink a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Remove release build overridesLaurențiu Nicola2020-10-091-12/+0
| | | |
* | | | Merge #6189bors[bot]2020-10-093-15/+47
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6189: adt: correctly inherit field visibility from enum r=jonas-schievink a=jonas-schievink Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | | adt: correctly inherit field visibility from enumJonas Schievink2020-10-093-15/+47
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility.
* | | | Merge #6188bors[bot]2020-10-092-43/+119
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6188: Treat `ast::Name` in field patterns as use r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>