aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge #4365bors[bot]2020-05-071-0/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4365: Use the correct color for structs r=matklad a=matklad This works around https://github.com/microsoft/vscode/issues/97162 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Use the correct color for structsAleksey Kladov2020-05-071-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | This works around https://github.com/microsoft/vscode/issues/97162
* | | | | | Merge #4346bors[bot]2020-05-072-2/+70
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4346: Fix rename of enum variant visible from module r=matklad a=montekki Probably fixes #4237 It looks like the ref is found correctly in this case but it's visibility is not correctly determined. I took a stab at fixing that by adding an implementation of `HasVisibility` for `EnumVariant` so it works more or less the same way it does for struct fields. In other words, the `search_range` here does not contain the ref since it's not considered visible: https://github.com/rust-analyzer/rust-analyzer/blob/efd8e34c396f1524623a495e47111f1047cf2879/crates/ra_ide_db/src/search.rs#L209-L214 Before that I tried to populate `ItemScope` with visible enum variants but that ended up with breaking tests all over the place and also it looked illogical in the end: `ItemScope` is not populated with, say, public struct fields and the same should be true for `enum` variants. I've added two more or less identical tests: one for the case with a struct field rename and one for enum variant rename; the test for struct should probably be removed and the names should be changed. Co-authored-by: Fedor Sakharov <[email protected]>
| * | | | | Remove HasVisibility implementationFedor Sakharov2020-05-073-12/+6
| | | | | |
| * | | | | Fix rename of enum variant visible from moduleFedor Sakharov2020-05-064-2/+76
| | | | | |
* | | | | | Merge #4364bors[bot]2020-05-078-70/+69
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4364: Touch up assists public API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | SimplifyAleksey Kladov2020-05-075-6/+5
| | | | | | |
| * | | | | | Nicer APIAleksey Kladov2020-05-073-42/+42
| | | | | | |
| * | | | | | Rename AssitLabel -> AssistAleksey Kladov2020-05-074-24/+24
|/ / / / / /
* | | | | | Merge #4350bors[bot]2020-05-0738-593/+521
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4350: Refactor assists API to be more convenient for adding new assists r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Refactor assists API to be more convenient for adding new assistsAleksey Kladov2020-05-0738-593/+521
|/ / / / / / | | | | | | | | | | | | | | | | | | It now duplicates completion API in its shape.
* | | | | | Merge #4359bors[bot]2020-05-071-1/+7
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4359: Fix panic in FunctionSignature r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Fix panic in FunctionSignatureAleksey Kladov2020-05-071-1/+7
|/ / / / /
* | | | | Merge #4333bors[bot]2020-05-061-15/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4333: Update Arch Linux and ALE install instructions r=matklad a=polyzen Package has been added to the Arch repos: https://www.archlinux.org/packages/community/x86_64/rust-analyzer/ ALE merged rust-analyzer support: https://github.com/dense-analysis/ale/commit/70005134e5b2d40d176ee5b851ac64a296b22201 Co-authored-by: Daniel M. Capella <[email protected]>
| * | | | | Update Arch Linux and ALE install instructionsDaniel M. Capella2020-05-051-15/+8
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Package has been added to the Arch repos: https://www.archlinux.org/packages/community/x86_64/rust-analyzer/ ALE merged rust-analyzer support: https://github.com/dense-analysis/ale/commit/70005134e5b2d40d176ee5b851ac64a296b22201
* | | | | Merge #4353bors[bot]2020-05-061-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4353: Better mapping to TextMate scopes for keywords r=matklad a=matklad https://github.com/microsoft/vscode/issues/94367#issuecomment-608629883 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Better mapping to TextMate scopes for keywordsAleksey Kladov2020-05-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | https://github.com/microsoft/vscode/issues/94367#issuecomment-608629883
| | | | | |
| \ \ \ \ \
*-. \ \ \ \ \ Merge #4316 #4351bors[bot]2020-05-062-5/+46
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4316: do not truncate display for hover r=matklad a=bnjjj close #4311 4351: Fix Windows server path r=matklad a=lnicola CC @Coder-256. Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Laurențiu Nicola <[email protected]>
| | * | | | | Fix Windows server pathLaurențiu Nicola2020-05-061-1/+1
| | | | | | | | | | | | | | | | | | | | | CC @Coder-256.
| * | | | | | do not truncate display for hoverBenjamin Coenen2020-05-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | do not truncate display for hoverBenjamin Coenen2020-05-061-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer into fix_4311Benjamin Coenen2020-05-0661-567/+657
| |\ \ \ \ \ \ | | | |/ / / / | | |/| | | |
| * | | | | | do not truncate display for hover #4311Benjamin Coenen2020-05-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | | Merge #4349bors[bot]2020-05-061-1/+1
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4349: package.json: Minor configuration spelling fix r=matklad a=seanbright Co-authored-by: Sean Bright <[email protected]>
| * | | | | | package.json: Minor configuration spelling fixSean Bright2020-05-061-1/+1
| | | | | | |
* | | | | | | Merge #4331bors[bot]2020-05-063-11/+140
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4331: Fixture improvements r=TimoFreiberg a=TimoFreiberg As mentioned in [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/resolve_path.20between.20fixture.20files) :) I think always allowing unindented first lines is friendlier than making the user fix it and I don't see any drawbacks. Co-authored-by: Timo Freiberg <[email protected]>
| * | | | | | | Allow fixture strings with unindented first lineTimo Freiberg2020-05-061-9/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows fixtures like "//- /lib.rs ... //- /foo.rs ... "
| * | | | | | | Add fixture doc commentTimo Freiberg2020-05-062-2/+45
| | | | | | | |
* | | | | | | | Merge #4043bors[bot]2020-05-064-0/+998
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4043: add Ok wrapping assist #3907 r=matklad a=bnjjj About issue #3907 close #3907 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | | | | add Ok wrappingBenjamin Coenen2020-05-064-0/+998
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | | Merge #4347bors[bot]2020-05-061-6/+23
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4347: Fix usefulness check for never type r=flodiebold a=MikailBag Co-authored-by: Mikail Bagishov <[email protected]>
| * | | | | | Fix usefulness check for never typeMikail Bagishov2020-05-061-6/+23
| | |_|/ / / | |/| | | |
* | | | | | Merge #4345bors[bot]2020-05-066-47/+32
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4345: Refactor assists a bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | SimplifyAleksey Kladov2020-05-063-33/+17
| | | | | |
| * | | | | MinorAleksey Kladov2020-05-061-1/+2
| | | | | |
| * | | | | RenameAleksey Kladov2020-05-064-13/+13
| | | | | |
* | | | | | Merge #4344bors[bot]2020-05-066-87/+60
|\| | | | | | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4344: Use SourceChange for assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Use SourceChange for assistsAleksey Kladov2020-05-066-87/+60
|/ / / /
* | | | Fix TODOAleksey Kladov2020-05-063-19/+17
| | | |
* | | | Merge #4341bors[bot]2020-05-0636-256/+292
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4341: Move target to AssistLabel r=matklad a=matklad Target is used for assists sorting, so we need it before we compute the action. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Move target to AssistLabelAleksey Kladov2020-05-0636-256/+292
|/ / / / | | | | | | | | | | | | | | | | Target is used for assists sorting, so we need it before we compute the action.
* | | | Merge #4340bors[bot]2020-05-066-25/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4340: Lift SourceChange to the ra_ide_db r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Lift SourceChange to the ra_ide_dbAleksey Kladov2020-05-066-25/+25
| | | | |
* | | | | Merge #4339bors[bot]2020-05-061-2/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4339: Fix capitalization r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Fix capitalizationAleksey Kladov2020-05-061-2/+2
|/ / / /
* | | | Merge #4338bors[bot]2020-05-062-35/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4338: Simplify tidy tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Simplify tidy testsAleksey Kladov2020-05-062-35/+33
| | | | |
* | | | | Merge #4337bors[bot]2020-05-0639-261/+242
|\| | | | | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 4337: Cleanup assists tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | RegenerateAleksey Kladov2020-05-065-42/+44
| | | |
| * | | Merge doc_tests and testsAleksey Kladov2020-05-064-41/+28
| | | |