aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6631bors[bot]2020-11-245-1/+20
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 6631: Gate autoimports begind experimental completions flag r=kjeremy a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/6612 Adds a possibility to disable autoimports: <img width="598" alt="image" src="https://user-images.githubusercontent.com/2690773/100156673-f8037f80-2eb1-11eb-8e74-59ebe4260ba3.png"> and other experimental completions we might want to add later. Co-authored-by: Kirill Bulatov <[email protected]>
| * Document experimental completionsKirill Bulatov2020-11-241-0/+7
| |
| * Gate autoimports begind experimental completions flagKirill Bulatov2020-11-244-1/+13
|/
* Merge #6630bors[bot]2020-11-246-29/+19
|\ | | | | | | | | | | | | | | | | | | 6630: followup to "hir_expand: propagate expansion errors" r=jonas-schievink a=jonas-schievink https://github.com/rust-analyzer/rust-analyzer/pull/6625 bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * Rename `parse_macro` to `parse_macro_expansion`Jonas Schievink2020-11-246-9/+9
| | | | | | | | This does not parse macros, it expands a macro and parses the *result*
| * hir_expand::db: reduce fn visibilityJonas Schievink2020-11-241-15/+9
| |
| * Remove fixed FIXME, propagate errors betterJonas Schievink2020-11-241-6/+2
|/
* Merge #6625bors[bot]2020-11-244-46/+91
|\ | | | | | | | | | | | | | | | | | | 6625: hir_expand: propagate expansion errors r=jonas-schievink a=jonas-schievink This is needed to collect and report expansion errors later. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * hir_expand: propagate expansion errorsJonas Schievink2020-11-244-46/+91
|/
* Merge #6624bors[bot]2020-11-241-31/+120
|\ | | | | | | | | | | | | | | 6624: Check structs for match exhaustiveness r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * Check structs for match exhaustivenessLukas Wirth2020-11-241-31/+120
|/
* Merge #6621bors[bot]2020-11-241-42/+55
|\ | | | | | | | | | | | | | | 6621: Handle ellipsis in tuple patterns in match exhaustiveness checking r=flodiebold a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * Add middle ellipsis missing arm textLukas Wirth2020-11-241-0/+14
| |
| * Handle ellipsis in tuple patterns in match exhaustiveness checkingLukas Wirth2020-11-241-42/+41
|/
* Merge #6618bors[bot]2020-11-242-12/+129
|\ | | | | | | | | | | | | | | | | | | 6618: Properly infer tuple patterns when encountering ellipsis r=Veykril a=Veykril We basically just split the subpatterns into two halves when the ellipsis is present and then offset the latter half to account for the ignored bindings. Fixes #6616 Co-authored-by: Lukas Wirth <[email protected]>
| * Properly infer tuple struct patterns when encountering ellipsisLukas Wirth2020-11-242-9/+70
| |
| * Properly infer tuple patterns when encountering ellipsisLukas Wirth2020-11-242-8/+64
| |
* | Merge #6620bors[bot]2020-11-241-15/+15
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6620: cargo update (without cargo_metadata) r=kjeremy a=kjeremy This is a `cargo update` run without updating `cargo_metadata`. `cargo_metadata` `0.12.1` pins `semver-parser` to `0.10.0` (https://github.com/oli-obk/cargo_metadata/commit/4e88e5624c5f20ca94dad0ea97fdb438fdea443f) which brings back the compile time blowup that @matklad tried so hard to avoid in https://github.com/steveklabnik/semver-parser/pull/50. Co-authored-by: kjeremy <[email protected]>
| * | cargo updatekjeremy2020-11-241-15/+15
|/ /
* | Merge #6619bors[bot]2020-11-243-8/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | 6619: New lsp-types to fix versioning r=kjeremy a=kjeremy Fixes #6603 Co-authored-by: kjeremy <[email protected]>
| * | New lsp-types to fix versioningkjeremy2020-11-243-8/+19
|/ / | | | | | | Fixes #6603
* | Merge #6617bors[bot]2020-11-241-1/+1
|\ \ | |/ |/| | | | | | | | | | | 6617: Avoid string allocations in ignore_test r=lnicola a=lnicola CC @jakobhellermann Co-authored-by: Laurențiu Nicola <[email protected]>
| * Avoid string allocations in ignore_testLaurențiu Nicola2020-11-241-1/+1
|/
* Merge #6610bors[bot]2020-11-241-7/+76
|\ | | | | | | | | | | | | | | | | | | 6610: add 'Re-enable this test' assist r=SomeoneToIgnore a=jakobhellermann The `Ignore this test` assist previously allowed ignoring multiple times, each time adding a `#[ignore]` attribute. This PR instead shows an assist to undo the ignoring. Co-authored-by: Jakob Hellermann <[email protected]>
| * add 'Re-enable this test' assistJakob Hellermann2020-11-231-7/+76
| |
* | Merge #6613bors[bot]2020-11-241-1/+7
|\ \ | |/ |/| | | | | | | | | | | 6613: Don't assume DidChangeTextDocument paths exist r=SomeoneToIgnore a=mjibson Fixes #5933 Co-authored-by: Matt Jibson <[email protected]>
| * Don't assume DidChangeTextDocument paths existMatt Jibson2020-11-231-1/+7
| | | | | | | | Fixes #5933
* | Merge #6609bors[bot]2020-11-231-6/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6609: Minor, import style r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Minor, import styleAleksey Kladov2020-11-231-6/+5
|/ /
* | Merge #6606bors[bot]2020-11-233-3/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6606: Parse unsafe extern block r=lnicola a=dtolnay `unsafe extern` block is parsed successfully by rustc, which means it is usable in attribute macro input. https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6f805556f176d082d87255957f16b5f6 ```rust #[cfg(parse)] unsafe extern "C++" { fn demo(); } ``` ```diff [email protected] - [email protected] + [email protected] [email protected] [email protected] "#" [email protected] "[" [email protected] [email protected] [email protected] [email protected] "cfg" [email protected] [email protected] "(" [email protected] "parse" [email protected] ")" [email protected] "]" [email protected] "\n" [email protected] "unsafe" [email protected] " " [email protected] [email protected] "extern" [email protected] " " [email protected] "\"C++\"" - [email protected] " " - [email protected] - [email protected] "{" - [email protected] "\n " - [email protected] - [email protected] "fn" - [email protected] " " - [email protected] - [email protected] "demo" - [email protected] - [email protected] "(" - [email protected] ")" - [email protected] ";" - [email protected] "\n" - [email protected] "}" + [email protected] " " + [email protected] + [email protected] "{" + [email protected] "\n " + [email protected] + [email protected] "fn" + [email protected] " " + [email protected] + [email protected] "demo" + [email protected] + [email protected] "(" + [email protected] ")" + [email protected] ";" + [email protected] "\n" + [email protected] "}" ``` This is of interest for https://github.com/dtolnay/cxx. Co-authored-by: David Tolnay <[email protected]>
| * | Parse unsafe extern blockDavid Tolnay2020-11-233-3/+25
|/ /
* | Merge #6598bors[bot]2020-11-211-1/+1
|\ \ | |/ |/| | | | | | | | | | | 6598: Textmate grammar: ensure word boundary after `true` r=dustypomerleau a=dustypomerleau Adding round brackets ensures word boundaries on both sides of booleans (reported in https://github.com/dustypomerleau/rust-syntax/issues/7). Co-authored-by: Dusty Pomerleau <[email protected]>
| * ensure word boundary after `true`Dusty Pomerleau2020-11-211-1/+1
|/
* Merge #6595bors[bot]2020-11-201-7/+64
|\ | | | | | | | | | | | | | | 6595: Don't wrap parens around expr in remove_dbg assist if its in conditions r=Veykril a=Veykril If the expr in the `dbg!` macro consists of multiple elements it won't remove the parentheses if its in a `match` or condition-using construct, as these are followed by siblings causing the `is_leaf` check to fail. Co-authored-by: Lukas Wirth <[email protected]>
| * Don't wrap parens around expr in remove_dbg assist if its in conditionsLukas Wirth2020-11-201-7/+64
|/
* Merge #6592bors[bot]2020-11-191-16/+16
|\ | | | | | | | | | | | | | | 6592: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * cargo updatekjeremy2020-11-191-16/+16
|/
* Merge #6585bors[bot]2020-11-188-9/+149
|\ | | | | | | | | | | | | | | | | | | | | | | | | 6585: Link rustc error page and clippy lint page via CodeDescription r=kjeremy a=Veykril Fixes #6371 This makes the error code in here clickable, same for clippy lints ![image](https://user-images.githubusercontent.com/3757771/99459468-6d110b00-292e-11eb-9cde-d43ec9cebc09.png) For clippy I just chose the master build of the site as I believe that to be pretty much always the best fitting. Co-authored-by: Lukas Wirth <[email protected]>
| * Fill code_description for rust_analyzer diagnosticsLukas Wirth2020-11-181-1/+8
| |
| * update diagnostics test_data with code_description changesLukas Wirth2020-11-186-6/+108
| |
| * Link clippy lint codes in diagnosticsLukas Wirth2020-11-181-7/+22
| |
| * Link rustc error codes in diagnosticsLukas Wirth2020-11-181-3/+19
|/
*---. Merge #6577 #6579 #6581bors[bot]2020-11-176-25/+37
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6577: fix typos in syntax.md r=matklad a=jakobhellermann 6579: cargo update and add new license r=matklad a=kjeremy 6581: Use vscode-languageclient 7.0.0-next.14 r=matklad a=kjeremy Co-authored-by: Jakob Hellermann <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | | * Use vscode-languageclient 7.0.0-next.14kjeremy2020-11-173-13/+15
| | | |
| | * | cargo update and add new licensekjeremy2020-11-172-10/+20
| | | |
| * | | fix typos in syntax.mdJakob Hellermann2020-11-171-2/+2
| |/ /
* | | Merge #6553bors[bot]2020-11-1722-96/+369
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6553: Auto imports in completion r=matklad a=SomeoneToIgnore ![completion](https://user-images.githubusercontent.com/2690773/99155339-ae4fb380-26bf-11eb-805a-655b1706ce70.gif) Closes https://github.com/rust-analyzer/rust-analyzer/issues/1062 but does not handle the completion order, since it's a separate task for https://github.com/rust-analyzer/rust-analyzer/issues/4922 , https://github.com/rust-analyzer/rust-analyzer/issues/4922 and maybe something else. 2 quirks in the current implementation: * traits are not auto imported during method completion If I understand the current situation right, we cannot search for traits by a **part** of a method name, we need a full name with correct case to get a trait for it. * VSCode (?) autocompletion is not as rigid as in Intellij Rust as you can notice on the animation. Intellij is able to refresh the completions on every new symbol added, yet VS Code does not query the completions on every symbol for me. With a few debug prints placed in RA, I've observed the following behaviour: after the first set of completion suggestions is received, next symbol input does not trigger a server request, if the completions contain this symbol. When more symbols added, the existing completion suggestions are filtered out until none are left and only then, on the next symbol it queries for completions. It seems like the only alternative to get an updated set of results is to manually retrigger it with Esc and Ctrl + Space. Despite the eerie latter bullet, the completion seems to work pretty fine and fast nontheless, but if you have any ideas on how to make it more smooth, I'll gladly try it out. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Actually enable eager completionKirill Bulatov2020-11-171-1/+1
| | | |
| * | | Avoid turning completion objects into buildersKirill Bulatov2020-11-169-84/+117
| | | |
| * | | Remove query aliasesKirill Bulatov2020-11-163-10/+10
| | | |