aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge #6888bors[bot]2020-12-151-62/+67
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6888: Use standard test style r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Use standard test styleAleksey Kladov2020-12-151-62/+67
| | | | |
* | | | | Merge #6889bors[bot]2020-12-152-0/+17
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6889: Resolve `macro-error` diagnostics on asm & llvm_asm r=matklad a=lf- We currently stub these out as returning unit. This fixes spurious RA `macro-error` diagnostics introduced somewhere around 0.2.400 in the following: ```rust unsafe { asm!(""); llvm_asm!(""); } ``` I'd ideally like to write a unit test for this, but I'm not familiar with where the tests for `hir_expand` are. Thanks to @edwin0cheng for help on resolving this issue. Co-authored-by: lf- <[email protected]>
| * | | | | Resolve `macro-error` diagnostics on asm & llvm_asmlf-2020-12-152-0/+17
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We currently stub these out as returning unit. This fixes spurious RA diagnostics in the following: ```rust unsafe { asm!(""); llvm_asm!(""); } ```
* | | | | Merge #6887bors[bot]2020-12-151-4/+4
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6887: Add `#` to canonical test example r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Add `#` to canonical test exampleAleksey Kladov2020-12-151-4/+4
| | | | |
* | | | | Merge #6875bors[bot]2020-12-152-0/+130
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6875: Add find usages for enum constructors r=matklad a=sasurau4 Fix #2549 for enum Co-authored-by: Daiki Ihara <[email protected]>
| * | | | | Add find usages for enum constructorsDaiki Ihara2020-12-142-0/+130
| | |_|_|/ | |/| | |
* | | | | Merge #6885bors[bot]2020-12-151-0/+1
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6885: Add !language-configuration.json to .vscodeignore r=matklad a=bryangingechen #6840 added a `language-configuration.json` file to `package.json`, but because `.vscodeignore` was not updated, this file was not uploaded when the extension was published, leading to constant errors in the VS Code dev tools console: ``` [Extension Host] stack trace: Error: ENOENT: no such file or directory, open '/Users/-/.vscode/extensions/matklad.rust-analyzer-0.2.416/language-configuration.json' ``` Co-authored-by: Bryan Gin-ge Chen <[email protected]>
| * | | | add language-configuration.json to .vscodeignoreBryan Gin-ge Chen2020-12-151-0/+1
|/ / / /
* | | | Merge #6874bors[bot]2020-12-142-0/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6874: Implement `module_path!()` r=jonas-schievink a=jonas-schievink Closes https://github.com/rust-analyzer/rust-analyzer/issues/6747 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Implement `module_path!()`Jonas Schievink2020-12-142-0/+11
| | |/ / | |/| |
* | | | Merge #6862bors[bot]2020-12-148-39/+131
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6862: Add LifetimeParam resolving to Semantics r=matklad a=Veykril This is stuff required for the lifetime references/definitions PR. I pulled this out to make it easier to review as well as because there is one thing that still has to be addressed which can be found in the review comments. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add LifetimeParam resolving to SemanticsLukas Wirth2020-12-148-39/+131
| | |/ | |/|
* | | Merge #6817bors[bot]2020-12-143-78/+36
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6817: Replace goblin crate with object r=matklad a=lnicola Continuation of #4385. Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | Replace goblin crate with objectLaurențiu Nicola2020-12-133-78/+36
| | |
* | | Merge #6871bors[bot]2020-12-141-0/+2
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | 6871: Link config source r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Link config sourceAleksey Kladov2020-12-141-0/+2
|/ /
* | Merge #6858bors[bot]2020-12-131-0/+17
|\ \ | | | | | | | | | | | | | | | | | | | | | 6858: Docs: Explain manual installation in VS Code r=lnicola a=cauthmann same as https://github.com/rust-analyzer/rust-analyzer.github.io/pull/81 , just against the correct repository this time Co-authored-by: Christian Authmann <[email protected]>
| * | Docs: Explain manual installation in VS CodeChristian Authmann2020-12-131-0/+17
| | |
* | | Merge #6840bors[bot]2020-12-132-0/+49
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6840: Add a language configuration file for VS Code r=matklad a=dustypomerleau There has been recent discussion in #6451 and #6682 about the need to include angle brackets in auto-close and auto-surround functionality. This PR will accomplish that, but only for users of VS Code, as it uses the VS Code-specific `language-configuration.json` to get the job done. Since there are a large number of VS Code users in the Rust Analyzer cohort, it may be reasonable to fix the issue for them, while waiting on a more comprehensive solution in the language server. In addition to the usual brackets, I've added auto-closing of block comments. I avoided autoclosing single quotes, given that lifetimes are more common than chars. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | add a language configuration for VS CodeDusty Pomerleau2020-12-132-0/+49
| | |
* | | Merge #6856bors[bot]2020-12-131-0/+37
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6856: Add test for #6852 r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | Add test for #6852Florian Diebold2020-12-131-0/+37
|/ / /
* | | Merge #6855bors[bot]2020-12-131-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6855: Change recommendation when source can't be loaded from sysroot r=matklad a=flodiebold Since we just tried running `rustup component add`, it doesn't make sense to me to recommend trying that again. If we're reaching this case, it's probably more likely that rustc was installed via package manager, in which case the source should be installed the same way (e.g. if you install the rust-src package on Ubuntu it will install a symlink in the right place to make our sysroot detection work, and IMO we should get other distributors to do the same if they aren't already). Co-authored-by: Florian Diebold <[email protected]>
| * | | Change recommendation when source can't be loaded from sysrootFlorian Diebold2020-12-131-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Since we just tried running `rustup component add`, it doesn't make sense to me to recommend trying that again. If we're reaching this case, it's probably more likely that rustc was installed via package manager, in which case the source should be installed the same way (e.g. if you install the rust-src package on Ubuntu it will install a symlink in the right place to make our sysroot detection work).
* | | Merge #6852bors[bot]2020-12-133-3/+17
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 6852: Ignore lifetime params in substitutions r=matklad a=Veykril [`hir_ty::utils::Generics`](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/hir_ty/src/utils.rs#L153) currently only assumes type parameters but not lifetime parameters and therefor creates incorrect index and length calculations, this PR just makes the use sites ignore LifetimeGenerics for now. This fixes the panic at least locally for me for `analysis-stats`. Funnily enough this panic prevented me from using reference search for the `args` field to fix this problem. Co-authored-by: Lukas Wirth <[email protected]>
| * | Ignore lifetime params in substitutionsLukas Wirth2020-12-133-3/+17
| | |
* | | Merge #6845bors[bot]2020-12-122-1/+34
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6845: Don't HirDisplay unknown types when displaying for source r=Veykril a=Veykril Was wondering why the add missing impl assist didn't do anything here: ![Code_JCA1Qo0V9P](https://user-images.githubusercontent.com/3757771/101990300-7af44a80-3ca6-11eb-8431-e5eb4de4e78c.png) Turns out me forgetting to set the Index::Idx type in the trait causes RA to panic due to it trying to to create an unparsable type in the `make` module. Now we get this instead which imo is definitely better to have. ![Code_MUFPJUCULY](https://user-images.githubusercontent.com/3757771/101990347-c9094e00-3ca6-11eb-9c6a-146bddf64b7c.png) Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't HirDisplay unknown types when displaying for sourceLukas Wirth2020-12-122-1/+34
| | |
* | | Merge #6846bors[bot]2020-12-1210-10/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6846: Remove some redundant allocations r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | Remove some redundant allocationsJeremy Kolb2020-12-1210-10/+9
|/ / /
* | | Merge #6818bors[bot]2020-12-1216-96/+249
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6818: Add Lifetimes to the HIR r=matklad a=Veykril This doesn't handle resolve yet as I don't know yet how that will be used. I'll get to that once I start moving the lifetime reference PR to the hir. This also adds a new `hir` name type for lifetimes and labels, `hir::LifetimeName`. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add Lifetimes to the HIRLukas Wirth2020-12-1116-96/+249
| | |/ | |/|
* | | Merge #6841bors[bot]2020-12-121-0/+10
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6841: Added "Remove this semicolon" test r=matklad a=ivan770 Closes https://github.com/rust-analyzer/rust-analyzer/pull/6769#discussion_r540150066 Co-authored-by: ivan770 <[email protected]>
| * | | Added remove this semicolon testivan7702020-12-121-0/+10
|/ / /
* | | Merge #6839bors[bot]2020-12-122-4/+74
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6839: Infer labeled blocks r=flodiebold a=Veykril The test should cover all the interesting cases I believe(main part of it is copied from the loop label break test above it). The test is indented to stay consistent with the rest of the tests in the file, I can dedent all the tests in the file in a follow up PR if desired. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Infer labeled blocksLukas Wirth2020-12-112-4/+74
| | |/ | |/|
* | | Merge #6813bors[bot]2020-12-112-6/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6813: negative sign matching in mbe matching for literal r=edwin0cheng a=edwin0cheng Fix #6292 r @jonas-schievink Co-authored-by: Edwin Cheng <[email protected]>
| * | | Add missing arg for eat_charEdwin Cheng2020-12-111-3/+3
| | | |
| * | | negative sign matching in mbe matching for literalEdwin Cheng2020-12-112-6/+39
| | |/ | |/|
* | | Merge #6838bors[bot]2020-12-111-8/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6838: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | cargo updatekjeremy2020-12-111-8/+8
|/ / /
* | | Merge #6836bors[bot]2020-12-112-25/+29
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6836: Use Attrs::docs in NavigationTarget instead of DocCommentsOwner r=kjeremy a=Veykril That should be the last place where the AST comment machinery is referred to. Co-authored-by: Lukas Wirth <[email protected]>
| * | Use Attrs::docs in NavigationTarget instead of DocCommentsOwnerLukas Wirth2020-12-112-25/+29
|/ /
* | Merge #6834bors[bot]2020-12-112-12/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6834: Use Attrs::docs in runnables instead of DocCommentsOwner r=kjeremy a=Veykril I figured that we should probably move as much of the doc usage to the HIR as possible hence this PR. If we should keep this AST-based feel free to close. This change does have the nice(but not really useful as I doubt anyones gonna write doc tests like these) side effect that these two doc string snippets allow being run now. ![image](https://user-images.githubusercontent.com/3757771/101945607-bf241400-3bee-11eb-96ce-ccae80028b1f.png) ![image](https://user-images.githubusercontent.com/3757771/101946375-2e9a0380-3bef-11eb-9950-e35168fdd048.png) Co-authored-by: Lukas Wirth <[email protected]>
| * | Use Attrs::docs in runnables instead of DocCommentsOwnerLukas Wirth2020-12-112-12/+12
| | |
* | | Merge #6832bors[bot]2020-12-111-0/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6832: Add upstream commit to builtin_attr.rs r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Add upstream commit to builtin_attr.rsJonas Schievink2020-12-111-0/+2
|/ / /
* | | Merge #6819bors[bot]2020-12-112-0/+429
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6819: Add builtin attributes for use in nameres r=jonas-schievink a=jonas-schievink These are not yet used, but have to go through nameres later in order to support procedural macro attributes Co-authored-by: Jonas Schievink <[email protected]>