aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge #6158bors[bot]2020-10-071-5/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6158: Fix for negative literals in macros r=matklad a=cutsoy _This pull request fixes #6028._ When writing `-42.0f32` in Rust, it is usually parsed as two different tokens (a minus operator and a float literal). But a procedural macro can also generate new tokens, including negative [float literals](https://doc.rust-lang.org/stable/proc_macro/struct.Literal.html#method.f32_suffixed): ```rust #[proc_macro] fn example_verbose(input: TokenStream) -> TokenStream { let literal = Literal::f32_suffixed(-42.0); quote! { #literal } } ``` or even shorter ```rust #[proc_macro] fn example(input: TokenStream) -> TokenStream { let literal = -42.0f32; quote! { #literal } } ``` Unfortunately, these currently cause RA to crash: ``` thread '<unnamed>' panicked at 'Fail to convert given literal Literal { text: "-42.0f32", id: TokenId( 4294967295, ), }', crates/mbe/src/subtree_source.rs:161:28 ``` This pull request contains both a fix 8cf9362 and a unit test 27798ee. In addition, I installed the patched server with `cargo xtask install --server` and verified in VSCode that it no longer crashes when a procedural macro returns a negative number literal. Co-authored-by: Tim <[email protected]>
| * | | | Added unit test for negative number literals in macros.Tim2020-10-061-0/+21
| | | | |
| * | | | Fixed parsing of negative number literals in macros.Tim2020-10-061-5/+12
| | |/ / | |/| |
* | | | Merge #6160bors[bot]2020-10-075-1/+448
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6160: Add validation check for ambiguous trait objects r=matklad a=Veykril Fixes #285. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Add validation check for ambiguous trait objectsLukas Wirth2020-10-065-1/+448
| | | | |
* | | | | Merge #6159bors[bot]2020-10-071-0/+17
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6159: Document "*.mutable" trick in manual r=matklad a=stanciuadrian Closes #5803. Co-authored-by: Adrian Stanciu <[email protected]>
| * | | | Update manual.adocAdrian Stanciu2020-10-061-0/+17
|/ / / /
* | | | Merge #6128bors[bot]2020-10-061-4/+25
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6128: Trim all trailing whitespace in onEnter r=matklad a=repnop Fixes #5848 Co-authored-by: Wesley Norris <[email protected]>
| * | | | Trim all trailing whitespace in onEnterWesley Norris2020-10-031-4/+25
| | |_|/ | |/| | | | | | | | | | Fixes #5848
* | | | Merge #6157bors[bot]2020-10-061-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6157: Document privacy invariant of SyntaxPtr r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Document privacy invariant of SyntaxPtrAleksey Kladov2020-10-061-0/+2
|/ / / /
* | | | Merge #6140bors[bot]2020-10-065-9/+81
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6140: honour hover.content_format client capability r=lnicola a=robinvd This removes all markdown when the client does not support the markdown MarkupKind. Otherwise the output on the editor will have some markdown boilerplate, making it less readable. For example kak_lsp does not currently support markdown. ![image](https://user-images.githubusercontent.com/22073483/95112949-ef0ff080-0741-11eb-82a7-0594fa2cd736.png) after: ![image](https://user-images.githubusercontent.com/22073483/95113089-2bdbe780-0742-11eb-94fa-bcfec6d7347a.png) Co-authored-by: Robin van Dijk <[email protected]>
| * | | | add break after codeblocksRobin van Dijk2020-10-061-2/+4
| | | | |
| * | | | add doc describing limited capabilitiesRobin van Dijk2020-10-061-0/+2
| | | | |
| * | | | add docstringRobin van Dijk2020-10-051-0/+3
| | | | |
| * | | | honor content_format clientcapRobin van Dijk2020-10-055-9/+74
| |/ / / | | | | | | | | | | | | | | | | | | | | This removes all markdown when the client does not support the markdown MarkupKind Otherwise the output on the editor will have some markdown boilerplate, making it less readable
* | | | Merge #6155bors[bot]2020-10-061-0/+2
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 6155: Add test makr r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Add test makrAleksey Kladov2020-10-061-0/+2
|/ / /
* | | Merge #6151bors[bot]2020-10-061-10/+26
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6151: Constrain ImportMap to only store simple paths r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Constrain ImportMap to only store simple pathsAleksey Kladov2020-10-061-10/+26
|/ / /
* | | Merge #6150bors[bot]2020-10-068-46/+65
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6150: Move ModPath->ast::Path function to IDE layer r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Move ModPath->ast::Path function to IDE layerAleksey Kladov2020-10-068-46/+65
| | | | | | | | | | | | | | | | closes #6092
* | | | Merge #6148bors[bot]2020-10-062-6/+57
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6148: Fix trait object hir formatting behind pointer and references r=matklad a=Veykril Fixes #6064 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Fix trait object hir formatting behind pointer and referencesLukas Wirth2020-10-062-6/+57
| |/ /
* | | Merge #6149bors[bot]2020-10-061-0/+7
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | 6149: Smoke test docs generation r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Smoke test docs generationAleksey Kladov2020-10-061-0/+7
|/ /
* | Merge #6124bors[bot]2020-10-0610-31/+64
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6124: Better normalized crate name usage r=jonas-schievink a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/5343 Closes https://github.com/rust-analyzer/rust-analyzer/issues/5932 Uses normalized name for code snippets (to be able to test the fix), hover messages and documentation rewrite links (are there any tests for those?). Also renamed the field to better resemble the semantics. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Properly name the fieldKirill Bulatov2020-10-028-24/+26
| | |
| * | Fix the hover dash issuesKirill Bulatov2020-10-024-9/+10
| | |
| * | Add a dash testKirill Bulatov2020-10-022-2/+32
| | |
* | | Merge #6139bors[bot]2020-10-067-119/+188
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6139: Make find_path_prefixed configurable r=matklad a=Veykril This makes `find_path_prefixed` more configurable allowing one to choose whether it always returns absolute paths, self-prefixed paths or to ignore local imports when building the path. The config names are just thrown in here, taking better names if they exist :) This should fix #6131 as well? Co-authored-by: Lukas Wirth <[email protected]>
| * | | Make ImportPrefix a configuration optionLukas Wirth2020-10-056-10/+49
| | | |
| * | | Make find_path_prefixed configurableLukas Wirth2020-10-052-110/+140
| | |/ | |/|
* | | Merge #6147bors[bot]2020-10-061-2/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6147: Do not leave braces for colons in dbg! r=matklad a=SomeoneToIgnore Tweak remove dbg heuristics a bit to remove braces when colons (`:`) are used in the non-leaf dbg expressions. Before: `dbg!(Foo::foo_test()).bar()` -> `(Foo::foo_test()).bar()` After: `dbg!(Foo::foo_test()).bar()` -> `Foo::foo_test().bar()` Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Do not leave braces for colons in dbg!Kirill Bulatov2020-10-061-2/+7
|/ / /
* | | Merge #6133bors[bot]2020-10-051-0/+17
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6133: Add some notes related to privacy and network access r=SomeoneToIgnore a=lnicola Closes #5551. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Add notes concerning privacy and network accessLaurențiu Nicola2020-10-041-0/+17
| |/ /
* | | Merge #6111bors[bot]2020-10-054-5/+738
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6111: Add assist for converting the base of integer literals. r=SomeoneToIgnore a=vlakreeh This PR adds an assist similar to Intellij's [convert number to](https://i.imgur.com/JH6wstP.png). It also does a small refactor to [assists/src/tests.rs](https://github.com/rust-analyzer/rust-analyzer/blob/fc34403018079ea053f26d0a31b7517053c7dd8c/crates/assists/src/tests.rs) to add the ability to specify the resolved assist for a specific action within an assist group. ## Demo ![Demo of the assist in action](https://i.imgur.com/MBhdPFH.gif) Co-authored-by: vlakreeh <[email protected]>
| * | | Add tests for convert integer literal assistvlakreeh2020-09-301-4/+570
| | | |
| * | | Add ability to specify ResolvedAssist by labelvlakreeh2020-09-291-5/+22
| | | |
| * | | Add convert integer literal assistvlakreeh2020-09-293-0/+150
| | | |
* | | | Merge #6143bors[bot]2020-10-052-1/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6143: Account for proc macro helpers when parsing attr r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6138 Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Account for proc macro helpers when parsing attrJonas Schievink2020-10-052-1/+9
|/ / / /
* | | | Merge #6127bors[bot]2020-10-052-2/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6127: Correctly complete items with leading underscore r=SomeoneToIgnore a=fmease Fixes #6091. Let me know if the test is placed into the right file or if it is even desired. Co-authored-by: León Orell Valerian Liehr <[email protected]>
| * | | | Correctly complete items with leading underscoreLeón Orell Valerian Liehr2020-10-032-2/+23
| | | | |
* | | | | Merge #6142bors[bot]2020-10-052-6/+8
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6142: Fix feature name r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Fix feature nameAleksey Kladov2020-10-052-6/+8
|/ / / /
* | | | Merge #5997bors[bot]2020-10-031-15/+117
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5997: Better inlay hints in 'for' loops r=popzxc a=popzxc For #5206 (one part of the fix). This PR refines the logic of spawning an inlay hints in `for` loops. We only must provide a hint if the following criteria are met: - User already typed `in` keyword. - Type of expression is known and it's not unit. **However:** I don't know why, but I was unable to make `complete_for_hint` test work. Either without or with my changes, I was always getting this test failed because no hint was spawned for the loop variable. This change works locally, so I would really appreciate an explanation why this test isn't working now and how to fix it. ![image](https://user-images.githubusercontent.com/12111581/93024580-41a53380-f600-11ea-9bb1-1f8ac141be95.png) Co-authored-by: Igor Aleksanov <[email protected]>
| * | | Improve readability in inlay_hints.rsIgor Aleksanov2020-10-031-4/+5
| | | |
| * | | Remove 'for_expr' test from inlay_hints.rsIgor Aleksanov2020-10-031-14/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 17:34:06 +0000