aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix problem with format string tokenizationRoland Ruckerbauer2020-05-301-5/+0
| | | | Fixed by just not handling closing curlybrace escaping.
* Merge #4654bors[bot]2020-05-303-0/+4
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4654: Add semantic highlight to ? operator r=matklad a=ruabmbua Made it an operator with controlFlow modifier. To highlight in vscode as red: ```json "editor.semanticTokenColorCustomizations": { "enabled": true, "rules": { "operator.controlFlow": "#ff0000", } } ``` ![Bildschirmfoto von 2020-05-29 21-32-06](https://user-images.githubusercontent.com/2522373/83297998-f3585a00-a1f3-11ea-9d14-4ef04b9b6b9a.png) https://github.com/rust-analyzer/rust-analyzer/issues/4597 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * Add semantic highlight to QUESTION tokenRoland Ruckerbauer2020-05-293-0/+4
| | | | | | | | Made it an operator with controlFlow modifier.
* | Merge #4562bors[bot]2020-05-304-0/+354
|\ \ | | | | | | | | | | | | | | | | | | | | | 4562: Assist: replace anonymous lifetime with a named one r=matklad a=jbalint (fixes #4523) Co-authored-by: Jess Balint <[email protected]>
| * | add support for naming anon lifetimes in function return typeJess Balint2020-05-281-50/+210
| | |
| * | tweak syntaxJess Balint2020-05-231-49/+40
| | |
| * | use char rangeJess Balint2020-05-221-2/+2
| | |
| * | fix generated docs issueJess Balint2020-05-223-23/+72
| | |
| * | Remove doc using `cargo xtask codegen`.Jess Balint2020-05-221-24/+0
| | |
| * | handle the case of conflicting lifetime param nameJess Balint2020-05-221-7/+36
| | | | | | | | | | | | - and clean/format code
| * | Assist: replace anonymous lifetime with a named oneJess Balint2020-05-223-0/+149
| | | | | | | | | | | | (fixes #4523)
* | | Merge #4653bors[bot]2020-05-302-5/+61
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4653: Fix match ergonomics in closure parameters r=matklad a=flodiebold Fixes #4476. Co-authored-by: Florian Diebold <[email protected]>
| * | | Fix match ergonomics in closure parametersFlorian Diebold2020-05-292-5/+61
| | |/ | |/| | | | | | | Fixes #4476.
* | | Merge #4655bors[bot]2020-05-301-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4655: Fix typo in docs/dev/lsp-extensions.md: automagiacally -> automagically r=kjeremy a=theHamsta This may be a typo... Co-authored-by: Stephan Seitz <[email protected]>
| * | | Fix typo in docs/dev/lsp-extensions.md: automagiacally -> automagicallyStephan Seitz2020-05-291-1/+1
| | | |
* | | | Merge #4651bors[bot]2020-05-292-4/+2
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4651: Use first match branch in case of type mismatch, not last r=kjeremy a=flodiebold The comment says this was intentional, but I do agree with #4304 that it makes more sense the other way around (for if/else as well). Fixes #4304. Co-authored-by: Florian Diebold <[email protected]>
| * | | Use first match branch in case of type mismatch, not lastFlorian Diebold2020-05-292-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The comment says this was intentional, but I do agree with #4304 that it makes more sense the other way around (for if/else as well). Fixes #4304.
* | | | Merge #4652bors[bot]2020-05-293-22/+56
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 4652: Upgrade Chalk r=kjeremy a=flodiebold Fixes #4072. Co-authored-by: Florian Diebold <[email protected]>
| * | | Upgrade ChalkFlorian Diebold2020-05-293-22/+56
| |/ / | | | | | | | | | Fixes #4072.
* | | Merge #4648bors[bot]2020-05-2912-72/+259
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4648: Support raw_ref_op's raw reference operator r=matklad a=robojumper Fixes #4642. This syntax (and its semantics) are implemented in rustc behind the `raw_ref_op` feature. It is not entirely clear whether this is the syntax that will become stable, but [it seems like](https://github.com/rust-lang/rust/pull/72279) rust-analyzer must still support this unstable syntax to support future stable rust. Also fixes a random inference failure involving a direct coercion from `&[T, _]` to `*const [T]`. Co-authored-by: robojumper <[email protected]>
| * | Support raw_ref_op's raw reference operatorrobojumper2020-05-2812-72/+259
|/ /
* | Merge #4640bors[bot]2020-05-284-1/+86
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4640: Add `inRustProject` when-clause for commands in vscode r=vsrs a=vsrs At the moment all rust-analyzer commands always visible in the command palette, even if there is no rust project opened. This PR adds special [when-clause](https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts) context. This context also might be used in key bindings. Co-authored-by: vsrs <[email protected]> Co-authored-by: vsrs <[email protected]>
| * | Add `inRustProject` context documentation.vsrs2020-05-281-0/+10
| | |
| * | Add `inRustProject` when-clause for commands.vsrs2020-05-273-1/+76
| | |
* | | Merge #4641bors[bot]2020-05-286-86/+71
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4641: Upgrade Chalk r=matklad a=flodiebold Chalk newly added TypeName::Never and Array; I implemented the conversion for Never, but not Array since that expects a const argument. Co-authored-by: Florian Diebold <[email protected]>
| * | | Upgrade ChalkFlorian Diebold2020-05-276-86/+71
| |/ / | | | | | | | | | | | | Chalk newly added TypeName::Never and Array; I implemented the conversion for Never, but not Array since that expects a const argument.
* | | Merge #4646bors[bot]2020-05-282-4/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4646: Link forum topic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Link forum topicAleksey Kladov2020-05-282-4/+8
|/ / /
* | | Merge #4639bors[bot]2020-05-272-3/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 4639: Fixed missing newline on each field on "Missing structure fields". r=flodiebold a=flipbit03 Co-authored-by: Cadu <[email protected]>
| * | Fixed missing newline on each field on "Missing structure fields".Cadu2020-05-272-3/+3
|/ /
* | Merge #4592bors[bot]2020-05-273-1/+49
|\ \ | | | | | | | | | | | | | | | | | | | | | 4592: fix textedit range returned for completion when left token is a keyword r=bnjjj a=bnjjj close #4545 Co-authored-by: Benjamin Coenen <[email protected]>
| * | fix textedit range returned for completion when left token is a keywordBenjamin Coenen2020-05-272-0/+3
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | fix textedit range returned for completion when left token is a keyword #4545Benjamin Coenen2020-05-243-1/+46
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #4596bors[bot]2020-05-271-1/+59
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * | | Trim at presentation layerYuki Kodama2020-05-252-4/+2
| | | |
| * | | Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| | | |
| * | | Use built-in methodYuki Kodama2020-05-251-11/+5
| | | |
| * | | Separate assertionsYuki Kodama2020-05-251-7/+65
| | | |
| * | | Reflect test caseYuki Kodama2020-05-251-7/+7
| | | |
| * | | Strip leading underscoreYuki Kodama2020-05-251-2/+10
| | | |
| | | |
| \ \ \
*-. \ \ \ Merge #4625 #4629bors[bot]2020-05-272-7/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | | | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Closes #4628
| * | | | | Partially fix displaying inlay hints in Github PR diff viewsveetaha2020-05-261-4/+5
| | | | | |
* | | | | | Merge #4633bors[bot]2020-05-271-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4633: typo r=matklad a=Veetaha Co-authored-by: Veetaha <[email protected]>
| * | | | | | typoVeetaha2020-05-271-1/+1
|/ / / / / /
* | | | | | Merge #4632bors[bot]2020-05-271-0/+63
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4632: Document inlay hints and runnables r=matklad a=matklad We want to change those, but let's document what we have in meantime bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Document inlay hints and runnablesAleksey Kladov2020-05-271-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to change those, but let's document what we have in meantime
* | | | | | | Merge #4622bors[bot]2020-05-274-43/+40
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4622: Pass trivially copy types as copy r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | | Pass trivially copy types as copykjeremy2020-05-264-43/+40
| | |/ / / / | |/| | | |
* | | | | | Merge #4623bors[bot]2020-05-262-13/+13
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4623: Update deps r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 19:14:56 +0000