aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #127bors[bot]2018-10-156-79/+187
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 127: Improve folding r=matklad a=aochagavia I was messing around with adding support for multiline comments in folding and ended up changing a bunch of other things. First of all, I am not convinced of folding groups of successive items. For instance, I don't see why it is worthwhile to be able to fold something like the following: ```rust use foo; use bar; ``` Furthermore, this causes problems if you want to fold a multiline import: ```rust use foo::{ quux }; use bar; ``` The problem is that now there are two possible folds at the same position: we could fold the first use or we could fold the import group. IMO, the only place where folding groups makes sense is when folding comments. Therefore I have **removed folding import groups in favor of folding multiline imports**. Regarding folding comments, I made it a bit more robust by requiring that comments can only be folded if they have the same flavor. So if you have a bunch of `//` comments followed by `//!` comments, you will get two separate fold groups instead of a single one. Finally, I rewrote the API in such a way that it should be trivial to add new folds. You only need to: * Create a new FoldKind * Add it to the `fold_kind` function that converts from `SyntaxKind` to `FoldKind` Fixes #113 Co-authored-by: Adolfo Ochagavía <[email protected]>
| * | Improve testsAdolfo Ochagavía2018-10-132-30/+63
| | |
| * | Only fold groups of similar commentsAdolfo Ochagavía2018-10-132-28/+31
| | |
| * | Cleanup fold code and split logic to fold single elementsAdolfo Ochagavía2018-10-124-40/+112
| | |
| * | Fold multiline commentsAdolfo Ochagavía2018-10-122-21/+21
| |/
* | Merge #110bors[bot]2018-10-1510-12/+315
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 110: Signature help r=matklad a=kjeremy @matklad Once this is in shape I would like to add tests. I think a separate PR should be done for returning documentation information and markdown. Fixes #102 Co-authored-by: Jeremy A. Kolb <[email protected]>
| * | A FnDescriptor shouldn't exist without a nameJeremy A. Kolb2018-10-123-49/+47
| | |
| * | RegenerateJeremy A. Kolb2018-10-121-1/+2
| | |
| * | Language Server: textDocument/signatureHelpJeremy A. Kolb2018-10-1110-12/+316
| |/ | | | | | | | | | | | | | | | | | | Implements a pretty barebones function signature help mechanism in the language server. Users can use `Analysis::resolve_callback()` to get basic information about a call site. Fixes #102
* | Merge #112bors[bot]2018-10-143-133/+152
|\ \ | |/ |/| | | | | | | | | | | 112: brush up docs r=matklad a=matklad @kjeremy @aochagavia @DJMcNab anything else significant to add here? Co-authored-by: Aleksey Kladov <[email protected]>
| * Apply review suggestionsAleksey Kladov2018-10-141-10/+16
| |
| * brush up docsAleksey Kladov2018-10-143-133/+146
| |
* | Merge #122bors[bot]2018-10-1120-49/+68
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 122: Use rustc-hash crate r=matklad a=mominul Replace std's HashMap, HashSet with FxHashMap and FxHashSet. Closes #121 Thanks! Co-authored-by: Muhammad Mominul Huque <[email protected]>
| * | Replace HashMap, HashSet with FxHashMap and FxHashSetMuhammad Mominul Huque2018-10-1120-49/+68
| | |
* | | Merge #116bors[bot]2018-10-114-58/+199
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 116: Collapse comments upon join r=matklad a=aochagavia Todo: - [x] Write tests - [x] Resolve fixmes - [x] Implement `comment_start_length` using the parser I left a bunch of questions as fixmes. Can someone take a look at them? Also, I would love to use the parser to calculate the length of the leading characters in a comment (`//`, `///`, `//!`, `/*`), so any hints are greatly appreciated. Co-authored-by: Adolfo Ochagavía <[email protected]> Co-authored-by: Adolfo Ochagavía <[email protected]>
| * | Remove smart multiline comment joinAdolfo Ochagavía2018-10-111-22/+23
| | |
| * | Add testsAdolfo Ochagavía2018-10-111-0/+56
| | |
| * | Remove nestingAdolfo Ochagavía2018-10-111-75/+68
| | |
| * | Use Comment wrapperAdolfo Ochagavía2018-10-114-36/+78
| | |
| * | Collapse comments upon joinAdolfo Ochagavía2018-10-101-15/+64
| | |
* | | Merge #118bors[bot]2018-10-112-22/+3
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 118: Remove error publishing through publishDecorations r=matklad a=aochagavia The errors are already reported by `publishDiagnostics` Closes #109 Co-authored-by: Adolfo Ochagavía <[email protected]>
| * | Report errors only onceAdolfo Ochagavía2018-10-101-14/+3
| | |
| * | Remove error publishing through publishDecorationsAdolfo Ochagavía2018-10-102-8/+0
| |/
* | Merge #120bors[bot]2018-10-102-34/+65
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | 120: Cleanup grammar generation r=matklad a=ReinierMaas https://github.com/rust-analyzer/rust-analyzer/blob/31c8ebb743572ef07ac4ca77ddd17eddbcf4b24c/crates/ra_syntax/src/ast/generated.rs#L207-L210 Needed an additional newline before the `pub fn`. Removing `-` for #114. Runnning `cargo gen-kinds` to update grammar. Co-authored-by: Reinier Maas <[email protected]> Co-authored-by: Reinier Maas <[email protected]>
| * Update crates/ra_syntax/src/ast/generated.rsReinier Maas2018-10-101-32/+64
| | | | | | | | effect of running cargo gen-kinds
| * Update generated.rs.teraReinier Maas2018-10-101-2/+1
|/ | | Removing `-` for #114
* Merge #115bors[bot]2018-10-094-14/+29
|\ | | | | | | | | | | | | | | 115: Format vscode extension and add npm run fix r=matklad a=aochagavia Co-authored-by: Adolfo Ochagavía <[email protected]>
| * Format vscode extension and add npm run fixAdolfo Ochagavía2018-10-094-14/+29
|/
* Merge #106bors[bot]2018-10-0912-401/+630
|\ | | | | | | | | | | | | | | 106: Add on-enter handler r=matklad a=matklad Now, typing doc comments is much more pleasant Co-authored-by: Aleksey Kladov <[email protected]>
| * Add on-enter handlerAleksey Kladov2018-10-0912-401/+630
| | | | | | | | Now, typing doc comments is much more pleasant
* | Merge #111bors[bot]2018-10-091-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 111: gate on tslint r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | gate on tslintAleksey Kladov2018-10-091-1/+1
| | |
* | | Merge #107bors[bot]2018-10-091-4/+13
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 107: Switch to absolute offsets for extend comment word r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Switch to absolute offsets for extend comment wordAleksey Kladov2018-10-091-4/+13
| | |
* | | don't gate on appveyorAleksey Kladov2018-10-091-1/+1
|/ /
* / Fix link to appveyor's CIAleksey Kladov2018-10-091-1/+1
|/
* Merge pull request #108 from rust-analyzer/readmeAleksey Kladov2018-10-091-2/+2
|\ | | | | fix readme
| * fix readmeAleksey Kladov2018-10-091-2/+2
|/
* Prepare gen_lsp_server for publishingAleksey Kladov2018-10-094-17/+88
|
* Merge #104bors[bot]2018-10-0925-494/+805
|\ | | | | | | | | | | | | | | | | | | | | | | 104: Add vscode extension to CI r=aochagavia a=DJMcNab Note that this testing is only done on travis - we are only running formatting and linting, so feature parity on appveyor is not required. CC @aochagavia. Fixes? #100 Co-authored-by: Daniel McNab <[email protected]>
| * Run prettier on all filesDaniel McNab2018-10-0823-129/+220
| |
| * Add tslint and prettier to ciDaniel McNab2018-10-085-403/+623
|/
* Merge #103bors[bot]2018-10-0818-415/+557
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 103: WIP: refactor vscode extension r=aochagavia a=aochagavia Todo: - [x] Add more comments, so other people can find their way in the codebase - [x] Resolve remaining tslint suggestions - [ ] Integrate with CI @matklad The standard configuration of tslint forbids using `console.log` and `console.error`. Is there any reason we are using those or can I remove them? If they are used for debugging purposes I would prefer to remove them and rely on vscode's excellent debugger. Co-authored-by: Adolfo Ochagavía <[email protected]>
| * Add some commentsAdolfo Ochagavía2018-10-084-25/+44
| |
| * Fix remaining tslint suggestionsAdolfo Ochagavía2018-10-0815-78/+82
| |
| * Apply tslint suggestions, round oneAdolfo Ochagavía2018-10-0716-242/+258
| |
| * Refactor vscode extensionAdolfo Ochagavía2018-10-0714-415/+518
| |
* | Attach comments smartlyAleksey Kladov2018-10-084-24/+97
| |
* | replace loop with iteratorsAleksey Kladov2018-10-081-6/+7
| |
* | Simplify event processingAleksey Kladov2018-10-086-98/+122
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 03:33:15 +0000