aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | Merge #4292bors[bot]2020-05-042-8/+12
|\ \ \ \ \ \ \ \ \ | | |_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4292: Fix focus range for TypeParam r=matklad a=matklad closes #4274 bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | Fix focus range for TypeParamAleksey Kladov2020-05-042-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closes #4274
* | | | | | | | | Merge #4291bors[bot]2020-05-042-5/+10
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4291: Add test marks r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | Add test marksAleksey Kladov2020-05-042-5/+10
|/ / / / / / / /
* | | | | | | | Merge #4282bors[bot]2020-05-042-18/+70
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4282: More name hints omitting heuristics r=matklad a=SomeoneToIgnore Omit parameter name hints for cases like the first two parameters from the screenshot: <img width="394" alt="Screenshot 2020-05-03 at 15 06 34" src="https://user-images.githubusercontent.com/2690773/80914717-165b2f80-8d56-11ea-8675-040972f70d98.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | | | | | Code review fixesKirill Bulatov2020-05-041-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | | | | Move snake case method to heckKirill Bulatov2020-05-032-15/+16
| | | | | | | | |
| * | | | | | | | Omit name hints for enum names similar to parameter namesKirill Bulatov2020-05-031-12/+52
| | | | | | | | |
| * | | | | | | | Omit name hints for method names similar to parameter namesKirill Bulatov2020-05-031-13/+25
| | | | | | | | |
* | | | | | | | | Merge #4285bors[bot]2020-05-042-1/+34
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4285: add support of cfg attributes on enum variants r=edwin0cheng a=bnjjj close #4279 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | | | | | | add support of cfg attributes on enum variants #4279Benjamin Coenen2020-05-032-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | | | | | Merge #4286bors[bot]2020-05-041-1/+6
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4286: Make incremental sync opt-in r=matklad a=lnicola @matklad do you want to merge this? I'd make it opt-out, but it's fine to test it more. Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | | | | | | | Make incremental sync opt-inLaurențiu Nicola2020-05-031-1/+6
| | | | | | | | | | |
* | | | | | | | | | | Merge #4287bors[bot]2020-05-041-4/+4
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4287: Update debugging.md r=matklad a=lonesometraveler Co-authored-by: KENTARO OKUDA <[email protected]>
| * | | | | | | | | | Update debugging.mdKENTARO OKUDA2020-05-031-4/+4
| | | | | | | | | | |
* | | | | | | | | | | Merge #4268bors[bot]2020-05-035-19/+66
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4268: Support auto-import in macro r=SomeoneToIgnore a=edwin0cheng Fixed: #3854 Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | | | | | | Support auto-import in macroEdwin Cheng2020-05-025-19/+66
| | |_|_|_|/ / / / / | |/| | | | | | | |
* | | | | | | | | | Merge #4280bors[bot]2020-05-032-2/+4
|\ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4280: Add documents owner for ImplDef and SourceFile r=matklad a=edwin0cheng When working on #3182, I found that `ImplDef` and `SourceFile` do not implemet `DocCommentsOwer` trait, and I tested it in `cargo doc` that `impl` could has some doc-comments. I am not so sure about `SourceFile` case, but in theory if that file is a crate root, the doc comment of it should represent the whole crate documentation, right ? Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | | | | | Add documents owner for ImplDef and SourceFileEdwin Cheng2020-05-032-2/+4
| | |_|_|_|/ / / / | |/| | | | | | |
* | | | | | | | | Merge #4278bors[bot]2020-05-031-1/+17
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4278: Log panics in apply_document_changes r=matklad a=lnicola This doesn't necessarily help (because of https://github.com/rust-analyzer/rust-analyzer/issues/4263#issuecomment-623078531), but maybe we could leave it in there for a while in case it catches something. Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | | | | | Log panics in apply_document_changesLaurențiu Nicola2020-05-031-1/+17
| | | | | | | | |
* | | | | | | | | Merge #4276bors[bot]2020-05-031-3/+9
|\| | | | | | | | | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4276: Don't count start of non-ASCII characters as being inside of them r=matklad a=lnicola I'm still not sure that `utf16_to_utf8_col` is correct for code points from Supplementary Planes. These have two UTF-16 code units, and I feel we're not going to count them correctly. Fixes the crash in https://github.com/rust-analyzer/rust-analyzer/issues/4263#issuecomment-622988258. Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | | | | | Don't count start of non-ASCII characters as being inside of themLaurențiu Nicola2020-05-031-3/+9
| | | | | | | |
* | | | | | | | Merge #4270bors[bot]2020-05-035-40/+308
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4270: Improve derive macro completion r=edwin0cheng a=SomeoneToIgnore * Adds completions for standard derive macros (considering their dependencies on each other, so we don't get compile errors) * Adds completions for custom derive macros that are in scope, if the proc macro feature is enabled in the settings * Separates macro completion from other completions to avoid incorrect completion propositions Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | | | | | Fix derive argument parsingKirill Bulatov2020-05-021-26/+40
| | | | | | | | |
| * | | | | | | | Separate macros completion from otherKirill Bulatov2020-05-021-15/+17
| | | | | | | | |
| * | | | | | | | Propose custom derives in completionKirill Bulatov2020-05-022-16/+39
| | | | | | | | |
| * | | | | | | | Complete standard derivesKirill Bulatov2020-05-022-16/+245
| | | | | | | | |
| * | | | | | | | Fix the extension methodKirill Bulatov2020-05-021-1/+1
| | |/ / / / / / | |/| | | | | |
* | | | | | | | Merge #4272bors[bot]2020-05-021-21/+21
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | / / / / / | | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | 4272: Fix Typos r=jonas-schievink a=lonesometraveler Co-authored-by: KENTARO OKUDA <[email protected]>
| * | | | | | Update syntax.mdKENTARO OKUDA2020-05-021-2/+2
| | | | | | |
| * | | | | | Fix TyposKENTARO OKUDA2020-05-021-20/+20
| | | | | | |
| | | | | | |
| \ \ \ \ \ \
*-. \ \ \ \ \ \ Merge #4207 #4253bors[bot]2020-05-028-14/+390
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4207: Add unwrap block assist #4156 r=matklad a=bnjjj close issue #4156 4253: Remove `workspaceLoaded` setting r=matklad a=eminence The `workspaceLoaded` notification setting was originally designed to control the display of a popup message that said: "workspace loaded, {} rust packages" This popup was removed and replaced by a much sleeker message in the VSCode status bar that provides a real-time status while loading: rust-analyzer: {}/{} packages This was done as part of #3587 The change in this PR simply renames this setting from `workspaceLoaded` to `progress` to better describe what it actually controls. At the moment, the only type of progress message that is controlled by this setting is the initial load messages, but in theory other messages could also be controlled by this setting. Reviewer notes: * If we didn't like the idea of causing minor breaking to user's config, we could keep the setting name as `workspaceLoaded` * I think we can now close both #2719 and #3176 since the notification dialog in question no longer exists (actually I think you can close those issues even if you reject this PR 😄 ) Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | | | | | | Remove `workspaceLoaded` settingAndrew Chin2020-05-023-13/+2
| | | |_|_|_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `workspaceLoaded` notification setting was originally designed to control the display of a popup message that said: "workspace loaded, {} rust packages" This popup was removed and replaced by a much sleeker message in the VSCode status bar that provides a real-time status while loading: rust-analyzer: {}/{} packages This was done as part of #3587 The new status-bar indicator is unobtrusive and shouldn't need to be disabled. So this setting is removed.
| * | | | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-0213-17/+139
| |\ \ \ \ \ \ \
| * | | | | | | | Add unwrap block assist #4156Benjamin Coenen2020-05-021-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-02255-11165/+11241
| |\ \ \ \ \ \ \ \
| * | | | | | | | | Add unwrap block assist #4156Benjamin Coenen2020-05-021-76/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | | | | Add unwrap block assist #4156Benjamin Coenen2020-05-011-46/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-0168-592/+1928
| |\ \ \ \ \ \ \ \ \ | | | |_|_|_|_|_|_|/ | | |/| | | | | | |
| * | | | | | | | | Add unwrap block assist #4156Benjamin Coenen2020-04-293-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | | | | | Add unwrap block assist #4156Benjamin Coenen2020-04-295-1/+475
| | |_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | | | | Merge #4261bors[bot]2020-05-0211-62/+107
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4261: Fix parsing of blocks without `{` r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | | | Fix parsing of blocks without `{`Aleksey Kladov2020-05-0211-62/+107
|/ / / / / / / /
* | | | | | | | Merge #4234bors[bot]2020-05-0213-17/+139
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4234: Support local_inner_macros r=jonas-schievink a=edwin0cheng This PR implements `#[macro_export(local_inner_macros)]` support. Note that the rustc implementation is quite [hacky][1] too. :) [1]: https://github.com/rust-lang/rust/blob/614f273e9388ddd7804d5cbc80b8865068a3744e/src/librustc_resolve/macros.rs#L456 Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | | | Test whether it is bang macro properlyEdwin Cheng2020-05-022-8/+10
| | | | | | | |
| * | | | | | | Add test in name resolutionsEdwin Cheng2020-05-021-0/+37
| | | | | | | |
| * | | | | | | Update crates/ra_hir_expand/src/builtin_derive.rs Edwin Cheng2020-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix spacing Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | | | Make AttrQuery copyableEdwin Cheng2020-05-012-10/+15
| | | | | | | |
| * | | | | | | Support local_inner_macrosEdwin Cheng2020-05-0110-19/+97
| | |/ / / / / | |/| | | | |