aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused variableJeremy A. Kolb2018-11-071-1/+0
|
* Show documentation for hover requestsJeremy A. Kolb2018-11-076-4/+71
|
* Add some more DocCommentsOwnerJeremy A. Kolb2018-11-072-2/+14
|
* Merge #207bors[bot]2018-11-078-13/+235
|\ | | | | | | | | | | | | | | 207: Finish implementing char validation r=aochagavia a=aochagavia The only thing missing right now are good integration tests (and maybe more descriptive error messages) Co-authored-by: Adolfo Ochagavía <[email protected]>
| * Fix backslash escapeAdolfo Ochagavía2018-11-071-2/+4
| |
| * Use ArrayString instead of hand rolled data structureAdolfo Ochagavía2018-11-075-39/+6
| |
| * cargo formatAdolfo Ochagavía2018-11-072-30/+39
| |
| * Add lots of testsAdolfo Ochagavía2018-11-073-6/+125
| |
| * Store hex digits in a stack-allocated bufferAdolfo Ochagavía2018-11-072-5/+45
| |
| * Finish implementing char validationAdolfo Ochagavía2018-11-063-8/+93
| |
* | Merge #213bors[bot]2018-11-061-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 213: remove the last changing file from cache r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | remove the last changing file from cacheAleksey Kladov2018-11-061-0/+1
|/ /
* | Merge #212bors[bot]2018-11-061-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 212: evitct more stuff from cache r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | evitct more stuff from cacheAleksey Kladov2018-11-061-1/+1
|/ /
* | Merge #211bors[bot]2018-11-064-206/+969
|\ \ | | | | | | | | | | | | | | | | | | | | | 211: ra_syntax::File is just RootNode r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | ra_syntax::File is just RootNodeAleksey Kladov2018-11-064-206/+969
|/ /
* | Merge #210bors[bot]2018-11-061-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 210: cleanup cahces more aggressively r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | cleanup cahces more aggressivelyAleksey Kladov2018-11-061-1/+1
| | |
* | | Merge #209bors[bot]2018-11-067-1818/+1265
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 209: Owned nodes r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add a pinch of commentsAleksey Kladov2018-11-063-0/+16
| | |
| * | Generalize Owned nodesAleksey Kladov2018-11-066-1818/+1249
|/ /
* | Merge #208bors[bot]2018-11-063-1/+35
|\ \ | | | | | | | | | | | | | | | | | | | | | 208: grammar: fix where clause parsing r=matklad a=matklad closes #205 Co-authored-by: Aleksey Kladov <[email protected]>
| * | grammar: fix where clause parsingAleksey Kladov2018-11-063-1/+35
|/ / | | | | | | closes #205
* / upstream basic tree algorithms to rowanAleksey Kladov2018-11-064-110/+13
|/
* new discordAleksey Kladov2018-11-061-4/+2
|
* Merge #199bors[bot]2018-11-061-1/+1
|\ | | | | | | | | | | | | | | 199: Use closing paren as a trigger character r=matklad a=kjeremy This seems counter-intuitive based on the concept of "trigger character" but it provides a better function signature experience. Co-authored-by: Jeremy A. Kolb <[email protected]>
| * Use closing paren as a trigger characterJeremy A. Kolb2018-11-051-1/+1
|/ | | | | This seems counter-intuitive based on the concept of "trigger character" but it provides a better function signature experience.
* Merge #188bors[bot]2018-11-0511-68/+193
|\ | | | | | | | | | | | | | | | | 188: Introduce `SyntaxErrorKind` and `TextRange` to `SyntaxError` r=matklad a=aochagavia Co-authored-by: Adolfo Ochagavía <[email protected]> Co-authored-by: Adolfo Ochagavía <[email protected]>
| * cargo formatAdolfo Ochagavía2018-11-052-5/+9
| |
| * Introduce Location and make SyntaxError fields privateAdolfo Ochagavía2018-11-0510-52/+82
| |
| * Introduce SyntaxErrorKind and TextRange in SyntaxErrorAdolfo Ochagavía2018-11-0410-64/+155
| |
* | bring back testutilsAleksey Kladov2018-11-051-1/+1
| |
* | add descriptionAleksey Kladov2018-11-051-1/+3
| |
* | Switch ra_syntax to 2015 editionAleksey Kladov2018-11-052-1/+4
| |
* | Introduce var works with tail exprsAleksey Kladov2018-11-051-11/+45
| |
* | Merge #194bors[bot]2018-11-057-165/+132
|\ \ | | | | | | | | | | | | | | | | | | | | | 194: Introduce FilePosition r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Use FilePosition everywhereAleksey Kladov2018-11-057-157/+124
| | |
| * | rename Position to FilePostionAleksey Kladov2018-11-052-9/+9
|/ /
* | don't send backtraces for canceled requestsAleksey Kladov2018-11-051-5/+15
| |
* | Merge #193bors[bot]2018-11-0512-87/+198
|\ \ | | | | | | | | | | | | | | | | | | | | | 193: Inline modules r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fully add inline modules to module treeAleksey Kladov2018-11-059-47/+99
| | |
| * | Submodule is enumAleksey Kladov2018-11-053-21/+67
| | |
| * | collect all submodulesAleksey Kladov2018-11-052-20/+30
| | |
| * | submodules works with module sourcesAleksey Kladov2018-11-052-13/+20
| | |
| * | use module_for_sourceAleksey Kladov2018-11-053-12/+8
| | |
| * | Introduce modules_from_source fnAleksey Kladov2018-11-051-6/+6
|/ /
* | reduce code duplicationAleksey Kladov2018-11-052-21/+19
| |
* | Merge #192bors[bot]2018-11-054-35/+129
|\ \ | |/ |/| | | | | | | | | | | 192: grammar: for predicates in where r=matklad a=matklad closes #191 Co-authored-by: Aleksey Kladov <[email protected]>
| * grammar: for predicates in whereAleksey Kladov2018-11-054-35/+129
|/ | | | closes #191
* Merge #184bors[bot]2018-11-046-2/+397
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 184: Basic validation for character literals r=aochagavia a=aochagavia As part of #27 I would like to add a validator for characters that detects missing quotes and too long characters. I set up a dummy implementation to get my feet wet, which generates errors whenever it finds a character. Right now I have the following questions: 1. The `SyntaxError` type seems too basic to me. I think it would make sense to have a `SyntaxErrorKind` instead of a `msg` field (we can implement `Display` for it so you can generate the string if desired). It should also have a `TextRange` instead of a `TextUnit`, so you can support errors that are longer than one character. Do you agree? 1. I am manually checking whether the literal is a character (see the `is_char` method). Ideally, I would like to have a `LiteralKind` enum with variants like `Int`, `Float`, `Char`, `String`, etc. but it seems cumbersome to write all that by hand. Is there a way to specify this in `grammar.ron` so that the code is generated (the same way the `Expr` enum is generated)? By the way, there seems to be no error reporting of panics inside the language server. When I was developing this PR I accidentally introduced a panic, which resulted in no syntax errors being shown. I knew something was wrong, because normally the vscode highlights syntax errors, but I didn't know it was caused by a panic. Co-authored-by: Adolfo Ochagavía <[email protected]>