aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #3131bors[bot]2020-02-144-211/+96
|\ | | | | | | | | | | | | | | 3131: vscode: simplified config and to removed one source of truth of default values r=matklad a=Veetaha Though not intended initially, the implementation of config design is alike [dart's one](https://github.com/Dart-Code/Dart-Code/blob/master/src/extension/config.ts) as pointed by @matklad in PM. Co-authored-by: Veetaha <[email protected]>
| * make onConfigChange handler privateVeetaha2020-02-141-1/+1
| |
| * vscode: moved to getters as per matkladVeetaha2020-02-145-39/+33
| |
| * vscode: reordered config constructor before methodsVeetaha2020-02-131-5/+6
| |
| * vscode: redesigned config with simplicity and Dart extension config ↵Veetaha2020-02-135-216/+96
| | | | | | | | implementation in mind
| * vscode: added more type safety to package.json configVeetaha2020-02-131-0/+10
| |
* | Merge #3147bors[bot]2020-02-143-0/+42
|\ \ | | | | | | | | | | | | | | | | | | | | | 3147: Check that impl self type matches up with expected self type in path mode r=matklad a=flodiebold Fixes #3144. Co-authored-by: Florian Diebold <[email protected]>
| * | Check that impl self type matches up with expected self type in path modeFlorian Diebold2020-02-143-0/+42
| | | | | | | | | | | | Fixes #3144.
* | | Merge #3145bors[bot]2020-02-144-9/+78
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3145: Make Self implement the trait inside trait default methods r=matklad a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | Make Self implement the trait inside trait default methodsFlorian Diebold2020-02-144-9/+78
| | | |
* | | | Merge #3146bors[bot]2020-02-141-1/+1
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3146: Typo r=flodiebold a=Veetaha typo Co-authored-by: Veetaha <[email protected]>
| * | | TypoVeetaha2020-02-141-1/+1
|/ / / | | | | | | typo
* | | Merge #3143bors[bot]2020-02-141-2/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3143: Make AtomicX type resolve again r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Make AtomicX type resolve againAleksey Kladov2020-02-141-2/+4
| | | |
* | | | Merge #3142bors[bot]2020-02-141-0/+3
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 3142: Ensure that the manual is self-improving r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Ensure that the manual is self-improvingAleksey Kladov2020-02-141-0/+3
| |/ /
* | | Merge #3141bors[bot]2020-02-141-5/+2
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3141: Simplify r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | SimplifyAleksey Kladov2020-02-141-5/+2
| | |
* | | Merge #3140bors[bot]2020-02-145-299/+214
|\| | | | | | | | | | | | | | | | | | | | | | | 3140: Start manual r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Move rm_rf to not-bashAleksey Kladov2020-02-142-9/+23
| | |
| * | Trim outputAleksey Kladov2020-02-141-1/+1
| | |
| * | Add fs2 module for better error messagesAleksey Kladov2020-02-142-5/+28
| | |
| * | Update the manual on releaseAleksey Kladov2020-02-141-1/+4
| | |
| * | Add dry run mode to xtask releaseAleksey Kladov2020-02-142-6/+9
| | |
| * | Start manualAleksey Kladov2020-02-142-280/+152
| | |
* | | Merge #3139bors[bot]2020-02-142-12/+12
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3139: Expect vscode 1.42 r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Expect vscode 1.42kjeremy2020-02-142-12/+12
|/ /
* | Merge #3137bors[bot]2020-02-141-1/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3137: Do not register all proposed features r=matklad a=kjeremy Instead only opt-in to CallHierarchy since it has a vscode API but LSP support is still proposed. Discovered while working on SemanticTokens which does not have a vscode API and is still in the proposed state. Somehow enabling it would crash the language server. See https://github.com/microsoft/vscode-languageserver-node/issues/572 Co-authored-by: kjeremy <[email protected]>
| * | Do not register all proposed featureskjeremy2020-02-141-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead only opt-in to CallHierarchy since it has a vscode API but LSP support is still proposed. Discovered while working on SemanticTokens which does not have a vscode API and is still in the proposed state. Somehow enabling it would crash the language server. See https://github.com/microsoft/vscode-languageserver-node/issues/572
* | | Merge #3133bors[bot]2020-02-142-372/+376
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3133: Move hir_fmt code to display module r=matklad a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | Move hir_fmt code to display moduleFlorian Diebold2020-02-142-372/+376
| |/ /
* | | Merge #3136bors[bot]2020-02-147-162/+202
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3136: Not bash r=matklad a=matklad More declarative installation Co-authored-by: Aleksey Kladov <[email protected]>
| * | CleanupAleksey Kladov2020-02-141-1/+1
| | |
| * | More declarative fs massagingAleksey Kladov2020-02-142-18/+35
| | |
| * | Replace Cmd with not-bashAleksey Kladov2020-02-145-154/+171
| | |
| * | Prevent auto-update of dev extensionAleksey Kladov2020-02-143-6/+24
| | |
| * | MinorAleksey Kladov2020-02-141-31/+19
| | |
* | | Merge #3132bors[bot]2020-02-143-11/+11
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3132: Rename Ty::Param => Ty::Placeholder r=matklad a=flodiebold This aligns more with Chalk. Co-authored-by: Florian Diebold <[email protected]>
| * | Rename Ty::Param => Ty::PlaceholderFlorian Diebold2020-02-143-11/+11
|/ / | | | | | | This aligns more with Chalk.
* | Merge #3116bors[bot]2020-02-132-13/+22
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 3116: vscode: added error handling to download file streams r=matklad a=Veetaha As a followup for #3092 `ts-nested-error` is mine, it is just [one file worth nothing](https://github.com/Veetaha/ts-nested-error/blob/master/src/nested-error.ts), but let's us inspect original errors Co-authored-by: Veetaha <[email protected]>
| * | vscode: removed nested errors as per matkladVeetaha2020-02-133-10/+3
| | |
| * | vscode: replaced DownloadFileError with NestedError itself for simplicityVeetaha2020-02-131-6/+7
| | |
| * | vscode: switched to stream.pipeline with .on(close) workaroundVeetaha2020-02-121-19/+17
| | |
| * | vscode: added error handling to download file streamsVeetaha2020-02-114-7/+24
| | |
* | | Merge #3120bors[bot]2020-02-132-45/+545
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3120: Support trait auto import r=matklad a=SomeoneToIgnore Unfortunately, for real cases it does not work as spectacular as in the tests. The main reason for that is type inference: * The callee type [here](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_hir_ty/src/method_resolution.rs#L369) is unknown for many cases * The trait solution [here](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_hir_ty/src/method_resolution.rs#L399) is also often ambiguous That results in trait candidates being rejected, and some real cases not supported. Example: no imports for `String::from_str("test")` Co-authored-by: Kirill Bulatov <[email protected]>
| * | | Do not collect all traitsKirill Bulatov2020-02-121-102/+53
| | | |
| * | | Support associated constsKirill Bulatov2020-02-121-18/+133
| | | |
| * | | Also consider associated constantsKirill Bulatov2020-02-121-8/+8
| | | |
| * | | Revert source_analyzer changesKirill Bulatov2020-02-122-55/+6
| | | |
| * | | Fix post-rebase issuesKirill Bulatov2020-02-122-25/+25
| | | |