aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Add HighlightModifier::Callable and add it for localsGrayJack2020-10-164-0/+8
| | | |
* | | | Merge #6339bors[bot]2020-10-239-104/+224
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6339: Diagnose #[cfg]s in bodies r=matklad a=jonas-schievink This PR threads diagnostics through body lowering using the `BodySourceMap`, and emits `InactiveCode` diagnostics for expressions, statements, and match arms that are `#[cfg]`d out. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Fix name of InactiveCode diagnosticJonas Schievink2020-10-232-7/+7
| | | | |
| * | | | Diagnose #[cfg]s in bodiesJonas Schievink2020-10-239-98/+218
| | | | |
* | | | | Merge #6336bors[bot]2020-10-231-7/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6336: Improve Chalk debugging r=matklad a=flodiebold - add panic context for the trait goal if CHALK_DEBUG is set - print the Chalk program even if we're panicking - log goal/solution while TLS is still set Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Improve Chalk debuggingFlorian Diebold2020-10-231-7/+23
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | - add panic context for the trait goal if CHALK_DEBUG is set - print the Chalk program even if we're panicking - log goal/solution while TLS is still set
* | | | | Merge #6341bors[bot]2020-10-231-8/+62
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6341: Complete variants when only enun name is typed r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Complete variants when only enun name is typedAleksey Kladov2020-10-231-8/+62
|/ / / / | | | | | | | | | | | | | | | | This allows the client to filter `Foo::Bar` when *either* `Foo` or `Bar` is typed.
* | | | Merge #6335bors[bot]2020-10-232-5/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6335: Fix panic context r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Fix panic contextAleksey Kladov2020-10-232-5/+5
| | | | |
* | | | | Merge #6324bors[bot]2020-10-2315-140/+816
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6324: Improve #[cfg] diagnostics r=jonas-schievink a=jonas-schievink Unfortunately I ran into https://github.com/rust-analyzer/rust-analyzer/issues/4058 while testing this on https://github.com/nrf-rs/nrf-hal/, so I didn't see much of it in action yet, but it does seem to work. Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| * | | | cfg: move tests to separate fileJonas Schievink2020-10-234-208/+195
| | | | | | | | | | | | | | | | | | | | | | | | | that way we don't have to re-check the entire project when a test is changed
| * | | | Reorder itemsJonas Schievink2020-10-231-9/+9
| | | | |
| * | | | Use format_toJonas Schievink2020-10-231-4/+3
| | | | | | | | | | | | | | | | | | | | Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Update crates/cfg/src/cfg_expr.rsJonas Schievink2020-10-221-1/+1
| | | | | | | | | | | | | | | Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Emit better #[cfg] diagnosticsJonas Schievink2020-10-229-65/+124
| | | | |
| * | | | Fix typoJonas Schievink2020-10-222-1/+2
| | | | |
| * | | | Implement DNF-based `#[cfg]` introspectionJonas Schievink2020-10-225-2/+622
| | | | |
| * | | | Simplify cfg representationJonas Schievink2020-10-213-31/+41
| | | | |
* | | | | Merge #6098bors[bot]2020-10-225-26/+132
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6098: Insert ref for completions r=adamrk a=adamrk Follow up to https://github.com/rust-analyzer/rust-analyzer/pull/5846. When we have a local in scope which needs a ref or mutable ref to match the name and type of the active in the completion context then a new completion item with `&` or `&mut ` is inserted. E.g. ```rust fn foo(arg: &i32){}; fn main() { let arg = 1_i32; foo(a<|>) } ``` now offers `&arg` as a completion option with the highest score. Co-authored-by: adamrk <[email protected]>
| * | | | | Insert ref for completionsadamrk2020-10-225-26/+132
|/ / / / /
| | | | |
| \ \ \ \
*-. \ \ \ \ Merge #6325 #6327bors[bot]2020-10-222-1/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6325: Add generated diagnostic docs to the manual r=matklad a=flodiebold It seemed that we're not actually including the generated diagnostic docs anywhere yet? So I added something to the manual. This is completely untested though. 6327: Update debugging.md r=matklad a=stanciuadrian `on_task` is no longer there. I have used `on_request` instead. Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Adrian Stanciu <[email protected]>
| | * | | | | Update debugging.mdAdrian Stanciu2020-10-221-1/+1
| | | |/ / / | | |/| | |
| * / | | | Add generated diagnostic docs to the manualFlorian Diebold2020-10-221-0/+7
| |/ / / /
* | | | | Merge #6326bors[bot]2020-10-221-1/+28
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6326: hide paramater inlay hints for cloned vars if applicable r=SomeoneToIgnore a=Veykril This causes `foo.clone()` parameters to be handled as if they were just `foo` parameters for inlay hint logic. Fixes #6315 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Hide paramater inlay hints for cloned vars if applicableLukas Wirth2020-10-221-1/+28
| | |_|/ | |/| |
* | | | Merge #6319bors[bot]2020-10-222-3/+34
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6319: Properly identify camel cased acronyms as UpperCamelCase r=popzxc a=ArifRoktim This closes #6305. Co-authored-by: Arif Roktim <[email protected]>
| * | | | Properly identify camel cased acronyms as UpperCamelCaseArif Roktim2020-10-212-3/+34
| |/ / /
| | | |
| \ \ \
*-. \ \ \ Merge #6320 #6321bors[bot]2020-10-222-23/+58
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6320: Textmate grammar: prevent line comments from breaking block comments (closes #6281) r=matklad a=dustypomerleau Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6281. Previously, line comments were able to break block comments by essentially commenting out the closing `*/`, resulting in a never-ending comment. This PR splits block comments into a separate repository group to fix this problem. Since the comment scopes also include ignored parameters and inferred types, I've added the change proposed by @bnjjj in https://github.com/rust-analyzer/rust-analyzer/pull/6317, in order to close https://github.com/rust-analyzer/rust-analyzer/issues/6311 as well. 6321: Fix opening module documentation opening parent documentation instead r=matklad a=zacps The whole path/URL joining code is kind of ugly which is what led to this, but at the same time I don't really want to rewrite it right now... Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6286 Co-authored-by: Dusty Pomerleau <[email protected]> Co-authored-by: Zac Pullar-Strecker <[email protected]>
| | * | | | Fix opening module documentation opening parent documentation insteadZac Pullar-Strecker2020-10-221-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The whole path/URL joining code is kind of ugly which is what led to this, but at the same time I don't really want to rewrite it right now...
| * | | | | fix: prevent line comments inside block commentsDusty Pomerleau2020-10-221-19/+34
| |/ / / / | | | | | | | | | | | | | | | | | | | | - prevent line comments inside block comments - prevent underscore-prefixed functions and macros from receiving comment scope
* | | | | Merge #6314bors[bot]2020-10-221-2/+40
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6314: generate assist respect cfg attributes r=matklad a=bnjjj close #6312 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | generate_impl assist respect cfg attributes #6312Benjamin Coenen2020-10-221-2/+40
| |/ / / | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #6307bors[bot]2020-10-213-2/+99
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6307: Add whitelist of safe intrinsics r=frazar a=frazar This PR should fix #5996, where intrinsic operations where all marked as unsafe. I'm rather new to this codebase, so I might be doing something *very* wrong. Please forgive me! In particular, I'm not sure how to "check that we are in extern `rust-intrinsics`" as mentioned [in this comment](https://github.com/rust-analyzer/rust-analyzer/issues/5996#issuecomment-709234802). Co-authored-by: Francesco Zardi <[email protected]>
| * | | Refactor is_intrinsic_fn_unsafe() and make it privateFrancesco Zardi2020-10-211-39/+42
| | | |
| * | | Move safe intrinsic testsFrancesco Zardi2020-10-212-20/+18
| | | |
| * | | Fix typo in commentFrancesco Zardi2020-10-211-1/+1
| | | |
| * | | Add whitelist of safe intrinsicsFrancesco Zardi2020-10-213-2/+98
| | | |
* | | | Merge #6302bors[bot]2020-10-211-22/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6302: Textmate grammar: fix raw string highlighting r=matklad a=dustypomerleau 1. Fixes the raw string highlighting issue noted by @matklad in https://github.com/rust-analyzer/rust-analyzer/pull/6275. 2. Improves raw string highlighting by requiring the number of surrounding `#` to match. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | | fix: require matching hash quantities for raw stringsDusty Pomerleau2020-10-211-22/+3
|/ / / /
* | | | Merge #6270bors[bot]2020-10-204-11/+29
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6270: Update crates r=matklad a=kjeremy This brings in a number of new dependencies though. Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | Update cratesJeremy Kolb2020-10-204-11/+29
|/ / / / | | | | | | | | | | | | This brings in a number of new dependencies though.
* | | | Merge #6259bors[bot]2020-10-202-17/+51
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6259: allow xtask install --client[=CLIENT] to specify client r=Emilgardis a=Emilgardis Co-authored-by: Emil Gardström <[email protected]>
| * | | | rename flag --client-code to --client on xtask installEmil Gardström2020-10-201-8/+8
| | | | |
| * | | | allow xtask install --client-code[=CLIENT] to specify clientEmil Gardström2020-10-172-15/+49
| | | | |
* | | | | Merge #6109bors[bot]2020-10-208-136/+240
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6109: add completions for clippy lint in attributes r=bnjjj a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | | add completions for clippy lint in attributesBenjamin Coenen2020-10-208-136/+240
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge #6256bors[bot]2020-10-203-0/+160
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6256: Assist: replace string with char r=bnjjj a=bnjjj close #6252 Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Coenen Benjamin <[email protected]>
| * | | | | Update crates/assists/src/handlers/replace_string_with_char.rsCoenen Benjamin2020-10-201-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Assist: replace string with charBenjamin Coenen2020-10-202-8/+39
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>