aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Rename declaration_name -> display_nameAleksey Kladov2020-10-2011-35/+28
| | | | | | | | Declaration names sounds like a name of declaration -- something you can use for analysis. It empathically isn't, and is just a label displayed in various UI. It's important not to confuse the two, least we accidentally mix semantics with UI (I believe, there's already a case of this in the FamousDefs at least).
* Merge #6294bors[bot]2020-10-202-0/+28
|\ | | | | | | | | | | | | | | | | 6294: Add a hacky remidy for #6038 r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add a hacky remidy for #6038Aleksey Kladov2020-10-202-0/+28
| | | | | | | | | | | | | | The proper fix I think is: * move rust-lang/rust library crates to a separate workspace * when packaging rust-src component, vendor sources of external deps
* | Merge #6266bors[bot]2020-10-2010-6/+156
|\ \ | |/ |/| | | | | | | | | | | | | 6266: Generate diagnostics docs r=matklad a=popzxc Resolves #6215 Co-authored-by: Igor Aleksanov <[email protected]>
| * Add generated_diagnostic.adoc to the release.rs and smoke_test_docs_generationIgor Aleksanov2020-10-192-1/+9
| |
| * Use xshell::read_file instead of fs::read_to_stringIgor Aleksanov2020-10-194-9/+10
| |
| * Add descriptions for diagnostics parseable by xtaskIgor Aleksanov2020-10-192-0/+64
| |
| * Create xtask module to generate diagnostics docsIgor Aleksanov2020-10-193-0/+77
|/
* Merge #6290bors[bot]2020-10-191-3/+3
|\ | | | | | | | | | | | | | | | | 6290: Fix deprecation warning r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix deprecation warningAleksey Kladov2020-10-191-3/+3
|/ | | | See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
* Merge #6288bors[bot]2020-10-191-0/+1
|\ | | | | | | | | | | | | | | | | 6288: Tag release branch rather than master r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Tag release branch rather than masterAleksey Kladov2020-10-191-0/+1
|/
* Merge #6274bors[bot]2020-10-191-1/+3
|\ | | | | | | | | | | | | | | 6274: Check cargoExtraArgs for undefined before using r=matklad a=feileacan Fixes #6273 Co-authored-by: feileacan <[email protected]>
| * Check cargoExtraArgs for undefined before usingfeileacan2020-10-181-1/+3
| |
* | Merge #6284bors[bot]2020-10-191-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6284: Document logging of project model r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Document logging of project modelAleksey Kladov2020-10-191-0/+1
|/ /
* | Merge #6283bors[bot]2020-10-191-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6283: Minor, rename feature r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Minor, rename featureAleksey Kladov2020-10-191-1/+1
|/ /
* | Merge #6282bors[bot]2020-10-191-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6282: Try to fix publishing r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Try to fix publishingAleksey Kladov2020-10-191-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | This errro specifically: Updating crates.io index error: failed to select a version for the requirement `ra_ap_stdx = "^0.0.0"` candidate versions found which didn't match: 0.0.20 location searched: /home/runner/work/rust-analyzer/rust-analyzer/crates/stdx required by package `ra_ap_completion v0.0.20 (/home/runner/work/rust-analyzer/rust-analyzer/crates/completion)` error: unable to update Cargo.lock Error: Process completed with exit code 1.
* | Merge #6280bors[bot]2020-10-191-6/+6
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6280: :arrow_up: crates r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | :arrow_up: cratesAleksey Kladov2020-10-191-6/+6
|/ /
* | Merge #6277bors[bot]2020-10-182-5/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6277: Change visibility works for type aliases r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Change visibility works for type aliasesAleksey Kladov2020-10-182-5/+19
|/ /
* | Merge #6276bors[bot]2020-10-1834-227/+337
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6276: Extract call_info and completion into separate crates r=matklad a=popzxc As it was discussed in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Completion.20refactoring), we need to move `completions` into a separate crate. Unfortunately, the dependency on `call_info::ActiveParameter` doesn't look easy to get rid of, and it seems to be a topic for a separate PR, thus I also extracted `call_info` into a separate crate (on which both `ide` and `completion` crates depend). Additionally, a few `FIXME`s in doc-comments were resolved in order to make `tidy` happy. Co-authored-by: Igor Aleksanov <[email protected]>
| * | Extract call_info and completion into separate cratesIgor Aleksanov2020-10-1834-227/+337
|/ /
* | Merge #6275bors[bot]2020-10-181-14/+6
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 6275: Textmate grammar: prevent unwanted interpolation scopes r=matklad a=dustypomerleau Fixes the issues noted by @matklad after merging #6248. 1. prevent accidental interpolation scopes when `{` is used in a string 1. prevent interpolations from extending beyond the end of a string Co-authored-by: Dusty Pomerleau <[email protected]>
| * fix: prevent unwanted interpolation scopesDusty Pomerleau2020-10-181-14/+6
|/
* Merge #6272bors[bot]2020-10-182-9/+9
|\ | | | | | | | | | | | | | | | | 6272: :arrow_up: xshell r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * update depsAleksey Kladov2020-10-182-5/+5
| |
| * :arrow_up: xshellAleksey Kladov2020-10-181-4/+4
|/
* Merge #6271bors[bot]2020-10-173-2/+20
|\ | | | | | | | | | | | | | | | | 6271: Complete methods when receiver is a macro r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Complete methods when receiver is a macroAleksey Kladov2020-10-172-0/+16
| |
| * Improve readabilityAleksey Kladov2020-10-171-2/+4
| |
* | Merge #6248bors[bot]2020-10-171-3/+22
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6248: Textmate grammar: prevent early termination of raw strings with hash (closes #6042) r=matklad a=dustypomerleau Problematic sample code from #6042: ```rust #[derive(Debug, Clone, Logos)] enum Quoted<'source> { #[regex(r#"[^\\"']+"#)] Text(&'source str), #[token("\\")] StartEscape, #[token("\'", |_| Quote::Single)] #[token("\"", |_| Quote::Double)] End(Quote), #[error] Error, } ``` Before fix: <img width="400" alt="Screen Shot 2020-10-16 at 10 45 59" src="https://user-images.githubusercontent.com/6304651/96198390-6a726d00-0fa0-11eb-8428-e76b2866836b.png"> After fix: <img width="400" alt="Screen Shot 2020-10-16 at 10 45 33" src="https://user-images.githubusercontent.com/6304651/96198408-7a8a4c80-0fa0-11eb-9104-ca708009fe63.png"> Co-authored-by: Dusty Pomerleau <[email protected]>
| * fix: prevent early termination of raw strings with hashDusty Pomerleau2020-10-161-3/+22
| |
* | Merge #6265bors[bot]2020-10-171-8/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6265: :arrow_up: xshell r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | :arrow_up: xshellAleksey Kladov2020-10-171-8/+8
|/ /
* | Merge #6262bors[bot]2020-10-174-5/+131
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6262: Do not spawn redundant hints r=SomeoneToIgnore a=popzxc Closes #5206 This is a second part of the fix (first was #5997). This PR adds a new method to the `CompletionContext`: `no_completion_required`. If this method returns `true`, it essentially means that user is unlikely to expect any hints from the IDE at this cursor position. Currently, checks for the following cases were added: - Previous item is `fn`: user creates a new function, names of existing functions won't be helpful. Exception for this case is `impl Foo for Bar` -- we must suggest trait function names. - User entered `for _ i<|>`: it's obviously going to be `in` keyword, any hints here will be confusing. More checks may be added there later, but currently I've only figured two cases. ![no_redundant_hints](https://user-images.githubusercontent.com/12111581/96332088-da4d2a00-106a-11eb-89a1-1159ece18f9d.png) Co-authored-by: Igor Aleksanov <[email protected]>
| * | Scan all ancestors for the impl trait block checkIgor Aleksanov2020-10-172-14/+17
| | |
| * | Allow hints after 'fn' keyword if it's an impl trait blockIgor Aleksanov2020-10-173-4/+37
| | |
| * | Add test for new pattern functionsIgor Aleksanov2020-10-171-0/+8
| | |
| * | Improve test_no_completions_required testIgor Aleksanov2020-10-171-1/+17
| | |
| * | Remove redundant completionsIgor Aleksanov2020-10-173-4/+70
|/ /
* | Merge #6260bors[bot]2020-10-1714-325/+181
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6260: xshell r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Switch from not_bash to xshellAleksey Kladov2020-10-1714-325/+181
|/ /
* | Merge #6253bors[bot]2020-10-161-0/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6253: Document change of 'cargo' Runnable kind in lsp-extensions.md r=lnicola a=popzxc As was requested in https://github.com/rust-analyzer/rust-analyzer/pull/5954#issuecomment-708325521 Co-authored-by: Igor Aleksanov <[email protected]>
| * | Document change of 'cargo' Runnable kind in lsp-extensions.mdIgor Aleksanov2020-10-161-0/+3
| | |
* | | Merge #6255bors[bot]2020-10-164-10/+13
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 6255: Improve compile time a tiny bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Improve compile time a tiny bitAleksey Kladov2020-10-164-10/+13
|/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 20:40:04 +0100