aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Adjusted the completion lookups to filter by just the name.Kevin DeLorey2020-02-141-29/+44
|
* Completion now replaces whole fn/const/type def with snippet.Kevin DeLorey2020-02-131-16/+31
|
* Cheese const tests as they requre an ident before becoming a CONST_DEF.Kevin DeLorey2020-02-131-28/+21
|
* Started to refactor the trigger of the trait_impl completion.Kevin DeLorey2020-02-131-33/+77
|
* Formatting.Kevin DeLorey2020-02-111-1/+3
|
* Fixing minor suggestions and added module level documentation.Kevin DeLorey2020-02-112-11/+7
|
* Removed doc comments entirely from the changes.Kevin DeLorey2020-02-112-41/+0
|
* Formatted changes.Kevin DeLorey2020-02-113-29/+23
|
* Removed docs from private method.Kevin DeLorey2020-02-111-8/+0
|
* Fixed warning generated after refactoring.Kevin DeLorey2020-02-111-1/+1
|
* Updated the `add_missing_impl_members` to use the shared utility.Kevin DeLorey2020-02-112-34/+15
|
* Adjusted the hashset buckets to lump functions/consts together as their ↵Kevin DeLorey2020-02-111-9/+10
| | | | names must be unique.
* Added tests to test associated types and consts.Kevin DeLorey2020-02-111-0/+78
|
* Added some documentation to the `complete_trait_impl` completion.Kevin DeLorey2020-02-111-1/+48
|
* Added associated const magic completion.Kevin DeLorey2020-02-101-11/+53
|
* Added a utility function that can be used to determine the missing impl items.Kevin DeLorey2020-02-094-118/+95
|
* Merge branch 'master' into kdelorey/complete-trait-implKevin DeLorey2020-02-09363-4552/+7355
|\
| * Merge #3068bors[bot]2020-02-091-13/+37
| |\ | | | | | | | | | | | | | | | | | | | | | 3068: Do not import anything if first segment of the qualified path resolves r=matklad a=SomeoneToIgnore Part of initial https://github.com/rust-analyzer/rust-analyzer/pull/3061, closing 2nd issue mentioned in the last comment there. Co-authored-by: Kirill Bulatov <[email protected]>
| | * Fix rebase leftoversKirill Bulatov2020-02-091-2/+2
| | |
| | * Do not import anything if first segment of FQN resolvesKirill Bulatov2020-02-091-12/+36
| | |
| * | Merge #3053bors[bot]2020-02-0911-30/+429
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3053: Feature: downloading lsp server from GitHub r=matklad a=Veetaha This is currently very WIP, I may need to change this and that, add "download language server command", logging stuff (for future bug reports), etc., but it already works. Also didn't test this on windows yet and mac (don't have the latter) The quirks: * Downloaded binary doesn't have executable permissions by default, that's why we ~~`chmod 111`~~ (**[UPD]** `chmod 755` as per @lnicola [suggestion](https://github.com/rust-analyzer/rust-analyzer/pull/3053#discussion_r376694456)) for it. * To remove installed binary run `rm /${HOME}/.config/Code/User/globalStorage/matklad.rust-analyzer/ra_lsp_server-linux`, ~~note that `-f` flag is necessary, because of `111` permissions (I think this should be changed)~~ (**[UPD]** --force is no longer needed due to 755 permissions). I also tried to keep things simple and not to use too many dependencies, all the ones added have 0 dependencies, (`ts-not-nil` is my personal npm package, that imitates `unwrap()` in TypeScript) **[UPD]** I reduced throttle latency of progress indicator to 200ms for smoother UX // TODO: - [x] ~~Add `Rust Analyzer: Download latest language server` vscode command.~~ **[UPD]**: having reviewed the code and estimated available options I concluded that this feature requires too many code changes, I'd like to extract this into a separate PR after we merge this one. - [x] Add some logging for future debugging - [x] ~~Gracefully handle the case when language server is not available (e.g. no internet connection, user explicitly rejected the download, etc.)~~ **[UPD]** Decided to postpone better implementation of graceful degradation logic as per [conversation](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Deployment.20and.20installation/near/187758550). Demo (**[UPD]** this is a bit outdated, but still mainly reflects the feature): ![ra-github-release-download-mvp](https://user-images.githubusercontent.com/36276403/74077961-4f248a80-4a2d-11ea-962f-27c650fd6c4c.gif) Related issue: #2988 #3007 Co-authored-by: Veetaha <[email protected]> Co-authored-by: Veetaha <[email protected]>
| | * docs: fix spelling untill -> untilVeetaha2020-02-091-1/+1
| | | | | | | | | Co-Authored-By: Jonas Platte <[email protected]>
| | * docs: minor fixes in wordings and punctuationVeetaha2020-02-091-2/+2
| | |
| | * vscode: updated docs on prebuilt binariesVeetaha2020-02-091-0/+32
| | |
| | * vscode: added logging when donloading binariesVeetaha2020-02-093-5/+26
| | |
| | * vscode: move throtting of download progress to call siteVeetaha2020-02-092-16/+19
| | |
| | * vscode: replaced unwrapNotNil() with ! as per @matkladVeetaha2020-02-093-21/+3
| | |
| | * vscode: refactor inverted ternaries to if statements as per @matkladVeetaha2020-02-092-2/+6
| | |
| | * vscode: remove noise data fields declarations as per @matkladVeetaha2020-02-091-6/+1
| | |
| | * vscode: refactor levels of code nesting and string literals quotesVeetaha2020-02-091-26/+30
| | |
| | * vscode: fix chmod to octal literalVeetaha2020-02-091-1/+1
| | | | | | | | | Co-Authored-By: Aleksey Kladov <[email protected]>
| | * vscode: minor names and message contents changesVeetaha2020-02-082-9/+12
| | |
| | * vscode: rename raLspServer variable to langServerVeetaha2020-02-081-3/+3
| | |
| | * vscode: refactor commentVeetaha2020-02-081-1/+1
| | |
| | * vscode: refactor platform artifact name query to switch statement, move ↵Veetaha2020-02-084-70/+89
| | | | | | | | | | | | BinarySource union variants into a namespace
| | * vscode: reduce throttle latency of downloadFile() progress callback for ↵Veetaha2020-02-081-1/+1
| | | | | | | | | | | | smoother UX
| | * vscode: add name to the second unused argument of withProgress() callbackVeetaha2020-02-081-1/+1
| | |
| | * vscode: add docs to installation module interfaces and sanity check to ↵Veetaha2020-02-082-4/+39
| | | | | | | | | | | | donloadFile()
| | * vscode: converted fetchLatestArtifactMetadata params to positional, added docsVeetaha2020-02-081-10/+10
| | |
| | * vscode: changed chmod value to 755 as per @lnicolaVeetaha2020-02-081-3/+3
| | |
| | * vscode: amended config to use binary from globalStoragePath, added ui for ↵Veetaha2020-02-0810-41/+229
| | | | | | | | | | | | downloading
| | * added fetchLatestArtifactMetadata() and downloadFile() functionsVeetaha2020-02-084-1/+111
| | |
| | * vscode: add FIXME about language client shared resource protectionVeetaha2020-02-081-0/+3
| | |
| * | Merge #3070bors[bot]2020-02-091-1/+17
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3070: Set auto-import target r=matklad a=matklad closes #3067 Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Set auto-import targetAleksey Kladov2020-02-091-1/+17
| |/ / | | | | | | | | | closes #3067
| * | Merge #3069bors[bot]2020-02-096-156/+152
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3069: Simplify Assists interface r=matklad a=matklad Instead of building a physical tree structure, just tag related assists with the same group Co-authored-by: Aleksey Kladov <[email protected]>
| | * | Simplify Assists interfaceAleksey Kladov2020-02-095-141/+108
| | | | | | | | | | | | | | | | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group
| | * | Slightly simpler API for groupsAleksey Kladov2020-02-092-48/+77
| |/ /
| * | Merge #3066bors[bot]2020-02-092-11/+11
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3066: Some README fixes/cleanups r=matklad a=flodiebold Make capitalization more consistent and fix some typos. Co-authored-by: Florian Diebold <[email protected]>
| | * | Some README fixes/cleanupsFlorian Diebold2020-02-092-11/+11
| |/ / | | | | | | | | | Make capitalization more consistent and fix some typos.