aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #1638bors[bot]2019-08-031-30/+32
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1638: Avoid cloning a TtToken in SubtreeTokenSource::mk_token r=matklad a=lnicola According to `perf record`, this function is the hottest one while running `ra_cli analysis-stats`: Before: ``` 6.05% ra_cli ra_cli <ra_mbe::subtree_source::SubtreeTokenSource as ra_parser::TokenSource>::lookahead_nth 5.56% ra_cli ra_cli <rowan::green::GreenNode as core::hash::Hash>::hash 4.16% ra_cli libc-2.29.so _int_malloc 3.93% ra_cli ra_cli ra_mbe::subtree_source::SubtreeTokenSource::get Database loaded, 255 roots, 231.676882ms Crates in this dir: 27 Total modules found: 282 Total declarations: 9642 Total functions: 3287 Total expressions: 64616 Expressions of unknown type: 9111 (14%) Expressions of partially unknown type: 3417 (5%) Analysis: 24.012797561s, 0b allocated 0b resident target/release/ra_cli analysis-stats 24.60s user 0.56s system 100% cpu 25.125 total ``` After: ``` 5.85% ra_cli ra_cli <rowan::green::GreenNode as core::hash::Hash>::hash 4.55% ra_cli libc-2.29.so _int_malloc 4.31% ra_cli ra_cli ra_parser::parser::Parser::nth 3.61% ra_cli ra_cli <ra_syntax::parsing::text_token_source::TextTokenSource as ra_parser::TokenSource>::lookahead_nth 3.54% ra_cli ra_cli ra_syntax::syntax_node::SyntaxTreeBuilder::finish_node 3.46% ra_cli libc-2.29.so _int_free 3.12% ra_cli libc-2.29.so malloc 2.76% ra_cli ra_cli ra_parser::event::process 2.68% ra_cli ra_cli alloc::sync::Arc<T>::drop_slow 2.50% ra_cli ra_cli ra_mbe::subtree_source::SubtreeTokenSource::get 2.31% ra_cli ra_cli <smol_str::SmolStr as core::hash::Hash>::hash 2.04% ra_cli libc-2.29.so __memmove_avx_unaligned_erms 1.92% ra_cli ra_cli <ra_mbe::subtree_source::SubtreeTokenSource as ra_parser::TokenSource>::lookahead_nth Database loaded, 255 roots, 236.176803ms Crates in this dir: 27 Total modules found: 282 Total declarations: 9642 Total functions: 3287 Total expressions: 64620 Expressions of unknown type: 9107 (14%) Expressions of partially unknown type: 3425 (5%) Analysis: 22.562328486s, 0b allocated 0b resident target/release/ra_cli analysis-stats 23.12s user 0.57s system 100% cpu 23.659 total ``` r? @edwin0cheng, @matklad Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Return a Ref from SubtreeTokenSource::getLaurențiu Nicola2019-08-031-33/+29
| | | |
| * | | Avoid cloning a TtToken in SubtreeTokenSource::mk_tokenLaurențiu Nicola2019-08-031-9/+15
| |/ /
* | | Merge #1630bors[bot]2019-08-032-3/+55
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1630: Removes `*/` from block doc comments r=matklad a=kjeremy The trailing `/` was annoying me on hover. Co-authored-by: kjeremy <[email protected]>
| * | | Unconditionally trim the end of commentskjeremy2019-07-312-13/+5
| | | |
| * | | Removes `*/` in block doc commentskjeremy2019-07-312-2/+62
| | | |
* | | | Merge #1637bors[bot]2019-08-033-28/+70
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 1637: Resolve out of line modules inside inline module with attribute path r=matklad a=andreevlex Fixed #1510 Fixed #1529 Co-authored-by: Alexander Andreev <[email protected]>
| * | | Resolve out of line modules inside inline module with attribute pathAlexander Andreev2019-08-033-28/+70
|/ / / | | | | | | | | | | | | Fixed #1510 Fixed #1529
* | | Merge #1633bors[bot]2019-08-021-1/+1
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 1633: Update rls URL r=flodiebold a=tomhennigan Docs folder was removed in rust-lang/compiler-team@dbe0ee74e911693841a16727caab756ab4d0b9ab. Co-authored-by: Tom Hennigan <[email protected]>
| * | Fix rls URL.Tom Hennigan2019-08-021-1/+1
|/ / | | | | Docs folder was removed in rust-lang/compiler-team@dbe0ee74e911693841a16727caab756ab4d0b9ab.
* | Merge #1631bors[bot]2019-07-311-1/+0
|\ \ | |/ |/| | | | | | | | | | | 1631: Remove test comment r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * remove-commentkjeremy2019-07-311-1/+0
|/
* Merge #1629bors[bot]2019-07-312-0/+23
|\ | | | | | | | | | | | | | | 1629: Add explicit newline preserving tests r=matklad a=kjeremy I didn't see anything that explicitly called this out so added tests. Co-authored-by: kjeremy <[email protected]>
| * Add explicit newline preserving testskjeremy2019-07-312-0/+23
|/
* Merge #1628bors[bot]2019-07-313-62/+53
|\ | | | | | | | | | | | | | | 1628: Update insta to 0.9.0 and cargo update r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * Update insta to 0.9.0 and cargo updatekjeremy2019-07-313-62/+53
|/
* Merge #1627bors[bot]2019-07-313-5/+27
|\ | | | | | | | | | | | | | | 1627: Hide ignored lines in rustdoc r=kjeremy a=rizakrko This fixes #1620. Co-authored-by: Roman Stoliar <[email protected]>
| * Fixed review commentsRoman Stoliar2019-07-301-3/+9
| |
| * Hide comments in rust section of doc commentsRoman Stoliar2019-07-303-5/+21
| |
* | Merge #1625bors[bot]2019-07-301-0/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 1625: Fix flip comma assist r=matklad a=eupn Should fix and close #1619 🤔 r? @matklad Co-authored-by: Evgenii P <[email protected]>
| * | rustfmtEvgenii P2019-07-301-10/+15
| | |
| * | Fix flip comma assistEvgenii P2019-07-301-0/+25
|/ /
* | Merge #1602bors[bot]2019-07-294-4/+194
|\ \ | | | | | | | | | | | | | | | | | | | | | 1602: Assist to merge identical match arms r=matklad a=theotherphil Fixes https://github.com/rust-analyzer/rust-analyzer/issues/1250 Co-authored-by: Phil Ellison <[email protected]>
| * | Add merge_match_arm assist, bump rowan to 0.6.1Phil Ellison2019-07-294-4/+194
|/ /
* | Merge #1604bors[bot]2019-07-292-14/+34
|\ \ | |/ |/| | | | | | | | | | | 1604: Fix failing type interference for floating point literal r=matklad a=theotherphil Fixes https://github.com/rust-analyzer/rust-analyzer/issues/1592 Co-authored-by: Phil Ellison <[email protected]>
| * Move assist test, add literal type inference testPhil Ellison2019-07-292-26/+15
| |
| * cargo formatPhil Ellison2019-07-281-3/+1
| |
| * Add special case for f32 and f43 suffices on Literal.kindPhil Ellison2019-07-283-17/+26
| |
| * Add issue link and trailing newlinePhil Ellison2019-07-281-1/+2
| |
| * More direct failing testPhil Ellison2019-07-281-0/+13
| |
| * Add failing testPhil Ellison2019-07-281-0/+10
| |
* | Merge #1601bors[bot]2019-07-2938-1064/+870
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 1601: Inline snapshots for tests r=matklad a=theotherphil Fixes https://github.com/rust-analyzer/rust-analyzer/issues/1127. The "cargo format" commits are required to get the formatting tests to pass. However, they actually mess up the formatting. Co-authored-by: Phil Ellison <[email protected]>
| * | Rerun cargo format, to make tests pass and formatting incorrectPhil Ellison2019-07-282-7/+7
| | |
| * | Remove vertical ellipses in references.csPhil Ellison2019-07-281-34/+33
| | |
| * | Remove vertical ellipses from tests in complete_snippet.rs and presentation.rsPhil Ellison2019-07-282-102/+94
| | |
| * | Remove vertical ellipses from tests in complete_scope.rsPhil Ellison2019-07-281-243/+225
| | |
| * | cargo formatPhil Ellison2019-07-285-117/+117
| | |
| * | Inline snapshot for test_file_structure (less clear that this one is a good ↵Phil Ellison2019-07-282-192/+187
| | | | | | | | | | | | idea)
| * | Inline snapshots for all tests in runnables.rsPhil Ellison2019-07-285-88/+68
| | |
| * | Inline snapshots for all tests in references.rsPhil Ellison2019-07-282-39/+33
| | |
| * | Inline snapshots for all tests in complete_snippet, remove now-unused ↵Phil Ellison2019-07-287-81/+58
| | | | | | | | | | | | check_completion
| * | Inline snapshots for all tests in presentation.rsPhil Ellison2019-07-287-177/+152
| | |
| * | Inline snapshots for all tests in complete_scope.rsPhil Ellison2019-07-2814-434/+396
| | |
| * | Remove unused highlights_code_inside_macro snapshot, inline ↵Phil Ellison2019-07-283-83/+33
| |/ | | | | | | rename_mod_in_dir snapshot
* | Merge #1621bors[bot]2019-07-292-10/+23
|\ \ | | | | | | | | | | | | | | | | | | | | | 1621: Document AssistBuilder r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | Document AssistBuilderAleksey Kladov2019-07-292-10/+23
| | | | | | | | | | | | closes #1603
* | | Merge #1606bors[bot]2019-07-293-47/+311
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1606: Add `if let`, `while let` and match arm inlay hints r=matklad a=SomeoneToIgnore <img width="693" alt="image" src="https://user-images.githubusercontent.com/2690773/62013363-152f1d80-b19a-11e9-90ea-07568757baa2.png"> Add more inline hints support. Looks like `while let` type inference support is missing currently, so the corresponding hint tests lack the actual results. I've also could not find a good way to distinguish between `a` and `b` pats in the following expressions: `if let Some(Test { a: None, b: y }) = &test {};` In this case we don't need to add a hint for first pat (`a: None`), since it's matched against the particular enum variant and need a hint for `y`, since it's a new variable. But both `a` and `b` are `BIND_PAT` with similar contents, so looks like there's nothing I can check for to find any differences. I don't display any hints for such cases now, to avoid confusion, but would be nice to know if there's a way to fix this behavior. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Support destructuring patternsKirill Bulatov2019-07-283-47/+311
| | |
* | | Merge #1605bors[bot]2019-07-292-49/+152
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1605: Resolve modules inside inline module r=matklad a=andreevlex #1510 Co-authored-by: Alexander Andreev <[email protected]>
| * | | Fixed request changes.Alexander Andreev2019-07-291-9/+19
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 18:28:06 +0000