aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6027bors[bot]2020-09-274-21/+46
|\ | | | | | | | | | | | | | | | | | | | | 6027: Spawn a flycheck instance per workspace r=matklad a=jonas-schievink Limitations: - All instances are restarted on every file change - There's only one configuration used for all of them Co-authored-by: Jonas Schievink <[email protected]>
| * Spawn a flycheck instance per workspaceJonas Schievink2020-09-274-21/+46
|/
* Merge #6073bors[bot]2020-09-255-55/+203
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 6073: Dont unnecessarily unnest imports r=matklad a=Veykril Fixes #6071 This has the side effect that paths that refer to items inside of the current module get prefixed with `self`. Changing this behavior is unfortunately not straightforward should it be unwanted, though I don't see a problem with this as prefixing imports like this with `self` is what I do personally anyways 😅. You can see what I mean with this in one of the tests which had to be changed in `crates/ssr/src/tests.rs`. There is one test that i still have to look at though, ~~which I by accident pushed with `#[ignore]` on it~~, which is `different_crate_renamed`, for some reason this now doesn't use the crate alias. This also makes me believe that aliases in general will break with this. So maybe this is not as straight forwards as I'd hoped for, but I don't really know how aliases work here. Edit: The failing test should work now Co-authored-by: Lukas Wirth <[email protected]>
| * Remove partial import test in insert_useLukas Wirth2020-09-251-10/+0
| |
| * Don't unnecessarily unnest imports for import insertionLukas Wirth2020-09-254-45/+203
| |
* | Merge #6076bors[bot]2020-09-253-13/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | 6076: Update chalk to 0.28.0 r=matklad a=vandenheuvel Co-authored-by: Bram van den Heuvel <[email protected]>
| * | Update chalk to 0.28.0Bram van den Heuvel2020-09-253-13/+19
| | |
* | | Merge #6055bors[bot]2020-09-251-0/+5
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 6055: Add ok postfix completion r=matklad a=mullr Wrapping values in `Ok(...)` is so pervasive that it seems reasonable for it to have its own postfix completion. Co-authored-by: Russell Mull <[email protected]>
| * | Cargo fmtRussell Mull2020-09-221-9/+2
| | |
| * | Add ok postfix completionRussell Mull2020-09-221-0/+12
| | |
* | | Merge #6072bors[bot]2020-09-252-6/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6072: Cleanup unintended unresolved reference in syntax higlighting test r=matklad a=Nashenas88 Fixes the issue brought up here https://github.com/rust-analyzer/rust-analyzer/pull/5957#discussion_r486625707 cc @jonas-schievink Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | Cleanup unintended unresolved reference in syntax higlighting testPaul Daniel Faria2020-09-242-6/+6
| | |/ | |/|
* | | Merge #6062bors[bot]2020-09-244-9/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6062: Bump smol_str from 0.1.16 to 0.1.17 r=matklad a=woshilapin When I built `rust-analyzer` today, I noticed the following warnings. ``` warning: use of deprecated item 'syntax::SmolStr::new_inline_from_ascii': Use `new_inline` instead --> crates/mbe/src/syntax_bridge.rs:639:30 | 639 | ... (SmolStr::new_inline_from_ascii(1, &[punct.char as u8]), punct.id) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default warning: 1 warning emitted ``` So I thought it would be a nice small PR. Co-authored-by: Jean SIMARD <[email protected]>
| * | | Bump smol_str from 0.1.16 to 0.1.17Jean SIMARD2020-09-244-9/+12
| | | |
* | | | Merge #6050bors[bot]2020-09-241-0/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6050: VS Code + WSL: describe binary location r=matklad a=qnighy It looks like VS Code server chooses a different location for `globalStorage`. Co-authored-by: Masaki Hara <[email protected]>
| * | | VS Code + WSL: describe binary locationMasaki Hara2020-09-211-0/+1
| | |/ | |/| | | | It looks like VS Code server chooses a different location for `globalStorage`.
* | | Merge #6056bors[bot]2020-09-241-0/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6056: Add dbgr postfix completion r=matklad a=lnicola Expanding to `dbg!(&e)`. Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | Add dbgr postfix completionLaurențiu Nicola2020-09-221-0/+12
| | | |
* | | | Merge #6061bors[bot]2020-09-244-19/+117
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6061: Allow to use a Github Auth token for fetching releases r=matklad a=Matthias247 This change allows to use a authorization token provided by Github in order to fetch metadata for a RA release. Using an authorization token prevents to get rate-limited in environments where lots of RA users use a shared client IP (e.g. behind a company NAT). The auth token is stored in `ExtensionContext.globalState`. As far as I could observe through testing with a local WSL2 environment that state is synced between an extension installed locally and a remote version. The change provides no explicit command to query for an auth token. However in case a download fails it will provide a retry option as well as an option to enter the auth token. This should be more discoverable for most users. Closes #3688 Co-authored-by: Matthias Einwag <[email protected]>
| * | | Fix lintMatthias Einwag2020-09-231-1/+1
| | | |
| * | | Move unlink on download into download functionMatthias Einwag2020-09-232-11/+11
| | | | | | | | | | | | | | | | | | | | Since this is required by all callsites its easier to have it in the function itself.
| * | | Remane functionMatthias Einwag2020-09-231-5/+5
| | | |
| * | | Use closure in trailing position and strongly type header mapMatthias Einwag2020-09-232-18/+21
| | | |
| * | | Apply suggestions from code reviewMatthias Einwag2020-09-231-1/+1
| | | | | | | | | | | | Co-authored-by: Veetaha <[email protected]>
| * | | Remove stray newlineMatthias Einwag2020-09-231-1/+0
| | | |
| * | | Fix clearing the tokenMatthias Einwag2020-09-231-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version would have interpreted an empty token as an abort of the dialog and would have not properly cleared the token. This is now fixed by checking for `undefined` for a an abort and by setting the token to `undefined` in order to clear it.
| * | | Add a command for updating the Github API tokenMatthias Einwag2020-09-232-0/+13
| | | |
| * | | Use retry dialog also for downloadsMatthias Einwag2020-09-231-20/+30
| | | | | | | | | | | | | | | | | | | | | | | | Since the change already implements a retry dialog for network operations, let's also use it for allowing to retry the actual file.
| * | | Fix tslintMatthias Einwag2020-09-231-2/+2
| | | |
| * | | Allow to use a Github Auth token for fetching releasesMatthias Einwag2020-09-233-4/+72
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change allows to use a authorization token provided by Github in order to fetch metadata for a RA release. Using an authorization token prevents to get rate-limited in environments where lots of RA users use a shared client IP (e.g. behind a company NAT). The auth token is stored in `ExtensionContext.globalState`. As far as I could observe through testing with a local WSL2 environment that state is synced between an extension installed locally and a remote version. The change provides no explicit command to query for an auth token. However in case a download fails it will provide a retry option as well as an option to enter the auth token. This should be more discoverable for most users. Closes #3688
* | | Merge #5846bors[bot]2020-09-243-8/+161
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5846: Add references to fn args during completion r=matklad a=adamrk When completing a function call, if there is an argument taken as a ref or mut ref which matches the name and type of a variable in scope, we will insert a `&` or `&mut` when filling in the function arguments. This addresses https://github.com/rust-analyzer/rust-analyzer/issues/5449. E.g. ```rust fn foo(x: &i32) {} fn main() { let x = 5; foo # completing foo here generates `foo(&x)` now instead of `foo(x)` } ``` Co-authored-by: adamrk <[email protected]>
| * | | Make unify private againadamrk2020-09-022-2/+2
| | | |
| * | | Trim mut keyword in fn completionadamrk2020-09-021-1/+22
| | | |
| * | | Remove exposing unificationadamrk2020-09-024-23/+1
| | | |
| * | | Collect locals in contextadamrk2020-09-022-12/+15
| | | |
| * | | Add back Param structadamrk2020-09-012-3/+13
| | | |
| * | | Add references to fn args during completionadamrk2020-08-305-10/+151
| | | |
* | | | Merge #6068bors[bot]2020-09-233-10/+10
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 6068: More compliant lsp-types 0.82 r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | lsp-types 0.82kjeremy2020-09-233-10/+10
|/ / /
* | | Merge #6048bors[bot]2020-09-212-0/+47
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6048: Code Docs r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Apply suggestions from code reviewAleksey Kladov2020-09-211-5/+5
| | | | | | | | | | | | Co-authored-by: LaurenÈ›iu Nicola <[email protected]>
| * | | Document AstTransformationAleksey Kladov2020-09-211-0/+28
| | | |
| * | | Document SemanticScopeAleksey Kladov2020-09-211-0/+19
|/ / /
* | | Merge #6043bors[bot]2020-09-213-9/+51
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6043: Allow missing trait members assist without needing braces r=matklad a=M-J-Hooper Assist to complete missing items when implementing a trait does not appear without impl def braces (see #5144 ). The reason behind this was that this assist is based on `ast::AssocItemList` which only appears in the AST after the braces are added to the impl def. Instead of relying on and replacing the item list, we now instead replace the entire `ast::Impl` and add the item list if its missing. Co-authored-by: Matt Hooper <[email protected]>
| * | | Rename impl edit method to be more explicitMatt Hooper2020-09-212-2/+2
| | | |
| * | | Added test for impl member assist when impl def is missing bracesMatt Hooper2020-09-211-0/+19
| | | |
| * | | Replace entire impl def instead of only associated items for missing impl ↵Matt Hooper2020-09-211-9/+12
| | | | | | | | | | | | | | | | member assist (if braces are missing from an impl def then there is no associated item list in the AST)
| * | | Add make utility for empty associated item listsMatt Hooper2020-09-211-0/+4
| | | |
| * | | Add edit utility for adding an associated item list to a impl defMatt Hooper2020-09-211-0/+16
| | | |
* | | | Merge #6018bors[bot]2020-09-202-8/+15
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6018: Correct project_root path for ProjectJson. r=jonas-schievink a=woody77 It was already the folder containing the rust-project.json file, not the file itself. This also removes the Option-ness of it, since it's now an infallible operation to set the member value. Co-authored-by: Aaron Wood <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-02 12:28:47 +0000