aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge #9206bors[bot]2021-06-106-82/+97
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9206: minor: Speed up fst items lookup during completions r=SomeoneToIgnore a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/7542 A number of profile calls added for `import_on_the_fly` contents. Before: <img width="606" alt="Screenshot 2021-06-11 at 00 19 13" src="https://user-images.githubusercontent.com/2690773/121598998-22321e80-ca4b-11eb-9a3d-dc9cb2936705.png"> After: <img width="859" alt="Screenshot 2021-06-11 at 00 19 27" src="https://user-images.githubusercontent.com/2690773/121599022-2a8a5980-ca4b-11eb-82b6-13ab0ed56d58.png"> As a result, low hanging fruit was spotted: crazy amount of `fst_path` calls. Reducing that won ~200ms in the `import_on_the_fly @ sel` case in the `integrated_completion_benchmark`: <img width="861" alt="Screenshot 2021-06-11 at 00 19 38" src="https://user-images.githubusercontent.com/2690773/121599277-7d641100-ca4b-11eb-8667-53206994de27.png"> I'm not sure how to proceed with the remaining `???` marks in such methods as `collect_import_map` though: there's nothing but library calls in cycles, but maybe I'll come up with something later. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | | Reduce fst_path callsKirill Bulatov2021-06-101-11/+5
| | | | | |
| * | | | | Add more profiling for flyimportsKirill Bulatov2021-06-106-71/+92
|/ / / / /
* | | | | Merge #9202bors[bot]2021-06-103-0/+20
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9202: feat: Make `MemoryUsage` work on Windows r=jonas-schievink a=jonas-schievink Unfortunately there is no convenient API for heap statistics, so this instead uses the Commit Charge value, which is the amount of memory that needs to be allocated either in physical RAM or in the page file. This approximation seems to be good enough to find queries that waste a large amount of memory, but it should generally be expected to be off by several MB. bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Make `MemoryUsage` work on WindowsJonas Schievink2021-06-103-0/+20
| | | | |
* | | | | Merge #9196bors[bot]2021-06-092-5/+23
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9196: fix: Don't classify attributes on macro-calls are the macro itself r=Veykril a=Veykril Fixes #9184 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Don't classify attributes on macro-calls are the macro itselfLukas Wirth2021-06-092-5/+23
|/ / / /
* | | | Merge #9195bors[bot]2021-06-091-208/+178
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 9195: minor: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | SimplifyLukas Wirth2021-06-091-208/+178
| |/ /
* | | Merge #9193bors[bot]2021-06-0910-11/+128
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 9193: Implement dummy expansions for builtin attributes r=jonas-schievink a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | Remove unnecessary duplicationLukas Wirth2021-06-091-56/+8
| | |
| * | Implement dummy expansions for builtin attributesLukas Wirth2021-06-0910-11/+176
|/ /
* | Merge #9191bors[bot]2021-06-093-2/+20
|\ \ | | | | | | | | | | | | | | | | | | | | | 9191: fix: Don't descend MacroCall TokenTree delimiters r=jonas-schievink a=Veykril Fixes #9190 Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't descend MacroCall TokenTree delimitersLukas Wirth2021-06-093-2/+20
| | |
* | | Merge #9186bors[bot]2021-06-081-20/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9186: fix: Prefer attr macros in "expand macro recursively" r=jonas-schievink a=jonas-schievink This allows expanding attribute macros on fn-like macro invocations bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Prefer attr macros in "expand macro recursively"Jonas Schievink2021-06-081-20/+14
| | | |
* | | | Merge #9183bors[bot]2021-06-081-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9183: Fix typo r=lnicola a=phynalle Co-authored-by: phynalle <[email protected]>
| * | | | Fix typophynalle2021-06-081-1/+1
| | |/ / | |/| |
* | | | Merge #9187bors[bot]2021-06-083-8/+30
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 9187: fix: Fix edge case for ImportGranularity guessing r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | Fix edge case for ImportGranularity guessingLukas Wirth2021-06-083-8/+30
| |/ /
| | |
| \ \
*-. \ \ Merge #9181 #9182bors[bot]2021-06-0810-59/+219
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9181: Don't complete values in type position r=jonas-schievink a=Veykril Will add some proper tests in a bit 9182: fix: don't complete derive macros as fn-like macros r=jonas-schievink a=jonas-schievink Part of https://github.com/rust-analyzer/rust-analyzer/issues/8518 bors r+ Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | | fix: don't complete derive macros as fn-like macrosJonas Schievink2021-06-084-4/+88
| | | | |
| * | | | Add tests checking no value completion in type posLukas Wirth2021-06-083-0/+55
| | | | |
| * | | | Don't complete values in type positionLukas Wirth2021-06-088-55/+76
| | |/ / | |/| |
* | | | Merge #9180bors[bot]2021-06-081-50/+56
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9180: fix: fix some IDE functionality inside attribute macros r=jonas-schievink a=jonas-schievink In `SourceToDefCtx::find_container`, we might encounter a container that has an attribute macro. We need to skip that item, instead of bailing out and creating an empty `Resolver`, otherwise all names in the macro stay unresolved. Part of https://github.com/rust-analyzer/rust-analyzer/issues/9142 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | source_to_def: skip items with no defJonas Schievink2021-06-081-50/+56
|/ / /
* | | Revert "Merge #9177"Aleksey Kladov2021-06-081-342/+335
| | | | | | | | | | | | | | | | | | | | | This reverts commit f1818cb7ba2808cba3fd9bf8f199c382060a1f19, reversing changes made to 6c9362d61b895c11b1d0cf6837ada9f2a0a30eaf. This broke things
* | | Merge #9177bors[bot]2021-06-081-335/+342
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9177: :arrow_up: npm packages r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: npm packagesAleksey Kladov2021-06-081-335/+342
| | | |
* | | | Merge #9153bors[bot]2021-06-081-0/+1
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 9153: QOL: VSCode status bar icon on click now shows server status r=matklad a=Milo123459 Now, when you click the little status bar text, it will automatically reload the server. I don't think I've ever seen anyone click it randomly, and, it's there to save you a few clicks. Co-authored-by: Milo <[email protected]>
| * | | fixMilo2021-06-071-1/+1
| | | |
| * | | fixMilo2021-06-061-1/+1
| | | |
| * | | when you click status bar icon it now restarts serverMilo2021-06-061-0/+1
| | | |
* | | | Merge #9171bors[bot]2021-06-075-36/+33
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9171: internal: simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | simplifyLukas Wirth2021-06-075-36/+33
| | | | |
* | | | | Merge #9170bors[bot]2021-06-077-90/+32
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9170: internal: Remove unnecessary `completion::macro_in_item_position` module r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Remove unnecessary completion::macro_in_item_positionLukas Wirth2021-06-076-72/+17
| | | | |
| * | | | Reorder CompletionContext fieldsLukas Wirth2021-06-072-18/+15
| | |/ / | |/| |
* | | | Merge #9169bors[bot]2021-06-078-30/+170
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9169: internal: steps towards attribute macro token mapping r=jonas-schievink a=jonas-schievink This doesn't work yet, but we seem to be getting a bit further along (for example, we now stop highlighting `use` items inside item with attribute macros as if they were written verbatim). bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Attempt to track attr macros during highlightingJonas Schievink2021-06-072-0/+40
| | | | |
| * | | | Make "expand macro" command work with attribute macrosJonas Schievink2021-06-072-7/+43
| | | | |
| * | | | Handle attribute macros in `descend_into_macros`Jonas Schievink2021-06-066-23/+87
| | | | |
* | | | | Merge #9144bors[bot]2021-06-071-15/+337
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9144: Extend convert_tuple_struct_to_named_struct to also apply to enum tuple variants r=matklad a=joshuawarner32 This is largely copied and adapted from the existing `convert_tuple_struct_to_named_struct` code. Not sure if maybe some of this code can/should be shared between those two assists - but the differences are significant enough to make it at least seem like a non-trivial refactor. Co-authored-by: Joshua Warner <[email protected]>
| * | | | | fmtJoshua Warner2021-06-061-3/+12
| | | | | |
| * | | | | Refactor to be just one assistJoshua Warner2021-06-053-532/+328
| | | | | |
| * | | | | Add assist for converting a tuple enum variant to a named variantJoshua Warner2021-06-052-0/+517
| | | | | |
* | | | | | Merge #9166bors[bot]2021-06-071-7/+9
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9166: Clarify label documentation r=matklad a=flodiebold Also some other cleanups while I'm there. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Further clarificationFlorian Diebold2021-06-071-1/+2
| | | | | |
| * | | | | One additional grammar fixFlorian Diebold2021-06-071-1/+1
| | | | | |
| * | | | | Clarify label documentationFlorian Diebold2021-06-071-7/+8
| | | | | | | | | | | | | | | | | | Also some other cleanups while I'm there.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 00:41:15 +0000