aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #1037bors[bot]2019-03-252-0/+300
|\ | | | | | | | | | | | | | | 1037: inline immutable local varialbe r=matklad a=gfreezy resolved #1033 Co-authored-by: gfreezy <[email protected]>
| * use | instead of multiple match armsgfreezy2019-03-251-27/+27
| |
| * inline immutable local varialbegfreezy2019-03-252-0/+300
| |
* | Merge #1034bors[bot]2019-03-2515-165/+424
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1034: HIR diagnostics API r=matklad a=matklad This PR introduces diagnostics API for HIR, so we can now start issuing errors and warnings! Here are requirements that this solution aims to fulfill: * structured diagnostics: rather than immediately rendering error to string, we provide a well-typed blob of data with error-description. These data is used by IDE to provide fixes * open set diagnostics: there's no single enum with all possible diagnostics, which hopefully should result in better modularity The `Diagnostic` trait describes "a diagnostic", which can be downcast to a specific diagnostic kind. Diagnostics are expressed in terms of macro-expanded syntax tree: they store pointers to syntax nodes. Diagnostics are self-contained: you don't need any context, besides `db`, to fully understand the meaning of a diagnostic. Because diagnostics are tied to the source, we can't store them in salsa. So subsystems like type-checking produce subsystem-local diagnostic (which is a closed `enum`), which is expressed in therms of subsystem IR. A separate step converts these proto-diagnostics into `Diagnostic`, by merging them with source-maps. Note that this PR stresses type-system quite a bit: we now type-check every function in open files to compute errors! Discussion on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Diagnostics.20API Co-authored-by: Aleksey Kladov <[email protected]>
| * | move tests to where they belongAleksey Kladov2019-03-254-44/+32
| | |
| * | simplifyAleksey Kladov2019-03-251-6/+1
| | |
| * | tweak diagnostics APIAleksey Kladov2019-03-253-11/+16
| | |
| * | test diagnosticsAleksey Kladov2019-03-253-1/+61
| | |
| * | more enterprisey diagnostics setupAleksey Kladov2019-03-253-59/+75
| | |
| * | fixesAleksey Kladov2019-03-252-4/+3
| | |
| * | check impls as wellAleksey Kladov2019-03-252-1/+10
| | |
| * | cleanupAleksey Kladov2019-03-256-51/+70
| | |
| * | switch modules to new diagnosticsAleksey Kladov2019-03-258-135/+156
| | |
| * | allow dyn diagnosticsAleksey Kladov2019-03-256-33/+112
| | |
| * | diagnosticsAleksey Kladov2019-03-256-6/+74
| | |
* | | Merge #1047bors[bot]2019-03-251-39/+36
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1047: :arrow_up: deps r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | :arrow_up: depsAleksey Kladov2019-03-251-39/+36
|/ / /
* | | Merge #1019bors[bot]2019-03-2510-79/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1019: structure moved to ra_ide_api r=matklad a=pasa structure subtask for #1009 Co-authored-by: Sergey Parilin <[email protected]>
| * | | structure moved to ra_ide_apiSergey Parilin2019-03-2510-79/+7
|/ / / | | | | | | | | | ra_ide_api_light removed completely
* | | Merge #1045bors[bot]2019-03-251-37/+34
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1045: simplify r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | simplifyAleksey Kladov2019-03-251-37/+34
|/ / /
* | | Merge #1044bors[bot]2019-03-251-1/+1
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 1044: fix build r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | fix buildAleksey Kladov2019-03-251-1/+1
| | |
* | | Merge #1041bors[bot]2019-03-255-63/+105
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 1041: Add convenience functions to SourceChange for creating single edits r=matklad a=vipentti Fixes #1018 Co-authored-by: Ville Penttinen <[email protected]>
| * | Rename source_edit to source_file_edit to match file_system_editVille Penttinen2019-03-255-11/+11
| | |
| * | Further improvements to the SourceChange convenience methodsVille Penttinen2019-03-254-27/+50
| | | | | | | | | | | | | | | Rename system_edit to file_system_edit, add more documentation, add source_file_edit_from to create a SourceChange from `FileId` and `TextEdit`.
| * | Add convenience functions to SourceChange for creating single editsVille Penttinen2019-03-244-44/+63
| | |
* | | Merge #1043bors[bot]2019-03-252-2/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1043: link docs from dev docs, not from the main readme r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | link docs from dev docs, not from the main readmeAleksey Kladov2019-03-252-2/+5
| | | | | | | | | | | | | | | | If you want to **use** ra, you don't need api docs
* | | | Merge #1042bors[bot]2019-03-251-27/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1042: Remove windows from CI r=matklad a=matklad We don't actually look at the CI results for windows anyway! In general, rust-analyzer should be written in a completely OS-independent way. That is, testing on one OS should be enough. If this is not the case, that means something is seriously broken. No doubt there are components which actually talk to the outside world, and they may be platform dependent. We should extract such components to a separate repo with an extensive multi platform CI, like we did for VFS Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Remove windows from CIAleksey Kladov2019-03-251-27/+20
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't actually look at the CI results for windows anyway! In general, rust-analyzer should be written in a completely OS-independent way. That is, testing on one OS should be enough. If this is not the case, that means something is seriously broken. No doubt there are components which actually talk to the outside world, and they may be platform dependent. We should extract such components to a separate repo with an extensive multi platform CI, like we did for VFS
* | | | Merge #1036bors[bot]2019-03-254-35/+135
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1036: Assist to flip equality (==) and negated equality (!=) operands. r=matklad a=marcogroppo This PR adds an assist to flip the equality operands. I hope this is the right way to do this (I'm a newbie...) Fixes #1023. Co-authored-by: Marco Groppo <[email protected]>
| * | | Target only the actual operator.Marco Groppo2019-03-243-47/+58
| | | | | | | | | | | | | | | | | | | | Renamed `BinExpr::op()` and `PrefixExpr::op()` to `op_kind`. Now `op()` returns the `SyntaxNode`.
| * | | Minor formatting changes.Marco Groppo2019-03-241-1/+1
| | | |
| * | | Assist to flip equality (==) and negative equality (!=) operands.Marco Groppo2019-03-242-0/+89
| | | |
* | | | Merge #1035bors[bot]2019-03-252-0/+15
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1035: Add master branch docs build and publish r=matklad a=robojumper Closes #1024. Additional setup required: * The rust-analyzer travis repo needs an [environment variable](https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings) `DOCS_TOKEN` that will be used to publish docs to the `gh-pages` branch. This is a GitHub access token with the appropriate permissions to push to this repository. Travis will keep this a secret. * In the GitHub repository settings, the GitHub pages source needs to be set to the `gh-pages` branch. This option will only appear once a branch is created with this exact name -- created either through the `deploy` step or manually. * In the GitHub repository settings, a GitHub pages theme will need to be chosen. What theme to use is unimportant, but [you must choose a theme](https://github.community/t5/GitHub-Pages/Github-Pages-are-not-published-after-following-the-documentation/m-p/18676#M1398). Docs are built as part of any rust build (on linux and windows, though all my Travis windows builds have timed out), but only published on master builds on linux. The docs badge links to `https://rust-analyzer.github.io/rust-analyzer/ra_ide_api/index.html` -- since this project is a cargo workspace, there isn't a global index page, hence just the link to an arbitrarily chosen crate. If this project had a canonical main crate with good documentation, one could link to that. All other crates are accessible through the sidebar. Co-authored-by: robojumper <[email protected]>
| * | | Add docs buildrobojumper2019-03-232-0/+15
| |/ /
* | | Merge #1029bors[bot]2019-03-242-24/+100
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | 1029: Add impl members assist shold not copy docstrings, attrs and default methods r=matklad a=gfreezy 1. `add missing impl members` assist should not copy docstrings, attrs and default methods 2. Add `add impl default members` assist fixed #1022 Co-authored-by: gfreezy <[email protected]>
| * | Add assist for adding default methodsgfreezy2019-03-232-3/+59
| | |
| * | Add impl members assist shold not copy docstrings, attrs and default methods.gfreezy2019-03-231-22/+42
| | |
* | | Merge #1039bors[bot]2019-03-243-1/+130
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 1039: Support references in higher-ranked trait bounds r=matklad a=vipentti Fixes #1020 Co-authored-by: Ville Penttinen <[email protected]>
| * | Support references in higher-ranked trait boundsVille Penttinen2019-03-243-1/+130
|/ / | | | | | | Fixes #1020
* | Merge #1031bors[bot]2019-03-238-236/+222
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 1031: Move most things out of ra_ide_api_light r=matklad a=detrumi This moves everything except `structure` out of `ra_ide_api_light`. So this PR and #1019 finish up #1009, whichever is merged last should probably remove the `ra_ide_api_light` crate. Also, `LocalEdit` was removed since it wasn't used any more. Co-authored-by: Wilco Kusee <[email protected]>
| * | Move highlighting and matching_braceWilco Kusee2019-03-237-164/+166
| | |
| * | Remove LocalEdit usageWilco Kusee2019-03-233-70/+55
| | |
| * | Move typing to ra_ide_apiWilco Kusee2019-03-233-7/+6
| | |
* | | Merge #1032bors[bot]2019-03-232-2/+25
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1032: Fix apply_substs assertion failure r=matklad a=flodiebold Fixes #1030. Co-authored-by: Florian Diebold <[email protected]>
| * | | Fix apply_substs assertion failureFlorian Diebold2019-03-232-2/+25
|/ / / | | | | | | | | | Fixes #1030.
* | | Merge #1027bors[bot]2019-03-232-22/+0
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1027: remove obsolete diagnostic r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | remove obsolete diagnosticAleksey Kladov2019-03-232-22/+0
|/ / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 20:07:25 +0000