aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Mark non-code block as textpcpthm2019-03-191-1/+1
|
* Error about attributes onpcpthm2019-03-193-12/+82
| | | | unallowed types of expression statement
* Allow attributes on top level expressionpcpthm2019-03-198-35/+231
| | | | | | A top level expression is either - a expression statement or - the last expression in a block
* Merge #991bors[bot]2019-03-1814-81/+149
|\ | | | | | | | | | | | | | | | | | | | | | | 991: Use Marker argument for item parsers r=matklad a=pcpthm Before doing this for expressions, I found that the pattern (Marker argument) should be applied to the item parsers because visiblity and modifiers are parsed in a separate function. Fixed some parser bugs: - Fix pub_expr: `pub 42;` was allowed. - Fix incorrect parsing of crate::path: incorrectly parsed as `crate` as a visibility. Co-authored-by: pcpthm <[email protected]>
| * Use Marker argument for item parserspcpthm2019-03-1814-81/+149
| | | | | | | | | | - Fix pub_expr - Fix incorrect parsing of crate::path
* | Merge #989bors[bot]2019-03-182-0/+153
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 989: Implement naive version of fill_struct_fields assist r=matklad a=yanchith Fixes #964 This implements the `fill_struct_fields` assist. Currently only works for named struct fields, but not for tuple structs, because we seem to be missing a `TupleStructLit` (akin to `StructLit`, but for tuple structs). I am happy to implement `TupleStructLit` parsing given some guidance (provided it's really missing) and make the assist work for tuple structs as well. Could do so either in this PR, or another one 🙂 Sorry if I missed something important, this is my first PR for Rust Analyzer. Btw is there any way to run the assists in emacs? UPDATE: I just realized that parsing `TupleStructLit` would be quite difficult as it it really similar, if not identical to a function call... Co-authored-by: yanchith <[email protected]>
| * | Only replace NamedFieldList and add test for preserving Selfyanchith2019-03-181-13/+45
| | |
| * | Remove unachievable TODOyanchith2019-03-181-1/+0
| | |
| * | Implement naive version of fill_struct_fields assistyanchith2019-03-172-0/+122
| | |
* | | Merge #987bors[bot]2019-03-182-84/+70
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | 987: Refactor maybe_item to use Marker argument r=pcpthm a=pcpthm As suggested at <https://github.com/rust-analyzer/rust-analyzer/pull/980#issuecomment-473659745>. For expression paring functions, changing signature - from `fn(&mut Parser) -> Option<CompletedMarker>` to `fn(&mut Parser, Marker) -> Result<CompletedMarker, Marker>` - from `fn(&mut Parser) -> CompletedMarker` to `fn(&mut Parser, Marker) -> CompletedMarker` is my plan. Co-authored-by: pcpthm <[email protected]>
| * | Apply stylistic changes suggestedpcpthm2019-03-182-17/+14
| | |
| * | Refactor maybe_item to use Marker argumentpcpthm2019-03-172-86/+75
| | |
* | | Merge #982bors[bot]2019-03-173-17/+137
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 982: Implement BindingMode for pattern matching. r=flodiebold a=mjkillough Implement `BindingMode` for pattern matching, so that types can be correctly inferred using match ergonomics. The binding mode defaults to `Move` (referred to as 'BindingMode::BindByValue` in rustc), and is updated by automatic dereferencing of the value being matched. Fixes #888. - [Binding modes in The Reference](https://doc.rust-lang.org/reference/patterns.html#binding-modes) - [`rustc` implementation](https://github.com/rust-lang/rust/blob/e17c48e2f21eefd59748e364234efc7037a3ec96/src/librustc_typeck/check/_match.rs#L77) (and [definition of `BindingMode`](https://github.com/rust-lang/rust/blob/e957ed9d10ec589bdd523b88b4b44c41b1ecf763/src/librustc/ty/binding.rs)) - [Match Ergonomics RFC](https://github.com/rust-lang/rfcs/blob/master/text/2005-match-ergonomics.md#binding-mode-rules) Co-authored-by: Michael Killough <[email protected]>
| * | | Split test case and use tested_by!.Michael Killough2019-03-173-76/+103
| | | |
| * | | Simplify match statement.Michael Killough2019-03-171-6/+1
| | | |
| * | | impl Default for BindingMode.Michael Killough2019-03-171-5/+11
| | | | | | | | | | | | | | | | | | | | This decouples callers from knowing what the default binding mode of pattern matching is.
| * | | Implement BindingMode for pattern matching.Michael Killough2019-03-162-62/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement `BindingMode` for pattern matching, so that types can be correctly inferred using match ergonomics. The binding mode defaults to `Move` (referred to as 'BindingMode::BindByValue` in rustc), and is updated by automatic dereferencing of the value being matched.
* | | | Merge #983bors[bot]2019-03-173-0/+218
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 983: support remainder assignment operator r=matklad a=JeanMertz `%=` was returning errors for me, turns out it wasn't added as a valid assignment operation. I'm not sure what the best location would be to add a test for this. Please let me know and I'll add one. Co-authored-by: Jean Mertz <[email protected]>
| * | | | support remainder assignment operatorJean Mertz2019-03-173-0/+218
| | | | |
* | | | | Merge #986bors[bot]2019-03-174-133/+133
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 986: Fix parse tree of attribute on match arm r=matklad a=pcpthm ```rust match () { #[attr] () => (), } ``` Incorrect parse tree: `MatchArmList(Attr(..), MatchArm(..))`. Fixed: `MatchArmList(MatchArm(Attr(..), ...))`. Co-authored-by: pcpthm <[email protected]>
| * | | | Fix parse tree of attribute on match armpcpthm2019-03-174-133/+133
|/ / / /
* | | | Merge #985bors[bot]2019-03-171-57/+56
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 985: simplify parsing blocks a bit r=pcpthm a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | simplify parsing blocks a bitAleksey Kladov2019-03-171-57/+56
| | | | |
* | | | | Merge #984bors[bot]2019-03-173-1/+54
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 984: Allow attribute on struct literal field r=matklad a=pcpthm Cherrypicked from #980 Co-authored-by: pcpthm <[email protected]>
| * | | | Allow attribute on struct literal fieldpcpthm2019-03-173-1/+54
|/ / / /
* | | | Merge #968bors[bot]2019-03-1736-1954/+2053
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 968: Macro aware name resoltion r=matklad a=matklad The first commit lays the ground work for new name resolution, including * extracting position-indendent items from parse trees * walking the tree of modules * old-style macro_rules resolve cc @pnkfelix: this looks like an API name resolution should interact with. Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | docsAleksey Kladov2019-03-171-9/+15
| | | | |
| * | | | remove fixmeAleksey Kladov2019-03-171-2/+1
| | | | |
| * | | | remove old macro supportAleksey Kladov2019-03-178-261/+95
| | | | |
| * | | | rename ModuleId -> CrateModuleIdAleksey Kladov2019-03-178-39/+40
| | | | |
| * | | | fix error on wrong pathAleksey Kladov2019-03-174-12/+43
| | | | |
| * | | | log timeAleksey Kladov2019-03-171-0/+2
| | | | |
| * | | | Reorganize name resolutionAleksey Kladov2019-03-1714-522/+481
| | | | |
| * | | | hack around non-terminating macro expansionAleksey Kladov2019-03-171-0/+14
| | | | |
| * | | | remove lower moduleAleksey Kladov2019-03-1712-264/+48
| | | | |
| * | | | remove ItemMapAleksey Kladov2019-03-177-569/+59
| | | | |
| * | | | move tests over to crate-def-mapAleksey Kladov2019-03-179-850/+689
| | | | |
| * | | | Replace module_tree with CrateDefMapAleksey Kladov2019-03-1716-511/+333
| | | | |
| * | | | add name resolution from the old implAleksey Kladov2019-03-179-185/+739
| | | | | | | | | | | | | | | | | | | | unlike the old impl, this also handles macro imports across crates
| * | | | add skeleton for macro-aware name resolutionsAleksey Kladov2019-03-178-9/+773
|/ / / /
* | | | Merge #947bors[bot]2019-03-172-0/+285
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 947: Add missing impl members r=matklad a=Xanewok Closes #878. This took longer than expected as I wrapped my head around the API and the project - hopefully I didn't miss any edge case here. r? @matklad Co-authored-by: Igor Matuszewski <[email protected]>
| * | | Move the primary assist fn to the top of the fileIgor Matuszewski2019-03-161-30/+30
| | | |
| * | | Provide assist when cursor is immediately outside impl item blockIgor Matuszewski2019-03-161-14/+18
| | | |
| * | | Do a cleanup/legibility passIgor Matuszewski2019-03-161-21/+21
| | | |
| * | | Take into account parent indent when filling trait membersIgor Matuszewski2019-03-161-9/+41
| | | |
| * | | Simplify trait resolution fragmentIgor Matuszewski2019-03-161-6/+3
| | | |
| * | | Ignore unnamed trait fns and add more testsIgor Matuszewski2019-03-161-2/+70
| | | |
| * | | Simplify calculation of missing functionsIgor Matuszewski2019-03-161-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | Asymptotically computing a set difference is faster but in the average case we won't have more than ~10 functions. Also prefer not using hash sets as these may yield nondeterministic results.
| * | | Properly support the case when the cursor is inside an empty block or outsideIgor Matuszewski2019-03-161-15/+44
| | | |
| * | | Redo indent calculation when adding missing impl membersIgor Matuszewski2019-03-161-9/+21
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-21 04:53:30 +0000