aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6387bors[bot]2020-10-283-13/+72
|\ | | | | | | | | | | | | | | | | 6387: do not use associated types placeholder for inlay hint r=flodiebold a=bnjjj close #6191 Co-authored-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-284-8/+17
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-283-60/+44
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-286-155/+108
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-282-31/+102
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not use associated types placeholder for inlay hint #6191Benjamin Coenen2020-10-273-19/+61
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6384bors[bot]2020-10-281-3/+67
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6384: add doctest runnables on struct r=lnicola a=bnjjj I will check for how to do the same on trait implementation on another PR. #6356 Co-authored-by: Benjamin Coenen <[email protected]>
| * | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-1/+1
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-3/+67
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Merge #6392bors[bot]2020-10-281-0/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6392: Also set textDecoration: none on inlay hints r=SomeoneToIgnore a=lnicola Closes #6380 Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Also set textDecoration: none on inlay hintsLaurențiu Nicola2020-10-281-0/+1
|/ / /
* | | Merge #6379bors[bot]2020-10-273-0/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6379: Highlight never type as BuiltinType r=matklad a=Veykril Fixes #6374 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Highlight never type as BuiltinTypeLukas Wirth2020-10-263-0/+15
| | | |
* | | | Merge #6382bors[bot]2020-10-271-0/+1
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 6382: Set font-wieght: normal on inlay hints r=SomeoneToIgnore a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | Set font-wieght: normal on inlay hintsLaurențiu Nicola2020-10-271-0/+1
| | | |
* | | | Merge #6383bors[bot]2020-10-271-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6383: Update client install command in dev docs r=kjeremy a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
| * | | | Update client install command in dev docsLaurențiu Nicola2020-10-271-1/+1
| |/ / /
* | | | Merge #6376bors[bot]2020-10-274-1/+26
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6376: Avoid impls_fnonce to return true when the trait solving is ambiguous r=flodiebold a=GrayJack This PR should fix #6375 This adds a variation of `method_resolution::implements_trait` called `method_resolution::implements_trait_unique`, that only returns true when the trait solving is unique, and also change `impls_fnonce` to use the later instead. I also added a test just to be sure. Co-authored-by: GrayJack <[email protected]>
| * | | Fix testGrayJack2020-10-261-158/+158
| | | |
| * | | Add test to avoid regressionGrayJack2020-10-262-153/+165
| | | |
| * | | Fix case where non FnOnce variables is marked callableGrayJack2020-10-262-1/+14
| | |/ | |/|
* | | Merge #6257bors[bot]2020-10-261-11/+11
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6257: Don't suggest extracting out 1-tuple enum variants r=matklad a=repnop Fixes #6241. Co-authored-by: Wesley Norris <[email protected]>
| * | Don't suggest extracting out 1-tuple enum variantsWesley Norris2020-10-261-11/+11
| | | | | | | | | | | | Fixes #6241.
* | | Merge #6378bors[bot]2020-10-261-2/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6378: Better ordering of assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Better ordering of assistsAleksey Kladov2020-10-261-2/+3
|/ / /
* | | Merge #6351bors[bot]2020-10-2622-185/+165
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6351: Organized completions r=popzxc a=popzxc This PR continues the work on refactoring of the `completions` crate. In this episode: - Actual completions methods are encapsulated into `completions` module, so they aren't mixed with the rest of the code. - Name duplication was removed (`complete_attribute` => `completions::attribute`, `completion_context` => `context`). - `Completions` structure was moved from `item` module to the `completions`. - `presentation` module was removed, as it was basically a module with `impl` for `Completions`. - Code approaches were a bit unified here and there. Co-authored-by: Igor Aleksanov <[email protected]>
| * | Reduce visibility of some methodsIgor Aleksanov2020-10-262-3/+3
| | |
| * | Add a module doc-comment for completions moduleIgor Aleksanov2020-10-251-0/+2
| | |
| * | Remove presentation moduleIgor Aleksanov2020-10-253-1421/+1409
| | |
| * | Move Completions structure definition into completions moduleIgor Aleksanov2020-10-259-74/+74
| | |
| * | Reorganize completions structureIgor Aleksanov2020-10-2523-109/+99
| | |
* | | Merge #6367bors[bot]2020-10-262-2/+22
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6367: Handle #![cfg] in crate root r=jonas-schievink a=jonas-schievink Now we correctly skip analysis of winapi on non-Windows platforms. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Handle #![cfg] in crate rootJonas Schievink2020-10-262-2/+22
| | | |
* | | | Merge #6313bors[bot]2020-10-2621-24/+77
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 6313: Latest proposed LSP 3.16.0 and refresh semantic tokens r=matklad a=kjeremy Needs: https://github.com/gluon-lang/lsp-types/pull/183 Co-authored-by: kjeremy <[email protected]> Co-authored-by: Jeremy A. Kolb <[email protected]>
| * | | Update testsJeremy A. Kolb2020-10-2610-0/+22
| | | |
| * | | Request a refresh of semantic tokens if things are loaded upkjeremy2020-10-262-0/+16
| | | |
| * | | Update packagekjeremy2020-10-262-12/+12
| | | |
| * | | Latest proposed LSP 3.16.0kjeremy2020-10-269-24/+39
| | | | | | | | | | | | | | | | Needs: https://github.com/gluon-lang/lsp-types/pull/183
* | | | Merge #6333bors[bot]2020-10-264-8/+141
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6333: Don't interpret type path as part of visibility. r=matklad a=ArifRoktim This closes #5902. I only check that the next token isn't equal to `T![:]`, instead of the next two not being equal to `T![::]`. Is that ok? Co-authored-by: Arif Roktim <[email protected]>
| * | | | Allow assist move_arm_cond_to_match_guard inside blocksArif Roktim2020-10-241-7/+80
| | | | |
| * | | | Don't interpret type path as part of visibility.Arif Roktim2020-10-243-1/+61
| | | | |
* | | | | Merge #6347bors[bot]2020-10-261-24/+141
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6347: Support insertion in SyntaxRewriter r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Remove InsertPos::Before variant in Syntax RewriterLukas Wirth2020-10-241-13/+20
| | | | | |
| * | | | | Support insertion in SyntaxRewriterLukas Wirth2020-10-241-24/+134
| | | | | |
* | | | | | Merge #6350bors[bot]2020-10-261-126/+123
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6350: Make IncorrectDiagnostic match rustc by copying rustc's code. r=popzxc a=ArifRoktim This closes #6343 and closes #6345. The old algorithm which used a `DetectedCase` enum, didn't match how rustc thinks of cases. Some inputs can be interpreted as more than 1 case depending on the situation. For example, to rustc: - `ABCD`: Can be both camel case and upper snake case - `X86_64`: Can be both camel case and upper snake case I could've made `detect_case` return a collection of `DetectedCase` and then modified the other code as such, but I think using the same code rustc uses is simpler and a surefire way to achieve the same diagnostics as rustc. Co-authored-by: Arif Roktim <[email protected]>
| * | | | | Make IncorrectDiagnostic match rustc by copying rustc's code.Arif Roktim2020-10-251-126/+123
| |/ / / /
* | | | | Merge #6360bors[bot]2020-10-263-1/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6360: Fix unary minus highlighting r=matklad a=Veykril Fixes #6358 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Fix unary minus highlightingLukas Wirth2020-10-253-1/+14
| | | | | |
* | | | | | Merge #6361bors[bot]2020-10-261-1/+19
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6361: Textmate grammar: angle bracket fix (closes #6323) r=dustypomerleau a=dustypomerleau Fixes #6323 After tinkering, it became clear that `<` and `>` should really default to the punctuation interpretation in the vast majority of cases. In addition, the breakage is greater when an angle bracket is missed. So, rather than optimizing for a type parameter `meta` scope and considering every possible parent scope and child scope, the easier fix was to narrow the case where `<` and `>` are treated as comparison operators. Co-authored-by: Dusty Pomerleau <[email protected]>
| * | | | | | fix: narrow the case where angle brackets are seen as comparison operatorsDusty Pomerleau2020-10-261-1/+19
|/ / / / / /