aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6659bors[bot]2020-11-281-2/+7
|\ | | | | | | | | | | | | | | | | 6659: Explain how we get precise spans for diagnostics. r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Explain how we get precise spans for diagnostics.Aleksey Kladov2020-11-281-2/+7
| |
* | Merge #6645bors[bot]2020-11-2810-9/+212
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6645: Publish diagnostics for macro expansion errors r=matklad a=jonas-schievink This adds 2 new diagnostics, emitted during name resolution: * `unresolved-proc-macro`, a weak warning that is emitted when a proc macro is supposed to be expanded, but was not provided by the build system. This usually means that proc macro support is turned off, but may also indicate setup issues when using rust-project.json. Being a weak warning, this should help set expectations when users see it, while not being too obstructive. We do not yet emit this for attribute macros though, just custom derives and `!` macros. * `macro-error`, which is emitted when any macro (procedural or `macro_rules!`) fails to expand due to some error. This is an error-level diagnostic, but currently still marked as experimental, because there might be spurious errors and this hasn't been tested too well. This does not yet emit diagnostics when expansion in item bodies fails, just for module-level macros. Known bug: The "proc macro not found" diagnostic points at the whole item for custom derives, it should just point at the macro's name in the `#[derive]` list, but I haven't found an easy way to do that. Screenshots: ![screenshot-2020-11-26-19:54:14](https://user-images.githubusercontent.com/1786438/100385782-f8bc2300-3023-11eb-9f27-e8f8ce9d6114.png) ![screenshot-2020-11-26-19:55:39](https://user-images.githubusercontent.com/1786438/100385784-f954b980-3023-11eb-9617-ac2eb0a0a9dc.png) Co-authored-by: Jonas Schievink <[email protected]>
| * More accurately place proc-macro diagnosticJonas Schievink2020-11-274-9/+49
| |
| * Publish diagnostics for macro expansion errorsJonas Schievink2020-11-278-7/+168
| |
| * Add dedicated error for "proc macro not found"Jonas Schievink2020-11-272-1/+3
| |
* | Merge #6650bors[bot]2020-11-2830-303/+305
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6650: Make completion and assists module independent r=matklad a=SomeoneToIgnore A follow-up of https://github.com/rust-analyzer/rust-analyzer/pull/6553#discussion_r524402907 Move the common code for both assists and completion modules into a separate crate. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Move the helpers into ide_dbKirill Bulatov2020-11-2827-70/+29
| | |
| * | Rustdocs fixesKirill Bulatov2020-11-272-2/+4
| | |
| * | Group import data in a structKirill Bulatov2020-11-275-52/+49
| | |
| * | Extract the import code into the shared moduleKirill Bulatov2020-11-2730-254/+298
| | |
* | | Merge #6656bors[bot]2020-11-281-45/+59
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6656: Coalesce flycheck events r=matklad a=jonas-schievink Co-authored-by: Jonas Schievink <[email protected]>
| * | | Coalesce flycheck eventsJonas Schievink2020-11-271-45/+59
|/ / /
* | | Merge #6653bors[bot]2020-11-271-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6653: Downgrade "failed to load" error to warning r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6596 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | Downgrade "failed to load" error to warningJonas Schievink2020-11-271-1/+1
|/ / /
* | | Merge #6652bors[bot]2020-11-271-2/+4
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6652: Add/Fix macro expansion profiling r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | Add/Fix macro expansion profilingJonas Schievink2020-11-271-2/+4
|/ /
* | Merge #6651bors[bot]2020-11-279-0/+22
|\ \ | |/ |/| | | | | | | | | | | 6651: Profile completions better r=SomeoneToIgnore a=SomeoneToIgnore During https://github.com/rust-analyzer/rust-analyzer/issues/6612 investigation, had added a few more profiling points and considered that they can be useful later, ergo the PR. Co-authored-by: Kirill Bulatov <[email protected]>
| * Fix the profiling stringKirill Bulatov2020-11-271-1/+1
| | | | | | Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * Profile completions betterKirill Bulatov2020-11-279-0/+22
|/
* Merge #6648bors[bot]2020-11-271-9/+18
|\ | | | | | | | | | | | | | | 6648: Avoid allocation in ast::String::value if the string needs no unescaping r=lnicola a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * Avoid allocation in ast::String::value if the string needs no unescapingLukas Wirth2020-11-271-9/+18
| |
* | Merge #6586bors[bot]2020-11-271-8/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | 6586: Don't call a closure a function in the infer_function_return_type assist label r=lnicola a=Veykril `Add this function's return type` becomes `Add this closure's return type` for closures. This makes it more obvious that we are indeed planning on modifying the closure and not its containing function. Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't call a closure function in infer_function_return_type labelLukas Wirth2020-11-171-8/+16
| | |
* | | Merge #6646bors[bot]2020-11-261-2/+2
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 6646: Remove single r#trait identifer usage r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't use raw identifiersLukas Wirth2020-11-261-2/+2
|/ /
* | Merge #6635bors[bot]2020-11-262-14/+46
|\ \ | | | | | | | | | | | | | | | | | | | | | 6635: Complete struct in irrefutable let r=Veykril a=Veykril Fixes #6210 Co-authored-by: Lukas Wirth <[email protected]>
| * | Complete struct in irrefutable letLukas Wirth2020-11-262-14/+46
| | |
* | | Merge #6644bors[bot]2020-11-262-8/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6644: Simplify error formatting r=lnicola a=lnicola CC jonas-schievink bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Simplify error formattingLaurențiu Nicola2020-11-262-8/+5
|/ / /
* | | Merge #6643bors[bot]2020-11-261-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6643: Remove unused import r=lnicola a=lnicola Not sure why CI didn't catch this... bors r+ Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | | Remove unused importLaurențiu Nicola2020-11-261-1/+1
|/ / /
* | | Merge #6641bors[bot]2020-11-263-8/+13
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6641: Fix def map volatility with `#[cfg]` diagnostics r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Don't store `SyntaxNodePtr` in `CrateDefMap`Jonas Schievink2020-11-262-8/+7
| | | | | | | | | | | | | | | | It is volatile across reparses and makes incrementality worse.
| * | | Test def map invalidation with #[cfg] below changeJonas Schievink2020-11-261-0/+6
|/ / /
* | | Merge #6640bors[bot]2020-11-262-0/+27
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6640: Implement `Display` for macro expansion errors r=jonas-schievink a=jonas-schievink Co-authored-by: Jonas Schievink <[email protected]>
| * | | Implement `Display` for macro expansion errorsJonas Schievink2020-11-262-0/+27
|/ / /
* | | Merge #6639bors[bot]2020-11-265-56/+42
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6639: Use `ExpandResult` instead of `MacroResult` r=jonas-schievink a=jonas-schievink `MacroResult` is redundant. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Use `ExpandResult` instead of `MacroResult`Jonas Schievink2020-11-265-56/+42
|/ / / | | | | | | | | | `MacroResult` is redundant
* | | Merge #6638bors[bot]2020-11-265-29/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6638: Use named fields in `ExpandResult` r=jonas-schievink a=jonas-schievink bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * | | Use named fields in `ExpandResult`Jonas Schievink2020-11-265-29/+39
|/ / /
* | | Merge #6637bors[bot]2020-11-261-8/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6637: Publish diagnostics on file open r=jonas-schievink a=jonas-schievink Diagnostics are sometimes only showing up when typing. This should fix that. Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6381 Co-authored-by: Jonas Schievink <[email protected]>
| * | | Publish diagnostics on file openJonas Schievink2020-11-261-8/+9
|/ / / | | | | | | | | | | | | Diagnostics are sometimes only showing up when typing. This should fix that.
| | |
| \ \
*-. \ \ Merge #6614 #6632bors[bot]2020-11-267-35/+117
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6614: Improve autoimports on completion speed r=matklad a=SomeoneToIgnore Presumably closes https://github.com/rust-analyzer/rust-analyzer/issues/6594 May help https://github.com/rust-analyzer/rust-analyzer/issues/6612 * Ignore modules eaferly * Do less completion string rendering 6632: Pin cargo_metadata r=matklad a=kjeremy See: https://github.com/oli-obk/cargo_metadata/pull/142#issuecomment-733653275 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | | Pin cargo_metadatakjeremy2020-11-253-3/+3
| | | | |
| * | | | Improve autoimports on completion speedKirill Bulatov2020-11-244-32/+114
| | | | | | | | | | | | | | | | | | | | | | | | | * Ignore modules eaferly * Do less completion string rendering
* | | | | Merge #6496bors[bot]2020-11-261-3/+0
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6496: Use builtin scopes more r=matklad a=georgewfraser VSCode has added more builtin fallback scopes, so we can remove some of our fallback scopes by aligning with their conventions. Note that the macro scope doesn't seem to actually *work* at the moment. I have filed a bug with VSCode: https://github.com/microsoft/vscode/issues/110150 Co-authored-by: George Fraser <[email protected]>
| * | | | Just remove the macro fallbackGeorge Fraser2020-11-252-2/+8
| | | | |
| * | | | Use builtin scopes moreGeorge Fraser2020-11-072-11/+2
| | | | |
* | | | | Merge #6631bors[bot]2020-11-245-1/+20
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6631: Gate autoimports begind experimental completions flag r=kjeremy a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/6612 Adds a possibility to disable autoimports: <img width="598" alt="image" src="https://user-images.githubusercontent.com/2690773/100156673-f8037f80-2eb1-11eb-8e74-59ebe4260ba3.png"> and other experimental completions we might want to add later. Co-authored-by: Kirill Bulatov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-06 17:21:30 +0100