aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge #8776bors[bot]2021-05-0910-74/+119
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8776: fix: fix unnecessary recomputations due to macros r=jonas-schievink a=jonas-schievink This computes a macro's fragment kind eagerly (when the calling file is still available in parsed form) and stores it in the `MacroCallLoc`. This means that during expansion we no longer have to reparse the file containing the macro call, avoiding the unnecessary salsa dependencies (https://github.com/rust-analyzer/rust-analyzer/pull/8746#issuecomment-834776349). Marking as draft until I manage to find a test for this problem, since for some reason `typing_inside_a_function_should_not_invalidate_expansions` does not catch this (which might indicate that I misunderstand the problem). I've manually confirmed that this fixes the issue described in https://github.com/rust-analyzer/rust-analyzer/pull/8746#issuecomment-834776349: ``` 7ms - parse_query @ FileId(179) 12ms - SourceBinder::to_module_def 12ms - crate_def_map:wait 5ms - item_tree_query (1 calls) 7ms - ??? ``` Co-authored-by: Jonas Schievink <[email protected]>
| * | | Test that none of the macros are reparsedJonas Schievink2021-05-091-0/+6
| | | |
| * | | Precompute macro fragment kindJonas Schievink2021-05-099-74/+113
| | | |
* | | | Merge #8779bors[bot]2021-05-091-9/+32
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8779: fix: join lines doesn't add space before closing quote r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | fix: join lines doesn't add space before closing quoteAleksey Kladov2021-05-091-9/+32
|/ / / /
* | | | Merge #8777bors[bot]2021-05-092-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8777: Escape characters in builtin macros correctly r=edwin0cheng a=edwin0cheng Fixes #8749 It is the same bug in #8560 but in our `quote!` macro. Because the "\" are adding exponentially in #8749 case, so the text is eat up all the memory. bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | | | Escape characters in builtin macros correctlyEdwin Cheng2021-05-092-4/+4
| |/ / /
* | | | Merge #8774bors[bot]2021-05-093-37/+82
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8774: feat: Honor `.cargo/config.toml` r=matklad a=Veykril ![f1Gup1aiAn](https://user-images.githubusercontent.com/3757771/117545448-1dcaae00-b026-11eb-977a-0f35a5e3f2e0.gif) Implements `cargo/.config` build target and cfg access by using unstable cargo options: - `cargo config get` to read the target triple out of the config to pass to `cargo metadata` --filter-platform - `cargo rustc --print` to read out the `rustc_cfgs`, this causes us to honor `rustflags` and the like. If those commands fail, due to not having a nightly toolchain present for example, they will fall back to invoking rustc directly as we currently do. I personally think it should be fine to use these unstable options as they are unlikely to change(even if they did it shouldn't be a problem due to the fallback) and don't burden the user if they do not have a nightly toolchain at hand since we fall back to the previous behaviour. cc #8741 Closes #6604, Closes #5904, Closes #8430, Closes #8480 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Use RUSTC_BOOTSTRAP=1 instead of +nightly when discovering rust_cfgs ↡Lukas Wirth2021-05-082-40/+35
| | | | | | | | | | | | | | | | throughs cargo
| * | | Discover rustc_cfg through unstable cargo optionsLukas Wirth2021-05-083-33/+83
| | | |
* | | | Merge #8773bors[bot]2021-05-086-78/+222
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 8773: fix: Correctly support SelfType when searching for usages r=Veykril a=Veykril Fixes #7443 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Don't handle Self as a usage for TraitDefsLukas Wirth2021-05-082-23/+27
| | | |
| * | | Fix builtintype def_to_tyLukas Wirth2021-05-081-8/+14
| | | |
| * | | Correctly support SelfType when searching for usagesLukas Wirth2021-05-086-76/+210
| | | |
* | | | Merge #8775bors[bot]2021-05-082-2/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8775: Add `=` to pattern recovery r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Add `=` to pattern recoveryLukas Wirth2021-05-082-2/+23
| |/ / /
* | | | Merge #8772bors[bot]2021-05-081-11/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8772: minor: remove dead code r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | minor: remove dead codeAleksey Kladov2021-05-081-11/+1
| | | | |
* | | | | Merge #8770bors[bot]2021-05-082-74/+127
|\| | | | | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 8770: feat: add "mentoring instructions" test for pull up assist r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | | feat: add "mentoring instructions" test for pull up assistAleksey Kladov2021-05-081-1/+32
| | | |
| * | | internal: pull_assignment_up uses mutable treesAleksey Kladov2021-05-082-69/+71
| | | |
| * | | minor: add missing testAleksey Kladov2021-05-081-16/+36
| | | |
* | | | Merge #8769bors[bot]2021-05-082-121/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8769: internal: removed dead code r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | | dead codeAleksey Kladov2021-05-081-121/+1
| | | |
| * | | Disable more incrementalAleksey Kladov2021-05-081-0/+7
| | | |
* | | | Merge #8768bors[bot]2021-05-081-56/+46
|\| | | | |/ / |/| | | | | | | | | | | | | | | | | | | | 8768: internal: remove one more usage of SyntaxRewriter r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: remove one more usage of SyntaxRewriterAleksey Kladov2021-05-081-56/+46
|/ /
* | Merge #8765bors[bot]2021-05-083-65/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8765: internal: remove one more syntax rewriter r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: remove one more syntax rewriterAleksey Kladov2021-05-083-65/+38
|/ /
* | Merge #8764bors[bot]2021-05-081-4/+17
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8764: internal: add rust-analyzer version to panic context r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: add rust-analyzer version to panic contextAleksey Kladov2021-05-081-4/+17
| | |
* | | Merge #8763bors[bot]2021-05-081-35/+35
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 8763: feat: make troubleshooting a top-level section r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | feat: make troubleshooting a top-level sectionAleksey Kladov2021-05-081-35/+35
| | |
* | | Merge #8762bors[bot]2021-05-081-1/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | 8762: internal: disable broken incremental builds 😿 r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: disable broken incremental builds 😿Aleksey Kladov2021-05-081-1/+3
|/ /
* | Merge #8761bors[bot]2021-05-081-8/+32
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8761: feat: friendlier trouble shooting guide r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | feat: friendlier trouble shooting guideAleksey Kladov2021-05-081-8/+32
|/ /
* | Merge #8760bors[bot]2021-05-082-225/+381
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8760: :arrow_up: package-lock.json r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | :arrow_up: package-lock.jsonAleksey Kladov2021-05-082-225/+381
|/ /
* | Merge #8759bors[bot]2021-05-081-0/+27
|\ \ | | | | | | | | | | | | | | | | | | | | | 8759: docs: Add Kate installation section r=matklad a=meven Replaces https://github.com/rust-analyzer/rust-analyzer.github.io/pull/111#issuecomment-834797031 Co-authored-by: MΓ©ven Car <[email protected]>
| * | docs: Add Kate installation sectionMΓ©ven Car2021-05-081-0/+27
|/ /
* | Merge #8755bors[bot]2021-05-072-4/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8755: fix: direct people to the right repository r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | fix: direct people to the right repositoryAleksey Kladov2021-05-072-4/+4
|/ /
* | Merge #8753bors[bot]2021-05-074-1/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8753: internal: expose cfg attrs from hir::Crate r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: expose cfg attrs from hir::CrateAleksey Kladov2021-05-074-1/+8
|/ /
* | Merge #8752bors[bot]2021-05-073-36/+36
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 8752: Switch from jemalloc to tikv-jemalloc r=matklad a=djrenren Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8252. No idea if we're still interested in this but it was a simple change so here's the PR. Co-authored-by: John Renner <[email protected]>
| * | Use package renaming so source doesn't say tikvJohn Renner2021-05-072-4/+4
| | |
| * | Switch from jemalloc to tikv-jemallocJohn Renner2021-05-073-38/+38
|/ /
* | Merge #8751bors[bot]2021-05-071-6/+13
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 8751: minor: standard snippet r=matklad a=matklad bors r+ πŸ€– Co-authored-by: Aleksey Kladov <[email protected]>
| * | minor: standard snippetAleksey Kladov2021-05-071-6/+13
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-25 17:56:00 +0000