aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6683bors[bot]2020-12-014-28/+88
|\ | | | | | | | | | | | | | | 6683: Emit macro diagnostics when lowering bodies r=matklad a=jonas-schievink Changes `Expander::enter_expand` to return an `ExpandResult`, and adds any contained errors to the body diagnostic list. Co-authored-by: Jonas Schievink <[email protected]>
| * Emit unresolved proc macro errorsJonas Schievink2020-12-012-9/+28
| |
| * Emit macro diagnostics when lowering bodiesJonas Schievink2020-11-304-27/+68
| |
* | Merge #6688bors[bot]2020-12-016-43/+87
|\ \ | |/ |/| | | | | | | | | | | | | 6688: Place cursor correctly when completing assoc fns with self r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Place cursor correctly when completing assoc fns with selfAleksey Kladov2020-12-014-31/+64
| |
| * Fix typoAleksey Kladov2020-12-011-2/+2
| |
| * Type-safer API for dealing with parameter lists with optional selfAleksey Kladov2020-12-014-10/+21
|/
* Merge #6681bors[bot]2020-11-303-52/+81
|\ | | | | | | | | | | | | | | 6681: builtin_macro: move to `mbe::ExpandResult` r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * builtin_macro: move to `mbe::ExpandResult`Jonas Schievink2020-11-303-52/+81
|/
* Merge #6680bors[bot]2020-11-302-2/+11
|\ | | | | | | | | | | | | | | 6680: Fix use merging not using the first path segment r=Veykril a=Veykril Finally figured out why nested imports don't properly merge in some cases Co-authored-by: Lukas Wirth <[email protected]>
| * Fix use merging not using the first path segmentLukas Wirth2020-11-302-2/+11
| |
* | Merge #6678bors[bot]2020-11-302-3/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | 6678: bump lexer r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | bump lexerkjeremy2020-11-302-3/+3
|/ /
* | Merge #6677bors[bot]2020-11-301-20/+19
|\ \ | |/ |/| | | | | | | | | | | 6677: cargo update r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * cargo updatekjeremy2020-11-301-20/+19
|/
* Merge #6676bors[bot]2020-11-303-36/+31
|\ | | | | | | | | | | | | | | | | 6676: Minor cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Minor cleanupAleksey Kladov2020-11-303-36/+31
|/
* Merge #6665bors[bot]2020-11-292-1/+103
|\ | | | | | | | | | | | | | | 6665: Support self in reference search r=matklad a=Veykril The approach here is simply checking the descendants of the function body for `PathExpr` then checking whether it only contains a single `self` `PathSegment`, this is to prevent us from picking up `self` tokens from local `UseTree`s. Co-authored-by: Lukas Wirth <[email protected]>
| * Support self in reference searchLukas Wirth2020-11-292-1/+103
| |
* | Merge #6599bors[bot]2020-11-294-10/+23
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6599: Add attribute highlight modifier to all tokens inside attributes r=matklad a=Veykril This has the side effect that we also emit `attribute.attribute` highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now. Fixes #6536 Co-authored-by: Lukas Wirth <[email protected]>
| * | Add attribute highlight modifier to all tokens inside attributesLukas Wirth2020-11-214-10/+23
| | |
* | | Merge #6601bors[bot]2020-11-292-0/+61
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6601: add let and letm postfix to turn expressions into variables r=matklad a=bnjjj Partially resolve #6426 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | add let and letm postfix to turn expressions into variablesBenjamin Coenen2020-11-282-11/+56
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | add let and letm postfix to turn expressions into variablesBenjamin Coenen2020-11-211-0/+16
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #6670bors[bot]2020-11-291-14/+152
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6670: Allow renaming between self and first param with owned parameters r=matklad a=Veykril This fixes renaming owned SelfParams turning the parameter into a reference, as in, for a type `Foo`, `fn foo(self) {}` became `fn foo(renamed_name: &Foo) {}` prior to this. Similarly for the other way around, we now support renaming non-ref parameters to `self`. Additionally we do more checks now than before. We check: - that the function has an impl block - that we are renaming the first parameter(prior we ignored which parameter was renamed and always picked the first nevertheless) - that the parameter's type aligns with the impl block(minus one level of reference abstraction to account for `&self`/`&mut self`) Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Reject more cases of invalid parameter to self renamesLukas Wirth2020-11-291-13/+122
| | | | |
| * | | | Fix renaming owned self to parameter emitting refLukas Wirth2020-11-291-1/+30
|/ / / /
* | | | Merge #6669bors[bot]2020-11-291-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6669: Align default importMergeBehaviour with VSCode r=lnicola a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | | Align default importMergeBehaviour with VSCodeFlorian Diebold2020-11-291-1/+1
|/ / / /
* | | | Merge #6666bors[bot]2020-11-291-17/+39
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6666: Support 'go to definition' for self r=jonas-schievink a=Veykril Also reverts #6660, instead of showing the type it now works like it does for names by returning the declaration we are already on. This for example enables VSCode to show all references(#6665) when executing `go to definition` on the declaration. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Support 'go to definition' for selfLukas Wirth2020-11-291-17/+39
| | |_|/ | |/| |
* | | | Merge #6664bors[bot]2020-11-281-3/+43
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6664: Show type of self param on hover r=jonas-schievink a=Veykril Show the type of `self` when hovering the token in a `SelfParam`. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Show type of self param on hoverLukas Wirth2020-11-281-3/+43
| | | |
* | | | Merge #6660bors[bot]2020-11-281-6/+36
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6660: Support "go to definition" for SelfParams r=jonas-schievink a=Veykril Fixes #6657 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Support goto definition for ADT-SelfParamsLukas Wirth2020-11-281-6/+36
| |/ / /
* | | | Merge #6659bors[bot]2020-11-281-2/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6659: Explain how we get precise spans for diagnostics. r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Explain how we get precise spans for diagnostics.Aleksey Kladov2020-11-281-2/+7
| | | | |
* | | | | Merge #6645bors[bot]2020-11-2810-9/+212
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6645: Publish diagnostics for macro expansion errors r=matklad a=jonas-schievink This adds 2 new diagnostics, emitted during name resolution: * `unresolved-proc-macro`, a weak warning that is emitted when a proc macro is supposed to be expanded, but was not provided by the build system. This usually means that proc macro support is turned off, but may also indicate setup issues when using rust-project.json. Being a weak warning, this should help set expectations when users see it, while not being too obstructive. We do not yet emit this for attribute macros though, just custom derives and `!` macros. * `macro-error`, which is emitted when any macro (procedural or `macro_rules!`) fails to expand due to some error. This is an error-level diagnostic, but currently still marked as experimental, because there might be spurious errors and this hasn't been tested too well. This does not yet emit diagnostics when expansion in item bodies fails, just for module-level macros. Known bug: The "proc macro not found" diagnostic points at the whole item for custom derives, it should just point at the macro's name in the `#[derive]` list, but I haven't found an easy way to do that. Screenshots: ![screenshot-2020-11-26-19:54:14](https://user-images.githubusercontent.com/1786438/100385782-f8bc2300-3023-11eb-9f27-e8f8ce9d6114.png) ![screenshot-2020-11-26-19:55:39](https://user-images.githubusercontent.com/1786438/100385784-f954b980-3023-11eb-9617-ac2eb0a0a9dc.png) Co-authored-by: Jonas Schievink <[email protected]>
| * | | | More accurately place proc-macro diagnosticJonas Schievink2020-11-274-9/+49
| | | | |
| * | | | Publish diagnostics for macro expansion errorsJonas Schievink2020-11-278-7/+168
| | | | |
| * | | | Add dedicated error for "proc macro not found"Jonas Schievink2020-11-272-1/+3
| |/ / /
* | | | Merge #6650bors[bot]2020-11-2830-303/+305
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6650: Make completion and assists module independent r=matklad a=SomeoneToIgnore A follow-up of https://github.com/rust-analyzer/rust-analyzer/pull/6553#discussion_r524402907 Move the common code for both assists and completion modules into a separate crate. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | Move the helpers into ide_dbKirill Bulatov2020-11-2827-70/+29
| | | | |
| * | | | Rustdocs fixesKirill Bulatov2020-11-272-2/+4
| | | | |
| * | | | Group import data in a structKirill Bulatov2020-11-275-52/+49
| | | | |
| * | | | Extract the import code into the shared moduleKirill Bulatov2020-11-2730-254/+298
| | | | |
* | | | | Merge #6656bors[bot]2020-11-281-45/+59
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6656: Coalesce flycheck events r=matklad a=jonas-schievink Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | Coalesce flycheck eventsJonas Schievink2020-11-271-45/+59
|/ / / / /
* | | | | Merge #6653bors[bot]2020-11-271-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6653: Downgrade "failed to load" error to warning r=jonas-schievink a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6596 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | Downgrade "failed to load" error to warningJonas Schievink2020-11-271-1/+1
|/ / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 18:09:11 +0000