aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
*-. Merge #3780 #3787bors[bot]2020-03-314-70/+134
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3780: Simplify r=matklad a=Veetaha I absolutely love tha fact that removing `.clone()` simplifies the code comparing to other languages where it's actually the contrary (ahem ~~`std::move()`~~) 3787: vscode: add syntax tree inspection hovers and highlights r=matklad a=Veetaha ![inspect-tree](https://user-images.githubusercontent.com/36276403/78029767-c7426900-7369-11ea-9ed6-b8a0f8e05bac.gif) I implemented the reverse mapping (when you hover in the rust editor), but it seems overcomplicated, so I removed it Related #3682 Co-authored-by: veetaha <[email protected]> Co-authored-by: Veetaha <[email protected]>
| | * vscode: small refactorveetaha2020-03-311-1/+1
| | |\
| | | * vscode: apply review nitsVeetaha2020-03-311-1/+1
| | | |
| | * | vscode: scroll to the syntax node in rust editor when highlightingveetaha2020-03-311-1/+2
| | |/
| | * vscode: add docs about syntax treeveetaha2020-03-311-0/+6
| | |
| | * vscode: use ctx.subscriptions instead of local .disposablesveetaha2020-03-311-15/+12
| | |
| | * vscode: add syntax tree inspection hovers and highlightsveetaha2020-03-312-55/+118
| | |
| * | Simplifyveetaha2020-03-311-16/+13
| |/
* | Merge #3795bors[bot]2020-03-314-39/+40
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3795: Reduce deps r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Reduce depsAleksey Kladov2020-03-314-39/+40
|/ /
* | Merge #3793bors[bot]2020-03-312-5/+62
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3793: Add integrated test for concat include env r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add integrated test for concat include envAleksey Kladov2020-03-312-5/+62
|/ /
* | Merge #3792bors[bot]2020-03-3118-29/+29
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3792: Rename cargo_watch -> flycheck r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Rename cargo_watch -> flycheckAleksey Kladov2020-03-3118-29/+29
| | |
* | | Merge #3791bors[bot]2020-03-311-33/+17
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3791: Revert accidental package.json changes r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Revert accidental package.json changesAleksey Kladov2020-03-311-33/+17
|/ /
* | Merge #3738bors[bot]2020-03-3111-23/+696
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3738: Implement ra_proc_macro client logic r=matklad a=edwin0cheng This PR add the actual client logic for `ra_proc_macro` crate: 1. Define all necessary rpc serialization data structure, which include `ra_tt` related data and some task messages. Although adding `Serialize` and `Deserialize` trait to ra_tt directly seem to be much easier, we deliberately duplicate the `ra_tt` struct with `#[serde(with = "XXDef")]` for separation of code responsibility. 2. Define a simplified version of lsp base protocol for rpc, which basically copy from lsp-server code base. 3. Implement the actual `IO` for the client side progress spawning and message passing. Co-authored-by: Edwin Cheng <[email protected]>
| * | Fix rebasedEdwin Cheng2020-03-311-1/+1
| | |
| * | Redirect stderr to nullEdwin Cheng2020-03-311-0/+1
| | |
| * | Pipe error to stderrEdwin Cheng2020-03-311-2/+5
| | |
| * | Refactor a bitEdwin Cheng2020-03-311-11/+9
| | |
| * | Use a weak ptr to hold the send end of channelEdwin Cheng2020-03-311-28/+18
| | |
| * | Add drop for processEdwin Cheng2020-03-311-2/+6
| | |
| * | Unwrap channel send()Edwin Cheng2020-03-311-13/+4
| | |
| * | Use jod_threadEdwin Cheng2020-03-313-17/+16
| | |
| * | Fix formattingEdwin Cheng2020-03-312-6/+6
| | |
| * | Simple cross-process message protocolEdwin Cheng2020-03-313-225/+86
| | |
| * | Remove unused structEdwin Cheng2020-03-311-10/+5
| | |
| * | Improve shutdown processEdwin Cheng2020-03-312-19/+54
| | |
| * | Use matches in is_dylibEdwin Cheng2020-03-311-11/+3
| | |
| * | Add back doc string for processEdwin Cheng2020-03-311-0/+2
| | |
| * | Fix testEdwin Cheng2020-03-313-5/+3
| | |
| * | Implement ra_proc_macro client logicEdwin Cheng2020-03-3111-23/+827
|/ /
* | Merge #3790bors[bot]2020-03-3114-121/+135
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3790: Better names for config structs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Better names for config structsAleksey Kladov2020-03-3113-104/+102
| | |
| * | WIP: uniformalize external tools configAleksey Kladov2020-03-311-17/+33
| | |
* | | Merge #3789bors[bot]2020-03-312-28/+39
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3789: Update node deps r=kjeremy a=kjeremy Silences warnings on install Co-authored-by: kjeremy <[email protected]>
| * | Update node depskjeremy2020-03-312-28/+39
|/ /
* | Merge #3788bors[bot]2020-03-311-14/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | 3788: Update deps r=kjeremy a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | Update depskjeremy2020-03-311-14/+14
| | |
* | | Merge #3778bors[bot]2020-03-311-8/+2
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 3778: Use more functional programming in ArenaMap::insert r=matklad a=kjeremy I find this more readable and it flattens out the body a little. Others may disagree. Co-authored-by: kjeremy <[email protected]>
| * | Use resize_withkjeremy2020-03-311-2/+1
| | |
| * | Do not call reserve since extend will handle it.kjeremy2020-03-301-3/+0
| | | | | | | | | | | | | | | `Take` implements `TrustedLen` so we are guaranteed that only one reserve call will be made.
| * | Use more functional programming in ArenaMap::insertkjeremy2020-03-301-5/+3
| |/ | | | | | | I find this more readable and it flattens out the body a little.
* | Merge #3786bors[bot]2020-03-312-14/+45
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3786: When adding match arm, don't let the floating comma r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | When adding match arm, don't let the floating commaAleksey Kladov2020-03-312-14/+45
| | |
* | | Merge #3781bors[bot]2020-03-312-1/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3781: Add crate versions when running cargo -p commands. r=matklad a=o0Ignition0o If someone (unfortunately) creates a project that happens to have the same name as one of its (future) dependencies, there is [a way for them to change the dependency's alias in the Cargo.toml file](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#renaming-dependencies-in-cargotoml), to mitigate the name conflict. Unfortunately cargo -p commands don't seem to pick it up, which seems to put rust-analyzer run commands in a tough situation: ``` > Executing task: cargo test --package config --example default -- tests --nocapture < error: There are multiple `config` packages in your project, and the specification `config` is ambiguous. Please re-run this command with `-p <spec>` where `<spec>` is one of the following: config:0.1.0 config:0.9.3 The terminal process terminated with exit code: 101 ``` cargo suggests us to be more specific and refer to a package by its name and version, which this PR achieves. I passed the version as a String because I don't really understand how the ra_db types work, but I would love to switch it to [a fully fledged Version type](https://steveklabnik.github.io/semver/semver/index.html) if you guide me towards that :) Co-authored-by: o0Ignition0o <[email protected]>
| * | | Add crate versions when running cargo -p commands.o0Ignition0o2020-03-312-1/+15
| |/ / | | | | | | | | | | | | | | | | | | Until now cargo commands with the -p flag would pass the package name only. It doesn't play super well with the toml Renaming dependencies feature. This commit specifies the package name and version when a cargo command is run with the -p flag, to avoid ambiguities.
* | | Merge #3785bors[bot]2020-03-313-1/+32
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 3785: Attach doc-comment to declaration if there are newlines in between r=matklad a=ltentrup This commit changes the parser to attach doc-comments to the corresponding declaration in case there are newlines in between the doc-comment and the declaration. Implements the changes proposed in #3757 Co-authored-by: Leander Tentrup <[email protected]>
| * | Attach doc-comment to declaration if there are newlines in betweenLeander Tentrup2020-03-313-1/+32
|/ / | | | | | | This commit changes the parser to attach doc-comments to the corresponding declaration in case there are newlines in between the doc-comment and the declaration.