aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge #4775bors[bot]2020-06-083-24/+57
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4775: Add goto def for enum variant field r=matklad a=unexge Closes #4764. I'm not familiar with ra codebase, there might be better ways to do that :smile: Co-authored-by: unexge <[email protected]>
| * | | | Use explicit match for extracting def from `classify_name`unexge2020-06-081-2/+5
| | | | |
| * | | | Swap `into_definition` and `definition` semantics for `FieldShorthand` variantunexge2020-06-081-2/+2
| | | | |
| * | | | Add `FieldShorthand` variant to `NameClass`unexge2020-06-083-27/+32
| | | | |
| * | | | Add goto def for enum variant fieldunexge2020-06-062-0/+25
| | | | |
* | | | | Merge #4683bors[bot]2020-06-084-46/+368
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4683: Implement syntax highlighting for doctests r=ltentrup a=ltentrup The implementation is more complicated than the previous injection logic as the doctest comments consist of multiple ranges. The implementation extracts the doctests together with an offset-mapping, applies the syntax highlighting, and updates the text ranges. <img width="478" alt="Bildschirmfoto 2020-06-01 um 15 45 25" src="https://user-images.githubusercontent.com/201808/83415249-1f0b5800-a41f-11ea-8fa6-c282434d6ff7.png"> Part of #4170. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | Implement syntax highlighting for doctestsLeander Tentrup2020-06-084-46/+368
| | | | | |
* | | | | | Merge #4794bors[bot]2020-06-083-58/+73
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4794: Tweak release r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | RefactorAleksey Kladov2020-06-082-41/+49
| | | | | | |
| * | | | | | Move to a dedicated fileAleksey Kladov2020-06-083-57/+64
|/ / / / / /
* | | | | | Merge #4773bors[bot]2020-06-086-68/+312
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4773: Run|Debug hover actions. r=matklad a=vsrs ![hover_actions_run](https://user-images.githubusercontent.com/62505555/83335644-dfc1f780-a2b6-11ea-820b-ccaa82290e7d.gif) This hover actions work exactly like corresponding lenses. Co-authored-by: vsrs <[email protected]>
| * | | | | | Apply suggestions from code reviewvsrs2020-06-083-21/+21
| | | | | | |
| * | | | | | Add lib target filtering.vsrs2020-06-061-11/+18
| | | | | | |
| * | | | | | Disable runnables lookup in macro-generated code.vsrs2020-06-061-1/+10
| | | | | | |
| * | | | | | Add Run|Debug hover actionsvsrs2020-06-066-24/+184
| | | | | | |
| * | | | | | Preliminary runnables refactoringvsrs2020-06-063-54/+122
| | |/ / / / | |/| | | |
* | | | | | Merge #4793bors[bot]2020-06-081-0/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4793: Don't @ people in commit messages r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | | Don't @ people in commit messagesAleksey Kladov2020-06-081-0/+8
|/ / / / / /
* | | | | | Merge #4792bors[bot]2020-06-081-0/+27
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4792: Document more knowledge r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Preconditions styleAleksey Kladov2020-06-081-0/+20
| | | | | |
| * | | | | IDE APIAleksey Kladov2020-06-081-0/+7
|/ / / / /
* | | | | Merge #4781bors[bot]2020-06-081-32/+27
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4781: Remove redundancy in syntax highlighting tests r=matklad a=ltentrup Follow up from #4683. Improves syntax highlighting testing by introducing a function that contains the boilerplate comparison code. Keeps the `ra_fixture` argument in the first position, thus, the editor syntax highlighting injection still works. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | Remove redundancy in syntax highlighting testsLeander Tentrup2020-06-071-32/+27
| | |/ / / | |/| | |
* | | | | Merge #4770bors[bot]2020-06-086-104/+33
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4770: Clean up handling of int/float literal types r=matklad a=flodiebold 'Unknown' int/float types actually never exist as such, they get replaced by type variables immediately. So the whole `Uncertain<IntTy>` thing was unnecessary and just led to a bunch of match branches that were never hit. Co-authored-by: Florian Diebold <[email protected]>
| * | | | | Clean up handling of int/float literal typesFlorian Diebold2020-06-066-104/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'Unknown' int/float types actually never exist as such, they get replaced by type variables immediately. So the whole `Uncertain<IntTy>` thing was unnecessary and just led to a bunch of match branches that were never hit.
* | | | | | Merge #4787bors[bot]2020-06-082-15/+24
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4787: Fix bug in lexer for format specifier r=matklad a=ltentrup The `type` and `width` were not correctly distinguished. Fixes #4696. Co-authored-by: Leander Tentrup <[email protected]>
| * | | | | | Fix bug in lexer for format specifier where the `type` and `width` were not ↵Leander Tentrup2020-06-072-15/+24
| | |/ / / / | |/| | | | | | | | | | | | | | | | correctly distinguished
* | | | | | Merge #4788bors[bot]2020-06-071-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4788: Update quote r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | | | Update quoteJeremy Kolb2020-06-071-2/+2
|/ / / / / /
* | | | | | Merge #4780bors[bot]2020-06-071-4/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4780: Fix VSCode settings r=SomeoneToIgnore a=vincentisambart closes #4779 #4779 was reproducing every time, so doing a bisect I found out the problem to be coming from #4730. The only change to the extension that #4730 included was changes to editors/code/package.json. So I tried modifying those changes a bit and got it working. Co-authored-by: Vincent Isambart <[email protected]>
| * | | | | Fix VSCode settingsVincent Isambart2020-06-071-4/+1
|/ / / / /
* | | | | Merge #4772bors[bot]2020-06-061-0/+48
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4772: Document certain invariants r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Document certain invariantsAleksey Kladov2020-06-061-0/+27
| | | | |
| * | | | Document import styleAleksey Kladov2020-06-061-0/+21
| |/ / /
* | | | Merge #4769bors[bot]2020-06-061-1/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4769: Fix Run lens. r=matklad a=vsrs This PR fixes a bug introduced in https://github.com/rust-analyzer/rust-analyzer/pull/4710: second and all subsequent clicks on the Run lens produce invalid commands: 1. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture` 2. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture` **`-- hover::tests::test_hover_enum_has_impl_action --exact --nocapture`** 3. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture` **`-- hover::tests::test_hover_enum_has_impl_action --exact --nocapture -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture`** Co-authored-by: vsrs <[email protected]>
| * | | Fix Run lens.vsrs2020-06-061-1/+1
| | | |
* | | | Merge #4765bors[bot]2020-06-0610-115/+192
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4765: Fix type parameter defaults r=matklad a=flodiebold They should not be applied in expression or pattern contexts, unless there are other explicitly given type args. (The existing tests about this were actually wrong.) Co-authored-by: Florian Diebold <[email protected]>
| * | | Fix type parameter defaultsFlorian Diebold2020-06-0510-115/+192
|/ / / | | | | | | | | | | | | They should not be applied in expression or pattern contexts, unless there are other explicitly given type args.
* | | Merge #4761bors[bot]2020-06-053-10/+19
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4761: Upgrade Chalk to published version r=matklad a=flodiebold CC @pksunkara Co-authored-by: Florian Diebold <[email protected]>
| * | | Upgrade Chalk to published versionFlorian Diebold2020-06-053-10/+19
| | | |
* | | | Merge #4689bors[bot]2020-06-0512-81/+442
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4689: Implement return position impl trait / opaque type support r=matklad a=flodiebold This is working, but I'm not that happy with how the lowering works. We might need an additional representation between `TypeRef` and `Ty` where names are resolved and `impl Trait` bounds are separated out, but things like inference variables don't exist and `impl Trait` is always represented the same way. Also note that this doesn't implement correct handling of RPIT *inside* the function (which involves turning the `impl Trait`s into variables and creating obligations for them). That intermediate representation might help there as well. Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]>
| * | | | Review fixesFlorian Diebold2020-06-055-25/+68
| | | | |
| * | | | Implement return position impl trait / opaque type supportFlorian Diebold2020-06-0510-77/+395
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is working, but I'm not that happy with how the lowering works. We might need an additional representation between `TypeRef` and `Ty` where names are resolved and `impl Trait` bounds are separated out, but things like inference variables don't exist and `impl Trait` is always represented the same way. Also note that this doesn't implement correct handling of RPIT *inside* the function (which involves turning the `impl Trait`s into variables and creating obligations for them). That intermediate representation might help there as well.
* | | | Merge #4760bors[bot]2020-06-056-79/+35
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4760: Minimize FileLoader interface r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Minimize FileLoader interfaceAleksey Kladov2020-06-056-79/+35
| |/ / /
| | | |
| \ \ \
*-. \ \ \ Merge #4729 #4748bors[bot]2020-06-0522-169/+899
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4729: Hover actions r=matklad a=vsrs This PR adds a `hoverActions` LSP extension and a `Go to Implementations` action as an example: ![hover_actions_impl](https://user-images.githubusercontent.com/62505555/83335732-6d9de280-a2b7-11ea-8cc3-75253d062fe0.gif) 4748: Add an `ImportMap` and use it to resolve item paths in `find_path` r=matklad a=jonas-schievink Removes the "go faster" queries I added in https://github.com/rust-analyzer/rust-analyzer/pull/4501 and https://github.com/rust-analyzer/rust-analyzer/pull/4506. I've checked this PR on the rustc code base and the assists are still fast. This should fix https://github.com/rust-analyzer/rust-analyzer/issues/4515. Note that this does introduce a change in behavior: We now always refer to items defined in external crates using paths through the external crate. Previously we could also use a local path (if for example the extern crate was reexported locally), as seen in the changed test. If that is undesired I can fix that, but the test didn't say why the previous behavior would be preferable. Co-authored-by: vsrs <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | | Clarify when we visit modules multiple timesJonas Schievink2020-06-051-1/+3
| | | | |
| | * | | impl Debug for ImportMapJonas Schievink2020-06-051-19/+23
| | | | |
| | * | | Reorder importsJonas Schievink2020-06-053-5/+7
| | | | |
| | * | | Make `find_path_inner` private againJonas Schievink2020-06-051-1/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 15:49:51 +0000