aboutsummaryrefslogtreecommitdiff
path: root/crates/assists/src/handlers
Commit message (Collapse)AuthorAgeFilesLines
...
| * | SimplifyAleksey Kladov2020-11-062-9/+2
| | |
| * | Kill RAW_ literalsAleksey Kladov2020-11-0612-21/+32
| | | | | | | | | | | | | | | Syntactically, they are indistinguishable from non-raw versions, so it doesn't make sense to separate then *at the syntax* level.
* | | Merge #6477bors[bot]2020-11-061-0/+337
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6477: Add infer_function_return_type assist r=matklad a=Veykril This adds an assist to insert a functions return type if it hasn't been specified yet by inferring it from the functions tail expression. This assist only becomes active if the cursor is on the tail expression. See https://github.com/rust-analyzer/rust-analyzer/issues/6303#issuecomment-714657326 Co-authored-by: Lukas Wirth <[email protected]>
| * | Adjust test-texts in infer_function_return_typeLukas Wirth2020-11-061-78/+78
| | |
| * | Enable infer_function_return_type in return-type positionLukas Wirth2020-11-061-29/+129
| | |
| * | Wrap non-block expressions in closures with a blockLukas Wirth2020-11-061-12/+31
| | |
| * | Ignore unit expressions in infer_function_return_type assistLukas Wirth2020-11-061-3/+13
| | |
| * | Support closures in infer_function_return_type assistLukas Wirth2020-11-061-19/+114
| | |
| * | Add infer_function_return_type assistLukas Wirth2020-11-061-0/+113
| |/
* | Merge #6480bors[bot]2020-11-061-14/+107
|\ \ | | | | | | | | | | | | | | | | | | | | | 6480: Support closure in change_return_type_to_result assist r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | Support closure in change_return_type_to_result assistLukas Wirth2020-11-061-14/+107
| |/
* | More orthogonal APIAleksey Kladov2020-11-061-15/+8
| |
* | Move int parsing to IntNumber tokenAleksey Kladov2020-11-061-1/+1
|/
* Merge #6456bors[bot]2020-11-041-38/+110
|\ | | | | | | | | | | | | | | | | | | | | | | 6456: Support record variants in extract_struct_from_enum_variant r=matklad a=Veykril As requested :) This also prevents the assist from being disabled if a definition in the value namespace exists with the same name as our new struct since that won't cause a collision #4468 Co-authored-by: Lukas Wirth <[email protected]>
| * Support struct variants in extract_struct_from_enum_variantLukas Wirth2020-11-031-46/+74
| |
| * only check type namespace in extract_struct_from_enum_variant for collisionsLukas Wirth2020-11-031-9/+53
| |
* | Merge #6458bors[bot]2020-11-041-38/+114
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6458: Qualify trait impl created by add_custom_impl assist r=matklad a=Veykril When we find at least one trait with the same name as the derive accessible from the current module we now generate a qualified path to that trait in the generated impl. If we don't find any we just do what was done before and emit the trait name in the generated impl. Co-authored-by: Lukas Wirth <[email protected]>
| * | Qualify trait impl created by add_custom_impl assistLukas Wirth2020-11-031-38/+114
| |/
* | Merge #6454bors[bot]2020-11-031-135/+71
|\ \ | |/ |/| | | | | | | | | | | | | 6454: Fix overflow panic in convert_interger_literal assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix overflow panic in convert_interger_literal assistAleksey Kladov2020-11-031-135/+71
| | | | | | | | | | | | | | | | | | This also seizes the opportunity to move integer literal parsing to the syntax crate, were it logically belongs. Note though that this is still done in an ad hoc manner -- we probably should split kitchen sink ast::Literal into a separate APIs for strings, ints, etc
* | Make insert_use return a SyntaxRewriterLukas Wirth2020-11-023-94/+74
|/
* Merge #6393 #6399bors[bot]2020-11-021-13/+169
|\ | | | | | | | | | | | | | | | | | | | | | | | | 6393: Remove repetitive inlay hints (take 2) r=matklad a=lnicola 6399: Keep generic annotations when qualifying things r=matklad a=Veykril The `qualify_path` assists currently eats up already annotated generics in all but one cases which can be annoying if one already pre-fills generics of a type before it's been qualified. Co-authored-by: Matthew Sanetra <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| * Keep generic annotations when qualifying thingsLukas Wirth2020-10-291-13/+169
| |
* | Merge #6257bors[bot]2020-10-261-11/+11
|\ \ | |/ |/| | | | | | | | | | | 6257: Don't suggest extracting out 1-tuple enum variants r=matklad a=repnop Fixes #6241. Co-authored-by: Wesley Norris <[email protected]>
| * Don't suggest extracting out 1-tuple enum variantsWesley Norris2020-10-261-11/+11
| | | | | | | | Fixes #6241.
* | Merge #6333bors[bot]2020-10-261-7/+80
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6333: Don't interpret type path as part of visibility. r=matklad a=ArifRoktim This closes #5902. I only check that the next token isn't equal to `T![:]`, instead of the next two not being equal to `T![::]`. Is that ok? Co-authored-by: Arif Roktim <[email protected]>
| * | Allow assist move_arm_cond_to_match_guard inside blocksArif Roktim2020-10-241-7/+80
| | |
* | | Keep parens around in remove-dbg for range expressionsLukas Wirth2020-10-251-8/+9
| | |
* | | Don't keep parens around in remove-dbgLukas Wirth2020-10-251-1/+61
| | |
* | | Don't keep parens around with remove-dbg when encountering method chainingLukas Wirth2020-10-251-0/+20
| | |
* | | Re-export base_db from ide_dbIgor Aleksanov2020-10-243-3/+3
| | |
* | | Remove dependency on 'assists' from 'completion' crateIgor Aleksanov2020-10-244-7/+8
|/ /
* | generate_impl assist respect cfg attributes #6312Benjamin Coenen2020-10-221-2/+40
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6256bors[bot]2020-10-201-0/+141
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 6256: Assist: replace string with char r=bnjjj a=bnjjj close #6252 Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Coenen Benjamin <[email protected]>
| * | Update crates/assists/src/handlers/replace_string_with_char.rsCoenen Benjamin2020-10-201-1/+1
| | | | | | | | | Co-authored-by: Aleksey Kladov <[email protected]>
| * | Assist: replace string with charBenjamin Coenen2020-10-201-8/+22
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | replace_string_with_char #6252Benjamin Coenen2020-10-161-0/+127
| |/ | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #6172bors[bot]2020-10-202-1/+1049
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6172: Add qualify path assist r=matklad a=Veykril This implements a `qualify_path` assist which works quite similar to the `auto_import` assist but instead of adding imports to the file it well, qualifies the path. This PR also moves out the `AutoImportAssets` struct and functions from `auto_import` into a utils submodule as most of this is now shared between `auto_import` and `qualify_path`. Changes made to `AutoImportAssets` are solely in its `search_for_imports` function which now takes a prefixed parameter to discern between using `find_use_path_prefixed` and `find_use_path` as the former is the required behavior by `auto_import` and the latter by this assist. For missing imported traits instead of importing this will qualify the path with a trait cast as in: ```rust test_mod::TestStruct::TEST_CONST<|> ``` becomes ```rust <test_mod::TestStruct as test_mod::TestTrait>::TEST_CONST ``` and for trait methods ideally it would do the following: ```rust let test_struct = test_mod::TestStruct {}; test_struct.test_meth<|>od() ``` becomes ```rust let test_struct = test_mod::TestStruct {}; test_mod::TestTrait::test_method(&test_struct) ``` Fixes #4124. Co-authored-by: Lukas Wirth <[email protected]>
| * | De-duplicate `add_group` callsite in qualify_pathLukas Wirth2020-10-161-121/+108
| | |
| * | Properly qualify trait methods in qualify_path assistLukas Wirth2020-10-152-47/+79
| | |
| * | Add mark tests to qualify_path assistLukas Wirth2020-10-141-0/+9
| | |
| * | Add qualify path assistLukas Wirth2020-10-141-0/+1020
| | |
* | | Don't rely on display names in inlay_hintsAleksey Kladov2020-10-202-2/+2
| | |
* | | Minor, rename featureAleksey Kladov2020-10-191-1/+1
| | |
* | | Change visibility works for type aliasesAleksey Kladov2020-10-182-5/+19
| |/ |/|
* | More idiomatic classification APIAleksey Kladov2020-10-152-4/+4
| |
* | Document auto_import as a featureLukas Wirth2020-10-151-0/+55
|/
*-. Merge #6207 #6224 #6226 #6227bors[bot]2020-10-141-241/+28
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6207: Extract ImportAssets out of auto_import r=matklad a=Veykril See https://github.com/rust-analyzer/rust-analyzer/pull/6172#issuecomment-707182140 I couldn't fully pull out `AssistContext` as `find_node_at_offset_with_descend`: https://github.com/rust-analyzer/rust-analyzer/blob/81fa00c5b5d5ffb559a39c7ff5190a2519a8ea61/crates/assists/src/assist_context.rs#L90-L92 requires the `SourceFile` which is private in it and I don't think making it public just for this is the right call? 6224: :arrow_up: salsa r=matklad a=matklad bors r+ 🤖 6226: Add reminder to update lsp-extensions.md r=matklad a=matklad bors r+ 🤖 6227: Reduce bors timeout r=matklad a=matklad bors r+ 🤖 Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
* | | Fix stackoverflow in insert_use::recursive_mergeLukas Wirth2020-10-142-0/+31
| |/ |/|
* | Fix MergeBehaviour::Full not working when merging nested long pathsLukas Wirth2020-10-131-1/+1
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-05 01:16:10 +0000