Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make insert_use return a SyntaxRewriter | Lukas Wirth | 2020-11-02 | 1 | -13/+18 |
| | |||||
* | Remove more unreachable pubs | Aleksey Kladov | 2020-11-02 | 2 | -5/+5 |
| | |||||
* | Fix indentation of inserted use statements | Florian Diebold | 2020-10-24 | 1 | -34/+132 |
| | |||||
* | Properly qualify trait methods in qualify_path assist | Lukas Wirth | 2020-10-15 | 1 | -23/+17 |
| | |||||
*-. | Merge #6207 #6224 #6226 #6227 | bors[bot] | 2020-10-14 | 1 | -0/+268 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6207: Extract ImportAssets out of auto_import r=matklad a=Veykril See https://github.com/rust-analyzer/rust-analyzer/pull/6172#issuecomment-707182140 I couldn't fully pull out `AssistContext` as `find_node_at_offset_with_descend`: https://github.com/rust-analyzer/rust-analyzer/blob/81fa00c5b5d5ffb559a39c7ff5190a2519a8ea61/crates/assists/src/assist_context.rs#L90-L92 requires the `SourceFile` which is private in it and I don't think making it public just for this is the right call? 6224: :arrow_up: salsa r=matklad a=matklad bors r+ 🤖 6226: Add reminder to update lsp-extensions.md r=matklad a=matklad bors r+ 🤖 6227: Reduce bors timeout r=matklad a=matklad bors r+ 🤖 Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> | ||||
* | | | Fix stackoverflow in insert_use::recursive_merge | Lukas Wirth | 2020-10-14 | 1 | -2/+22 |
| |/ |/| | |||||
* | | Fix MergeBehaviour::Full not working when merging nested long paths | Lukas Wirth | 2020-10-13 | 1 | -3/+32 |
| | | |||||
| * | Slightly cleanup import_assets module | Lukas Wirth | 2020-10-13 | 1 | -56/+78 |
| | | |||||
| * | Adhere to style guidelines in import_assets | Lukas Wirth | 2020-10-13 | 1 | -37/+29 |
| | | |||||
| * | Extract ImportAssets out of auto_import | Lukas Wirth | 2020-10-13 | 1 | -0/+254 |
|/ | |||||
* | Fix path comparison not comparing paths correctly with unequal lengths | Lukas Wirth | 2020-10-01 | 1 | -48/+85 |
| | |||||
* | Fix MergingBehaviour::Last not working properly | Lukas Wirth | 2020-09-30 | 1 | -21/+52 |
| | |||||
* | Remove partial import test in insert_use | Lukas Wirth | 2020-09-25 | 1 | -10/+0 |
| | |||||
* | Merge #5989 | bors[bot] | 2020-09-16 | 1 | -84/+272 |
|\ | | | | | | | | | | | | | | | | | | | 5989: Rewrite import merging r=jonas-schievink a=Veykril Rewrites how import merging is being handled. It is now a recursive function to properly handle merging of intermediate levels in the import trees. With this ordering the imports is also now possible tho it doesn't quite order it the same way as `rustfmt` does yet, namely it orders lowercase identifiers after uppercase identifiers as that is the standard character order that rust uses. This also fixes a few weird behaviors that were visible in some of the `replace_qualified_name_with_use.rs` tests. This really took longer than I was hoping for, fighting with import trees is quite the exhausting task 😅 Co-authored-by: Lukas Wirth <[email protected]> | ||||
| * | Add make::glob_use_tree function to create star-only UseTree | Lukas Wirth | 2020-09-16 | 1 | -11/+3 |
| | | |||||
| * | Fix merge imports failing if the `self` module import is in the wrong tree | Lukas Wirth | 2020-09-12 | 1 | -22/+34 |
| | | |||||
| * | Tidy up `recursive_merge` implementation | Lukas Wirth | 2020-09-12 | 1 | -60/+60 |
| | | |||||
| * | Reimplement import merging by making it recursive properly nesting all levels | Lukas Wirth | 2020-09-12 | 1 | -64/+248 |
| | | |||||
* | | Make MergeBehaviour configurable | Lukas Wirth | 2020-09-12 | 1 | -1/+1 |
|/ | |||||
* | Allow merge_imports assists to merge imports of equal visibility | Lukas Wirth | 2020-09-05 | 1 | -6/+11 |
| | |||||
* | Remove duplicated import merge logic | Lukas Wirth | 2020-09-05 | 1 | -2/+7 |
| | |||||
* | Fix segment_iter not iterating segments properly | Lukas Wirth | 2020-09-05 | 1 | -5/+16 |
| | |||||
* | Add extra insert_use test for pub(crate) re-export handling | Lukas Wirth | 2020-09-03 | 1 | -8/+14 |
| | |||||
* | Fix import insertion breaking nested modules | Lukas Wirth | 2020-09-03 | 1 | -43/+95 |
| | |||||
* | Fix inserting imports in front of inner attributes | Lukas Wirth | 2020-09-03 | 1 | -1/+51 |
| | |||||
* | Replace insert_use_statement with the new insert_use | Lukas Wirth | 2020-09-03 | 1 | -8/+10 |
| | |||||
* | Impl make::blank_line | Lukas Wirth | 2020-09-03 | 1 | -25/+8 |
| | |||||
* | Use mark to check that paths that are too long will not be merged | Lukas Wirth | 2020-09-03 | 1 | -0/+13 |
| | |||||
* | Tidy up tests and apply suggested changes | Lukas Wirth | 2020-09-03 | 1 | -72/+107 |
| | |||||
* | Add more import insertion tests | Lukas Wirth | 2020-09-03 | 1 | -3/+68 |
| | |||||
* | Begin refactor of import insertion | Lukas Wirth | 2020-09-03 | 1 | -468/+440 |
| | |||||
* | Don't expose hir::Path out of hir | Aleksey Kladov | 2020-08-15 | 1 | -3/+2 |
| | | | | | | | | | | | | | | Conjecture: it's impossible to use hir::Path *correctly* from an IDE. I am not entirely sure about this, and we might need to add it back at some point, but I have to arguments that convince me that we probably won't: * `hir::Path` has to know about hygiene, which an IDE can't set up properly. * `hir::Path` lacks identity, but you actually have to know identity to resolve it correctly | ||||
* | Rename ra_assists -> assists | Aleksey Kladov | 2020-08-13 | 1 | -0/+547 |