aboutsummaryrefslogtreecommitdiff
path: root/crates/assists/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix the profiling stringKirill Bulatov2020-11-271-1/+1
| | | Co-authored-by: Laurențiu Nicola <[email protected]>
* Profile completions betterKirill Bulatov2020-11-272-0/+2
|
* Merge #6586bors[bot]2020-11-271-8/+16
|\ | | | | | | | | | | | | | | 6586: Don't call a closure a function in the infer_function_return_type assist label r=lnicola a=Veykril `Add this function's return type` becomes `Add this closure's return type` for closures. This makes it more obvious that we are indeed planning on modifying the closure and not its containing function. Co-authored-by: Lukas Wirth <[email protected]>
| * Don't call a closure function in infer_function_return_type labelLukas Wirth2020-11-171-8/+16
| |
* | Avoid string allocations in ignore_testLaurențiu Nicola2020-11-241-1/+1
| |
* | add 'Re-enable this test' assistJakob Hellermann2020-11-231-7/+76
| |
* | Don't wrap parens around expr in remove_dbg assist if its in conditionsLukas Wirth2020-11-201-7/+64
| |
* | Merge #6553bors[bot]2020-11-177-41/+48
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6553: Auto imports in completion r=matklad a=SomeoneToIgnore ![completion](https://user-images.githubusercontent.com/2690773/99155339-ae4fb380-26bf-11eb-805a-655b1706ce70.gif) Closes https://github.com/rust-analyzer/rust-analyzer/issues/1062 but does not handle the completion order, since it's a separate task for https://github.com/rust-analyzer/rust-analyzer/issues/4922 , https://github.com/rust-analyzer/rust-analyzer/issues/4922 and maybe something else. 2 quirks in the current implementation: * traits are not auto imported during method completion If I understand the current situation right, we cannot search for traits by a **part** of a method name, we need a full name with correct case to get a trait for it. * VSCode (?) autocompletion is not as rigid as in Intellij Rust as you can notice on the animation. Intellij is able to refresh the completions on every new symbol added, yet VS Code does not query the completions on every symbol for me. With a few debug prints placed in RA, I've observed the following behaviour: after the first set of completion suggestions is received, next symbol input does not trigger a server request, if the completions contain this symbol. When more symbols added, the existing completion suggestions are filtered out until none are left and only then, on the next symbol it queries for completions. It seems like the only alternative to get an updated set of results is to manually retrigger it with Esc and Ctrl + Space. Despite the eerie latter bullet, the completion seems to work pretty fine and fast nontheless, but if you have any ideas on how to make it more smooth, I'll gladly try it out. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Avoid turning completion objects into buildersKirill Bulatov2020-11-161-1/+1
| | |
| * | Better filter mod pathsKirill Bulatov2020-11-161-1/+1
| | |
| * | Use imports_locatorKirill Bulatov2020-11-162-28/+34
| | |
| * | Add imports in auto completionKirill Bulatov2020-11-165-12/+13
| |/
* | Use standard code style for test fixturesAleksey Kladov2020-11-171-270/+270
| |
* | **Unwrap Block** supports stand-alone blocksAleksey Kladov2020-11-171-1/+68
| |
* | SimplifyAleksey Kladov2020-11-171-3/+1
| |
* | Assist target should point at *existing* codeAleksey Kladov2020-11-171-1/+1
| |
* | Add **Ignore Test** assistAleksey Kladov2020-11-174-0/+74
|/
* add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-131-1/+1
| | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
* add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-131-1/+11
| | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
* Merge #6514bors[bot]2020-11-121-28/+92
|\ | | | | | | | | | | | | | | 6514: Fix extract_struct_from_enum_variant not updating record references r=Veykril a=Veykril Related to #6510 Co-authored-by: Lukas Wirth <[email protected]>
| * Add extra test to extract_struct_from_enum_variantLukas Wirth2020-11-121-1/+28
| |
| * Use Module::find_use_path_prefixed in extract_struct_from_enum_variant assistLukas Wirth2020-11-121-5/+9
| |
| * Fix extract_struct_from_enum_variant not updating record referencesLukas Wirth2020-11-121-26/+59
| |
* | Merge #6513bors[bot]2020-11-121-1/+82
|\ \ | | | | | | | | | | | | | | | | | | | | | 6513: Support qualified function calls in remove_unused_param r=Veykril a=Veykril Also adds a test to check that it removes unused params across files. Co-authored-by: Lukas Wirth <[email protected]>
| * | Support qualified function calls in remove_unused_paramLukas Wirth2020-11-121-1/+49
| | |
| * | Add multiple file edit tes to remove_unused_param assistLukas Wirth2020-11-091-0/+33
| |/
* | Remove the fixmeKirill Bulatov2020-11-121-36/+15
| |
* | Add a FIXME for non-unified inner attributesKirill Bulatov2020-11-121-2/+7
| |
* | Do not insert imports before inner commentsKirill Bulatov2020-11-121-18/+92
|/
* Fix panic when extracting structAleksey Kladov2020-11-092-3/+34
|
* Support multi-file assist testsAleksey Kladov2020-11-092-6/+56
|
* Merge #6506bors[bot]2020-11-095-1172/+1256
|\ | | | | | | | | | | | | | | | | 6506: Cleanup assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Use standard style for test codeAleksey Kladov2020-11-091-568/+635
| |
| * More consistent namingAleksey Kladov2020-11-093-81/+81
| |
| * More consistent namingAleksey Kladov2020-11-093-66/+83
| |
* | Merge #6465bors[bot]2020-11-091-9/+16
|\ \ | |/ |/| | | | | | | | | | | 6465: Support multiple file edits in AssistBuilder r=matklad a=Veykril Fixes #6459 Co-authored-by: Lukas Wirth <[email protected]>
| * Support multiple file edits in AssistBuilderLukas Wirth2020-11-041-9/+16
| |
* | Merge #6501bors[bot]2020-11-093-35/+51
|\ \ | | | | | | | | | | | | | | | | | | | | | 6501: Remove text_edit_builder api from AssistBuilder r=matklad a=Veykril Also fixes a small bug in `expand_glob_import` in regards to the very nice looking `something::{*}` import when only one item was used. Before it would duplicate the path and just append it, causing the following wrong import `something::something::UsedItem`. Co-authored-by: Lukas Wirth <[email protected]>
| * | Remove text_edit_builder api from AssistBuilderLukas Wirth2020-11-083-35/+51
| | |
* | | Merge #6476bors[bot]2020-11-073-110/+235
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6476: Add missing AssocItems in add_custom_impl assist r=matklad a=Veykril ```rust use std::fmt; #[derive(Debu<|>g)] struct Foo { bar: String, } ``` -> ```rust use std::fmt; struct Foo { bar: String, } impl fmt::Debug for Foo { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { ${0:todo!()} } } ``` Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add missing AssocItems in add_custom_impl assistLukas Wirth2020-11-053-110/+235
| | | |
* | | | Minimize convert_integer_literal testsm-ysk2020-11-071-368/+2
| |/ / |/| |
* | | Cleanup APIAleksey Kladov2020-11-061-1/+5
| | |
* | | Merge #6485bors[bot]2020-11-0613-31/+38
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6485: Remove RAW literals r=matklad a=matklad bors r+ 🤖 closes https://github.com/rust-analyzer/rust-analyzer/issues/6308 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | SimplifyAleksey Kladov2020-11-062-9/+2
| | | |
| * | | Kill RAW_ literalsAleksey Kladov2020-11-0613-23/+37
| | | | | | | | | | | | | | | | | | | | Syntactically, they are indistinguishable from non-raw versions, so it doesn't make sense to separate then *at the syntax* level.
* | | | Merge #6477bors[bot]2020-11-063-0/+352
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6477: Add infer_function_return_type assist r=matklad a=Veykril This adds an assist to insert a functions return type if it hasn't been specified yet by inferring it from the functions tail expression. This assist only becomes active if the cursor is on the tail expression. See https://github.com/rust-analyzer/rust-analyzer/issues/6303#issuecomment-714657326 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Adjust test-texts in infer_function_return_typeLukas Wirth2020-11-061-78/+78
| | | |
| * | | Enable infer_function_return_type in return-type positionLukas Wirth2020-11-061-29/+129
| | | |
| * | | Wrap non-block expressions in closures with a blockLukas Wirth2020-11-061-12/+31
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-01 00:52:56 +0000