Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Add ability to specify ResolvedAssist by label | vlakreeh | 2020-09-29 | 1 | -5/+22 | |
| | | ||||||
| * | Add convert integer literal assist | vlakreeh | 2020-09-29 | 3 | -0/+150 | |
| | | ||||||
* | | Simplify ast_transform | Aleksey Kladov | 2020-10-02 | 1 | -40/+34 | |
| | | ||||||
* | | Merge #6105 | bors[bot] | 2020-10-02 | 1 | -48/+85 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6105: Fix path comparison not comparing paths correctly with unequal lengths r=matklad a=Veykril ~~This PR includes the commit from #6102 there as I found a bug while writing that(so either merging this or both in order works) so I included a test there already which was just ignored.~~ This PR fixes that, basically inserting imports didn't consider path length for equality, so depending on the order it might insert the path before or after another import if they only differ in segment length. ~~Diff without the commit of #6102 https://github.com/rust-analyzer/rust-analyzer/commit/2d90d3937d71f9a00f3d44c15b20679215311637~~ Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | | Fix path comparison not comparing paths correctly with unequal lengths | Lukas Wirth | 2020-10-01 | 1 | -48/+85 | |
| | | | ||||||
* | | | Merge #6104 | bors[bot] | 2020-10-02 | 2 | -2/+2 | |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | 6104: Minor clippy performance suggestions r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]> | |||||
| * | | Minor clippy performance suggestions | kjeremy | 2020-09-30 | 2 | -2/+2 | |
| |/ | ||||||
* / | Fix MergingBehaviour::Last not working properly | Lukas Wirth | 2020-09-30 | 1 | -21/+52 | |
|/ | ||||||
* | Merge #6019 | bors[bot] | 2020-09-29 | 4 | -38/+11 | |
|\ | | | | | | | | | | | | | | | 6019: Remove make::path_from_text r=matklad a=Veykril This removes the `make::path_from_text` function, which according to a note should've been private. I removed it since it didn't really serve a purpose as it was simply wrapping `make::ast_from_text`. Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | Remove make::path_from_text | Lukas Wirth | 2020-09-16 | 4 | -38/+11 | |
| | | ||||||
* | | Microoptimize | Aleksey Kladov | 2020-09-28 | 1 | -6/+7 | |
| | | ||||||
* | | Remove partial import test in insert_use | Lukas Wirth | 2020-09-25 | 1 | -10/+0 | |
| | | ||||||
* | | Don't unnecessarily unnest imports for import insertion | Lukas Wirth | 2020-09-25 | 2 | -2/+66 | |
| | | ||||||
* | | Document AstTransformation | Aleksey Kladov | 2020-09-21 | 1 | -0/+28 | |
| | | ||||||
* | | Rename impl edit method to be more explicit | Matt Hooper | 2020-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | Added test for impl member assist when impl def is missing braces | Matt Hooper | 2020-09-21 | 1 | -0/+19 | |
| | | ||||||
* | | Replace entire impl def instead of only associated items for missing impl ↵ | Matt Hooper | 2020-09-21 | 1 | -9/+12 | |
| | | | | | | | | member assist (if braces are missing from an impl def then there is no associated item list in the AST) | |||||
* | | Merge #5989 | bors[bot] | 2020-09-16 | 3 | -103/+287 | |
|\ \ | |/ |/| | | | | | | | | | | | | | | | 5989: Rewrite import merging r=jonas-schievink a=Veykril Rewrites how import merging is being handled. It is now a recursive function to properly handle merging of intermediate levels in the import trees. With this ordering the imports is also now possible tho it doesn't quite order it the same way as `rustfmt` does yet, namely it orders lowercase identifiers after uppercase identifiers as that is the standard character order that rust uses. This also fixes a few weird behaviors that were visible in some of the `replace_qualified_name_with_use.rs` tests. This really took longer than I was hoping for, fighting with import trees is quite the exhausting task 😅 Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | Add make::glob_use_tree function to create star-only UseTree | Lukas Wirth | 2020-09-16 | 1 | -11/+3 | |
| | | ||||||
| * | Fix merge imports failing if the `self` module import is in the wrong tree | Lukas Wirth | 2020-09-12 | 1 | -22/+34 | |
| | | ||||||
| * | Tidy up `recursive_merge` implementation | Lukas Wirth | 2020-09-12 | 1 | -60/+60 | |
| | | ||||||
| * | Reimplement import merging by making it recursive properly nesting all levels | Lukas Wirth | 2020-09-12 | 3 | -83/+263 | |
| | | ||||||
* | | Make MergeBehaviour configurable | Lukas Wirth | 2020-09-12 | 6 | -15/+27 | |
|/ | ||||||
* | Properly preserve macro braces | Kirill Bulatov | 2020-09-11 | 1 | -25/+16 | |
| | ||||||
* | Merge #5955 | bors[bot] | 2020-09-11 | 2 | -82/+114 | |
|\ | | | | | | | | | | | | | | | | | | | 5955: Remove merge import code duplication r=jonas-schievink a=Veykril This removes the code duplication caused by #5935, this also allows the assist to merge imports that have equal visibility and prevents merges of unequal visibility. This PR also fixes an iteration mistake in the mentioned PR: Turns out I made a mistake when writing the `segment_iter` function, I was assuming that the `children` of a path will just be the segments, which is obviously not the case. This also brings insertion order of shorter paths in line with how `rustfmt` orders them. Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | Allow merge_imports assists to merge imports of equal visibility | Lukas Wirth | 2020-09-05 | 2 | -6/+61 | |
| | | ||||||
| * | Remove duplicated import merge logic | Lukas Wirth | 2020-09-05 | 2 | -77/+43 | |
| | | ||||||
| * | Fix segment_iter not iterating segments properly | Lukas Wirth | 2020-09-05 | 1 | -5/+16 | |
| | | ||||||
* | | One more test | Kirill Bulatov | 2020-09-10 | 1 | -0/+2 | |
| | | ||||||
* | | Use better heuristics for replacement text when removing dbg! | Kirill Bulatov | 2020-09-10 | 1 | -37/+116 | |
|/ | ||||||
* | Merge #5940 | bors[bot] | 2020-09-04 | 3 | -0/+183 | |
|\ | | | | | | | | | | | | | | | 5940: Implement "Replace `impl Trait` function argument with the named generic" assist. r=matklad a=alekseysidorov Fixes #5085 Co-authored-by: Aleksei Sidorov <[email protected]> | |||||
| * | Remove unnecessary comma | Aleksei Sidorov | 2020-09-04 | 2 | -10/+10 | |
| | | ||||||
| * | Fix tests | Aleksei Sidorov | 2020-09-04 | 2 | -17/+24 | |
| | | ||||||
| * | Update codegen | Aleksei Sidorov | 2020-09-04 | 1 | -0/+13 | |
| | | ||||||
| * | Fix nitpicks | Aleksei Sidorov | 2020-09-04 | 1 | -7/+12 | |
| | | ||||||
| * | Resolve most of corner cases | Aleksei Sidorov | 2020-09-03 | 1 | -8/+102 | |
| | | ||||||
| * | Initial implementation of the #5085 issue | Aleksei Sidorov | 2020-09-03 | 2 | -0/+64 | |
| | | ||||||
* | | Add extra insert_use test for pub(crate) re-export handling | Lukas Wirth | 2020-09-03 | 2 | -12/+19 | |
| | | ||||||
* | | Disable insert_import in extract_struct_from_enum_variant until its fixed | Lukas Wirth | 2020-09-03 | 1 | -0/+4 | |
| | | ||||||
* | | Fix import insertion breaking nested modules | Lukas Wirth | 2020-09-03 | 5 | -62/+117 | |
| | | ||||||
* | | Fix inserting imports in front of inner attributes | Lukas Wirth | 2020-09-03 | 2 | -3/+54 | |
| | | ||||||
* | | Replace insert_use_statement with the new insert_use | Lukas Wirth | 2020-09-03 | 4 | -54/+68 | |
| | | ||||||
* | | Impl make::blank_line | Lukas Wirth | 2020-09-03 | 2 | -26/+9 | |
| | | ||||||
* | | Use mark to check that paths that are too long will not be merged | Lukas Wirth | 2020-09-03 | 1 | -0/+13 | |
| | | ||||||
* | | Tidy up tests and apply suggested changes | Lukas Wirth | 2020-09-03 | 1 | -72/+107 | |
| | | ||||||
* | | Add more import insertion tests | Lukas Wirth | 2020-09-03 | 1 | -3/+68 | |
| | | ||||||
* | | Begin refactor of import insertion | Lukas Wirth | 2020-09-03 | 1 | -468/+440 | |
|/ | ||||||
* | Unify naming | Aleksey Kladov | 2020-09-03 | 1 | -1/+1 | |
| | ||||||
* | Reduce path_from_text usage | Aleksey Kladov | 2020-08-31 | 1 | -13/+17 | |
| | ||||||
* | **Inline Variable** works with field shorthand | Aleksey Kladov | 2020-08-26 | 1 | -2/+29 | |
| |