aboutsummaryrefslogtreecommitdiff
path: root/crates/assists/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6514bors[bot]2020-11-121-28/+92
|\ | | | | | | | | | | | | | | 6514: Fix extract_struct_from_enum_variant not updating record references r=Veykril a=Veykril Related to #6510 Co-authored-by: Lukas Wirth <[email protected]>
| * Add extra test to extract_struct_from_enum_variantLukas Wirth2020-11-121-1/+28
| |
| * Use Module::find_use_path_prefixed in extract_struct_from_enum_variant assistLukas Wirth2020-11-121-5/+9
| |
| * Fix extract_struct_from_enum_variant not updating record referencesLukas Wirth2020-11-121-26/+59
| |
* | Merge #6513bors[bot]2020-11-121-1/+82
|\ \ | | | | | | | | | | | | | | | | | | | | | 6513: Support qualified function calls in remove_unused_param r=Veykril a=Veykril Also adds a test to check that it removes unused params across files. Co-authored-by: Lukas Wirth <[email protected]>
| * | Support qualified function calls in remove_unused_paramLukas Wirth2020-11-121-1/+49
| | |
| * | Add multiple file edit tes to remove_unused_param assistLukas Wirth2020-11-091-0/+33
| |/
* | Remove the fixmeKirill Bulatov2020-11-121-36/+15
| |
* | Add a FIXME for non-unified inner attributesKirill Bulatov2020-11-121-2/+7
| |
* | Do not insert imports before inner commentsKirill Bulatov2020-11-121-18/+92
|/
* Fix panic when extracting structAleksey Kladov2020-11-092-3/+34
|
* Support multi-file assist testsAleksey Kladov2020-11-092-6/+56
|
* Merge #6506bors[bot]2020-11-095-1172/+1256
|\ | | | | | | | | | | | | | | | | 6506: Cleanup assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Use standard style for test codeAleksey Kladov2020-11-091-568/+635
| |
| * More consistent namingAleksey Kladov2020-11-093-81/+81
| |
| * More consistent namingAleksey Kladov2020-11-093-66/+83
| |
* | Merge #6465bors[bot]2020-11-091-9/+16
|\ \ | |/ |/| | | | | | | | | | | 6465: Support multiple file edits in AssistBuilder r=matklad a=Veykril Fixes #6459 Co-authored-by: Lukas Wirth <[email protected]>
| * Support multiple file edits in AssistBuilderLukas Wirth2020-11-041-9/+16
| |
* | Merge #6501bors[bot]2020-11-093-35/+51
|\ \ | | | | | | | | | | | | | | | | | | | | | 6501: Remove text_edit_builder api from AssistBuilder r=matklad a=Veykril Also fixes a small bug in `expand_glob_import` in regards to the very nice looking `something::{*}` import when only one item was used. Before it would duplicate the path and just append it, causing the following wrong import `something::something::UsedItem`. Co-authored-by: Lukas Wirth <[email protected]>
| * | Remove text_edit_builder api from AssistBuilderLukas Wirth2020-11-083-35/+51
| | |
* | | Merge #6476bors[bot]2020-11-073-110/+235
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6476: Add missing AssocItems in add_custom_impl assist r=matklad a=Veykril ```rust use std::fmt; #[derive(Debu<|>g)] struct Foo { bar: String, } ``` -> ```rust use std::fmt; struct Foo { bar: String, } impl fmt::Debug for Foo { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { ${0:todo!()} } } ``` Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add missing AssocItems in add_custom_impl assistLukas Wirth2020-11-053-110/+235
| | | |
* | | | Minimize convert_integer_literal testsm-ysk2020-11-071-368/+2
| |/ / |/| |
* | | Cleanup APIAleksey Kladov2020-11-061-1/+5
| | |
* | | Merge #6485bors[bot]2020-11-0613-31/+38
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6485: Remove RAW literals r=matklad a=matklad bors r+ 🤖 closes https://github.com/rust-analyzer/rust-analyzer/issues/6308 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | SimplifyAleksey Kladov2020-11-062-9/+2
| | | |
| * | | Kill RAW_ literalsAleksey Kladov2020-11-0613-23/+37
| | | | | | | | | | | | | | | | | | | | Syntactically, they are indistinguishable from non-raw versions, so it doesn't make sense to separate then *at the syntax* level.
* | | | Merge #6477bors[bot]2020-11-063-0/+352
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | 6477: Add infer_function_return_type assist r=matklad a=Veykril This adds an assist to insert a functions return type if it hasn't been specified yet by inferring it from the functions tail expression. This assist only becomes active if the cursor is on the tail expression. See https://github.com/rust-analyzer/rust-analyzer/issues/6303#issuecomment-714657326 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Adjust test-texts in infer_function_return_typeLukas Wirth2020-11-061-78/+78
| | | |
| * | | Enable infer_function_return_type in return-type positionLukas Wirth2020-11-061-29/+129
| | | |
| * | | Wrap non-block expressions in closures with a blockLukas Wirth2020-11-061-12/+31
| | | |
| * | | Ignore unit expressions in infer_function_return_type assistLukas Wirth2020-11-061-3/+13
| | | |
| * | | Support closures in infer_function_return_type assistLukas Wirth2020-11-061-19/+114
| | | |
| * | | Add infer_function_return_type assistLukas Wirth2020-11-063-0/+128
| |/ /
* | | Merge #6480bors[bot]2020-11-061-14/+107
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6480: Support closure in change_return_type_to_result assist r=Veykril a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | | Support closure in change_return_type_to_result assistLukas Wirth2020-11-061-14/+107
| |/ /
* | | More orthogonal APIAleksey Kladov2020-11-061-15/+8
| | |
* | | Move int parsing to IntNumber tokenAleksey Kladov2020-11-061-1/+1
|/ /
* | Merge #6456bors[bot]2020-11-041-38/+110
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6456: Support record variants in extract_struct_from_enum_variant r=matklad a=Veykril As requested :) This also prevents the assist from being disabled if a definition in the value namespace exists with the same name as our new struct since that won't cause a collision #4468 Co-authored-by: Lukas Wirth <[email protected]>
| * | Support struct variants in extract_struct_from_enum_variantLukas Wirth2020-11-031-46/+74
| | |
| * | only check type namespace in extract_struct_from_enum_variant for collisionsLukas Wirth2020-11-031-9/+53
| | |
* | | Merge #6458bors[bot]2020-11-041-38/+114
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | 6458: Qualify trait impl created by add_custom_impl assist r=matklad a=Veykril When we find at least one trait with the same name as the derive accessible from the current module we now generate a qualified path to that trait in the generated impl. If we don't find any we just do what was done before and emit the trait name in the generated impl. Co-authored-by: Lukas Wirth <[email protected]>
| * | Qualify trait impl created by add_custom_impl assistLukas Wirth2020-11-031-38/+114
| |/
* | Merge #6454bors[bot]2020-11-031-135/+71
|\ \ | |/ |/| | | | | | | | | | | | | 6454: Fix overflow panic in convert_interger_literal assist r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix overflow panic in convert_interger_literal assistAleksey Kladov2020-11-031-135/+71
| | | | | | | | | | | | | | | | | | This also seizes the opportunity to move integer literal parsing to the syntax crate, were it logically belongs. Note though that this is still done in an ad hoc manner -- we probably should split kitchen sink ast::Literal into a separate APIs for strings, ints, etc
* | Make insert_use return a SyntaxRewriterLukas Wirth2020-11-024-107/+92
|/
*-. Merge #6393 #6399bors[bot]2020-11-021-13/+169
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6393: Remove repetitive inlay hints (take 2) r=matklad a=lnicola 6399: Keep generic annotations when qualifying things r=matklad a=Veykril The `qualify_path` assists currently eats up already annotated generics in all but one cases which can be annoying if one already pre-fills generics of a type before it's been qualified. Co-authored-by: Matthew Sanetra <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| | * Keep generic annotations when qualifying thingsLukas Wirth2020-10-291-13/+169
| | |
* | | Remove more unreachable pubsAleksey Kladov2020-11-022-5/+5
|/ /
* | Merge #6257bors[bot]2020-10-261-11/+11
|\ \ | |/ |/| | | | | | | | | | | 6257: Don't suggest extracting out 1-tuple enum variants r=matklad a=repnop Fixes #6241. Co-authored-by: Wesley Norris <[email protected]>