| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Merge #5733 | bors[bot] | 2020-08-24 | 2 | -119/+617 |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5733: Fix expand glob import bugs r=matklad a=unexge fixes https://github.com/rust-analyzer/rust-analyzer/issues/5709 TODOs: - [x] Incorrect node replacing <details> <summary>Details</summary> ```rust use crate::{ body::scope::{ExprScopes, ScopeId}, body::Body, builtin_type::BuiltinType, db::DefDatabase, expr::{ExprId, PatId}, generics::GenericParams, item_scope::{BuiltinShadowMode, BUILTIN_SCOPE}, nameres::CrateDefMap, path::*<|>, per_ns::PerNs, visibility::{RawVisibility, Visibility}, AdtId, AssocContainerId, ConstId, ContainerId, DefWithBodyId, EnumId, EnumVariantId, FunctionId, GenericDefId, HasModule, ImplId, LocalModuleId, Lookup, ModuleDefId, ModuleId, StaticId, StructId, TraitId, TypeAliasId, TypeParamId, VariantId, }; ``` becames ```rust use crate::{PathKind, name, name, ModPath}; ``` </details> - [x] Ignoring visibility <details> <summary>Details</summary> ```rust mod foo { mod bar { pub struct Bar; } } use foo::bar::*; fn baz(bar: Bar) {} ``` becames ```rust mod foo { mod bar { pub struct Bar; } } use foo::bar::Bar; fn baz(bar: Bar) {} ``` although mod `bar` is private </details> - [x] Eating attributes Co-authored-by: unexge <[email protected]> | ||||
| | * | Use new `Definition::usages` API in expand glob import | unexge | 2020-08-20 | 1 | -1/+1 |
| | | | |||||
| | * | Fix importing private modules in expand glob import | unexge | 2020-08-20 | 1 | -0/+52 |
| | | | |||||
| | * | Fix importing unused traits in expand glob import | unexge | 2020-08-20 | 1 | -28/+73 |
| | | | |||||
| | * | Use fixme instead of todo | unexge | 2020-08-20 | 1 | -1/+1 |
| | | | |||||
| | * | Use `Definition::find_usages` for finding used items in expand glob import | unexge | 2020-08-20 | 2 | -114/+137 |
| | | | |||||
| | * | Run rustfmt | unexge | 2020-08-20 | 1 | -3/+5 |
| | | | |||||
| | * | Handle more cases in AST replacing in expand glob import | unexge | 2020-08-20 | 1 | -34/+219 |
| | | | |||||
| | * | Improve AST replacing in expand glob import | unexge | 2020-08-20 | 1 | -38/+229 |
| | | | |||||
| * | | Invert if should be smart about is_some, is_none, is_ok, is_err | dragfire | 2020-08-24 | 2 | -1/+38 |
| | | | |||||
| * | | :arrow_up: ungrammar | Aleksey Kladov | 2020-08-21 | 2 | -2/+2 |
| |/ | |||||
| * | **Remove Unused Parameter** refactoring | Aleksey Kladov | 2020-08-19 | 6 | -6/+162 |
| | | |||||
| * | Future proof find-usages API | Aleksey Kladov | 2020-08-19 | 2 | -2/+2 |
| | | | | | | | We might want to provide more efficient impls for check if usages exist, limiting the search, filtering and cancellation, so let's violate YAGNI a bit here. | ||||
| * | Introduce Label | Aleksey Kladov | 2020-08-18 | 2 | -18/+11 |
| | | |||||
| *-. | Merge #5776 #5780 | bors[bot] | 2020-08-17 | 2 | -6/+60 |
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5776: Fix eslint errors on .eslintrc.js and rollup.config.js r=matklad a=fuafa Eslint complains if these two files does not include in the `tsconfig.json`. ``` Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser. The file does not match your project config: .eslintrc.js. The file must be included in at least one of the projects provided.eslint ```  5780: Fixup whitespace when adding missing impl items r=matklad a=jDomantas Generate properly formatted whitespace when adding impl items - with an empty line between items and removing extra whitespace that often appears at the end. This is my first time working on rust analyzer so I'm not very familiar with its internal APIs. If there's a better way to do such syntax tree editing I'd be glad to hear it. Co-authored-by: xiaofa <[email protected]> Co-authored-by: jDomantas <[email protected]> | ||||
| | | * | update generated tests | jDomantas | 2020-08-17 | 1 | -2/+1 |
| | | | | |||||
| | | * | fixup whitespace when adding missing impl items | jDomantas | 2020-08-14 | 1 | -4/+59 |
| | | | | |||||
| * | | | Don't make fields private unless you have to | Aleksey Kladov | 2020-08-17 | 1 | -27/+10 |
| |/ / | |||||
| * | | Don't expose hir::Path out of hir | Aleksey Kladov | 2020-08-15 | 5 | -47/+37 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conjecture: it's impossible to use hir::Path *correctly* from an IDE. I am not entirely sure about this, and we might need to add it back at some point, but I have to arguments that convince me that we probably won't: * `hir::Path` has to know about hygiene, which an IDE can't set up properly. * `hir::Path` lacks identity, but you actually have to know identity to resolve it correctly | ||||
| * | | Remove deprecated Path::from_ast | Aleksey Kladov | 2020-08-15 | 1 | -19/+13 |
| |/ | | | | Long term, we probably should make hir::Path private to hir. | ||||
| * | Rename ra_assists -> assists | Aleksey Kladov | 2020-08-13 | 47 | -0/+16735 |
 |
index : rust-analyzer | |
| [FORK] modified to work on wasm targets |
| aboutsummaryrefslogtreecommitdiff |