aboutsummaryrefslogtreecommitdiff
path: root/crates/hir/src/lib.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* | Align Canonical more with Chalk's versionFlorian Diebold2021-03-211-13/+28
| | | | | | | | In particular, use chalk_ir::CanonicalVarKinds.
* | Use QuantifiedWhereClause in generic_predicates as wellFlorian Diebold2021-03-211-1/+1
| | | | | | | | | | Still far too much binder skipping going on; I find it hard to imagine this is all correct, but the tests pass.
* | Introduce QuantifiedWhereClause and DynTy analogous to ChalkFlorian Diebold2021-03-211-6/+11
| | | | | | | | | | This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point.
* | Merge #8133bors[bot]2021-03-211-1/+4
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 8133: Ignore type bindings in generic_predicates_for_param (fix panic on ena and crates depending on it) r=flodiebold a=flodiebold This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine. Co-authored-by: Florian Diebold <[email protected]>
| * | Ignore type bindings in generic_predicates_for_paramFlorian Diebold2021-03-211-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine.
* | | clippy::complexity simplifications related to IteratorsMatthias Krüger2021-03-211-1/+1
|/ /
* / Track labels in scopesLukas Wirth2021-03-211-0/+1
|/
* Turn Obligation into something similar to chalk_ir::DomainGoalFlorian Diebold2021-03-201-5/+6
| | | | This includes starting to make use of Chalk's `Cast` trait.
* Rename GenericPredicate -> WhereClauseFlorian Diebold2021-03-201-6/+6
|
* Add `AttrsWithOwner` and clean up `source_map`Jonas Schievink2021-03-191-1/+1
|
* Replace Projection variant in GenericPredicate with AliasEqLukas Wirth2021-03-191-11/+11
|
* Chalkify TraitRefFlorian Diebold2021-03-181-5/+5
|
* Store an `AstId` for procedural macrosJonas Schievink2021-03-181-2/+5
|
* Make MacroDefId's `AstId` mandatory when possibleJonas Schievink2021-03-181-1/+2
|
* Merge #8059bors[bot]2021-03-171-1/+1
|\ | | | | | | | | | | | | | | 8059: Move doc-comment highlight injection from AST to HIR r=matklad,jonas-schievink a=Veykril Fixes #5016 Co-authored-by: Lukas Wirth <[email protected]>
| * Properly handle doc attributes in doc-comment highlight injectionLukas Wirth2021-03-161-1/+1
| |
* | avoid converting types into themselves via .into() (clippy::useless-conversion)Matthias Krüger2021-03-171-6/+6
| | | | | | | | example: let x: String = String::from("hello world").into();
* | Rename Substs -> SubstitutionFlorian Diebold2021-03-161-8/+8
|/
* Merge #8034bors[bot]2021-03-161-4/+19
|\ | | | | | | | | | | | | | | 8034: Implement Crate::transitive_reverse_dependencies r=matklad a=Veykril changelog internal Implement Crate::transitive_reverse_dependencies Co-authored-by: Lukas Wirth <[email protected]>
| * Implement Crate::transitive_reverse_dependenciesLukas Wirth2021-03-151-4/+19
| |
| |
| \
*-. \ Merge #7900 #8000bors[bot]2021-03-161-24/+61
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * | Use hir formatter moreoxalica2021-03-151-1/+35
| | | |
| | * | Impl HirDisplay for function hover messageoxalica2021-03-151-2/+15
| | | |
| | * | Introduce FunctionQualifier for hir::FunctionDataoxalica2021-03-151-1/+1
| | | |
| | * | Collect HirDisplay impls to a single fileoxalica2021-03-151-20/+2
| | |/
| * | show function params in completion detailJosh Mcguigan2021-03-121-0/+8
| | |
* | | 7709: Import changes.Chetan Khilosiya2021-03-151-4/+2
| | |
* | | 7709: Added the check for return type of len function.Chetan Khilosiya2021-03-151-0/+7
| |/ |/|
* | Merge #8020bors[bot]2021-03-151-14/+44
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8020: Power up goto_implementation r=matklad a=Veykril by allowing it to be invoked on references of names, now showing all (trait) implementations of the given type in all crates instead of just the defining crate as well as including support for builtin types ![image](https://user-images.githubusercontent.com/3757771/111144403-52bb0700-8587-11eb-9205-7a2a5b8b75a3.png) Example screenshot of `impl`s of Box in `log`, `alloc`, `std` and the current crate. Before you had to invoke it on the definition where it would only show the `impls` in `alloc`. Co-authored-by: Lukas Wirth <[email protected]>
| * | goto_implementation: Look at the entire crate graph for trait implsLukas Wirth2021-03-151-8/+3
| | |
| * | Speedup trait impl search for goto_implementationLukas Wirth2021-03-151-2/+10
| | |
| * | Power up goto_implementationLukas Wirth2021-03-151-13/+40
| | | | | | | | | | | | | | | by allowing it to be invoked on references of names, showing all (trait) implementations of the given type in all crates including builtin types
* | | Merge #8018bors[bot]2021-03-151-5/+29
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8018: Make Ty wrap TyKind in an Arc r=flodiebold a=flodiebold ... to further move towards Chalk. This is a bit of a slowdown (218ginstr vs 213ginstr for inference on RA), even though it allows us to unwrap the Substs in `TyKind::Ref` etc.. Co-authored-by: Florian Diebold <[email protected]>
| * | | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-141-5/+29
| |/ /
* / / some clippy::performance fixesMatthias Krüger2021-03-151-2/+1
|/ / | | | | | | | | | | | | use vec![] instead of Vec::new() + push() avoid redundant clones use chars instead of &str for single char patterns in ends_with() and starts_with() allocate some Vecs with capacity to avoid unneccessary resizing
* | More renamingFlorian Diebold2021-03-141-1/+1
| |
* | Rename some fields to their Chalk namesFlorian Diebold2021-03-141-2/+2
| |
* | Move type lowering methods to TyLoweringContextFlorian Diebold2021-03-131-3/+3
| |
* | Create TraitEnvironment through a queryFlorian Diebold2021-03-131-5/+7
| |
* | Use chalk_ir::PlaceholderIndexFlorian Diebold2021-03-131-1/+1
| |
* | Use chalk_ir::FnDefIdFlorian Diebold2021-03-131-4/+1
| |
* | Use chalk_ir::AssocTypeIdFlorian Diebold2021-03-131-2/+5
| |
* | Separate `Ty` and `TyKind` like in ChalkFlorian Diebold2021-03-131-33/+34
|/ | | | | Currently `Ty` just wraps `TyKind`, but this allows us to change most places to already use `intern` / `interned`.
* Avoid double text edits when renaming mod declarationLukas Wirth2021-03-101-1/+0
|
* Delete `ContainerId`Jonas Schievink2021-03-091-21/+9
|
* Stop using `ContainerId` in `AssocContainerId`Jonas Schievink2021-03-091-2/+2
|
* Merge #7942bors[bot]2021-03-091-7/+1
|\ | | | | | | | | | | | | | | 7942: Show whether a binding is mutable or not on hover r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * Show whether a binding is mutable or not on hoverLukas Wirth2021-03-091-7/+1
| |
* | Cleanup auto-ref in completionAleksey Kladov2021-03-091-4/+3
|/
* Merge #7873 #7933bors[bot]2021-03-091-0/+11
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7873: Consider unresolved qualifiers during flyimport r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/7679 Takes unresolved qualifiers into account, providing better completions (or none, if the path is resolved or do not match). Does not handle cases when both path qualifier and some trait has to be imported: there are many extra issues with those (such as overlapping imports, for instance) that will require large diffs to address. Also does not do a fuzzy search on qualifier, that requires some adjustments in `import_map` for better queries and changes to the default replace range which also seems relatively big to include here. ![qualifier_completion](https://user-images.githubusercontent.com/2690773/110040808-0af8dc00-7d4c-11eb-83db-65af94e843bb.gif) 7933: Improve compilation speed r=matklad a=matklad bors r+ 🤖 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-30 03:06:49 +0000