Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
* | internal: remove one more accidentally quadratic code-path | Aleksey Kladov | 2021-06-22 | 1 | -20/+10 | |
| | | | | | | | | | | | | | | Definition::visibility was implemented in a rather roundabout way -- by asking the parent module about the effective visibility. This is problematic for a couple of reasons: * first, it doesn't work for local items * second, asking module about visibility of a child is a linear operation (that's a problem in itself, tracked in #9378) Instead, lets ask the declared visibility directly, we have all the code for it, and need only to actually us it. | |||||
* | intenral: dont export impl details | Aleksey Kladov | 2021-06-22 | 2 | -7/+5 | |
| | ||||||
* | minor: extend source_to_def docs | Aleksey Kladov | 2021-06-22 | 1 | -2/+18 | |
| | ||||||
* | internal: document source_to_def and it's connection to Kotlin&Roslyn | Aleksey Kladov | 2021-06-22 | 1 | -0/+69 | |
| | ||||||
* | Move features into potential_cfg_options | Jamie Cunliffe | 2021-06-21 | 1 | -2/+2 | |
| | ||||||
* | Improve completion of cfg attributes | Jamie Cunliffe | 2021-06-21 | 1 | -0/+4 | |
| | | | | | | | | | | | | The completion of cfg will look at the enabled cfg keys when performing completion. It will also look crate features when completing a feature cfg option. A fixed list of known values for some cfg options are provided. For unknown keys it will look at the enabled values for that cfg key, which means that completion will only show enabled options for those. | |||||
* | Apply some clippy suggestions | Clemens Wasser | 2021-06-21 | 1 | -23/+19 | |
| | ||||||
* | Nest all the or-patterns! | Lukas Wirth | 2021-06-17 | 1 | -8/+9 | |
| | ||||||
* | Filter out non-type completions in the respective completions modules instead | Lukas Wirth | 2021-06-16 | 1 | -12/+0 | |
| | ||||||
* | internal: more natural order of sources for TypeParam | Aleksey Kladov | 2021-06-14 | 1 | -1/+1 | |
| | | | | | We usually use first (left) variant of `Either` for "usual" case, and use right for odd things. For example, pat source is Pat | SelfParam. | |||||
* | Merge #9260 | bors[bot] | 2021-06-14 | 1 | -1/+1 | |
|\ | | | | | | | | | | | | | | | 9260: tree-wide: make rustdoc links spiky so they are clickable r=matklad a=lf- Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed. Co-authored-by: Jade <[email protected]> | |||||
| * | tree-wide: make rustdoc links spiky so they are clickable | Jade | 2021-06-14 | 1 | -1/+1 | |
| | | ||||||
* | | internal: kill diagnostic sink | Aleksey Kladov | 2021-06-13 | 3 | -135/+6 | |
| | | ||||||
* | | internal: use cov-mark rather than bailing out diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -45/+6 | |
| | | ||||||
* | | internal: refactor missing match arms diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -23/+9 | |
| | | ||||||
* | | internal: refactor incorrect case diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -36/+11 | |
| | | ||||||
* | | internal: refactor find_map diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -22/+8 | |
| | | ||||||
* | | internal: refactor missing or or some diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -34/+3 | |
| | | ||||||
* | | internal: refactor remove this semicolon diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -24/+3 | |
| | | ||||||
* | | internal: refactor mismatched args count diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -30/+5 | |
| | | ||||||
* | | internal: refactor missing unsafe diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -23/+3 | |
| | | ||||||
* | | internal: refactor BreakOutsideOfLoop diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -22/+4 | |
| | | ||||||
* | | internal: refactor NoSuchField diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -24/+3 | |
| | | ||||||
* | | internal: refactor unimplemented builtin macro diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -26/+12 | |
| | | ||||||
* | | internal: refactor macro error | Aleksey Kladov | 2021-06-13 | 2 | -33/+13 | |
| | | ||||||
* | | internal: refactor unresolved proc macro diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -50/+17 | |
| | | ||||||
* | | internal: refactor inactive code diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -41/+15 | |
| | | ||||||
* | | internal: refactor unresolved macro call diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -38/+19 | |
| | | ||||||
* | | internal: refactor unresolved import diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -26/+6 | |
| | | ||||||
* | | internal: refactor unresolved extern crate diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -25/+8 | |
| | | ||||||
* | | internal: unified missing fields diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -107/+62 | |
| | | ||||||
* | | internal: move missing_fields diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -56/+20 | |
| | | ||||||
* | | internal: start new diagnostics API | Aleksey Kladov | 2021-06-13 | 2 | -34/+37 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics. | |||||
* | | clippy::clone_on_copy | Maan2003 | 2021-06-13 | 1 | -1/+1 | |
| | | ||||||
* | | clippy::redudant_borrow | Maan2003 | 2021-06-13 | 3 | -9/+9 | |
| | | ||||||
* | | internal: move diagnostics infra to hir | Aleksey Kladov | 2021-06-12 | 3 | -17/+159 | |
| | | ||||||
* | | Move some hir_ty diagnostics to hir | Aleksey Kladov | 2021-06-12 | 2 | -17/+421 | |
| | | ||||||
* | | minor: optimize | Aleksey Kladov | 2021-06-12 | 2 | -3/+5 | |
| | | | | | | | | | | We shouldn't be looking at the source map unless we actually have diagnostics. | |||||
* | | internal: move missing unsafe diagnostic to hir | Aleksey Kladov | 2021-06-12 | 2 | -4/+40 | |
| | | ||||||
* | | internal: move inference diagnostics to hir | Aleksey Kladov | 2021-06-12 | 2 | -4/+72 | |
| | | ||||||
* | | Merge #9218 | bors[bot] | 2021-06-11 | 1 | -0/+14 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 9218: Item search now respects trait impl items r=Veykril a=Veykril Fixes #2977 Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | | Item search now respects trait impl items | Lukas Wirth | 2021-06-11 | 1 | -0/+14 | |
| |/ | ||||||
* / | Add more profiling for flyimports | Kirill Bulatov | 2021-06-10 | 1 | -0/+4 | |
|/ | ||||||
* | Implement dummy expansions for builtin attributes | Lukas Wirth | 2021-06-09 | 1 | -0/+1 | |
| | ||||||
* | Merge #9191 | bors[bot] | 2021-06-09 | 1 | -2/+10 | |
|\ | | | | | | | | | | | | | | | 9191: fix: Don't descend MacroCall TokenTree delimiters r=jonas-schievink a=Veykril Fixes #9190 Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | Don't descend MacroCall TokenTree delimiters | Lukas Wirth | 2021-06-09 | 1 | -2/+10 | |
| | | ||||||
| | | ||||||
| \ | ||||||
*-. \ | Merge #9181 #9182 | bors[bot] | 2021-06-08 | 2 | -1/+21 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9181: Don't complete values in type position r=jonas-schievink a=Veykril Will add some proper tests in a bit 9182: fix: don't complete derive macros as fn-like macros r=jonas-schievink a=jonas-schievink Part of https://github.com/rust-analyzer/rust-analyzer/issues/8518 bors r+ Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> | |||||
| | * | | fix: don't complete derive macros as fn-like macros | Jonas Schievink | 2021-06-08 | 1 | -0/+7 | |
| | |/ | ||||||
| * / | Don't complete values in type position | Lukas Wirth | 2021-06-08 | 2 | -1/+14 | |
| |/ | ||||||
* / | source_to_def: skip items with no def | Jonas Schievink | 2021-06-08 | 1 | -50/+56 | |
|/ |