aboutsummaryrefslogtreecommitdiff
path: root/crates/hir
Commit message (Collapse)AuthorAgeFilesLines
* Implement HirDisplay for some more typesLukas Wirth2021-03-161-2/+28
|
* Merge #7498bors[bot]2021-03-161-6/+24
|\ | | | | | | | | | | | | | | | | | | 7498: Clone for update r=matklad a=matklad rowan counterpart https://github.com/rust-analyzer/rowan/pull/93 #6857 Co-authored-by: Aleksey Kladov <[email protected]>
| * Upgrade rowanAleksey Kladov2021-03-161-6/+24
| | | | | | | | Notably, new rowan comes with support for mutable syntax trees.
| |
| \
*-. \ Merge #7900 #8000bors[bot]2021-03-162-24/+502
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * Pretty print root module of extern cratesoxalica2021-03-151-0/+4
| | |
| | * Fix trait type parameteroxalica2021-03-151-1/+7
| | |
| | * Use hir formatter moreoxalica2021-03-152-3/+213
| | |
| | * Impl HirDisplay for function hover messageoxalica2021-03-152-4/+247
| | |
| | * Introduce FunctionQualifier for hir::FunctionDataoxalica2021-03-151-1/+1
| | |
| | * Collect HirDisplay impls to a single fileoxalica2021-03-152-20/+27
| | |
| * | show function params in completion detailJosh Mcguigan2021-03-121-0/+8
| | |
* | | 7709: Import changes.Chetan Khilosiya2021-03-151-4/+2
| | |
* | | 7709: Added the check for return type of len function.Chetan Khilosiya2021-03-151-0/+7
| | |
* | | Return multiple modules in `parent_module`Lukas Wirth2021-03-153-10/+21
| |/ |/|
* | Merge #8020bors[bot]2021-03-151-14/+44
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8020: Power up goto_implementation r=matklad a=Veykril by allowing it to be invoked on references of names, now showing all (trait) implementations of the given type in all crates instead of just the defining crate as well as including support for builtin types ![image](https://user-images.githubusercontent.com/3757771/111144403-52bb0700-8587-11eb-9205-7a2a5b8b75a3.png) Example screenshot of `impl`s of Box in `log`, `alloc`, `std` and the current crate. Before you had to invoke it on the definition where it would only show the `impls` in `alloc`. Co-authored-by: Lukas Wirth <[email protected]>
| * | goto_implementation: Look at the entire crate graph for trait implsLukas Wirth2021-03-151-8/+3
| | |
| * | Speedup trait impl search for goto_implementationLukas Wirth2021-03-151-2/+10
| | |
| * | Power up goto_implementationLukas Wirth2021-03-151-13/+40
| | | | | | | | | | | | | | | by allowing it to be invoked on references of names, showing all (trait) implementations of the given type in all crates including builtin types
* | | Merge #8018bors[bot]2021-03-151-5/+29
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8018: Make Ty wrap TyKind in an Arc r=flodiebold a=flodiebold ... to further move towards Chalk. This is a bit of a slowdown (218ginstr vs 213ginstr for inference on RA), even though it allows us to unwrap the Substs in `TyKind::Ref` etc.. Co-authored-by: Florian Diebold <[email protected]>
| * | | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-141-5/+29
| |/ /
* | | Simplify source maps for fieldsAleksey Kladov2021-03-151-21/+3
| | |
* | | Goto definition works for `S { a: }` caseAleksey Kladov2021-03-151-3/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | What happens here is that we lower `: ` to a missing expression, and then correctly record that the corresponding field expression resolves to a specific field. Where we fail is in the mapping of syntax to this missing expression. Doing it via `ast_field.expr()` fails, as that expression is `None`. Instead, we go in the opposite direcition and ask each lowered field about its source. This works, but has wrong complexity `O(N)` and, really, the implementation is just too complex. We need some better management of data here.
* | | some clippy::performance fixesMatthias Krüger2021-03-151-2/+1
|/ / | | | | | | | | | | | | use vec![] instead of Vec::new() + push() avoid redundant clones use chars instead of &str for single char patterns in ends_with() and starts_with() allocate some Vecs with capacity to avoid unneccessary resizing
* | More renamingFlorian Diebold2021-03-141-1/+1
| |
* | Rename some fields to their Chalk namesFlorian Diebold2021-03-141-2/+2
| |
* | Move type lowering methods to TyLoweringContextFlorian Diebold2021-03-131-3/+3
| |
* | Create TraitEnvironment through a queryFlorian Diebold2021-03-131-5/+7
| |
* | Use chalk_ir::PlaceholderIndexFlorian Diebold2021-03-131-1/+1
| |
* | Use chalk_ir::FnDefIdFlorian Diebold2021-03-131-4/+1
| |
* | Use chalk_ir::AssocTypeIdFlorian Diebold2021-03-131-2/+5
| |
* | Separate `Ty` and `TyKind` like in ChalkFlorian Diebold2021-03-131-33/+34
|/ | | | | Currently `Ty` just wraps `TyKind`, but this allows us to change most places to already use `intern` / `interned`.
* Avoid double text edits when renaming mod declarationLukas Wirth2021-03-101-1/+0
|
* Delete `ContainerId`Jonas Schievink2021-03-091-21/+9
|
* Stop using `ContainerId` in `AssocContainerId`Jonas Schievink2021-03-091-2/+2
|
* Merge #7942bors[bot]2021-03-091-7/+1
|\ | | | | | | | | | | | | | | 7942: Show whether a binding is mutable or not on hover r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * Show whether a binding is mutable or not on hoverLukas Wirth2021-03-091-7/+1
| |
* | Cleanup auto-ref in completionAleksey Kladov2021-03-091-4/+3
|/
* Merge #7873 #7933bors[bot]2021-03-091-0/+11
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7873: Consider unresolved qualifiers during flyimport r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/7679 Takes unresolved qualifiers into account, providing better completions (or none, if the path is resolved or do not match). Does not handle cases when both path qualifier and some trait has to be imported: there are many extra issues with those (such as overlapping imports, for instance) that will require large diffs to address. Also does not do a fuzzy search on qualifier, that requires some adjustments in `import_map` for better queries and changes to the default replace range which also seems relatively big to include here. ![qualifier_completion](https://user-images.githubusercontent.com/2690773/110040808-0af8dc00-7d4c-11eb-83db-65af94e843bb.gif) 7933: Improve compilation speed r=matklad a=matklad bors r+ 🤖 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| * Less lifetines: derive SemanticsScope in placeKirill Bulatov2021-03-081-1/+1
| |
| * Refactor the import locationKirill Bulatov2021-03-081-0/+11
| |
| * Do not propose already imported importsKirill Bulatov2021-03-081-1/+1
| |
* | Use `Type::new_with_resolver_inner` moreJonas Schievink2021-03-091-26/+14
|/
* Hygiene is an internal implementation detail of the compilerAleksey Kladov2021-03-081-2/+5
|
* Remove useless code_model indirectionAleksey Kladov2021-03-085-2132/+2120
|
* Rename a few `crate_def_map`s to `def_map`Jonas Schievink2021-03-061-3/+3
| | | | These could all be block `DefMap`s instead of crate-level `DefMap`s
* Use chalk_ir::AdtIdLukas Wirth2021-03-041-3/+3
|
* Show docs on hover for keywords and primitivesLukas Wirth2021-03-021-6/+5
|
* Use chalk_ir::MutabilityLukas Wirth2021-03-011-5/+8
|
* Introduce Ty::AliasLukas Wirth2021-03-011-4/+4
|
* Being Ty::InferenceVar closes to chalk equivalentLukas Wirth2021-03-011-2/+2
|