aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src/infer/expr.rs
Commit message (Collapse)AuthorAgeFilesLines
* Record type mismatches for failed coercions in match etc.Florian Diebold2021-05-211-10/+12
|
* Refactor expectation handlingFlorian Diebold2021-05-211-30/+49
| | | | So as to not use `TyKind::Error` as "no expectation".
* Get rid of resolve_ty_as_possibleFlorian Diebold2021-05-211-13/+15
| | | | Instead use shallow resolving where necessary.
* Rework obligation handlingFlorian Diebold2021-05-211-3/+3
| | | | | | | | We can't do the easy hack that we did before anymore, where we kept track of whether any inference variables changed since the last time we rechecked obligations. Instead, we store the obligations in canonicalized form; that way we can easily check the inference variables to see whether they have changed since the goal was canonicalized.
* Fix if/else coercionFlorian Diebold2021-05-211-1/+4
|
* Remove our unification code, use Chalk's insteadFlorian Diebold2021-05-211-6/+6
|
* internal: Record mismatches of pattern types.Dawer2021-05-191-4/+5
|
* Address final feedbackJade2021-05-161-3/+2
| | | | | * rename ConstExtension->ConstExt * refactor a manual construction of a Const
* Add more tests, refactor array lengths/consteval workJade2021-05-141-33/+8
| | | | | | | | | | | Fix #2922: add unknown length as a condition for a type having unknown. Incorporate reviews: * Extract some of the const evaluation workings into functions * Add fixmes on the hacks * Add tests for impls on specific array lengths (these work!!! 😁) * Add tests for const generics (indeed we don't support it yet)
* Add support for lengths in array repeats, if they are literalsJade2021-05-131-6/+16
| | | | Now we will get the type of `[0u8; 4]`.
* Support length for ByteStringsJade2021-05-131-6/+14
| | | | I am not confident that my added byte string parsing is right.
* Add lowering of array lengths in typesJade2021-05-131-4/+4
| | | | | | | | | | | Now e.g. ```rust fn a(b: [u8; 2]) { } ``` will know about the length of b.
* Merge #8799bors[bot]2021-05-121-6/+20
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | 8799: Add basic support for array lengths in types r=flodiebold a=lf- This recognizes `let a = [1u8, 2, 3]` as having type `[u8; 3]` instead of the previous `[u8; _]`. Byte strings and `[0u8; 2]` kinds of range array declarations are unsupported as before. I don't know why a bunch of our rustc tests had single quotes inside strings un-escaped by `UPDATE_EXPECT=1 cargo t`, but I don't think it's bad? Maybe something in a nightly? Co-authored-by: Jade <[email protected]>
| * address review by @eddybJade2021-05-111-1/+1
| |
| * Add basic support for array lengths in typesJade2021-05-111-6/+20
| | | | | | | | | | | | | | | | | | | | This recognizes `let a = [1u8, 2, 3]` as having type `[u8; 3]` instead of the previous `[u8; _]`. Byte strings and `[0u8; 2]` kinds of range array declarations are unsupported as before. I don't know why a bunch of our rustc tests had single quotes inside strings un-escaped by `UPDATE_EXPECT=1 cargo t`, but I don't think it's bad? Maybe something in a nightly?
* | Fix inference with conditionally compiled tailsDaniel McNab2021-05-031-1/+1
|/ | | | Fixes #8378
* Move ToChalk -> mappingFlorian Diebold2021-04-091-1/+1
|
* Reorganize hir_ty modulesFlorian Diebold2021-04-091-1/+2
| | | | | Chalk isn't really a 'traits' thing anymore, so it doesn't make sense to have all the Chalk-related stuff in submodules of `traits`.
* CleanupFlorian Diebold2021-04-081-1/+5
|
* Intern SubstitutionsFlorian Diebold2021-04-081-1/+1
| | | | (Costs a bit of performance, reduces memory usage on RA by ~10%.)
* Remove unusedFlorian Diebold2021-04-081-1/+0
|
* Fix shifted_{in,out} callsFlorian Diebold2021-04-081-1/+1
|
* Remove Ty::substs{_mut}Florian Diebold2021-04-071-1/+4
| | | | | | Almost all uses actually only care about ADT substs, so it's better to be explicit. The methods were a bad abstraction anyway since they already didn't include the inner types of e.g. `TyKind::Ref` anymore.
* infer: remove `record_field_resolutions` fieldJonas Schievink2021-04-061-5/+2
| | | | | It stores no useful data, since we can derive all fields from `variant_resolutions`
* Merge #8364bors[bot]2021-04-061-2/+8
|\ | | | | | | | | | | | | | | | | | | 8364: Memory usage improvements r=jonas-schievink a=alexmaco These are mostly focused on splitting up enum variants with large size differences between variants by `Box`-ing things up. In my testing this reduces the memory usage somewhere in the low percentages, even though the measurements are quite noisy. Co-authored-by: Alexandru Macovei <[email protected]>
| * Use Box'es to reduce size of hir_def::expr::Expr from 128 to 72 bytes (on ↵Alexandru Macovei2021-04-061-2/+8
| | | | | | | | | | | | | | | | | | | | 64bit systems) Rationale: only a minority of variants used almost half the size. By keeping large members (especially in Option) behind a box the memory cost is only payed when the large variants are needed. This reduces the size Vec<Expr> needs to allocate.
* | Move Ty accessors to TyExtLukas Wirth2021-04-061-1/+2
| |
* | Add chalk_ir::Const to TyKind::ArrayLukas Wirth2021-04-061-4/+5
| |
* | Use a constructor function for Static lifetimesLukas Wirth2021-04-061-13/+8
| |
* | Add Lifetime to TyKind::RefLukas Wirth2021-04-061-7/+15
|/
* Fix shifting of binders in FnPointerFlorian Diebold2021-04-051-2/+4
| | | | | | | | | - don't shift in/out for Chalk mapping (we want to have the same binders now) - do shift in when creating the signature for a closure (though it shouldn't matter much) - do shift in when lowering a `fn()` type - correctly deal with the implied binder in TypeWalk
* Align FnPointer with ChalkFlorian Diebold2021-04-051-4/+4
|
* Substitution::prefix -> subst_prefixFlorian Diebold2021-04-051-2/+4
| | | | I probably want to get rid of this function completely later.
* Substitution::single -> from1Florian Diebold2021-04-051-2/+4
|
* Move ProjectionTy methods to extension traitFlorian Diebold2021-04-051-2/+2
|
* Add Interner parameter to Binders::substituteFlorian Diebold2021-04-051-6/+8
|
* Binders::subst -> substituteFlorian Diebold2021-04-051-5/+5
|
* Use VariableKinds in BindersFlorian Diebold2021-04-051-2/+2
|
* Move things from `traits` module to `types` as wellFlorian Diebold2021-04-041-3/+3
|
* Move things in hir_ty into submodulesFlorian Diebold2021-04-041-5/+1
| | | | | - all the types that will be replaced by Chalk go to `types` - `TypeWalk` impls go to `walk`
* Replace last uses of SubstsBuilder by TyBuilderFlorian Diebold2021-04-041-2/+1
|
* Some more TyBuilder useFlorian Diebold2021-04-041-29/+25
|
* Add TyBuilder::adtFlorian Diebold2021-04-041-17/+10
|
* Add TyBuilder::unit() and TyExt::is_unit()Florian Diebold2021-04-041-11/+11
|
* Rename Ty::interned to Ty::kindFlorian Diebold2021-04-031-6/+6
| | | | ... since that's the actual method on Chalk side that matches the signature.
* Introduce `GenericArg` like in ChalkFlorian Diebold2021-04-031-10/+14
| | | | | | | Plus some more adaptations to Substitution. Lots of `assert_ty_ref` that we should revisit when introducing lifetime/const parameters.
* Don't recheck obligations if we have learned nothing newFlorian Diebold2021-04-011-3/+3
| | | | | | | | | | This is just the most trivial check: If no inference variables have been updated, and there are no new obligations, we can just skip trying to solve them again. We could be smarter about it, but this already helps quite a bit, and I don't want to touch this too much before we replace the inference table by Chalk's. Fixes #8263 (well, improves it quite a bit).
* internal: ensure that runaway type-inference doesn't block the main loopAleksey Kladov2021-03-291-0/+2
| | | | | | We have a bug where type-checking `per_query_memory_usage` takes a couple of seconds. It also reveals another bug: our type inference is not cancellable.
* Fix recursive macro statement expansionEdwin Cheng2021-03-251-0/+1
|
* Merge #7907bors[bot]2021-03-241-12/+33
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7907: Autoderef with visibility r=cynecx a=cynecx Fixes https://github.com/rust-analyzer/rust-analyzer/issues/7841. I am not sure about the general approach here. Right now this simply tries to check whether the autoderef candidate is reachable from the current module. ~~However this doesn't exactly work with traits (see the `tests::macros::infer_derive_clone_in_core` test, which fails right now).~~ see comment below Refs: - `rustc_typeck` checking fields: https://github.com/rust-lang/rust/blob/66ec64ccf31883cd2c28d045912a76179c0c6ed2/compiler/rustc_typeck/src/check/expr.rs#L1610 r? @flodiebold Co-authored-by: cynecx <[email protected]>