aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src/traits
Commit message (Collapse)AuthorAgeFilesLines
* Fix return type of `self_type_parameter`Florian Diebold2021-04-071-2/+2
|
* Move hir_trait_id to extension traitFlorian Diebold2021-04-072-4/+4
|
* Remove `SolutionVariables`, add ConstrainedSubst analogous to ChalkFlorian Diebold2021-04-061-2/+14
| | | | ... just missing the constraints.
* Clean up Chalk mapping a bitFlorian Diebold2021-04-061-69/+37
|
* Move Ty accessors to TyExtLukas Wirth2021-04-061-1/+1
|
* Add chalk_ir::Const to TyKind::ArrayLukas Wirth2021-04-061-13/+8
|
* Use a constructor function for Static lifetimesLukas Wirth2021-04-061-7/+7
|
* Always use Static lifetimes in chalk mappingLukas Wirth2021-04-061-1/+2
|
* Add Lifetime to DynTyLukas Wirth2021-04-061-0/+1
|
* Add Lifetime to TyKind::RefLukas Wirth2021-04-061-5/+5
|
* Fix shifting of binders in FnPointerFlorian Diebold2021-04-051-6/+3
| | | | | | | | | - don't shift in/out for Chalk mapping (we want to have the same binders now) - do shift in when creating the signature for a closure (though it shouldn't matter much) - do shift in when lowering a `fn()` type - correctly deal with the implied binder in TypeWalk
* Align FnPointer with ChalkFlorian Diebold2021-04-051-5/+5
|
* Binders::wrap_empty -> wrap_empty_bindersFlorian Diebold2021-04-051-6/+2
|
* Substitution::single -> from1Florian Diebold2021-04-051-2/+4
|
* Move ProjectionTy methods to extension traitFlorian Diebold2021-04-051-3/+3
|
* Use more assoc. type aliases in the chalk internerJonas Schievink2021-04-051-22/+21
| | | | Makes it sligthly easier to swap out these types
* Rename shift_bound_vars{_out} to align with ChalkFlorian Diebold2021-04-051-1/+1
|
* Add Interner parameter to Binders::substituteFlorian Diebold2021-04-051-1/+1
|
* Binders::subst -> substituteFlorian Diebold2021-04-051-1/+1
|
* Use VariableKinds in BindersFlorian Diebold2021-04-052-18/+14
|
* Hide Binders internals moreFlorian Diebold2021-04-052-28/+32
|
* Pass interner to TraitRef::self_type_parameterLaurențiu Nicola2021-04-051-1/+1
|
* Pass interner to ProjectionTy::self_type_parameterLaurențiu Nicola2021-04-051-1/+1
|
* Rename TyKind::ForeignType to ForeignLaurențiu Nicola2021-04-051-2/+2
|
* Rename TyKind::Unknown to ErrorLaurențiu Nicola2021-04-052-4/+4
|
* Move things from `traits` module to `types` as wellFlorian Diebold2021-04-041-5/+3
|
* Move things in hir_ty into submodulesFlorian Diebold2021-04-041-5/+5
| | | | | - all the types that will be replaced by Chalk go to `types` - `TypeWalk` impls go to `walk`
* Replace Substitution::bound_vars and ::type_params_for_genericsFlorian Diebold2021-04-041-5/+5
|
* Add TyBuilder::unit() and TyExt::is_unit()Florian Diebold2021-04-041-2/+2
|
* Rename Ty::interned to Ty::kindFlorian Diebold2021-04-031-1/+1
| | | | ... since that's the actual method on Chalk side that matches the signature.
* Introduce `GenericArg` like in ChalkFlorian Diebold2021-04-032-17/+32
| | | | | | | Plus some more adaptations to Substitution. Lots of `assert_ty_ref` that we should revisit when introducing lifetime/const parameters.
* Fix chalk_ir assertionFlorian Diebold2021-03-241-5/+3
| | | | Fixes #8150.
* Align InEnvironment with ChalkFlorian Diebold2021-03-211-4/+1
| | | | | | This in particular means storing a chalk_ir::Environment, not our TraitEnvironment. This makes InEnvironment not usable for Type, where we need to keep the full TraitEnvironment.
* Align Canonical more with Chalk's versionFlorian Diebold2021-03-211-25/+2
| | | | In particular, use chalk_ir::CanonicalVarKinds.
* Use QuantifiedWhereClause in generic_predicates as wellFlorian Diebold2021-03-211-1/+1
| | | | | Still far too much binder skipping going on; I find it hard to imagine this is all correct, but the tests pass.
* Introduce QuantifiedWhereClause and DynTy analogous to ChalkFlorian Diebold2021-03-212-44/+60
| | | | | This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point.
* Ignore type bindings in generic_predicates_for_paramFlorian Diebold2021-03-211-1/+1
| | | | | | | | | | | | | This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine.
* Turn Obligation into something similar to chalk_ir::DomainGoalFlorian Diebold2021-03-201-4/+6
| | | | This includes starting to make use of Chalk's `Cast` trait.
* Remove WhereClause::ErrorFlorian Diebold2021-03-202-13/+2
| | | | | Chalk doesn't have it, and judging from the removed code, it wasn't useful anyway.
* Rename GenericPredicate -> WhereClauseFlorian Diebold2021-03-202-18/+16
|
* Replace Projection variant in GenericPredicate with AliasEqLukas Wirth2021-03-192-41/+67
|
* Chalkify TraitRefFlorian Diebold2021-03-182-13/+12
|
* avoid converting types into themselves via .into() (clippy::useless-conversion)Matthias Krüger2021-03-171-1/+1
| | | | example: let x: String = String::from("hello world").into();
* Rename Substs -> SubstitutionFlorian Diebold2021-03-162-15/+18
|
*-. Merge #7900 #8000bors[bot]2021-03-161-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * Use hir formatter moreoxalica2021-03-151-1/+1
| | |
* | | Use SmallVec for SubstsFlorian Diebold2021-03-151-3/+4
| |/ |/| | | | | | | Doesn't help as much as I hoped, but it helps a bit and I also did some refactorings that were necessary anyway.
* | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-141-17/+13
| |
* | Make Ty wrap TyKind in an ArcFlorian Diebold2021-03-141-1/+1
| | | | | | | | | | | | | | | | ... like it will be in Chalk. We still keep `interned_mut` and `into_inner` methods that will probably not exist with Chalk. This worsens performance slightly (5ginstr inference on RA), but doesn't include other simplifications we can do yet.
* | More renamingFlorian Diebold2021-03-141-10/+8
| |