Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make ToChalk implementations identity | Florian Diebold | 2021-04-08 | 1 | -258/+41 |
| | |||||
* | Fix return type of `self_type_parameter` | Florian Diebold | 2021-04-07 | 1 | -2/+2 |
| | |||||
* | Move hir_trait_id to extension trait | Florian Diebold | 2021-04-07 | 2 | -4/+4 |
| | |||||
* | Remove `SolutionVariables`, add ConstrainedSubst analogous to Chalk | Florian Diebold | 2021-04-06 | 1 | -2/+14 |
| | | | | ... just missing the constraints. | ||||
* | Clean up Chalk mapping a bit | Florian Diebold | 2021-04-06 | 1 | -69/+37 |
| | |||||
* | Move Ty accessors to TyExt | Lukas Wirth | 2021-04-06 | 1 | -1/+1 |
| | |||||
* | Add chalk_ir::Const to TyKind::Array | Lukas Wirth | 2021-04-06 | 1 | -13/+8 |
| | |||||
* | Use a constructor function for Static lifetimes | Lukas Wirth | 2021-04-06 | 1 | -7/+7 |
| | |||||
* | Always use Static lifetimes in chalk mapping | Lukas Wirth | 2021-04-06 | 1 | -1/+2 |
| | |||||
* | Add Lifetime to DynTy | Lukas Wirth | 2021-04-06 | 1 | -0/+1 |
| | |||||
* | Add Lifetime to TyKind::Ref | Lukas Wirth | 2021-04-06 | 1 | -5/+5 |
| | |||||
* | Fix shifting of binders in FnPointer | Florian Diebold | 2021-04-05 | 1 | -6/+3 |
| | | | | | | | | | - don't shift in/out for Chalk mapping (we want to have the same binders now) - do shift in when creating the signature for a closure (though it shouldn't matter much) - do shift in when lowering a `fn()` type - correctly deal with the implied binder in TypeWalk | ||||
* | Align FnPointer with Chalk | Florian Diebold | 2021-04-05 | 1 | -5/+5 |
| | |||||
* | Binders::wrap_empty -> wrap_empty_binders | Florian Diebold | 2021-04-05 | 1 | -6/+2 |
| | |||||
* | Substitution::single -> from1 | Florian Diebold | 2021-04-05 | 1 | -2/+4 |
| | |||||
* | Move ProjectionTy methods to extension trait | Florian Diebold | 2021-04-05 | 1 | -3/+3 |
| | |||||
* | Use more assoc. type aliases in the chalk interner | Jonas Schievink | 2021-04-05 | 1 | -22/+21 |
| | | | | Makes it sligthly easier to swap out these types | ||||
* | Rename shift_bound_vars{_out} to align with Chalk | Florian Diebold | 2021-04-05 | 1 | -1/+1 |
| | |||||
* | Add Interner parameter to Binders::substitute | Florian Diebold | 2021-04-05 | 1 | -1/+1 |
| | |||||
* | Binders::subst -> substitute | Florian Diebold | 2021-04-05 | 1 | -1/+1 |
| | |||||
* | Use VariableKinds in Binders | Florian Diebold | 2021-04-05 | 2 | -18/+14 |
| | |||||
* | Hide Binders internals more | Florian Diebold | 2021-04-05 | 2 | -28/+32 |
| | |||||
* | Pass interner to TraitRef::self_type_parameter | Laurențiu Nicola | 2021-04-05 | 1 | -1/+1 |
| | |||||
* | Pass interner to ProjectionTy::self_type_parameter | Laurențiu Nicola | 2021-04-05 | 1 | -1/+1 |
| | |||||
* | Rename TyKind::ForeignType to Foreign | Laurențiu Nicola | 2021-04-05 | 1 | -2/+2 |
| | |||||
* | Rename TyKind::Unknown to Error | Laurențiu Nicola | 2021-04-05 | 2 | -4/+4 |
| | |||||
* | Move things from `traits` module to `types` as well | Florian Diebold | 2021-04-04 | 1 | -5/+3 |
| | |||||
* | Move things in hir_ty into submodules | Florian Diebold | 2021-04-04 | 1 | -5/+5 |
| | | | | | - all the types that will be replaced by Chalk go to `types` - `TypeWalk` impls go to `walk` | ||||
* | Replace Substitution::bound_vars and ::type_params_for_generics | Florian Diebold | 2021-04-04 | 1 | -5/+5 |
| | |||||
* | Add TyBuilder::unit() and TyExt::is_unit() | Florian Diebold | 2021-04-04 | 1 | -2/+2 |
| | |||||
* | Rename Ty::interned to Ty::kind | Florian Diebold | 2021-04-03 | 1 | -1/+1 |
| | | | | ... since that's the actual method on Chalk side that matches the signature. | ||||
* | Introduce `GenericArg` like in Chalk | Florian Diebold | 2021-04-03 | 2 | -17/+32 |
| | | | | | | | Plus some more adaptations to Substitution. Lots of `assert_ty_ref` that we should revisit when introducing lifetime/const parameters. | ||||
* | Fix chalk_ir assertion | Florian Diebold | 2021-03-24 | 1 | -5/+3 |
| | | | | Fixes #8150. | ||||
* | Align InEnvironment with Chalk | Florian Diebold | 2021-03-21 | 1 | -4/+1 |
| | | | | | | This in particular means storing a chalk_ir::Environment, not our TraitEnvironment. This makes InEnvironment not usable for Type, where we need to keep the full TraitEnvironment. | ||||
* | Align Canonical more with Chalk's version | Florian Diebold | 2021-03-21 | 1 | -25/+2 |
| | | | | In particular, use chalk_ir::CanonicalVarKinds. | ||||
* | Use QuantifiedWhereClause in generic_predicates as well | Florian Diebold | 2021-03-21 | 1 | -1/+1 |
| | | | | | Still far too much binder skipping going on; I find it hard to imagine this is all correct, but the tests pass. | ||||
* | Introduce QuantifiedWhereClause and DynTy analogous to Chalk | Florian Diebold | 2021-03-21 | 2 | -44/+60 |
| | | | | | This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point. | ||||
* | Ignore type bindings in generic_predicates_for_param | Florian Diebold | 2021-03-21 | 1 | -1/+1 |
| | | | | | | | | | | | | | This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine. | ||||
* | Turn Obligation into something similar to chalk_ir::DomainGoal | Florian Diebold | 2021-03-20 | 1 | -4/+6 |
| | | | | This includes starting to make use of Chalk's `Cast` trait. | ||||
* | Remove WhereClause::Error | Florian Diebold | 2021-03-20 | 2 | -13/+2 |
| | | | | | Chalk doesn't have it, and judging from the removed code, it wasn't useful anyway. | ||||
* | Rename GenericPredicate -> WhereClause | Florian Diebold | 2021-03-20 | 2 | -18/+16 |
| | |||||
* | Replace Projection variant in GenericPredicate with AliasEq | Lukas Wirth | 2021-03-19 | 2 | -41/+67 |
| | |||||
* | Chalkify TraitRef | Florian Diebold | 2021-03-18 | 2 | -13/+12 |
| | |||||
* | avoid converting types into themselves via .into() (clippy::useless-conversion) | Matthias Krüger | 2021-03-17 | 1 | -1/+1 |
| | | | | example: let x: String = String::from("hello world").into(); | ||||
* | Rename Substs -> Substitution | Florian Diebold | 2021-03-16 | 2 | -15/+18 |
| | |||||
*-. | Merge #7900 #8000 | bors[bot] | 2021-03-16 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]> | ||||
| | * | Use hir formatter more | oxalica | 2021-03-15 | 1 | -1/+1 |
| | | | |||||
* | | | Use SmallVec for Substs | Florian Diebold | 2021-03-15 | 1 | -3/+4 |
| |/ |/| | | | | | | | Doesn't help as much as I hoped, but it helps a bit and I also did some refactorings that were necessary anyway. | ||||
* | | Don't use Substs for Ref/Raw/Array/Slice | Florian Diebold | 2021-03-14 | 1 | -17/+13 |
| | | |||||
* | | Make Ty wrap TyKind in an Arc | Florian Diebold | 2021-03-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | ... like it will be in Chalk. We still keep `interned_mut` and `into_inner` methods that will probably not exist with Chalk. This worsens performance slightly (5ginstr inference on RA), but doesn't include other simplifications we can do yet. |