aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src/traits
Commit message (Collapse)AuthorAgeFilesLines
* Rename Substs -> SubstitutionFlorian Diebold2021-03-162-15/+18
|
*-. Merge #7900 #8000bors[bot]2021-03-161-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * Use hir formatter moreoxalica2021-03-151-1/+1
| | |
* | | Use SmallVec for SubstsFlorian Diebold2021-03-151-3/+4
| |/ |/| | | | | | | Doesn't help as much as I hoped, but it helps a bit and I also did some refactorings that were necessary anyway.
* | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-141-17/+13
| |
* | Make Ty wrap TyKind in an ArcFlorian Diebold2021-03-141-1/+1
| | | | | | | | | | | | | | | | ... like it will be in Chalk. We still keep `interned_mut` and `into_inner` methods that will probably not exist with Chalk. This worsens performance slightly (5ginstr inference on RA), but doesn't include other simplifications we can do yet.
* | More renamingFlorian Diebold2021-03-141-10/+8
| |
* | Use chalk_ir::FnSigFlorian Diebold2021-03-141-10/+9
| |
* | Rename some fields to their Chalk namesFlorian Diebold2021-03-142-13/+13
| |
* | Move type lowering methods to TyLoweringContextFlorian Diebold2021-03-131-1/+1
| |
* | Use chalk_ir::OpaqueTyIdFlorian Diebold2021-03-132-26/+9
| |
* | Use chalk_ir::PlaceholderIndexFlorian Diebold2021-03-131-19/+3
| |
* | Use chalk_ir::ClosureIdFlorian Diebold2021-03-132-11/+6
| |
* | Use chalk_ir::FnDefIdFlorian Diebold2021-03-133-6/+4
| |
* | Use chalk_ir::AssocTypeIdFlorian Diebold2021-03-133-47/+26
| |
* | Use chalk_ir::ForeignDefIdFlorian Diebold2021-03-132-23/+2
| |
* | Separate `Ty` and `TyKind` like in ChalkFlorian Diebold2021-03-132-58/+65
|/ | | | | Currently `Ty` just wraps `TyKind`, but this allows us to change most places to already use `intern` / `interned`.
* Simplify a bitFlorian Diebold2021-03-121-10/+5
|
* Use Chalk Environment more directlyFlorian Diebold2021-03-122-35/+7
|
* Delete `ContainerId`Jonas Schievink2021-03-091-2/+2
|
* Use chalk_ir::AdtIdLukas Wirth2021-03-042-22/+8
|
* Use chalk_ir::MutabilityLukas Wirth2021-03-011-22/+6
|
* Introduce Ty::AliasLukas Wirth2021-03-012-15/+15
|
* Being Ty::InferenceVar closes to chalk equivalentLukas Wirth2021-03-011-22/+10
|
* Lift FnPointer into a structLukas Wirth2021-02-282-19/+14
|
* Remove Substs from Ty::ForeignTypeLukas Wirth2021-02-281-5/+4
|
* Turn Ty::Tuple variant into a tuple-variantLukas Wirth2021-02-281-2/+2
|
* Inline TypeCtor into TyLukas Wirth2021-02-282-108/+90
|
* Use chalk_ir::Scalar directlyLukas Wirth2021-02-281-60/+4
|
* Introduce TypeCtor::ScalarLukas Wirth2021-02-281-80/+60
|
* Update crateskjeremy2021-02-081-2/+3
| | | | Pulls in https://github.com/rust-lang/chalk/pull/682
* Bump chalkLaurențiu Nicola2021-02-021-2/+2
|
* Make `ModuleId`'s `krate` field privateJonas Schievink2021-01-221-2/+2
|
* Bump chalkLaurențiu Nicola2020-12-231-2/+9
|
* Upgrade ChalkFlorian Diebold2020-12-073-6/+72
| | | | | | | Also make overflow depth and max type size configurable through env variables. This can be helpful at least for debugging. Fixes #6628.
* Remove more unreachable pubsAleksey Kladov2020-11-023-19/+19
|
* Deny unreachable-pubAleksey Kladov2020-11-021-27/+27
| | | | | | | | It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs https://github.com/rust-lang/cargo/issues/5034.
* Upgrade Chalk to 0.36Florian Diebold2020-10-304-316/+176
| | | | Quite a few changes, because Chalk got rid of the `ApplicationTy` nesting.
* Get rid of FAKE_PLACEHOLDERFlorian Diebold2020-10-251-8/+9
| | | | | The lifetime placeholder can be replaced by the static lifetime, and for array sizes we should just be using a concrete const.
* Make unimplemented match variants explicitCasey Primozic2020-10-071-1/+2
|
* `todo!()` -> `unimplemented!() // FIXME` for CICasey Primozic2020-10-062-3/+5
|
* Bump chalk to use latest git to get fixCasey Primozic2020-10-062-0/+13
| | | | * Chalk very recently (like an hour ago) merged a fix that prevents rust analyzer from panicking. This allows it to be usable again for code that hits those situations. See #6134, #6145, Probably #6120
* Update chalk to 0.28.0Bram van den Heuvel2020-09-251-2/+8
|
* Update chalk to 0.27 and adapt to chalk changes.Charles Lew2020-09-154-27/+76
|
* Merge #5971bors[bot]2020-09-132-21/+87
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5971: Implement async blocks r=flodiebold a=oxalica Fix #4018 @flodiebold already gave a generic guide in the issue. Here's some concern about implementation detail: - Chalk doesn't support generator type yet. - Adding generator type as a brand new type (ctor) can be complex and need to *re-introduced* builtin impls. (Like how we implement closures before native closure support of chalk, which is already removed in #5401 ) - The output type of async block should be known after type inference of the whole body. - We cannot directly get the type from source like return-positon-impl-trait. But we still need to provide trait bounds when chalk asking for `opaque_ty_data`. - During the inference, the output type of async block can be temporary unknown and participate the later inference. `let a = async { None }; let _: i32 = a.await.unwrap();` So in this PR, the type of async blocks is inferred as an opaque type parameterized by the `Future::Output` type it should be, like what we do with closure type. And it really works now. Well, I still have some questions: - The bounds `AsyncBlockImplType<T>: Future<Output = T>` is currently generated in `opaque_ty_data`. I'm not sure if we should put this code here. - Type of async block is now rendered as `impl Future<Output = OutputType>`. Do we need to special display to hint that it's a async block? Note that closure type has its special format, instead of `impl Fn(..) -> ..` or function type. Co-authored-by: oxalica <[email protected]>
| * Fix and prettify commentsoxalica2020-09-111-4/+6
| |
| * Implement async blocksoxalica2020-09-102-21/+85
| |
* | Tweak interner for chalkNathan Whitaker2020-09-091-9/+9
| |
* | Lookup ADT and assoc. type names for chalk debugNathan Whitaker2020-09-092-5/+21
|/
* Lookup adt namesWilco Kusee2020-08-141-1/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-02 16:31:17 +0000