aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src/traits
Commit message (Collapse)AuthorAgeFilesLines
* Rename Ty::interned to Ty::kindFlorian Diebold2021-04-031-1/+1
| | | | ... since that's the actual method on Chalk side that matches the signature.
* Introduce `GenericArg` like in ChalkFlorian Diebold2021-04-032-17/+32
| | | | | | | Plus some more adaptations to Substitution. Lots of `assert_ty_ref` that we should revisit when introducing lifetime/const parameters.
* Fix chalk_ir assertionFlorian Diebold2021-03-241-5/+3
| | | | Fixes #8150.
* Align InEnvironment with ChalkFlorian Diebold2021-03-211-4/+1
| | | | | | This in particular means storing a chalk_ir::Environment, not our TraitEnvironment. This makes InEnvironment not usable for Type, where we need to keep the full TraitEnvironment.
* Align Canonical more with Chalk's versionFlorian Diebold2021-03-211-25/+2
| | | | In particular, use chalk_ir::CanonicalVarKinds.
* Use QuantifiedWhereClause in generic_predicates as wellFlorian Diebold2021-03-211-1/+1
| | | | | Still far too much binder skipping going on; I find it hard to imagine this is all correct, but the tests pass.
* Introduce QuantifiedWhereClause and DynTy analogous to ChalkFlorian Diebold2021-03-212-44/+60
| | | | | This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point.
* Ignore type bindings in generic_predicates_for_paramFlorian Diebold2021-03-211-1/+1
| | | | | | | | | | | | | This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine.
* Turn Obligation into something similar to chalk_ir::DomainGoalFlorian Diebold2021-03-201-4/+6
| | | | This includes starting to make use of Chalk's `Cast` trait.
* Remove WhereClause::ErrorFlorian Diebold2021-03-202-13/+2
| | | | | Chalk doesn't have it, and judging from the removed code, it wasn't useful anyway.
* Rename GenericPredicate -> WhereClauseFlorian Diebold2021-03-202-18/+16
|
* Replace Projection variant in GenericPredicate with AliasEqLukas Wirth2021-03-192-41/+67
|
* Chalkify TraitRefFlorian Diebold2021-03-182-13/+12
|
* avoid converting types into themselves via .into() (clippy::useless-conversion)Matthias Krüger2021-03-171-1/+1
| | | | example: let x: String = String::from("hello world").into();
* Rename Substs -> SubstitutionFlorian Diebold2021-03-162-15/+18
|
*-. Merge #7900 #8000bors[bot]2021-03-161-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * Use hir formatter moreoxalica2021-03-151-1/+1
| | |
* | | Use SmallVec for SubstsFlorian Diebold2021-03-151-3/+4
| |/ |/| | | | | | | Doesn't help as much as I hoped, but it helps a bit and I also did some refactorings that were necessary anyway.
* | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-141-17/+13
| |
* | Make Ty wrap TyKind in an ArcFlorian Diebold2021-03-141-1/+1
| | | | | | | | | | | | | | | | ... like it will be in Chalk. We still keep `interned_mut` and `into_inner` methods that will probably not exist with Chalk. This worsens performance slightly (5ginstr inference on RA), but doesn't include other simplifications we can do yet.
* | More renamingFlorian Diebold2021-03-141-10/+8
| |
* | Use chalk_ir::FnSigFlorian Diebold2021-03-141-10/+9
| |
* | Rename some fields to their Chalk namesFlorian Diebold2021-03-142-13/+13
| |
* | Move type lowering methods to TyLoweringContextFlorian Diebold2021-03-131-1/+1
| |
* | Use chalk_ir::OpaqueTyIdFlorian Diebold2021-03-132-26/+9
| |
* | Use chalk_ir::PlaceholderIndexFlorian Diebold2021-03-131-19/+3
| |
* | Use chalk_ir::ClosureIdFlorian Diebold2021-03-132-11/+6
| |
* | Use chalk_ir::FnDefIdFlorian Diebold2021-03-133-6/+4
| |
* | Use chalk_ir::AssocTypeIdFlorian Diebold2021-03-133-47/+26
| |
* | Use chalk_ir::ForeignDefIdFlorian Diebold2021-03-132-23/+2
| |
* | Separate `Ty` and `TyKind` like in ChalkFlorian Diebold2021-03-132-58/+65
|/ | | | | Currently `Ty` just wraps `TyKind`, but this allows us to change most places to already use `intern` / `interned`.
* Simplify a bitFlorian Diebold2021-03-121-10/+5
|
* Use Chalk Environment more directlyFlorian Diebold2021-03-122-35/+7
|
* Delete `ContainerId`Jonas Schievink2021-03-091-2/+2
|
* Use chalk_ir::AdtIdLukas Wirth2021-03-042-22/+8
|
* Use chalk_ir::MutabilityLukas Wirth2021-03-011-22/+6
|
* Introduce Ty::AliasLukas Wirth2021-03-012-15/+15
|
* Being Ty::InferenceVar closes to chalk equivalentLukas Wirth2021-03-011-22/+10
|
* Lift FnPointer into a structLukas Wirth2021-02-282-19/+14
|
* Remove Substs from Ty::ForeignTypeLukas Wirth2021-02-281-5/+4
|
* Turn Ty::Tuple variant into a tuple-variantLukas Wirth2021-02-281-2/+2
|
* Inline TypeCtor into TyLukas Wirth2021-02-282-108/+90
|
* Use chalk_ir::Scalar directlyLukas Wirth2021-02-281-60/+4
|
* Introduce TypeCtor::ScalarLukas Wirth2021-02-281-80/+60
|
* Update crateskjeremy2021-02-081-2/+3
| | | | Pulls in https://github.com/rust-lang/chalk/pull/682
* Bump chalkLaurențiu Nicola2021-02-021-2/+2
|
* Make `ModuleId`'s `krate` field privateJonas Schievink2021-01-221-2/+2
|
* Bump chalkLaurențiu Nicola2020-12-231-2/+9
|
* Upgrade ChalkFlorian Diebold2020-12-073-6/+72
| | | | | | | Also make overflow depth and max type size configurable through env variables. This can be helpful at least for debugging. Fixes #6628.
* Remove more unreachable pubsAleksey Kladov2020-11-023-19/+19
|