aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #8139bors[bot]2021-03-229-109/+131
|\ | | | | | | | | | | | | | | 8139: Align `Canonical` and `InEnvironment` with the Chalk versions r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * Align InEnvironment with ChalkFlorian Diebold2021-03-218-45/+38
| | | | | | | | | | | | This in particular means storing a chalk_ir::Environment, not our TraitEnvironment. This makes InEnvironment not usable for Type, where we need to keep the full TraitEnvironment.
| * Align Canonical more with Chalk's versionFlorian Diebold2021-03-215-68/+97
| | | | | | | | In particular, use chalk_ir::CanonicalVarKinds.
* | Merge #8136 #8146bors[bot]2021-03-229-106/+200
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 8136: Introduce QuantifiedWhereClause and DynTy analogous to Chalk r=flodiebold a=flodiebold This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point. There's a lot of skipping of the binders; once we're done with the Chalk move, we should review the remaining ones. 8146: Document patch policy r=matklad a=matklad bors r+ 🤖 Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| * Use QuantifiedWhereClause in generic_predicates as wellFlorian Diebold2021-03-217-31/+26
| | | | | | | | | | Still far too much binder skipping going on; I find it hard to imagine this is all correct, but the tests pass.
| * Introduce QuantifiedWhereClause and DynTy analogous to ChalkFlorian Diebold2021-03-216-98/+197
| | | | | | | | | | This introduces a bunch of new binders in lots of places, which we have to be careful about, but we had to add them at some point.
* | Merge #8137bors[bot]2021-03-213-9/+51
|\ \ | | | | | | | | | | | | | | | | | | | | | 8137: Fix box pattern inference panic r=flodiebold a=Veykril Fixes #6560 Co-authored-by: Lukas Wirth <[email protected]>
| * | Fix box pattern inference panicLukas Wirth2021-03-213-9/+51
| | |
* | | Merge #8134bors[bot]2021-03-211-0/+23
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 8134: Correct the paths of submodules from the include! macro r=edwin0cheng a=sticnarf This PR should fix #7846. It mostly follows the instructions from @edwin0cheng in that issue. Co-authored-by: Yilin Chen <[email protected]>
| * | use the included file as the source of expanded include macroYilin Chen2021-03-211-0/+23
| | | | | | | | | | | | Signed-off-by: Yilin Chen <[email protected]>
* | | Merge #8133bors[bot]2021-03-216-15/+169
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 8133: Ignore type bindings in generic_predicates_for_param (fix panic on ena and crates depending on it) r=flodiebold a=flodiebold This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine. Co-authored-by: Florian Diebold <[email protected]>
| * | Ignore type bindings in generic_predicates_for_paramFlorian Diebold2021-03-215-18/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to handle more cases without a query cycle, which includes certain cases that rustc accepted. That in turn means we avoid triggering salsa-rs/salsa#257 on valid code (it will still happen if the user writes an actual cycle). We actually accept more definitions than rustc now; that's because rustc only ignores bindings when looking up super traits, whereas we now also ignore them when looking for predicates to disambiguate associated type shorthand. We could introduce a separate query for super traits if necessary, but for now I think this should be fine.
| * | Test for a Salsa bugFlorian Diebold2021-03-213-0/+124
| |/
* | clippy::complexity simplifications related to IteratorsMatthias Krüger2021-03-211-1/+1
| |
* | remove more redundant clones (clippy::redundant_clone())Matthias Krüger2021-03-211-2/+1
|/
* Turn Obligation into something similar to chalk_ir::DomainGoalFlorian Diebold2021-03-2013-86/+124
| | | | This includes starting to make use of Chalk's `Cast` trait.
* Remove WhereClause::ErrorFlorian Diebold2021-03-207-42/+8
| | | | | Chalk doesn't have it, and judging from the removed code, it wasn't useful anyway.
* Rename GenericPredicate -> WhereClauseFlorian Diebold2021-03-209-99/+83
|
* Replace Projection variant in GenericPredicate with AliasEqLukas Wirth2021-03-199-120/+210
|
* Chalkify TraitRefFlorian Diebold2021-03-1814-68/+94
|
* Fix infinite recursion when computing diagnostics for inner itemsJonas Schievink2021-03-181-1/+14
|
* Merge #8082bors[bot]2021-03-181-0/+22
|\ | | | | | | | | | | | | | | | | | | | | | | 8082: Proper handle inner recursive macro rules cases r=edwin0cheng a=edwin0cheng Fixes #7645 cc @jonas-schievink bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * Handle inner recursive macro rules casesEdwin Cheng2021-03-181-0/+22
| |
* | Support `#[cfg]` on all associated itemsJonas Schievink2021-03-181-0/+19
| |
* | Add test for self-calling inner functionJonas Schievink2021-03-171-0/+21
| |
* | Improve testJonas Schievink2021-03-171-0/+21
| |
* | Add test for `#[cfg]` on function paramsJonas Schievink2021-03-171-0/+13
| |
* | Handle `#[cfg]` on call argumentsJonas Schievink2021-03-171-0/+23
|/
* avoid converting types into themselves via .into() (clippy::useless-conversion)Matthias Krüger2021-03-174-20/+20
| | | | example: let x: String = String::from("hello world").into();
* Rename Substs -> SubstitutionFlorian Diebold2021-03-1614-143/+155
|
*-. Merge #7900 #8000bors[bot]2021-03-164-13/+200
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| | * Use hir formatter moreoxalica2021-03-151-1/+1
| | |
| | * Impl HirDisplay for function hover messageoxalica2021-03-151-8/+195
| | |
| | * Introduce FunctionQualifier for hir::FunctionDataoxalica2021-03-152-4/+4
| | |
* | | Fix macro expansion for statements w/o semicolonEdwin Cheng2021-03-161-0/+16
| | |
* | | Use SmallVec for SubstsFlorian Diebold2021-03-153-14/+29
| | | | | | | | | | | | | | | Doesn't help as much as I hoped, but it helps a bit and I also did some refactorings that were necessary anyway.
* | | Fix unification logicFlorian Diebold2021-03-152-101/+117
| |/ |/|
* | Merge #8020bors[bot]2021-03-151-1/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8020: Power up goto_implementation r=matklad a=Veykril by allowing it to be invoked on references of names, now showing all (trait) implementations of the given type in all crates instead of just the defining crate as well as including support for builtin types ![image](https://user-images.githubusercontent.com/3757771/111144403-52bb0700-8587-11eb-9205-7a2a5b8b75a3.png) Example screenshot of `impl`s of Box in `log`, `alloc`, `std` and the current crate. Before you had to invoke it on the definition where it would only show the `impls` in `alloc`. Co-authored-by: Lukas Wirth <[email protected]>
| * | Speedup trait impl search for goto_implementationLukas Wirth2021-03-151-1/+9
| | |
* | | Merge #8018bors[bot]2021-03-1510-137/+126
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8018: Make Ty wrap TyKind in an Arc r=flodiebold a=flodiebold ... to further move towards Chalk. This is a bit of a slowdown (218ginstr vs 213ginstr for inference on RA), even though it allows us to unwrap the Substs in `TyKind::Ref` etc.. Co-authored-by: Florian Diebold <[email protected]>
| * | | Don't use Substs for Ref/Raw/Array/SliceFlorian Diebold2021-03-149-111/+74
| | | |
| * | | Make Ty wrap TyKind in an ArcFlorian Diebold2021-03-148-27/+53
| |/ / | | | | | | | | | | | | | | | | | | | | | ... like it will be in Chalk. We still keep `interned_mut` and `into_inner` methods that will probably not exist with Chalk. This worsens performance slightly (5ginstr inference on RA), but doesn't include other simplifications we can do yet.
* / / Simplify source maps for fieldsAleksey Kladov2021-03-152-6/+5
|/ /
* | More renamingFlorian Diebold2021-03-144-18/+22
| |
* | Use chalk_ir::FnSigFlorian Diebold2021-03-145-21/+22
| |
* | Rename some fields to their Chalk namesFlorian Diebold2021-03-1410-45/+45
| |
* | Move type lowering methods to TyLoweringContextFlorian Diebold2021-03-134-286/+246
| |
* | Create TraitEnvironment through a queryFlorian Diebold2021-03-134-45/+59
| |
* | Use chalk_ir::OpaqueTyIdFlorian Diebold2021-03-137-63/+53
| |
* | Use chalk_ir::PlaceholderIndexFlorian Diebold2021-03-137-43/+52
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-23 01:59:43 +0000